)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b389d81268518a80b13794c1388560657a13b658","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Unit Test failures due to host\u0027s ANA support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We recently added NVMe-oF native multipathing support but the unit tests"},{"line_number":10,"context_line":"assume that the host they are run on doesn\u0027t support it, so when running"},{"line_number":11,"context_line":"them on a system that does support it then 6 tests fail."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"086d9a07_d3e18439","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":53},"updated":"2022-06-09 05:15:48.000000000","message":"would be good to mention the original change for reference\n\nI3af33c5e43cfb104e436fb785b08fb28b50a031a","commit_id":"a87a6a5278a59e81d550c855c8f63ed9c53efdc0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c6fd7a32b4d324d5620390fb1182e2232a08b3a9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Unit Test failures due to host\u0027s ANA support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We recently added NVMe-oF native multipathing support but the unit tests"},{"line_number":10,"context_line":"assume that the host they are run on doesn\u0027t support it, so when running"},{"line_number":11,"context_line":"them on a system that does support it then 6 tests fail."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfbee201_98aa86e2","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":53},"in_reply_to":"086d9a07_d3e18439","updated":"2022-06-10 14:00:46.000000000","message":"Done","commit_id":"a87a6a5278a59e81d550c855c8f63ed9c53efdc0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b389d81268518a80b13794c1388560657a13b658","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Unit Test failures due to host\u0027s ANA support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We recently added NVMe-oF native multipathing support but the unit tests"},{"line_number":10,"context_line":"assume that the host they are run on doesn\u0027t support it, so when running"},{"line_number":11,"context_line":"them on a system that does support it then 6 tests fail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch just forces this assumption on the class attribute changing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfefc0b3_c354f35f","line":10,"range":{"start_line":9,"start_character":58,"end_line":10,"end_character":55},"updated":"2022-06-09 05:15:48.000000000","message":"I thought the tests should mock out _is_native_multipath_supported to return False if they assume multipathing is not supported, Also do the tests actually run this on the system to find out if native multipathing is supported or not?\n\n    with open(\u0027/sys/module/nvme_core/parameters/multipath\u0027, \u0027rt\u0027) as f:\n        return f.read().strip() \u003d\u003d \u0027Y\u0027","commit_id":"a87a6a5278a59e81d550c855c8f63ed9c53efdc0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b96830b656af914a7f84cf20aec6071ee7521e09","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Unit Test failures due to host\u0027s ANA support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We recently added NVMe-oF native multipathing support but the unit tests"},{"line_number":10,"context_line":"assume that the host they are run on doesn\u0027t support it, so when running"},{"line_number":11,"context_line":"them on a system that does support it then 6 tests fail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch just forces this assumption on the class attribute changing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e884a728_5e38203e","line":10,"range":{"start_line":9,"start_character":58,"end_line":10,"end_character":55},"in_reply_to":"96011d97_fc07d5ac","updated":"2022-06-15 02:31:01.000000000","message":"Ack","commit_id":"a87a6a5278a59e81d550c855c8f63ed9c53efdc0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c6fd7a32b4d324d5620390fb1182e2232a08b3a9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Unit Test failures due to host\u0027s ANA support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We recently added NVMe-oF native multipathing support but the unit tests"},{"line_number":10,"context_line":"assume that the host they are run on doesn\u0027t support it, so when running"},{"line_number":11,"context_line":"them on a system that does support it then 6 tests fail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch just forces this assumption on the class attribute changing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"96011d97_fc07d5ac","line":10,"range":{"start_line":9,"start_character":58,"end_line":10,"end_character":55},"in_reply_to":"bfefc0b3_c354f35f","updated":"2022-06-10 14:00:46.000000000","message":"The tests currently don\u0027t mock it in general and assume it\u0027s going to be False.\n\nThey currently run the code you mention, but if we set it to False (instead of the default of None) like this patch does then that code is no longer executed.\n\nSetting a default value is something we sometimes do so we don\u0027t have to be mocking it all around. That way only tests that want to test it specifically would have to mock it.","commit_id":"a87a6a5278a59e81d550c855c8f63ed9c53efdc0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b389d81268518a80b13794c1388560657a13b658","unresolved":true,"context_lines":[{"line_number":10,"context_line":"assume that the host they are run on doesn\u0027t support it, so when running"},{"line_number":11,"context_line":"them on a system that does support it then 6 tests fail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch just forces this assumption on the class attribute changing"},{"line_number":14,"context_line":"the value of native_multipath_supported from None to False and thus"},{"line_number":15,"context_line":"disabling the detection mechanism."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7d6fff66c5cc27bbd1f5caa737f01bc7784af710"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"85600da5_46316146","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":58},"updated":"2022-06-09 05:15:48.000000000","message":"I assume currently we don\u0027t have tests that check the code path when multipathing is enabled so if we plan to add those then this needs to change from class attribute to mocking _is_native_multipath_supported in those 6 tests","commit_id":"a87a6a5278a59e81d550c855c8f63ed9c53efdc0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b96830b656af914a7f84cf20aec6071ee7521e09","unresolved":false,"context_lines":[{"line_number":10,"context_line":"assume that the host they are run on doesn\u0027t support it, so when running"},{"line_number":11,"context_line":"them on a system that does support it then 6 tests fail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch just forces this assumption on the class attribute changing"},{"line_number":14,"context_line":"the value of native_multipath_supported from None to False and thus"},{"line_number":15,"context_line":"disabling the detection mechanism."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7d6fff66c5cc27bbd1f5caa737f01bc7784af710"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"85927dfe_e65ad8c2","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":58},"in_reply_to":"703c607f_9fef24f7","updated":"2022-06-15 02:31:01.000000000","message":"Thanks for doing it!","commit_id":"a87a6a5278a59e81d550c855c8f63ed9c53efdc0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c6fd7a32b4d324d5620390fb1182e2232a08b3a9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"assume that the host they are run on doesn\u0027t support it, so when running"},{"line_number":11,"context_line":"them on a system that does support it then 6 tests fail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch just forces this assumption on the class attribute changing"},{"line_number":14,"context_line":"the value of native_multipath_supported from None to False and thus"},{"line_number":15,"context_line":"disabling the detection mechanism."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7d6fff66c5cc27bbd1f5caa737f01bc7784af710"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"703c607f_9fef24f7","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":58},"in_reply_to":"85600da5_46316146","updated":"2022-06-10 14:00:46.000000000","message":"I believe what we don\u0027t have is tests for the _set_native_multipath_supported method, which is the one setting that value, and I\u0027m not happy having to add the tests to fix the tests which won\u0027t run locally...\n\nBut it\u0027s not an unreasonable request and I did miss it on the review, so I\u0027ll bite that bullet.","commit_id":"a87a6a5278a59e81d550c855c8f63ed9c53efdc0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b389d81268518a80b13794c1388560657a13b658","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"443fba5e_5fdf9064","updated":"2022-06-09 05:15:48.000000000","message":"Hi Gorka, few questions inline.","commit_id":"a87a6a5278a59e81d550c855c8f63ed9c53efdc0"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"55b4e218f41ad6fc5d10dd49ef77fa40bffeb828","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0875c355_7b83175d","updated":"2022-06-09 14:01:53.000000000","message":"The code looks good to me but, waiting on Rajat\u0027s comments","commit_id":"a87a6a5278a59e81d550c855c8f63ed9c53efdc0"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a15f33ca064be13b938584c00a667c9d5298c398","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c8cb7b2_61a81a1e","updated":"2022-06-14 21:16:45.000000000","message":"Rajat\u0027s comment were addressed and the code looks good to me","commit_id":"924af884db5797092e16e6176e9a70feddc9c892"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b96830b656af914a7f84cf20aec6071ee7521e09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cfffa68e_a370df58","updated":"2022-06-15 02:31:01.000000000","message":"Thanks Gorka. LGTM.","commit_id":"924af884db5797092e16e6176e9a70feddc9c892"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7d87013c343f55c36b8fc13906e17ae18f41481a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3857846d_b40b8728","updated":"2022-06-15 09:20:06.000000000","message":"recheck : ovn_agent error","commit_id":"924af884db5797092e16e6176e9a70feddc9c892"}]}