)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"ac540359343baaddc4d936ce5094ce82bef21d46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"afa45e3d_7e3789d0","updated":"2022-07-13 12:45:29.000000000","message":"Eric comment looks like completed, zuul voted and code LGTM.","commit_id":"dde8f102b714e2e4001a3fe82f975cd9978ac1c5"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"39807468dcaaacf0afeaecf8667760258a49ccfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c9555d90_0ae6d455","updated":"2022-07-13 14:23:02.000000000","message":"If Eric has convinced himself of the answer to his question, then I think this is good.","commit_id":"dde8f102b714e2e4001a3fe82f975cd9978ac1c5"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"6a3083c745c0266a9d9fdcf11fb98a787fac0365","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5078c285_b5cb9e0b","updated":"2022-07-13 13:39:20.000000000","message":"run Pure Storage CI","commit_id":"dde8f102b714e2e4001a3fe82f975cd9978ac1c5"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"5c7ab52c0dea8b7228df3e3fd5c5703775670505","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2ceb2f05_a7918728","updated":"2022-07-13 14:24:28.000000000","message":"waiting on gorka","commit_id":"dde8f102b714e2e4001a3fe82f975cd9978ac1c5"}],"os_brick/utils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"48380755274f5d20acb0b17fdb19ea04052fa867","unresolved":true,"context_lines":[{"line_number":257,"context_line":"    This is the reverse operation of the one performed by the"},{"line_number":258,"context_line":"    _symlink_name_from_device_path method."},{"line_number":259,"context_line":"    \"\"\""},{"line_number":260,"context_line":"    if (symlink and isinstance(symlink, str)"},{"line_number":261,"context_line":"            and symlink.startswith(CUSTOM_LINK_PREFIX)):"},{"line_number":262,"context_line":"        ending \u003d symlink[len(CUSTOM_LINK_PREFIX):]"},{"line_number":263,"context_line":"        return ending.replace(\u0027+\u0027, \u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0b00a99c_586940ac","line":260,"updated":"2022-07-12 19:52:16.000000000","message":"Is \"symlink\" ever another os.PathLike object that isn\u0027t a str?","commit_id":"dde8f102b714e2e4001a3fe82f975cd9978ac1c5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df8274c625d01b701f831ce78694133447d55160","unresolved":true,"context_lines":[{"line_number":257,"context_line":"    This is the reverse operation of the one performed by the"},{"line_number":258,"context_line":"    _symlink_name_from_device_path method."},{"line_number":259,"context_line":"    \"\"\""},{"line_number":260,"context_line":"    if (symlink and isinstance(symlink, str)"},{"line_number":261,"context_line":"            and symlink.startswith(CUSTOM_LINK_PREFIX)):"},{"line_number":262,"context_line":"        ending \u003d symlink[len(CUSTOM_LINK_PREFIX):]"},{"line_number":263,"context_line":"        return ending.replace(\u0027+\u0027, \u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a1051eae_0bd6f159","line":260,"range":{"start_line":260,"start_character":20,"end_line":260,"end_character":44},"updated":"2022-07-13 14:22:13.000000000","message":"so for RBD this will never evaluate to true right?\n\nisinstance(symlink, str)","commit_id":"dde8f102b714e2e4001a3fe82f975cd9978ac1c5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"efc9662fa730ab617bb16d1848fba22b91a5541d","unresolved":true,"context_lines":[{"line_number":257,"context_line":"    This is the reverse operation of the one performed by the"},{"line_number":258,"context_line":"    _symlink_name_from_device_path method."},{"line_number":259,"context_line":"    \"\"\""},{"line_number":260,"context_line":"    if (symlink and isinstance(symlink, str)"},{"line_number":261,"context_line":"            and symlink.startswith(CUSTOM_LINK_PREFIX)):"},{"line_number":262,"context_line":"        ending \u003d symlink[len(CUSTOM_LINK_PREFIX):]"},{"line_number":263,"context_line":"        return ending.replace(\u0027+\u0027, \u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba48d644_6288c88d","line":260,"in_reply_to":"0b00a99c_586940ac","updated":"2022-07-12 19:55:33.000000000","message":"It looks like this always comes from a connection_properties dict, so I suppose not.","commit_id":"dde8f102b714e2e4001a3fe82f975cd9978ac1c5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ea559a5dd5a5d20b6bebcf94bd9575d4bcbae9ca","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    This is the reverse operation of the one performed by the"},{"line_number":258,"context_line":"    _symlink_name_from_device_path method."},{"line_number":259,"context_line":"    \"\"\""},{"line_number":260,"context_line":"    if (symlink and isinstance(symlink, str)"},{"line_number":261,"context_line":"            and symlink.startswith(CUSTOM_LINK_PREFIX)):"},{"line_number":262,"context_line":"        ending \u003d symlink[len(CUSTOM_LINK_PREFIX):]"},{"line_number":263,"context_line":"        return ending.replace(\u0027+\u0027, \u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e83c44f8_33c74d68","line":260,"range":{"start_line":260,"start_character":20,"end_line":260,"end_character":44},"in_reply_to":"a1051eae_0bd6f159","updated":"2022-07-13 15:16:10.000000000","message":"Yeah, it will always be false because it is the IOWrapper","commit_id":"dde8f102b714e2e4001a3fe82f975cd9978ac1c5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ea559a5dd5a5d20b6bebcf94bd9575d4bcbae9ca","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    This is the reverse operation of the one performed by the"},{"line_number":258,"context_line":"    _symlink_name_from_device_path method."},{"line_number":259,"context_line":"    \"\"\""},{"line_number":260,"context_line":"    if (symlink and isinstance(symlink, str)"},{"line_number":261,"context_line":"            and symlink.startswith(CUSTOM_LINK_PREFIX)):"},{"line_number":262,"context_line":"        ending \u003d symlink[len(CUSTOM_LINK_PREFIX):]"},{"line_number":263,"context_line":"        return ending.replace(\u0027+\u0027, \u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ac573f1_4b242995","line":260,"in_reply_to":"ba48d644_6288c88d","updated":"2022-07-13 15:16:10.000000000","message":"From what I know/see this is a string or a some sort of file handle.","commit_id":"dde8f102b714e2e4001a3fe82f975cd9978ac1c5"}]}
