)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5b6cbb16d9908ce336d8bc879a53d892a53a06e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e5b972a8_478403c2","updated":"2022-07-26 12:06:56.000000000","message":"LGTM.","commit_id":"fa2e19207409edb3f9740b4093044bcaafd6173c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4ebe4892cbb35a5a3becee579508680333165d31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"68a7b881_881555dc","updated":"2022-07-28 09:58:07.000000000","message":"Thanks Gorka","commit_id":"fa2e19207409edb3f9740b4093044bcaafd6173c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"11b80c6c3c221554377dca8b6192ff33c5b06eae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"78b797f9_09083210","updated":"2022-08-11 10:39:00.000000000","message":"Revisions LGTM.","commit_id":"ec7246e17de2b2bf67ba074c61c168b0a8d1f2a9"}],"os_brick/initiator/connectors/nvmeof.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5ecaf118cc8728958b470b4b9a23caedacb0130d","unresolved":true,"context_lines":[{"line_number":273,"context_line":"                 source_conn_props: \u0027NVMeOFConnProps\u0027,"},{"line_number":274,"context_line":"                 nqn: str,"},{"line_number":275,"context_line":"                 portals: List[str],"},{"line_number":276,"context_line":"                 uuid: str \u003d None,"},{"line_number":277,"context_line":"                 nguid: str \u003d None,"},{"line_number":278,"context_line":"                 ns_id: str \u003d None,"},{"line_number":279,"context_line":"                 host_nqn\u003dNone,"},{"line_number":280,"context_line":"                 find_controllers\u003dFalse) -\u003e None:"},{"line_number":281,"context_line":"        \"\"\"Initialize instance."}],"source_content_type":"text/x-python","patch_set":1,"id":"178d385e_0e926073","line":278,"range":{"start_line":276,"start_character":0,"end_line":278,"end_character":35},"updated":"2022-07-25 22:03:53.000000000","message":"I missed this on the original patch, but I believe that \"implicit optionals\" are no longer OK (though our version of mypy may not be there yet).  You might want to change these to\n\n  whatever: Optional[str] \u003d None,","commit_id":"277f20f988cdc3d9b5c70cde8489b0dbc1725ca9"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"99f028c5ba194af4c2c261d5e329778cedb6611f","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                 source_conn_props: \u0027NVMeOFConnProps\u0027,"},{"line_number":274,"context_line":"                 nqn: str,"},{"line_number":275,"context_line":"                 portals: List[str],"},{"line_number":276,"context_line":"                 uuid: str \u003d None,"},{"line_number":277,"context_line":"                 nguid: str \u003d None,"},{"line_number":278,"context_line":"                 ns_id: str \u003d None,"},{"line_number":279,"context_line":"                 host_nqn\u003dNone,"},{"line_number":280,"context_line":"                 find_controllers\u003dFalse) -\u003e None:"},{"line_number":281,"context_line":"        \"\"\"Initialize instance."}],"source_content_type":"text/x-python","patch_set":1,"id":"7041d935_22673f78","line":278,"range":{"start_line":276,"start_character":0,"end_line":278,"end_character":35},"in_reply_to":"178d385e_0e926073","updated":"2022-07-26 09:39:12.000000000","message":"Makes sense, Done","commit_id":"277f20f988cdc3d9b5c70cde8489b0dbc1725ca9"}],"os_brick/tests/initiator/connectors/test_nvmeof.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"944f6475d7bb12a311de96b9900ce19f34ab9782","unresolved":true,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @mock.patch.object(nvmeof.Portal, \u0027get_device_by_property\u0027)"},{"line_number":190,"context_line":"    def test_get_device_by_ns_id(self, mock_property):"},{"line_number":191,"context_line":"        \"\"\"ns_id takes priority over target if no UUID and nguid.\"\"\""},{"line_number":192,"context_line":"        mock_property.return_value \u003d \u0027result\u0027"},{"line_number":193,"context_line":"        self.target.uuid \u003d None"},{"line_number":194,"context_line":"        self.target.nguid \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"03ffad85_5e782023","line":191,"range":{"start_line":191,"start_character":37,"end_line":191,"end_character":43},"updated":"2022-07-28 08:55:38.000000000","message":"-1: I don\u0027t think \"over target\" is the appropriate wording.  Probably best to leave it as:\n\n  ns_id takes priority if no UUID and nguid are present.","commit_id":"fa2e19207409edb3f9740b4093044bcaafd6173c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4ebe4892cbb35a5a3becee579508680333165d31","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @mock.patch.object(nvmeof.Portal, \u0027get_device_by_property\u0027)"},{"line_number":190,"context_line":"    def test_get_device_by_ns_id(self, mock_property):"},{"line_number":191,"context_line":"        \"\"\"ns_id takes priority over target if no UUID and nguid.\"\"\""},{"line_number":192,"context_line":"        mock_property.return_value \u003d \u0027result\u0027"},{"line_number":193,"context_line":"        self.target.uuid \u003d None"},{"line_number":194,"context_line":"        self.target.nguid \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"342137b3_a1e5cfa1","line":191,"range":{"start_line":191,"start_character":37,"end_line":191,"end_character":43},"in_reply_to":"03ffad85_5e782023","updated":"2022-07-28 09:58:07.000000000","message":"Done","commit_id":"fa2e19207409edb3f9740b4093044bcaafd6173c"}]}