)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d6529b8115bb021781e046826691e716706b6ee0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"74ebe163_e5c9947b","updated":"2022-09-13 12:38:28.000000000","message":"minor typo","commit_id":"5f3c1faa8763187bfd147a84b993eceb62a80bd2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"27ad0635663d6c6781a5a56179e1137885eb1f14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4b518774_de0fe111","updated":"2023-02-07 14:50:29.000000000","message":"recheck - Unrelated failure, \"One or more ports have an IP allocation from this subnet\"","commit_id":"5f3c1faa8763187bfd147a84b993eceb62a80bd2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6b672f59e5b853fb25d5d0fc9c58aace9fdbfcb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"089d8ed1_3196bab3","updated":"2023-02-07 10:32:22.000000000","message":"recheck os-brick-src-devstack-plugin-ceph-v timed out","commit_id":"5f3c1faa8763187bfd147a84b993eceb62a80bd2"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c1af8fec9660cad6edc5bbdf9411b6c20436087d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c713c18_77c45079","updated":"2023-02-13 17:09:41.000000000","message":"recheck\n\nos-brick-src-tempest-lvm-lio-barbican, which doesn\u0027t test this code, failed","commit_id":"a9ea965e4a4b2e2d1bbdb7190fc3ef8fba98e5be"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"34c2fe791755e8b8c0589344f5097ed9ba87386a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"57cac24c_c790c7cc","updated":"2023-02-09 08:01:58.000000000","message":"recheck RBD dependency issue\n\nFeb 08 11:54:15.039611 np0033010824 cinder-volume[116431]: ERROR cinder.volume.manager [None req-10a44a96-5df6-484e-912a-6645f83a7cf9 tempest-TestVolumeBootPattern-1532938313 None] Delete snapshot failed, due to snapshot busy.: cinder.exception.SnapshotIsBusy: deleting snapshot snapshot-90817cce-8d26-4fff-9b86-ac1ca195cdaa that has dependent volumes\n","commit_id":"a9ea965e4a4b2e2d1bbdb7190fc3ef8fba98e5be"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"65c88f51af9fc115334479d93325db10d3c9811f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5b02fc08_9793d4ab","updated":"2023-03-30 11:21:22.000000000","message":"run-INFINIDAT","commit_id":"a9ea965e4a4b2e2d1bbdb7190fc3ef8fba98e5be"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"b27b6d3a334fd84456e7ef082314fe01971db5d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3deebb99_cc115dfa","updated":"2023-02-14 01:00:20.000000000","message":"run-NEC Cinder CI","commit_id":"a9ea965e4a4b2e2d1bbdb7190fc3ef8fba98e5be"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"eb424d576bf2dd3ffdf921f42e0fd00c8fab7eb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0be85947_7cb2841a","updated":"2023-02-14 10:43:31.000000000","message":"run-NEC V Cinder CI","commit_id":"a9ea965e4a4b2e2d1bbdb7190fc3ef8fba98e5be"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"3a25b1bd0565af3415c120e293ed2c37c2bd3b47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8b7dffde_00b7ccee","updated":"2023-02-14 00:59:25.000000000","message":"run-NEC V Cinder CI","commit_id":"a9ea965e4a4b2e2d1bbdb7190fc3ef8fba98e5be"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2545bb82fccbfa1d49d2ebaeda5b0a08f61825db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c0b8f579_b96ef1aa","updated":"2023-08-23 15:54:02.000000000","message":"Code and tests look good, we are testing both scenarios where require_not_closed is True and False. LGTM.","commit_id":"00caa73776d9987103f9023a1c4e9c643fa77039"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"573b6c1bdae2ffa509a252319af4860855623523","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"634693aa_b3ee081f","updated":"2023-08-23 17:41:26.000000000","message":"I agree with Rajat, this looks very good to me.","commit_id":"00caa73776d9987103f9023a1c4e9c643fa77039"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"11e7c5d9757327bcf79431dc949b1fdbe3926a83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d4dd92be_6c0f6b9a","updated":"2023-08-23 13:25:07.000000000","message":"recheck\n\nos-brick-src-tempest-lvm-lio-barbican nova-api http 500s","commit_id":"00caa73776d9987103f9023a1c4e9c643fa77039"}],"os_brick/initiator/linuxrbd.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d6529b8115bb021781e046826691e716706b6ee0","unresolved":true,"context_lines":[{"line_number":243,"context_line":"        # Raise ValueError if already closed"},{"line_number":244,"context_line":"        super().flush()"},{"line_number":245,"context_line":"        # The underlying image may be close while this IOWrapper is not, in"},{"line_number":246,"context_line":"        # that case fluash has already been called."},{"line_number":247,"context_line":"        if not self.rbd_image.closed:"},{"line_number":248,"context_line":"            try:"},{"line_number":249,"context_line":"                self.rbd_image.flush()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ca42f756_84e2b5ab","line":246,"range":{"start_line":246,"start_character":20,"end_line":246,"end_character":26},"updated":"2022-09-13 12:38:28.000000000","message":"nit: flush","commit_id":"5f3c1faa8763187bfd147a84b993eceb62a80bd2"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c1af8fec9660cad6edc5bbdf9411b6c20436087d","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        # Raise ValueError if already closed"},{"line_number":244,"context_line":"        super().flush()"},{"line_number":245,"context_line":"        # The underlying image may be close while this IOWrapper is not, in"},{"line_number":246,"context_line":"        # that case fluash has already been called."},{"line_number":247,"context_line":"        if not self.rbd_image.closed:"},{"line_number":248,"context_line":"            try:"},{"line_number":249,"context_line":"                self.rbd_image.flush()"}],"source_content_type":"text/x-python","patch_set":1,"id":"c7609413_05000163","line":246,"range":{"start_line":246,"start_character":20,"end_line":246,"end_character":26},"in_reply_to":"ca42f756_84e2b5ab","updated":"2023-02-13 17:09:41.000000000","message":"Done","commit_id":"5f3c1faa8763187bfd147a84b993eceb62a80bd2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2545bb82fccbfa1d49d2ebaeda5b0a08f61825db","unresolved":true,"context_lines":[{"line_number":237,"context_line":"        super().flush()"},{"line_number":238,"context_line":"        # Don\u0027t fail on flush by calling it when underlying image is closed."},{"line_number":239,"context_line":"        try:"},{"line_number":240,"context_line":"            self.rbd_image.require_not_closed()"},{"line_number":241,"context_line":"        except rbd.InvalidArgument:  # Image is closed"},{"line_number":242,"context_line":"            LOG.warning(\"RBDVolumeIOWrapper\u0027s underlying image %s was closed \""},{"line_number":243,"context_line":"                        \"directly (probably by the GC) instead of through the \""}],"source_content_type":"text/x-python","patch_set":3,"id":"b08000f8_7a5c0444","line":240,"updated":"2023-08-23 15:54:02.000000000","message":"looks good based on the details https://docs.ceph.com/en/latest/rbd/api/librbdpy/#rbd.Image.require_not_closed","commit_id":"00caa73776d9987103f9023a1c4e9c643fa77039"}]}