)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"914d4015236552caaa202c3a22c4b423e1f85f4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fdc14cf4_940ff277","updated":"2023-01-05 14:46:57.000000000","message":"Just discovered that we do need to change tox.ini because of the way the ensure_tox role and ensure_tox_version var are implemented for zuul.  If tox is already present, it gets used, regardless of the value of ensure_tox_version.  The ensure_tox_version var is only used when tox is not present and needs to be installed.  This will be a problem for any devstack-based jobs, because by the time we get to run our tests, there\u0027s all sorts of opportunities for someone else to install an undesirable tox.  But as long as we say what tox version we want in the \u0027requires\u0027 in tox.ini, we should be ok.","commit_id":"420f5e1fd0db387385fb6c5f013c597c914bf51d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"93b907cac6cb5e8e17f1af9e2a24c32ca2950e11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"67bc77b1_fa52bea6","updated":"2023-01-04 11:10:29.000000000","message":"LGTM","commit_id":"420f5e1fd0db387385fb6c5f013c597c914bf51d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1ab143af39248dd2f65ee19faf21797b5049154d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ff65da3_8f3df277","updated":"2023-01-04 23:29:15.000000000","message":"See comment inline.","commit_id":"420f5e1fd0db387385fb6c5f013c597c914bf51d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1ff71d53ca64f254da686a69fa7d443807c9b045","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9ac803e1_edaaeaa9","updated":"2023-04-20 04:52:54.000000000","message":"in 2023.1, we switched to using tox4 so pinning to tox3 makes sense for stable branches from zed -\u003e N","commit_id":"a7dfaf4243ae4a75971462ad35765acfedca6a89"}],"tox.ini":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1ab143af39248dd2f65ee19faf21797b5049154d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.18.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"# python runtimes: https://governance.openstack.org/tc/reference/runtimes/ussuri.html"},{"line_number":5,"context_line":"envlist \u003d py3,pep8"},{"line_number":6,"context_line":"# this allows tox to infer the base python from the environment name"},{"line_number":7,"context_line":"# and override any basepython configured in this file"},{"line_number":8,"context_line":"ignore_basepython_conflict\u003dtrue"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"[testenv]"},{"line_number":11,"context_line":"basepython \u003d python3"}],"source_content_type":"text/x-properties","patch_set":1,"id":"7dc51046_f678a5f8","line":8,"range":{"start_line":2,"start_character":0,"end_line":8,"end_character":31},"updated":"2023-01-04 23:29:15.000000000","message":"we don\u0027t have a \u0027requires\u0027 key in this section, so I believe that the change made to cinder\u0027s tox.ini by change I3c22ff2d6e2951c6a8 are not needed for os-brick.","commit_id":"420f5e1fd0db387385fb6c5f013c597c914bf51d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"958f04fb98ce66a6cb146817e3df039072c64105","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.18.0"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"# python runtimes: https://governance.openstack.org/tc/reference/runtimes/ussuri.html"},{"line_number":5,"context_line":"envlist \u003d py3,pep8"},{"line_number":6,"context_line":"# this allows tox to infer the base python from the environment name"},{"line_number":7,"context_line":"# and override any basepython configured in this file"},{"line_number":8,"context_line":"ignore_basepython_conflict\u003dtrue"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"[testenv]"},{"line_number":11,"context_line":"basepython \u003d python3"}],"source_content_type":"text/x-properties","patch_set":1,"id":"417ef38f_3f75dd2d","line":8,"range":{"start_line":2,"start_character":0,"end_line":8,"end_character":31},"in_reply_to":"7dc51046_f678a5f8","updated":"2023-01-05 16:44:42.000000000","message":"Turns out I was wrong about that!","commit_id":"420f5e1fd0db387385fb6c5f013c597c914bf51d"}]}