)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"38ee52155fa0415a44fbb4ba99172128e8350feb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"39004a75_8d39e0aa","updated":"2023-03-07 14:05:45.000000000","message":"As there is no way to make tempest test LUN IDs \u003e 255 this patch and the associated Pure driver patch have been extensively tested with the Pure iSCSI and FC drivers, where is was possible to manually force LUN IDs on the backend storage.\nThe combined patches work as expected in master. ","commit_id":"4157d89dbfb82404784ffcd0de749237f7ee2b27"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"8f73d36ac1bd898e6e561e7bf010ae4fd5476bd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"10663e31_c843e00c","updated":"2023-03-30 11:38:51.000000000","message":"run-INFINIDAT","commit_id":"4157d89dbfb82404784ffcd0de749237f7ee2b27"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cd70257c081230a7cbb43e68d58648e96c4cbb8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9a16c544_82ee1348","updated":"2023-08-24 05:10:40.000000000","message":"code and tests looks good, we are transforming the LUN value if it\u0027s \u003e\u003d256 in SAM2 or if it\u0027s SAM3 flat addressing which is a straightforward logic. LGTM.","commit_id":"59961647d3c313d4014787f43f9c638313116e88"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"b608fedbd7d8fb2c50b80e36c46eec84c4f58823","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bddd0050_e3c609af","updated":"2023-08-23 15:03:21.000000000","message":"run Pure Storage CI","commit_id":"59961647d3c313d4014787f43f9c638313116e88"}],"os_brick/initiator/linuxscsi.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a2e9c4d25cad2494a1c3703a675518af4994f42d","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    WWN_TYPES \u003d {\u0027t10.\u0027: \u00271\u0027, \u0027eui.\u0027: \u00272\u0027, \u0027naa.\u0027: \u00273\u0027}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def _lun_for_addressing(lun, addressing_mode\u003dNone):"},{"line_number":53,"context_line":"        \"\"\"Convert luns to values used by the system."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        How a LUN is codified depends on the standard being used by the storage"}],"source_content_type":"text/x-python","patch_set":3,"id":"0c0682c0_0d54b857","line":52,"updated":"2023-02-23 19:58:31.000000000","message":"Shouldn\u0027t we specify some constants in this file for the strings to provide for the addressing modes that cinder drivers and others can use?","commit_id":"4423b9f778b55f6fbc27e20f5a7980607e45a5a4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9511df93388679ee9dad5a2338e1bd2c39bea70c","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    WWN_TYPES \u003d {\u0027t10.\u0027: \u00271\u0027, \u0027eui.\u0027: \u00272\u0027, \u0027naa.\u0027: \u00273\u0027}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def _lun_for_addressing(lun, addressing_mode\u003dNone):"},{"line_number":53,"context_line":"        \"\"\"Convert luns to values used by the system."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        How a LUN is codified depends on the standard being used by the storage"}],"source_content_type":"text/x-python","patch_set":3,"id":"256ecbce_d82f2aba","line":52,"in_reply_to":"0c0682c0_0d54b857","updated":"2023-03-07 10:33:55.000000000","message":"Yes definitely!!  Magic strings are a well known source of bugs.","commit_id":"4423b9f778b55f6fbc27e20f5a7980607e45a5a4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"dc1d2899e793736f209c5af813f2295fa2e4eb84","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    WWN_TYPES \u003d {\u0027t10.\u0027: \u00271\u0027, \u0027eui.\u0027: \u00272\u0027, \u0027naa.\u0027: \u00273\u0027}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def _lun_for_addressing(lun, addressing_mode\u003dNone):"},{"line_number":53,"context_line":"        \"\"\"Convert luns to values used by the system."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        How a LUN is codified depends on the standard being used by the storage"}],"source_content_type":"text/x-python","patch_set":3,"id":"3c071e91_501e4d13","line":52,"in_reply_to":"256ecbce_d82f2aba","updated":"2023-03-10 16:55:39.000000000","message":"Done","commit_id":"4423b9f778b55f6fbc27e20f5a7980607e45a5a4"}]}