)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"8bb60f5bd098f7d4665acb08a110436eddd4e905","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerFlex: Unnecessary login happen"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes issue in os-brick that causes token to never be cached and"},{"line_number":10,"context_line":"causeing unnecessary logins. Now it tests to see if token exists"},{"line_number":11,"context_line":"and caches it for future use."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bcfd9279_e1e50283","line":9,"updated":"2023-03-09 19:48:26.000000000","message":"This patch fixes the Dell PowerFlex (scaleio) connector for os-brick and enables the token to get cached and reusable. It avoids unnecessary logins. If the token already exists, then it get cached for future use.","commit_id":"402e64bb6a6a322ceb4fcdf42cb6d3417f69574b"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"ce135159d6ffc495cab9fdfe7cc1e1b3d2625501","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerFlex: Unnecessary login happen"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes issue in os-brick that causes token to never be cached and"},{"line_number":10,"context_line":"causeing unnecessary logins. Now it tests to see if token exists"},{"line_number":11,"context_line":"and caches it for future use."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e4d2a4a6_82be5e25","line":9,"in_reply_to":"bcfd9279_e1e50283","updated":"2023-03-13 17:23:11.000000000","message":"Done","commit_id":"402e64bb6a6a322ceb4fcdf42cb6d3417f69574b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8ed2b46f1ac56c81a657c452ef8f4eaf4cacd545","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerFlex: Unnecessary login happen"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes the unnecessary login issue introduced"},{"line_number":10,"context_line":"in Change-ID Iab54c515fe7be252df52b1a0503a251779805759"},{"line_number":11,"context_line":"in the Dell PowerFlex (scaleio) connector for os-brick."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2004630"},{"line_number":14,"context_line":"Change-Id: I2399b0b2af8254cd5697b44dcfcec553c2845bec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"dce84449_d3065dc1","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":54},"updated":"2023-09-26 08:01:59.000000000","message":"as discussed in last cinder meeting, it would be better to describe HOW we are able to fix the issue with some verbosity","commit_id":"96ee4d1e425ad55f11b79a19bed7ab70b1cc3763"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"de4279689d7bcafe66da35a3b59b217eec571165","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerFlex: Unnecessary login happen"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes the unnecessary login issue introduced"},{"line_number":10,"context_line":"in Change-ID Iab54c515fe7be252df52b1a0503a251779805759"},{"line_number":11,"context_line":"in the Dell PowerFlex (scaleio) connector for os-brick."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2004630"},{"line_number":14,"context_line":"Change-Id: I2399b0b2af8254cd5697b44dcfcec553c2845bec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"782539d0_54dceabc","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":54},"in_reply_to":"dce84449_d3065dc1","updated":"2023-09-26 09:34:28.000000000","message":"Done","commit_id":"96ee4d1e425ad55f11b79a19bed7ab70b1cc3763"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"2934099bbd3c96155ef5dc2eb3ede172d3c52339","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2e61bb51_f6cf067d","updated":"2023-04-19 15:08:11.000000000","message":"-1 for question","commit_id":"3cd2f8c107a33d2097dc4762ff5dd38511638c52"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"05e469e72496e9f808b1dab4c76bb0d55c06b4cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"33223f75_f1c9cc8d","updated":"2023-04-19 15:01:00.000000000","message":"Code change looks ok but I am not seeing a 3rd Party CI result.","commit_id":"3cd2f8c107a33d2097dc4762ff5dd38511638c52"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"74b22f2c186f14e65c265b969e55915e2803fe2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e8716bf1_338c0066","updated":"2023-04-20 12:11:30.000000000","message":"Comment inline","commit_id":"3cd2f8c107a33d2097dc4762ff5dd38511638c52"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"58665bb204982bc128dd6bc8e7857cf56607801f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bf147ec8_5b544090","updated":"2023-04-19 15:03:40.000000000","message":"run-DellEMC Powerflex CI","commit_id":"3cd2f8c107a33d2097dc4762ff5dd38511638c52"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"87eebe318b6fb654e663efdc6dae4e0174095c92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ef684064_8601e924","updated":"2023-03-30 11:33:34.000000000","message":"run-INFINIDAT","commit_id":"3cd2f8c107a33d2097dc4762ff5dd38511638c52"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5bd7f9c1b1ad09e1eb0d8649be8dfc527be42021","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3bf2b4ce_92f989dd","updated":"2023-06-12 09:14:53.000000000","message":"LGTM","commit_id":"bb2ee29a5a971fe7c6e3fa05743dc69b0db7b5d4"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"4b2570739626e31ba912f9e9cfcd6c25876944f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c54a61d9_18cab44c","updated":"2023-05-24 15:31:59.000000000","message":"Looks good to me - thank you!","commit_id":"bb2ee29a5a971fe7c6e3fa05743dc69b0db7b5d4"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d3622bb4c3c5b1257edc257b6fef806435e75a97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f0bc70c0_8490dc5a","updated":"2023-05-24 06:30:09.000000000","message":"My comment has been addressed. Zuul also passed.","commit_id":"bb2ee29a5a971fe7c6e3fa05743dc69b0db7b5d4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"722cb5259c53145c8b90633a2e77851439be04f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"01566eb3_be76eca0","updated":"2023-07-21 15:23:55.000000000","message":"improvement noted inline in the releasenote","commit_id":"bb2ee29a5a971fe7c6e3fa05743dc69b0db7b5d4"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"57f1e38476cf01162423d68ff1f139be9d8acda7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"32d854d7_339da4cc","updated":"2023-07-05 03:47:54.000000000","message":"looks good","commit_id":"bb2ee29a5a971fe7c6e3fa05743dc69b0db7b5d4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"11de43c0bfaa688f8322a5749c94254e539aff23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"13d3cd49_8d6f2da8","updated":"2023-09-15 14:16:41.000000000","message":"Dell CI is passing, I\u0027m assuming dell team has tested the change and the code change doesn\u0027t seem to require UTs. LGTM.","commit_id":"64b1262a40649ab6b90a59e5372350aee5d3759e"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"e3aa57ade21e6f238801ed7076bdfb931a531522","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"84f2b986_2c5033b4","updated":"2023-09-11 09:50:44.000000000","message":"LGTM","commit_id":"64b1262a40649ab6b90a59e5372350aee5d3759e"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"0dc1e1b099e8c2cf4123ecdd828f2872fbea2c33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c85e7891_1ec4edd0","updated":"2023-09-15 14:33:12.000000000","message":"Looks good to me - thank you!","commit_id":"64b1262a40649ab6b90a59e5372350aee5d3759e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2f2baac5a887a4e5b854cf0a1243e2fa57e3307e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"be3e1f19_5f0d9294","updated":"2023-09-15 16:02:45.000000000","message":"See comment inline about a potential problem.  Also, you mentioned in an earlier draft of the release note that you are fixing a regression--that would be helpful to mention in the commit message along with a reference to the breaking commit.  (BTW, I can\u0027t find commit 746109 in os-brick.)","commit_id":"64b1262a40649ab6b90a59e5372350aee5d3759e"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"88ce0ce81ebba069747864d9a24cce6c5733a842","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"25273a8d_18ac0a22","updated":"2023-08-24 03:13:44.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"64b1262a40649ab6b90a59e5372350aee5d3759e"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"5e3bcdd257153a7185e0a34d7ba49ee11ebd75a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"76a2adcd_a33ee747","updated":"2023-07-27 02:40:04.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"64b1262a40649ab6b90a59e5372350aee5d3759e"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"c96db92ff38cce341b25fe7bd4a192009f07efbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d7321f19_7051d334","updated":"2023-07-27 06:18:34.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"64b1262a40649ab6b90a59e5372350aee5d3759e"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"a170948d1964224b6ee0feacbe1f406055594200","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e08a293c_e15458d0","in_reply_to":"67b70c49_f080b6d4","updated":"2023-09-20 07:42:55.000000000","message":"So this is a patch ID, not a commit. Thanks.","commit_id":"64b1262a40649ab6b90a59e5372350aee5d3759e"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"052ef82c58213d84b1ea8df6e9ae024fca0bd0c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"67b70c49_f080b6d4","in_reply_to":"be3e1f19_5f0d9294","updated":"2023-09-20 07:40:35.000000000","message":"The \u0027commit 746109\u0027 refers to: \nhttps://review.opendev.org/c/openstack/os-brick/+/746109","commit_id":"64b1262a40649ab6b90a59e5372350aee5d3759e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fee3c046f36169b9653b14b051f00726b7338c89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"477427b4_e840f8ed","updated":"2023-09-27 14:42:00.000000000","message":"Thanks! the commit message makes it much more clear what is going on with this patch.","commit_id":"3225edc574fb44c4ef57af5a9fdcc9102ab67bb7"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"7b56c8fbf5815f6ec9a8fd1d4777cfe5626a0f7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3ef3a634_dd04b038","updated":"2023-09-26 11:46:12.000000000","message":"recheck os-brick-src-tempest-lvm-lio-barbican failure","commit_id":"9efa035366f61ae6286f30530f5d114f6be86d05"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"e4a91220ca541d2f34149c3c7ac04b206e9ed856","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"75f25bac_d7bdaacc","updated":"2023-09-27 04:50:48.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"9efa035366f61ae6286f30530f5d114f6be86d05"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"99fae8a1bf68504c051e4b544de27373dc40e6a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"393daa38_648f8b85","updated":"2023-09-28 05:59:27.000000000","message":"Downgrading to a +1 until the CI is green on this.","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"03a8d90ce700881178785dac9e7ee6c826d59770","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2c96e1d2_e4306ff1","updated":"2023-09-28 04:54:34.000000000","message":"PowerFlex os-brick CI [1] fails on:\n\u0027AssertionError: helper_command requires priv_context pypath for context object\u0027","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"9faa7178f7c1c67510e5ec5d988b51c50cdb9c52","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4bcece9f_52b22a9b","updated":"2023-09-28 05:08:48.000000000","message":"PowerFlex os-brick CI fails on below errors[1] when reading the Powerflex config file \u0027connector.conf\u0027:\n\u0027AssertionError: helper_command requires priv_context pypath for context object\u0027\n\nThis error occurs in the lib \u0027oslo_privsep\u0027[2]. It\u0027s not cause by this patch, but it prevents the PowerFlex driver from attaching and detaching volumes.\n\nPlease advise how to proceed?\nThanks!\n\n[1] https://elab-os-logsrv.delllabs.net/84/876284/13/check/DellEMC_PowerFlex_os-brick/26086d7/DellEMC_PowerFlex_os-brick/75/logs/screen-c-vol.txt.gz\n\n[2] https://github.com/openstack/oslo.privsep/blob/master/oslo_privsep/priv_context.py#L186","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5bb63fd09e456c43129f82e1f9acf6a41695c325","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f59651e5_259e820a","updated":"2023-09-28 10:14:55.000000000","message":"The revert of the problematic patch[1] has been created, let\u0027s monitor the CI after that patch merges.\n\n[1] https://review.opendev.org/#/q/I0292a30f402e","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"661a6efa56557b7948df72afc6e5de3b7336c27e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"453d2119_eab4d51d","updated":"2023-10-03 11:52:18.000000000","message":"recheck","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e9d4537e237dfefb9e49f40aa7e6ee1a1f08023b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f81154d6_9147433d","updated":"2023-09-27 11:13:34.000000000","message":"recheck","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"dffd4456994c619413bcf73b1af9200f29790f7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"87fab198_2879c789","updated":"2023-09-27 09:04:41.000000000","message":"recheck os-brick-src-tempest-lvm-lio-barbican failure","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"aa25d30130478c0998b77f170161dedf79bf2053","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c42f94cf_de949871","updated":"2023-09-27 21:13:18.000000000","message":"recheck os-brick-src-tempest-lvm-lio-barbican issue was fixed by https://review.opendev.org/c/openstack/cinderlib/+/896658","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0931148462996272e4574b6b6bc3b07b50fe9b5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d3133219_4209c2e5","updated":"2023-10-02 15:14:21.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"86b41c2af6cdcc0a07dffb62829bc173f1533e51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ecb58a14_13d5fc39","updated":"2023-09-28 03:39:07.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"40256d025df1c5ab34de0f041ce645d571d98e66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"825e82b0_afcaadda","updated":"2023-09-28 17:28:20.000000000","message":"run-DellEMC PowerFlex CI\n\nthe revert is merged, let\u0027s see if the CI passes","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"faae28ad6dd4de3d52574fe4e6f2dddfb4b31220","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7f17b8f7_19badeb0","in_reply_to":"319d91a6_aaca01a7","updated":"2023-10-03 11:53:15.000000000","message":"Ack","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"99fae8a1bf68504c051e4b544de27373dc40e6a6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"319d91a6_aaca01a7","in_reply_to":"4bcece9f_52b22a9b","updated":"2023-09-28 05:59:27.000000000","message":"I took a quick look at the oslo code and the last commit to touch oslo_privsep/priv_context.py was over 2 years ago, so nothing has changed there.  If you look at the recent os-brick changes, though, we merged a change a week ago that touches the scaleio priviliged code:\n\nhttps://review.opendev.org/#/q/I0292a30f402e\n\nand if you take a look at the powerflex CI runs for that review, looks like they never passed, and it also looks like they have the same error you are now seeing here.  So I think that patch is the culprit.\n\nSome more evidence is that the last change to touch the scaleio connector itself was https://review.opendev.org/#/q/I928c97ea977f roughly a week ago, and you can see that the powerflex CI was green for that patch.  It required a merge commit, so I bet that it was tested without I0292a30f402e being present.\n\nSo I think your next step is to take a closer look at https://review.opendev.org/#/q/I0292a30f402e","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"f3d6694f1a379b50bfeb084e135cb7ac8f693ea5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"8a48435b_118b6503","updated":"2023-10-17 06:59:06.000000000","message":"CI is in good shape. Please kindly review the change. Thank you!","commit_id":"14b024c505e68617a50af655d04aaa86b34d15c0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7f7a45a43c317c547d0abdc6312f87de36fcb94c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"14ba5ff5_e49e49b6","updated":"2024-02-21 14:44:01.000000000","message":"CI is passing now, so upgrading from +1 to +2","commit_id":"14b024c505e68617a50af655d04aaa86b34d15c0"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"9b101bd5e9849e24c11ea4388e5cde7f55f4aa86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"4474148e_4881fc35","updated":"2024-01-19 14:19:36.000000000","message":"Looks good to me - thank you!","commit_id":"14b024c505e68617a50af655d04aaa86b34d15c0"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"5ec822df4388dbff87ce96b8f0a73ad915688582","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"c707484c_42d32755","updated":"2023-10-30 17:30:47.000000000","message":"This looks safe to me.","commit_id":"14b024c505e68617a50af655d04aaa86b34d15c0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eff5e0f8b0a39f0f7cd080f5388850aaf931fc09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1d2ac119_b5431b0b","updated":"2024-02-21 14:38:44.000000000","message":"powerflex CI is reporting success now, LGTM\n\nDellEMC_PowerFlex_os-brick https://elab-os-logsrv.delllabs.net/84/876284/14/check/DellEMC_PowerFlex_os-brick/5aa7691/DellEMC_PowerFlex_os-brick/83 : SUCCESS in 1h 06m 11s","commit_id":"14b024c505e68617a50af655d04aaa86b34d15c0"}],"os_brick/initiator/connectors/scaleio.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"2934099bbd3c96155ef5dc2eb3ede172d3c52339","unresolved":true,"context_lines":[{"line_number":336,"context_line":"        self.server_password, server_token \u003d self._get_password_token("},{"line_number":337,"context_line":"            connection_properties)"},{"line_number":338,"context_line":"        if server_token:"},{"line_number":339,"context_line":"            self.server_token \u003d server_token"},{"line_number":340,"context_line":"        self.iops_limit \u003d connection_properties[\u0027iopsLimit\u0027]"},{"line_number":341,"context_line":"        self.bandwidth_limit \u003d connection_properties[\u0027bandwidthLimit\u0027]"},{"line_number":342,"context_line":"        self.verify_certificate \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"dd585fe5_daa7d60d","line":339,"updated":"2023-04-19 15:08:11.000000000","message":"I don\u0027t mind if the vendor\u0027s responsible maintainer wants to change the behavior this way. I\u0027m sure they know better. However, what\u0027s up with this weird defensive programming? The self.server_token is initiated to None, and the code using it expects None. Can _get_password_token() return a server_token that evaluates to False, for example empty, but is not None? Very curious, please explain.","commit_id":"3cd2f8c107a33d2097dc4762ff5dd38511638c52"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"d5c99e0f0468cc94a44113434d784e9d4846e6d0","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        self.server_password, server_token \u003d self._get_password_token("},{"line_number":337,"context_line":"            connection_properties)"},{"line_number":338,"context_line":"        if server_token:"},{"line_number":339,"context_line":"            self.server_token \u003d server_token"},{"line_number":340,"context_line":"        self.iops_limit \u003d connection_properties[\u0027iopsLimit\u0027]"},{"line_number":341,"context_line":"        self.bandwidth_limit \u003d connection_properties[\u0027bandwidthLimit\u0027]"},{"line_number":342,"context_line":"        self.verify_certificate \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"d372ef8b_48f5a2c7","line":339,"in_reply_to":"3b831b73_12816dea","updated":"2023-05-19 16:49:10.000000000","message":"Done","commit_id":"3cd2f8c107a33d2097dc4762ff5dd38511638c52"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"d2b6249ed016feeed48f7fcd89f221cbc579456d","unresolved":true,"context_lines":[{"line_number":336,"context_line":"        self.server_password, server_token \u003d self._get_password_token("},{"line_number":337,"context_line":"            connection_properties)"},{"line_number":338,"context_line":"        if server_token:"},{"line_number":339,"context_line":"            self.server_token \u003d server_token"},{"line_number":340,"context_line":"        self.iops_limit \u003d connection_properties[\u0027iopsLimit\u0027]"},{"line_number":341,"context_line":"        self.bandwidth_limit \u003d connection_properties[\u0027bandwidthLimit\u0027]"},{"line_number":342,"context_line":"        self.verify_certificate \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"3b831b73_12816dea","line":339,"in_reply_to":"dd585fe5_daa7d60d","updated":"2023-05-19 16:49:02.000000000","message":"The problem was that _get_password_token() get overwriting the token everytime get_config was called.","commit_id":"3cd2f8c107a33d2097dc4762ff5dd38511638c52"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"d2bf15191f35a1c6c00bbd312c352e1dc3ebee29","unresolved":true,"context_lines":[{"line_number":333,"context_line":"        self.server_ip \u003d connection_properties[\u0027serverIP\u0027]"},{"line_number":334,"context_line":"        self.server_port \u003d connection_properties[\u0027serverPort\u0027]"},{"line_number":335,"context_line":"        self.server_username \u003d connection_properties[\u0027serverUsername\u0027]"},{"line_number":336,"context_line":"        self.server_password \u003d self._get_password_token("},{"line_number":337,"context_line":"            connection_properties)"},{"line_number":338,"context_line":"        self.iops_limit \u003d connection_properties[\u0027iopsLimit\u0027]"},{"line_number":339,"context_line":"        self.bandwidth_limit \u003d connection_properties[\u0027bandwidthLimit\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"dd7ebc6b_8b4aac41","line":336,"updated":"2023-05-19 20:16:10.000000000","message":"I\u0027m sorry, looks like I prompted a correction that was not correct, perhaps? The function was renamed to _get_password, but the call remained _get_password_token. This cannot possibly work, or am I missing something?","commit_id":"4f767da9c5f7773128abf0c05de1787070cdb154"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"a243eaf20895e6aa1ee5c0e8caa7c4634095253a","unresolved":true,"context_lines":[{"line_number":333,"context_line":"        self.server_ip \u003d connection_properties[\u0027serverIP\u0027]"},{"line_number":334,"context_line":"        self.server_port \u003d connection_properties[\u0027serverPort\u0027]"},{"line_number":335,"context_line":"        self.server_username \u003d connection_properties[\u0027serverUsername\u0027]"},{"line_number":336,"context_line":"        self.server_password \u003d self._get_password_token("},{"line_number":337,"context_line":"            connection_properties)"},{"line_number":338,"context_line":"        self.iops_limit \u003d connection_properties[\u0027iopsLimit\u0027]"},{"line_number":339,"context_line":"        self.bandwidth_limit \u003d connection_properties[\u0027bandwidthLimit\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff6802fb_9cdf09cf","line":336,"in_reply_to":"dd7ebc6b_8b4aac41","updated":"2023-05-22 16:17:00.000000000","message":"You are right. I ran the unit tests then decided to change the function name. I should have rerun testing to catch the mistake.","commit_id":"4f767da9c5f7773128abf0c05de1787070cdb154"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"ca45d8158dfe8e2b2677ff8f837546fa6c7bc9cc","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        self.server_ip \u003d connection_properties[\u0027serverIP\u0027]"},{"line_number":334,"context_line":"        self.server_port \u003d connection_properties[\u0027serverPort\u0027]"},{"line_number":335,"context_line":"        self.server_username \u003d connection_properties[\u0027serverUsername\u0027]"},{"line_number":336,"context_line":"        self.server_password \u003d self._get_password_token("},{"line_number":337,"context_line":"            connection_properties)"},{"line_number":338,"context_line":"        self.iops_limit \u003d connection_properties[\u0027iopsLimit\u0027]"},{"line_number":339,"context_line":"        self.bandwidth_limit \u003d connection_properties[\u0027bandwidthLimit\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"f14c8dfd_13c34e56","line":336,"in_reply_to":"ff6802fb_9cdf09cf","updated":"2023-05-30 13:50:42.000000000","message":"Done","commit_id":"4f767da9c5f7773128abf0c05de1787070cdb154"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2f2baac5a887a4e5b854cf0a1243e2fa57e3307e","unresolved":true,"context_lines":[{"line_number":333,"context_line":"        self.server_ip \u003d connection_properties[\u0027serverIP\u0027]"},{"line_number":334,"context_line":"        self.server_port \u003d connection_properties[\u0027serverPort\u0027]"},{"line_number":335,"context_line":"        self.server_username \u003d connection_properties[\u0027serverUsername\u0027]"},{"line_number":336,"context_line":"        self.server_password, self.server_token \u003d self._get_password_token("},{"line_number":337,"context_line":"            connection_properties)"},{"line_number":338,"context_line":"        self.iops_limit \u003d connection_properties[\u0027iopsLimit\u0027]"},{"line_number":339,"context_line":"        self.bandwidth_limit \u003d connection_properties[\u0027bandwidthLimit\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"ca354809_e7e4bef5","side":"PARENT","line":336,"range":{"start_line":336,"start_character":8,"end_line":336,"end_character":47},"updated":"2023-09-15 16:02:45.000000000","message":"Note that the old code separated out the password and the token into different variables.  Thus the password was always a singular thing (which I imagine would be a string).","commit_id":"a0bc09ba50aae1a3f6c3601a4b90c5cb1a84b565"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"cca9ab02c824c68348a2f5e868038bf44b228e99","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        self.server_ip \u003d connection_properties[\u0027serverIP\u0027]"},{"line_number":334,"context_line":"        self.server_port \u003d connection_properties[\u0027serverPort\u0027]"},{"line_number":335,"context_line":"        self.server_username \u003d connection_properties[\u0027serverUsername\u0027]"},{"line_number":336,"context_line":"        self.server_password, self.server_token \u003d self._get_password_token("},{"line_number":337,"context_line":"            connection_properties)"},{"line_number":338,"context_line":"        self.iops_limit \u003d connection_properties[\u0027iopsLimit\u0027]"},{"line_number":339,"context_line":"        self.bandwidth_limit \u003d connection_properties[\u0027bandwidthLimit\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"4160a212_97be3de4","side":"PARENT","line":336,"range":{"start_line":336,"start_character":8,"end_line":336,"end_character":47},"in_reply_to":"ca354809_e7e4bef5","updated":"2023-09-20 11:52:56.000000000","message":"Done","commit_id":"a0bc09ba50aae1a3f6c3601a4b90c5cb1a84b565"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"908ce971ba9bb46877adb17093e41813d179eb45","unresolved":true,"context_lines":[{"line_number":90,"context_line":"    def _get_password(connection_properties):"},{"line_number":91,"context_line":"        # In old connection format we had the password and token in properties"},{"line_number":92,"context_line":"        if \u0027serverPassword\u0027 in connection_properties:"},{"line_number":93,"context_line":"            return (connection_properties[\u0027serverPassword\u0027],"},{"line_number":94,"context_line":"                    connection_properties[\u0027serverToken\u0027])"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # The new format reads password from file and doesn\u0027t have the token"},{"line_number":97,"context_line":"        LOG.info(\"Get ScaleIO connector password from configuration file\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"a5f4884c_fe19fca4","line":94,"range":{"start_line":93,"start_character":19,"end_line":94,"end_character":57},"updated":"2023-09-20 10:56:23.000000000","message":"Agree with Brian that the return value should be consistent else we could break if we enter this case","commit_id":"64b1262a40649ab6b90a59e5372350aee5d3759e"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"cca9ab02c824c68348a2f5e868038bf44b228e99","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def _get_password(connection_properties):"},{"line_number":91,"context_line":"        # In old connection format we had the password and token in properties"},{"line_number":92,"context_line":"        if \u0027serverPassword\u0027 in connection_properties:"},{"line_number":93,"context_line":"            return (connection_properties[\u0027serverPassword\u0027],"},{"line_number":94,"context_line":"                    connection_properties[\u0027serverToken\u0027])"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # The new format reads password from file and doesn\u0027t have the token"},{"line_number":97,"context_line":"        LOG.info(\"Get ScaleIO connector password from configuration file\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"2a8e963c_f8b26c64","line":94,"range":{"start_line":93,"start_character":19,"end_line":94,"end_character":57},"in_reply_to":"a5f4884c_fe19fca4","updated":"2023-09-20 11:52:56.000000000","message":"Done","commit_id":"64b1262a40649ab6b90a59e5372350aee5d3759e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2f2baac5a887a4e5b854cf0a1243e2fa57e3307e","unresolved":true,"context_lines":[{"line_number":333,"context_line":"        self.server_ip \u003d connection_properties[\u0027serverIP\u0027]"},{"line_number":334,"context_line":"        self.server_port \u003d connection_properties[\u0027serverPort\u0027]"},{"line_number":335,"context_line":"        self.server_username \u003d connection_properties[\u0027serverUsername\u0027]"},{"line_number":336,"context_line":"        self.server_password \u003d self._get_password("},{"line_number":337,"context_line":"            connection_properties)"},{"line_number":338,"context_line":"        self.iops_limit \u003d connection_properties[\u0027iopsLimit\u0027]"},{"line_number":339,"context_line":"        self.bandwidth_limit \u003d connection_properties[\u0027bandwidthLimit\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"b54475c1_7c1418e0","line":336,"range":{"start_line":336,"start_character":8,"end_line":336,"end_character":28},"updated":"2023-09-15 16:02:45.000000000","message":"If _get_password() takes the branch at line 92, you are going to have a tuple in self.server_password.  I imagine that all the current code is based on the assumption that this contains a string, not a tuple.  You haven\u0027t changed anything else, so my intuition is that something could break (like line 292, for instance).","commit_id":"64b1262a40649ab6b90a59e5372350aee5d3759e"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"cca9ab02c824c68348a2f5e868038bf44b228e99","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        self.server_ip \u003d connection_properties[\u0027serverIP\u0027]"},{"line_number":334,"context_line":"        self.server_port \u003d connection_properties[\u0027serverPort\u0027]"},{"line_number":335,"context_line":"        self.server_username \u003d connection_properties[\u0027serverUsername\u0027]"},{"line_number":336,"context_line":"        self.server_password \u003d self._get_password("},{"line_number":337,"context_line":"            connection_properties)"},{"line_number":338,"context_line":"        self.iops_limit \u003d connection_properties[\u0027iopsLimit\u0027]"},{"line_number":339,"context_line":"        self.bandwidth_limit \u003d connection_properties[\u0027bandwidthLimit\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"35bbfa09_f11d0db0","line":336,"range":{"start_line":336,"start_character":8,"end_line":336,"end_character":28},"in_reply_to":"b54475c1_7c1418e0","updated":"2023-09-20 11:52:56.000000000","message":"Done","commit_id":"64b1262a40649ab6b90a59e5372350aee5d3759e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"064fd22d14aff8e1f6f1b16fda250cf126ce9a0a","unresolved":true,"context_lines":[{"line_number":333,"context_line":"        self.server_ip \u003d connection_properties[\u0027serverIP\u0027]"},{"line_number":334,"context_line":"        self.server_port \u003d connection_properties[\u0027serverPort\u0027]"},{"line_number":335,"context_line":"        self.server_username \u003d connection_properties[\u0027serverUsername\u0027]"},{"line_number":336,"context_line":"        self.server_password, _ \u003d self._get_password_token("},{"line_number":337,"context_line":"            connection_properties)"},{"line_number":338,"context_line":"        self.iops_limit \u003d connection_properties[\u0027iopsLimit\u0027]"},{"line_number":339,"context_line":"        self.bandwidth_limit \u003d connection_properties[\u0027bandwidthLimit\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"af4c46a7_fe55f1c1","line":336,"range":{"start_line":336,"start_character":30,"end_line":336,"end_character":31},"updated":"2023-09-20 14:48:32.000000000","message":"correct my understanding if I\u0027m wrong,\n\nthis is the only place that calls _get_password_token method\nif the method returns connection_properties[\u0027serverToken\u0027] then we are ignoring it so I\u0027m not sure what is the purpose of returning the second part of it?\nIt would be better to just return 1 variable i.e. server_password from the _get_password_token method","commit_id":"3225edc574fb44c4ef57af5a9fdcc9102ab67bb7"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"3b4a4d765b365d6f12d7789954f3d814b2558ba6","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        self.server_ip \u003d connection_properties[\u0027serverIP\u0027]"},{"line_number":334,"context_line":"        self.server_port \u003d connection_properties[\u0027serverPort\u0027]"},{"line_number":335,"context_line":"        self.server_username \u003d connection_properties[\u0027serverUsername\u0027]"},{"line_number":336,"context_line":"        self.server_password, _ \u003d self._get_password_token("},{"line_number":337,"context_line":"            connection_properties)"},{"line_number":338,"context_line":"        self.iops_limit \u003d connection_properties[\u0027iopsLimit\u0027]"},{"line_number":339,"context_line":"        self.bandwidth_limit \u003d connection_properties[\u0027bandwidthLimit\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"c7bfdf87_7a824952","line":336,"range":{"start_line":336,"start_character":30,"end_line":336,"end_character":31},"in_reply_to":"af4c46a7_fe55f1c1","updated":"2023-09-20 16:20:39.000000000","message":"Done","commit_id":"3225edc574fb44c4ef57af5a9fdcc9102ab67bb7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fee3c046f36169b9653b14b051f00726b7338c89","unresolved":true,"context_lines":[{"line_number":337,"context_line":"        self.server_password, server_token \u003d self._get_password_token("},{"line_number":338,"context_line":"            connection_properties)"},{"line_number":339,"context_line":"        if server_token:"},{"line_number":340,"context_line":"            self.server_token \u003d server_token"},{"line_number":341,"context_line":"        self.iops_limit \u003d connection_properties[\u0027iopsLimit\u0027]"},{"line_number":342,"context_line":"        self.bandwidth_limit \u003d connection_properties[\u0027bandwidthLimit\u0027]"},{"line_number":343,"context_line":"        self.verify_certificate \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"d9a22224_ec8c1880","line":340,"updated":"2023-09-27 14:42:00.000000000","message":"OK, this makes a lot more sense.  If we don\u0027t get a token from this response, we will continue to use the current self.server_token, and an expired token will be handled the way it\u0027s always been handled, by a re-login during _check_response().","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"03a8d90ce700881178785dac9e7ee6c826d59770","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        self.server_password, server_token \u003d self._get_password_token("},{"line_number":338,"context_line":"            connection_properties)"},{"line_number":339,"context_line":"        if server_token:"},{"line_number":340,"context_line":"            self.server_token \u003d server_token"},{"line_number":341,"context_line":"        self.iops_limit \u003d connection_properties[\u0027iopsLimit\u0027]"},{"line_number":342,"context_line":"        self.bandwidth_limit \u003d connection_properties[\u0027bandwidthLimit\u0027]"},{"line_number":343,"context_line":"        self.verify_certificate \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"802f46df_1a2aad18","line":340,"in_reply_to":"d9a22224_ec8c1880","updated":"2023-09-28 04:54:34.000000000","message":"Done","commit_id":"3c2cdc12b417fcc81e72d10b056241960f1ba61e"}],"releasenotes/notes/bug-2004630-e94616509a51258c.yaml":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"c4538924b04d397b2c64d4b7d4074f79f9f5d86f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 2004630 \u003chttps://bugs.launchpad.net/cinder/+bug/2004630\u003e`_]"},{"line_number":5,"context_line":"    os_brick token cache is broken from commit 746109. This patch restores."},{"line_number":6,"context_line":"    This patch restore functionality in get_config to avoid unnecessary login"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ddc0e7f6_78eae507","line":4,"updated":"2023-03-09 19:49:29.000000000","message":"Dell PowerFlex (ScaleIO) connector bug","commit_id":"402e64bb6a6a322ceb4fcdf42cb6d3417f69574b"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"ce135159d6ffc495cab9fdfe7cc1e1b3d2625501","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 2004630 \u003chttps://bugs.launchpad.net/cinder/+bug/2004630\u003e`_]"},{"line_number":5,"context_line":"    os_brick token cache is broken from commit 746109. This patch restores."},{"line_number":6,"context_line":"    This patch restore functionality in get_config to avoid unnecessary login"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d37cfed5_e67f9fd5","line":4,"in_reply_to":"ddc0e7f6_78eae507","updated":"2023-03-13 17:23:11.000000000","message":"Done","commit_id":"402e64bb6a6a322ceb4fcdf42cb6d3417f69574b"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"c710ef66f357231728b08cd9ce8017a3af3b265b","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 2004630 \u003chttps://bugs.launchpad.net/cinder/+bug/2004630\u003e`_]"},{"line_number":5,"context_line":"    os_brick token cache is broken from commit 746109. This patch restores."},{"line_number":6,"context_line":"    This patch restore functionality in get_config to avoid unnecessary login"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"06e57b99_ab88b098","line":5,"updated":"2023-03-09 19:32:03.000000000","message":"This sentence doesn\u0027t look good, there\u0027s two times \u0027This patch restores\u0027\nos_brick token is not broken, that\u0027s the way the PowerFlex driver is getting his token which is broken, please rephrase it.","commit_id":"402e64bb6a6a322ceb4fcdf42cb6d3417f69574b"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"ce135159d6ffc495cab9fdfe7cc1e1b3d2625501","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 2004630 \u003chttps://bugs.launchpad.net/cinder/+bug/2004630\u003e`_]"},{"line_number":5,"context_line":"    os_brick token cache is broken from commit 746109. This patch restores."},{"line_number":6,"context_line":"    This patch restore functionality in get_config to avoid unnecessary login"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f7b038da_33a987b3","line":5,"in_reply_to":"06e57b99_ab88b098","updated":"2023-03-13 17:23:11.000000000","message":"Done","commit_id":"402e64bb6a6a322ceb4fcdf42cb6d3417f69574b"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"33699e0d36935c809d2bcbcdebea2169398db059","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerFlex (ScaleIO) connector bug"},{"line_number":5,"context_line":"    Commit 746109 broke the way PowerFlex gets Token from os-brick."},{"line_number":6,"context_line":"    This patch restores functionality in get_config to avoid unnecessary"},{"line_number":7,"context_line":"    logins."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"964a75a7_9169d0cb","line":4,"updated":"2023-03-13 18:07:28.000000000","message":"formerly named ScaleIO","commit_id":"7bc6b5fb85d3b75883bf67e8d9210a3596d80dde"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"97ab1fd01636e1f515f04d04a043176bafba5d62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerFlex (ScaleIO) connector bug"},{"line_number":5,"context_line":"    Commit 746109 broke the way PowerFlex gets Token from os-brick."},{"line_number":6,"context_line":"    This patch restores functionality in get_config to avoid unnecessary"},{"line_number":7,"context_line":"    logins."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cb4f02f9_ff0469cf","line":4,"in_reply_to":"964a75a7_9169d0cb","updated":"2023-03-14 13:54:52.000000000","message":"Done","commit_id":"7bc6b5fb85d3b75883bf67e8d9210a3596d80dde"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"74b22f2c186f14e65c265b969e55915e2803fe2c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerFlex formerly named ScaleIO connector bug"},{"line_number":5,"context_line":"    Commit 746109 broke the way PowerFlex gets Token from os-brick."},{"line_number":6,"context_line":"    This patch restores functionality in get_config to avoid unnecessary"},{"line_number":7,"context_line":"    logins."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3cf3d74c_ad126e1e","line":4,"updated":"2023-04-20 12:11:30.000000000","message":"In release notes, we need to provide launchpad bug url.\nKindly refer:\nhttps://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers","commit_id":"3cd2f8c107a33d2097dc4762ff5dd38511638c52"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"d2b6249ed016feeed48f7fcd89f221cbc579456d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerFlex formerly named ScaleIO connector bug"},{"line_number":5,"context_line":"    Commit 746109 broke the way PowerFlex gets Token from os-brick."},{"line_number":6,"context_line":"    This patch restores functionality in get_config to avoid unnecessary"},{"line_number":7,"context_line":"    logins."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a0c25f47_147d757c","line":4,"in_reply_to":"3cf3d74c_ad126e1e","updated":"2023-05-19 16:49:02.000000000","message":"Done","commit_id":"3cd2f8c107a33d2097dc4762ff5dd38511638c52"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"4227c3e9daf34fade141311b21781ce4a98a2e15","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerFlex driver `bug #2004630 "},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2004630\u003e`_:"},{"line_number":6,"context_line":"    Dell PowerFlex formerly named ScaleIO connector bug"},{"line_number":7,"context_line":"    Commit 746109 broke the way PowerFlex gets Token from os-brick."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"51ae696c_d7ac443c","line":4,"updated":"2023-07-21 14:54:46.000000000","message":"nit: remove trailing space","commit_id":"bb2ee29a5a971fe7c6e3fa05743dc69b0db7b5d4"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"7ffc5a66bd5a464a118855adeabe0bfb4ebb3efb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerFlex driver `bug #2004630 "},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2004630\u003e`_:"},{"line_number":6,"context_line":"    Dell PowerFlex formerly named ScaleIO connector bug"},{"line_number":7,"context_line":"    Commit 746109 broke the way PowerFlex gets Token from os-brick."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"64f50a66_f441d934","line":4,"in_reply_to":"29211151_e70d9c27","updated":"2023-07-26 17:19:14.000000000","message":"Done","commit_id":"bb2ee29a5a971fe7c6e3fa05743dc69b0db7b5d4"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"ed0d69e646f71d40626eea19cfba697a9e297e5c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerFlex driver `bug #2004630 "},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2004630\u003e`_:"},{"line_number":6,"context_line":"    Dell PowerFlex formerly named ScaleIO connector bug"},{"line_number":7,"context_line":"    Commit 746109 broke the way PowerFlex gets Token from os-brick."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"29211151_e70d9c27","line":4,"in_reply_to":"51ae696c_d7ac443c","updated":"2023-07-26 17:18:55.000000000","message":"Thanks for the review! Done","commit_id":"bb2ee29a5a971fe7c6e3fa05743dc69b0db7b5d4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"722cb5259c53145c8b90633a2e77851439be04f8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    PowerFlex driver `bug #2004630 "},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2004630\u003e`_:"},{"line_number":6,"context_line":"    Dell PowerFlex formerly named ScaleIO connector bug"},{"line_number":7,"context_line":"    Commit 746109 broke the way PowerFlex gets Token from os-brick."},{"line_number":8,"context_line":"    This patch restores functionality in get_config to avoid unnecessary"},{"line_number":9,"context_line":"    logins."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"cba5c2b7_5da7c123","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":67},"updated":"2023-07-21 15:23:55.000000000","message":"we don\u0027t want to mention this information in the releasenote.","commit_id":"bb2ee29a5a971fe7c6e3fa05743dc69b0db7b5d4"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"ed0d69e646f71d40626eea19cfba697a9e297e5c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    PowerFlex driver `bug #2004630 "},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2004630\u003e`_:"},{"line_number":6,"context_line":"    Dell PowerFlex formerly named ScaleIO connector bug"},{"line_number":7,"context_line":"    Commit 746109 broke the way PowerFlex gets Token from os-brick."},{"line_number":8,"context_line":"    This patch restores functionality in get_config to avoid unnecessary"},{"line_number":9,"context_line":"    logins."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"156e74bc_b83f9ee0","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":67},"in_reply_to":"cba5c2b7_5da7c123","updated":"2023-07-26 17:18:55.000000000","message":"Done","commit_id":"bb2ee29a5a971fe7c6e3fa05743dc69b0db7b5d4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"722cb5259c53145c8b90633a2e77851439be04f8","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerFlex driver `bug #2004630 "},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2004630\u003e`_:"},{"line_number":6,"context_line":"    Dell PowerFlex formerly named ScaleIO connector bug"},{"line_number":7,"context_line":"    Commit 746109 broke the way PowerFlex gets Token from os-brick."},{"line_number":8,"context_line":"    This patch restores functionality in get_config to avoid unnecessary"},{"line_number":9,"context_line":"    logins."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1b395b0c_238fbe23","line":9,"range":{"start_line":6,"start_character":4,"end_line":9,"end_character":11},"updated":"2023-07-21 15:23:55.000000000","message":"A better way to say this would be,\n\nFixed regression which caused the ScaleIO connector to login multiple times, even with an existing valid token.  The ScaleIO connector now caches and reuses the token.","commit_id":"bb2ee29a5a971fe7c6e3fa05743dc69b0db7b5d4"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"ed0d69e646f71d40626eea19cfba697a9e297e5c","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerFlex driver `bug #2004630 "},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2004630\u003e`_:"},{"line_number":6,"context_line":"    Dell PowerFlex formerly named ScaleIO connector bug"},{"line_number":7,"context_line":"    Commit 746109 broke the way PowerFlex gets Token from os-brick."},{"line_number":8,"context_line":"    This patch restores functionality in get_config to avoid unnecessary"},{"line_number":9,"context_line":"    logins."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"711ccdfe_10657bb0","line":9,"range":{"start_line":6,"start_character":4,"end_line":9,"end_character":11},"in_reply_to":"1b395b0c_238fbe23","updated":"2023-07-26 17:18:55.000000000","message":"Thanks, good input. Done!","commit_id":"bb2ee29a5a971fe7c6e3fa05743dc69b0db7b5d4"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"7ffc5a66bd5a464a118855adeabe0bfb4ebb3efb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerFlex driver `bug #2004630 "},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2004630\u003e`_:"},{"line_number":6,"context_line":"    Dell PowerFlex formerly named ScaleIO connector bug"},{"line_number":7,"context_line":"    Commit 746109 broke the way PowerFlex gets Token from os-brick."},{"line_number":8,"context_line":"    This patch restores functionality in get_config to avoid unnecessary"},{"line_number":9,"context_line":"    logins."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f7f3a709_ac48d639","line":9,"range":{"start_line":6,"start_character":4,"end_line":9,"end_character":11},"in_reply_to":"711ccdfe_10657bb0","updated":"2023-07-26 17:19:14.000000000","message":"Done","commit_id":"bb2ee29a5a971fe7c6e3fa05743dc69b0db7b5d4"}]}