)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f15eef703f68c5fe75b5ea0a4eca29929ef90b66","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix iSCSI disconnect_volume when flush fails"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In a iSCSI multipath environment, when the force ``flag`` is set"},{"line_number":10,"context_line":"and flushing fails, we try a flush second time."},{"line_number":11,"context_line":"Also if the ``ignore_errors`` flag is set, we ignore the exceptions"},{"line_number":12,"context_line":"and let the operation complete successfully without raising"},{"line_number":13,"context_line":"exceptions."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"19deecad_6d142db8","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":46},"updated":"2023-03-27 11:27:26.000000000","message":"nit: to flush a second time","commit_id":"3005f47a3571548237af725d45ae29549c695069"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"322e366ee1522def6144881fd92838fac8d276fa","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix iSCSI disconnect_volume when flush fails"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In a iSCSI multipath environment, when the force ``flag`` is set"},{"line_number":10,"context_line":"and flushing fails, we try a flush second time."},{"line_number":11,"context_line":"Also if the ``ignore_errors`` flag is set, we ignore the exceptions"},{"line_number":12,"context_line":"and let the operation complete successfully without raising"},{"line_number":13,"context_line":"exceptions."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"22af26c3_0a372358","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":46},"in_reply_to":"19deecad_6d142db8","updated":"2023-04-21 06:43:42.000000000","message":"Done","commit_id":"3005f47a3571548237af725d45ae29549c695069"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f15eef703f68c5fe75b5ea0a4eca29929ef90b66","unresolved":true,"context_lines":[{"line_number":25,"context_line":"removed the paths manually."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This patch implements the approach mentioned in 2) to resolve the"},{"line_number":28,"context_line":"issue."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Closes-Bug: #2012251"},{"line_number":31,"context_line":"Change-Id: I828911495a2de550ea997e6f51cc039a7b7fa8cd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6d9497b7_243ee618","line":28,"updated":"2023-03-27 11:27:26.000000000","message":"nit: It also ignores failures on the call to `multipathd del map` to solve the first issue.","commit_id":"3005f47a3571548237af725d45ae29549c695069"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"322e366ee1522def6144881fd92838fac8d276fa","unresolved":false,"context_lines":[{"line_number":25,"context_line":"removed the paths manually."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This patch implements the approach mentioned in 2) to resolve the"},{"line_number":28,"context_line":"issue."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Closes-Bug: #2012251"},{"line_number":31,"context_line":"Change-Id: I828911495a2de550ea997e6f51cc039a7b7fa8cd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a3d90468_7d01af88","line":28,"in_reply_to":"6d9497b7_243ee618","updated":"2023-04-21 06:43:42.000000000","message":"Done","commit_id":"3005f47a3571548237af725d45ae29549c695069"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b58f8136a43391da6a86cd9f7d530e35feaf90fa","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This patch implements the approach mentioned in 2) to resolve the"},{"line_number":28,"context_line":"issue."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Closes-Bug: #2012251"},{"line_number":31,"context_line":"Change-Id: I828911495a2de550ea997e6f51cc039a7b7fa8cd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6bccc18e_6744ee61","line":29,"updated":"2023-04-17 15:11:02.000000000","message":"I had some trouble resolving the commit message with what I was looking at in the patch, so I rewrote it to say what I think is happening.  You don\u0027t have to adopt my text; I\u0027m mainly writing this so you can let me know if I understand what\u0027s going on here.\n\n\nFix iSCSI disconnect_volume when flush fails\n\nThe purpose of providing force\u003dTrue and ignore_errors\u003dTrue is to tell os-brick that we want to disconnect the volume even if flush fails (force) and not raise any exceptions(ignore_errors).  Currently, in an iSCSI multipath environment, disconnect_volume can fail with both parameters True.\n\nThe current flow when disconnecting an iSCSI volume is that if flushing a multipath device fails, we manually remove the device, logout from the target portals, and try the flush again.\n\nThere are two problems here:\n\n1) code problem: The second flush is not wrapped by ExceptionChainer.  This causes it to raise the exception immediately after flush fails irrespective of the value of the ``ignore_errors`` flag.\n\n2) conceptual problem: In this situation, there is no point in making the second flush attempt.  Instead, we should just remove the multipath map from multipathd monitoring since we have already removed the paths manually.\n\nThis patch fixes the conceptual problem, which also fixes the code problem because we aren\u0027t making the problematic second flush.","commit_id":"3005f47a3571548237af725d45ae29549c695069"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"322e366ee1522def6144881fd92838fac8d276fa","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This patch implements the approach mentioned in 2) to resolve the"},{"line_number":28,"context_line":"issue."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Closes-Bug: #2012251"},{"line_number":31,"context_line":"Change-Id: I828911495a2de550ea997e6f51cc039a7b7fa8cd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fd6e5909_b5c49cc2","line":29,"in_reply_to":"6bccc18e_6744ee61","updated":"2023-04-21 06:43:42.000000000","message":"I\u0027ve updated the commit message as this is more easy to understand and also modified the last line based on Gorka\u0027s input.","commit_id":"3005f47a3571548237af725d45ae29549c695069"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"322e366ee1522def6144881fd92838fac8d276fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"10b9fc67_daa4da83","updated":"2023-04-21 06:43:42.000000000","message":"Thanks Brian and Gorka, I will update the retry logic in a separate patch since I still haven\u0027t finalized the approach and don\u0027t want to block this patch till then.","commit_id":"3005f47a3571548237af725d45ae29549c695069"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f15eef703f68c5fe75b5ea0a4eca29929ef90b66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c8d9e0a_93e3442c","updated":"2023-03-27 11:27:26.000000000","message":"Thanks for fixing this one.","commit_id":"3005f47a3571548237af725d45ae29549c695069"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b58f8136a43391da6a86cd9f7d530e35feaf90fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7c98f105_023af225","updated":"2023-04-17 15:11:02.000000000","message":"This looks OK to me, but see my comment on the commit message.","commit_id":"3005f47a3571548237af725d45ae29549c695069"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a18d7ca245d6b8d6df7bdb1cc7adc977b4e5d5c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"86a081f2_f4a73086","updated":"2023-04-21 12:12:48.000000000","message":"Revisions LGTM.","commit_id":"8070ac3bd903a443fbfd02abf8b0554d5d05cac1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"84217a8c488002faf719ece3d4170eddab59a16b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"51660dd6_98dc4568","updated":"2023-04-26 21:55:58.000000000","message":"There are no code changes between PS2 and PS3, so carrying over Gorka\u0027s +2 and approving this patch.","commit_id":"8070ac3bd903a443fbfd02abf8b0554d5d05cac1"}],"os_brick/initiator/linuxscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f15eef703f68c5fe75b5ea0a4eca29929ef90b66","unresolved":true,"context_lines":[{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    def multipath_del_map(self, mpath_device):"},{"line_number":764,"context_line":"        \"\"\"Remove a map from multipathd for monitoring.\"\"\""},{"line_number":765,"context_line":"        stdout, stderr \u003d self._execute(\u0027multipathd\u0027, \u0027del\u0027, \u0027map\u0027,"},{"line_number":766,"context_line":"                                       mpath_device,"},{"line_number":767,"context_line":"                                       run_as_root\u003dTrue, timeout\u003d5,"},{"line_number":768,"context_line":"                                       check_exit_code\u003dFalse,"},{"line_number":769,"context_line":"                                       root_helper\u003dself._root_helper)"},{"line_number":770,"context_line":"        return stdout.strip() \u003d\u003d \u0027ok\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"32c0dce2_5ebddb23","line":769,"range":{"start_line":765,"start_character":0,"end_line":769,"end_character":69},"updated":"2023-03-27 11:27:26.000000000","message":"nit: Maybe we could retry until the device is actually removed, similar to what you are doing in https://review.opendev.org/878242","commit_id":"3005f47a3571548237af725d45ae29549c695069"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"322e366ee1522def6144881fd92838fac8d276fa","unresolved":true,"context_lines":[{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    def multipath_del_map(self, mpath_device):"},{"line_number":764,"context_line":"        \"\"\"Remove a map from multipathd for monitoring.\"\"\""},{"line_number":765,"context_line":"        stdout, stderr \u003d self._execute(\u0027multipathd\u0027, \u0027del\u0027, \u0027map\u0027,"},{"line_number":766,"context_line":"                                       mpath_device,"},{"line_number":767,"context_line":"                                       run_as_root\u003dTrue, timeout\u003d5,"},{"line_number":768,"context_line":"                                       check_exit_code\u003dFalse,"},{"line_number":769,"context_line":"                                       root_helper\u003dself._root_helper)"},{"line_number":770,"context_line":"        return stdout.strip() \u003d\u003d \u0027ok\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9323b7fc_f80bc04e","line":769,"range":{"start_line":765,"start_character":0,"end_line":769,"end_character":69},"in_reply_to":"32c0dce2_5ebddb23","updated":"2023-04-21 06:43:42.000000000","message":"I\u0027m still figuring out the best way to retry and check if the multipath device exists. In the meantime, I don\u0027t want to block this patch so I will address this in a follow up.","commit_id":"3005f47a3571548237af725d45ae29549c695069"}]}