)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"08b92ae41a61dde28899376e247120533fc1b8bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa49ba20_6eca6e70","updated":"2023-08-23 16:29:15.000000000","message":"Code and tests look good.  I think it would be helpful to fix a comment noted inline, and possibly change a type annotation.","commit_id":"5382437042959f97102cc2a7929bbc1196a7086e"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"94522b455061b193cb2339fc5e24f0bf0e6a142e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8add9c47_b99ed4e1","updated":"2023-04-19 11:52:11.000000000","message":"It is indeed a good practice to make your project more robust by ensuring that necessary files and folders are created during the installation process or at runtime, especially when using distribution packages that might not create these files automatically. This can help prevent potential issues and errors.","commit_id":"5382437042959f97102cc2a7929bbc1196a7086e"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"81a1110a11cc91ecb328694a1ecf89fd78609a0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1df89524_72d372c9","updated":"2023-08-23 12:29:59.000000000","message":"run Pure Storage CI","commit_id":"5382437042959f97102cc2a7929bbc1196a7086e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"62e13d4763f8ab8301e46597c0c4000bad542958","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"beff6973_bd66e5b9","updated":"2023-08-23 17:51:02.000000000","message":"LGTM.","commit_id":"16c90d5fe97da04c7c42cbd3fe5505153ce95a91"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"068df11bd4beefe5c3bf5f39999855969b464c12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f1e4642f_b0c64fdd","updated":"2023-08-23 17:32:25.000000000","message":"The changes I requested of Gorka are non-functional (comment change and change in type annotation).  The os-brick-mypy job is green on this patch, so I\u0027m going to carry over Sofia\u0027s +2 from PS1 and ninja-approve this patch.","commit_id":"16c90d5fe97da04c7c42cbd3fe5505153ce95a91"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f140367e2d8fbf5c5c3d0a9e08087d4fabc4d2e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5ee83f67_ff5ef9f0","updated":"2023-08-23 22:30:39.000000000","message":"recheck os-brick-src-tempest-lvm-lio-barbican : test_attach_attached_volume_to_different_server timedout trying to connect to the server","commit_id":"16c90d5fe97da04c7c42cbd3fe5505153ce95a91"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9b794cb6e76c6c5698623a82ed22f828ddacb48b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8a989aca_de9b59dd","updated":"2023-08-24 02:02:38.000000000","message":"recheck os-brick-src-tempest-lvm-lio-barbican hit some server faults","commit_id":"16c90d5fe97da04c7c42cbd3fe5505153ce95a91"}],"os_brick/privileged/nvmeof.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"08b92ae41a61dde28899376e247120533fc1b8bc","unresolved":true,"context_lines":[{"line_number":102,"context_line":"def create_hostid(uuid: Optional[str]) -\u003e Optional[str]:"},{"line_number":103,"context_line":"    \"\"\"Create the hostid to ensure it\u0027s always the same."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    If no uuid is passed in, then we will generate a random one."},{"line_number":106,"context_line":"    \"\"\""},{"line_number":107,"context_line":"    try:"},{"line_number":108,"context_line":"        os.makedirs(\u0027/etc/nvme\u0027, mode\u003d0o755, exist_ok\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f4131ad_3c329325","line":105,"range":{"start_line":105,"start_character":3,"end_line":105,"end_character":64},"updated":"2023-08-23 16:29:15.000000000","message":"Looks like a comment from an earlier design?  The random uuid generation is being done in the utils.get_nvme_host_id function.  If uuid\u003dNone, you\u0027ll get \u0027None\\n\u0027 written to the file.\n\nAlso, your test for when uuid\u003dNone is for get_nvme_host_id, not this function.\n\nI suggest changing the type annotation at line 102 to simply \"uuid: str\" and not allow None to be a passed value for uuid, and removing this comment.","commit_id":"5382437042959f97102cc2a7929bbc1196a7086e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"66d1c1621fad880a785f72ead0284e136d79d22e","unresolved":false,"context_lines":[{"line_number":102,"context_line":"def create_hostid(uuid: Optional[str]) -\u003e Optional[str]:"},{"line_number":103,"context_line":"    \"\"\"Create the hostid to ensure it\u0027s always the same."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    If no uuid is passed in, then we will generate a random one."},{"line_number":106,"context_line":"    \"\"\""},{"line_number":107,"context_line":"    try:"},{"line_number":108,"context_line":"        os.makedirs(\u0027/etc/nvme\u0027, mode\u003d0o755, exist_ok\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"8279c52c_3b1dbd90","line":105,"range":{"start_line":105,"start_character":3,"end_line":105,"end_character":64},"in_reply_to":"7f4131ad_3c329325","updated":"2023-08-23 17:01:57.000000000","message":"I wrote the comment before I refactored the patch, and at that time the method did everything in one place (get and create), but then I decided to split it so that the get method (which is the frequently called code) doesn\u0027t need to go through privsep which is slower.","commit_id":"5382437042959f97102cc2a7929bbc1196a7086e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"068df11bd4beefe5c3bf5f39999855969b464c12","unresolved":false,"context_lines":[{"line_number":102,"context_line":"def create_hostid(uuid: Optional[str]) -\u003e Optional[str]:"},{"line_number":103,"context_line":"    \"\"\"Create the hostid to ensure it\u0027s always the same."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    If no uuid is passed in, then we will generate a random one."},{"line_number":106,"context_line":"    \"\"\""},{"line_number":107,"context_line":"    try:"},{"line_number":108,"context_line":"        os.makedirs(\u0027/etc/nvme\u0027, mode\u003d0o755, exist_ok\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"8de3b5d6_e2988659","line":105,"range":{"start_line":105,"start_character":3,"end_line":105,"end_character":64},"in_reply_to":"8279c52c_3b1dbd90","updated":"2023-08-23 17:32:25.000000000","message":"I think your decision to split the get and create makes a lot of sense.","commit_id":"5382437042959f97102cc2a7929bbc1196a7086e"}]}