)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1be99459735d53dd7dcc252417fb7d7a8e51ae02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"18340b80_f071d76b","updated":"2023-09-04 17:02:05.000000000","message":"Shouldn\u0027t we abandon this one now that your other patch has merged? https://review.opendev.org/c/openstack/os-brick/+/878045","commit_id":"6a261fcc2f702306ce8403f7bf6bf9e0b97a6b73"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"eaf65a9b464673ecd173ddb20dc9a3e7a780715f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"362402cb_6a8d2a6a","updated":"2023-11-09 20:43:21.000000000","message":"Something does not add up. The commit message says \"code problem: The second flush (flush_multipath_device) is not wrapped by ExceptionChainer.\" Fair enough, but the replacement is not wrapped either. But it (multipath_del_map) can raise BrickException at the very least. It is wrapped in \"with exc.context\" in FibreChannelConnector.disconnect_volume. Why such wrapping it not necessary in case of iscsi?\n\nI do not understand, so -1 is only for the question, not because I know this is wrong.","commit_id":"6a261fcc2f702306ce8403f7bf6bf9e0b97a6b73"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"682f7e8e7eb11b29eb95957e171dd70169a456b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"403ec19d_caa74c14","updated":"2023-06-16 11:10:37.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"6a261fcc2f702306ce8403f7bf6bf9e0b97a6b73"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"36497c992c20a3906571b415cce87f60e37c8991","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"71705266_aa5cbfa9","updated":"2023-06-19 03:29:53.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"6a261fcc2f702306ce8403f7bf6bf9e0b97a6b73"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"9a491136a1a122cd7dcb30af7bd353bb02df3618","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d99280de_8206a814","updated":"2023-06-19 03:40:24.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"6a261fcc2f702306ce8403f7bf6bf9e0b97a6b73"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"34b8706fd504c1ce85b0e37508d38d0bbf517efc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b3cdbbe5_261f9940","in_reply_to":"18340b80_f071d76b","updated":"2023-11-22 06:06:11.000000000","message":"That patch was reverted and multipath_del_map was added by another patch so this patch reproposes the fix.","commit_id":"6a261fcc2f702306ce8403f7bf6bf9e0b97a6b73"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"34b8706fd504c1ce85b0e37508d38d0bbf517efc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0993ef03_08042a07","in_reply_to":"362402cb_6a8d2a6a","updated":"2023-11-22 06:06:11.000000000","message":"Thanks Pete for pointing that out. In my original change, the multipath_del_map didn\u0027t raise an exception[1] hence the exception chainer was not used but you are right that the multipath_del_map method in master can raise BrickException so fixed it.\n\n[1] https://review.opendev.org/c/openstack/os-brick/+/878045/3/os_brick/initiator/linuxscsi.py","commit_id":"6a261fcc2f702306ce8403f7bf6bf9e0b97a6b73"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"6e085ae0bac82cea51b290ad5384f74350f343a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f9a7bc8f_cfa43b40","updated":"2023-11-22 06:12:29.000000000","message":"I ran  git review -d 883284  and the version 4 had the target_exc fix.","commit_id":"931a95fc3302985c780b32c6ed66d386ba75aec0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3b0cfc18479ee21d1268b434c9767bea1b6c656d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ee20e590_45c0fe3a","updated":"2024-08-16 21:14:26.000000000","message":"LGTM.","commit_id":"931a95fc3302985c780b32c6ed66d386ba75aec0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"34b8706fd504c1ce85b0e37508d38d0bbf517efc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e8bf8dff_34705345","updated":"2023-11-22 06:06:11.000000000","message":"Was facing mypy issues while using the exc variable. fixed it here[1] and rebased on top of it.\n\n[1] https://review.opendev.org/c/openstack/os-brick/+/901646","commit_id":"931a95fc3302985c780b32c6ed66d386ba75aec0"}]}