)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"a379eeb1247c55b0386732f6b14b8639e2d18305","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"37f1bd6a_ad425288","updated":"2023-07-17 01:14:56.000000000","message":"run-TOYOU TYDS CI","commit_id":"f0f987383ecd02b5396f939c1e87bd5ff134d64c"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"d658f2608ea4b1f76f1a5e3369a825782178735d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0aa69cc8_53c6b51d","updated":"2023-07-18 11:24:03.000000000","message":"run-storpoolci","commit_id":"f0f987383ecd02b5396f939c1e87bd5ff134d64c"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"e0f7bb458db80e7b3d719b3d75342c66c2726c52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4db9fff1_9d7217e3","updated":"2023-07-17 08:11:09.000000000","message":"run-storpoolci","commit_id":"f0f987383ecd02b5396f939c1e87bd5ff134d64c"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"caa3217a9c12431e2b80560d03fd1220984c46da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8c2929ec_d9707279","updated":"2023-07-16 12:35:12.000000000","message":"run-storpoolci","commit_id":"f0f987383ecd02b5396f939c1e87bd5ff134d64c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8ff853c6b2bd18c0c9028d5d923c807653623435","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5d5ecc92_22664cbc","updated":"2023-08-22 09:48:48.000000000","message":"Few questions on this:\n\n1. does this require a specific version of storage array that we need to query?\n2. does this require a releasenote stating the changes we might need when upgrading the environment?\n3. Should we support the legacy way of attaching to not break deployments that still rely on the old way? Does this require any changes from the cloud admin?","commit_id":"ce8972e40c1967f01f3d258634c0022bc4b0911c"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"84276773be61ddd7b5940ac5cbc3366e2b5b7555","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"67e7027c_43245141","updated":"2023-08-22 06:31:08.000000000","message":"run-storpoolci","commit_id":"ce8972e40c1967f01f3d258634c0022bc4b0911c"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"705021755c10a823236ad0299453e6ce55c87bb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8f7003b1_69d1636d","in_reply_to":"5d5ecc92_22664cbc","updated":"2023-08-29 07:28:54.000000000","message":"Hi Rajat!\n\n1. No, it does not\n2. Good point, I opened a bug [1] for this and linked it here (+ added a releasenote)\n3. This also handles existing attachments, it should not require a change from the cloud admin.\n\nThanks,\nBiser\n\n[1]: https://bugs.launchpad.net/cinder/+bug/2033292","commit_id":"ce8972e40c1967f01f3d258634c0022bc4b0911c"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"bb86538bf4142e8436ca6a4ca54fd2fa22df8149","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"172238d1_605126be","updated":"2023-08-24 19:18:40.000000000","message":"run-storpoolci","commit_id":"9796697a95172b9c83b1e549f476b9ac4506ef69"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"432e45313419bc9986e5a681b0e02b824910177b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"874d364a_a42dd8d8","updated":"2023-11-13 14:42:24.000000000","message":"check experimental","commit_id":"9f7e659ee9bf41151df94d591e40aefa1ebb9409"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fa75403cd3032ceba5beacb1798b7e8d10e62015","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"90618358_c63ed99a","updated":"2024-01-16 14:28:05.000000000","message":"one comment inline. storpool CI passes, LGTM.","commit_id":"9f7e659ee9bf41151df94d591e40aefa1ebb9409"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7f6189cc89292e9e2d5c7efae4c0e1316685e0c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4df54693_049db58a","updated":"2024-06-28 12:32:52.000000000","message":"minor change in releasenote, storpool CI still passing, LGTM.","commit_id":"c7d006ea7b9e9520a7c0acc1c62ae8f8728c2609"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8e31d602e4ad5c1eda83e55a526204762aae606d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"79cdc703_52c4b4ee","updated":"2024-07-03 14:00:58.000000000","message":"still LGTM","commit_id":"7c2c80c9a54e73bf56a0644e02f0918d29749749"}],"os_brick/initiator/connectors/storpool.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fa75403cd3032ceba5beacb1798b7e8d10e62015","unresolved":true,"context_lines":[{"line_number":71,"context_line":"    def _detach_retry(self, sp_ourid, volume):"},{"line_number":72,"context_line":"        \"\"\"Retry detaching."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        Retries attempt to handle LUKS tests-related failures:"},{"line_number":75,"context_line":"          busy: volume ... open at ..."},{"line_number":76,"context_line":"        \"\"\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        count \u003d 10"},{"line_number":79,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":8,"id":"8221cd3b_4b9ffefb","line":76,"range":{"start_line":74,"start_character":0,"end_line":76,"end_character":0},"updated":"2024-01-16 14:28:05.000000000","message":"seems strange why luks related failures would only show up with storpool, in any case, good to report a bug for it so we can find the actual issue related to this","commit_id":"9f7e659ee9bf41151df94d591e40aefa1ebb9409"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"705fb19931182c8f82998175d27e3cd466c391c1","unresolved":true,"context_lines":[{"line_number":152,"context_line":"                \u0027failed: %s\u0027 % (exc)) from exc"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        sp_global_id \u003d volume_info.globalId"},{"line_number":155,"context_line":"        return {\u0027type\u0027: \u0027block\u0027, \u0027path\u0027: str(DEV_STORPOOL_BYID / sp_global_id)}"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @utils.connect_volume_undo_prepare_result(unlink_after\u003dTrue)"},{"line_number":158,"context_line":"    def disconnect_volume(self, connection_properties, device_info,"}],"source_content_type":"text/x-python","patch_set":9,"id":"abb6ee64_6dc0093c","line":155,"range":{"start_line":155,"start_character":41,"end_line":155,"end_character":78},"updated":"2024-06-28 13:44:49.000000000","message":"I don\u0027t understand what\u0027s happening here -- string divided by string?\n\nWas this supposed to be more like\n\n    str(DEV_STORPOOL_BYID + \u0027/\u0027 + sp_global_id)\n?","commit_id":"c7d006ea7b9e9520a7c0acc1c62ae8f8728c2609"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d2ce67a4128283a377f36f0a666eb0c34a3dfa36","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                \u0027failed: %s\u0027 % (exc)) from exc"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        sp_global_id \u003d volume_info.globalId"},{"line_number":155,"context_line":"        return {\u0027type\u0027: \u0027block\u0027, \u0027path\u0027: str(DEV_STORPOOL_BYID / sp_global_id)}"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @utils.connect_volume_undo_prepare_result(unlink_after\u003dTrue)"},{"line_number":158,"context_line":"    def disconnect_volume(self, connection_properties, device_info,"}],"source_content_type":"text/x-python","patch_set":9,"id":"24b4f9d7_acd9fad3","line":155,"range":{"start_line":155,"start_character":41,"end_line":155,"end_character":78},"in_reply_to":"abb6ee64_6dc0093c","updated":"2024-06-28 14:03:04.000000000","message":"yes, thanks for pointing out.","commit_id":"c7d006ea7b9e9520a7c0acc1c62ae8f8728c2609"}]}