)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"38386ce8211b987e6142c2e8a3ae14aac0f64613","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a6efd05_81ed36c9","updated":"2023-07-13 18:58:32.000000000","message":"recheck\n\nos-brick-src-tempest-lvm-lio-barbican neutron errors","commit_id":"8d7bdc0013da26c06f971d510d55fe745dfa87d6"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"e390f220e4d3c06f6c51ad6d1b67ba2444db1dab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"43b274a2_e0bb0f0d","updated":"2023-08-04 14:39:33.000000000","message":"run-storpoolci","commit_id":"8d7bdc0013da26c06f971d510d55fe745dfa87d6"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"9338fed07ea18593d996bb1de2bde8c3e3fe7fc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d4cf4477_1bcbf226","updated":"2023-07-18 11:24:10.000000000","message":"run-storpoolci","commit_id":"8d7bdc0013da26c06f971d510d55fe745dfa87d6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b0132f3c1e3bd449d324c79724ff331f51767a5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a362c031_ece8377c","updated":"2023-09-15 07:56:20.000000000","message":"What this patch is about? Can you add more details in the description so that it\u0027s more clear to the reviewer?","commit_id":"3abb5932a693933ec231b99d49eefae9161adfbd"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"6102c431f1ed0f166e5404dfa36952214241983f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9ac4ca31_4678dcf5","in_reply_to":"a362c031_ece8377c","updated":"2023-09-20 15:06:59.000000000","message":"Hi happystacker, thanks for the suggestion! Added a few lines to the commit msg.","commit_id":"3abb5932a693933ec231b99d49eefae9161adfbd"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"3bd67bdb7ad0d99a6c6c8d926db6598dfccdc5d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"70749dbb_d38013e1","updated":"2023-11-10 04:17:27.000000000","message":"To be honest, I do not approve of throwing in __init__ of a connector. But the driver does that in the existing code, so this patch isn\u0027t making the situation worse.","commit_id":"f2574ec01b3b0144dcceefd41208b573844b8bbb"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"45f2c9a2239e450e26f193462d88cc6df8660da6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"344abdb0_909214af","updated":"2023-12-01 07:39:36.000000000","message":"run-storpoolci","commit_id":"f2574ec01b3b0144dcceefd41208b573844b8bbb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a4c97929255f04f8c40d37f56d1af2a0c1f25b95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"70e9a648_5709e495","updated":"2024-01-16 14:31:47.000000000","message":"storpool CI passed, changes LGTM.\n\ncinder-storpool-tempest https://spfactory.storpool.com/zuul/t/local/build/6b0fc0f1ccc24473a144aff686e46407 : SUCCESS in 1h 12m 40s","commit_id":"f2574ec01b3b0144dcceefd41208b573844b8bbb"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f395c6929e635ad4c54e9a0b98ef690fa521c566","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f302b055_95c77d2e","updated":"2024-07-05 05:52:11.000000000","message":"Code changes look good. Zuul \u0026 StorPool OpenStack CI have passed.","commit_id":"b290711cfb23603627e9e28c733fceb5184589b5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"984ff493270acbab2a34fbcec8831ef2368e461f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"676c7ba2_7005f1e0","updated":"2024-07-04 03:30:36.000000000","message":"rebased after https://review.opendev.org/c/openstack/os-brick/+/887575 merged","commit_id":"b290711cfb23603627e9e28c733fceb5184589b5"}],"os_brick/initiator/connectors/storpool.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"84915829f174c9585b4569fcfc4fd093ad6cefe1","unresolved":true,"context_lines":[{"line_number":69,"context_line":"            raise exception.BrickException("},{"line_number":70,"context_line":"                \u0027Could not initialize the StorPool API bindings: %s\u0027 % (e))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if \"SP_OURID\" not in self._attach.config():"},{"line_number":73,"context_line":"            raise exception.BrickException("},{"line_number":74,"context_line":"                \u0027Could not read \"SP_OURID\" from the StorPool configuration\"\u0027)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68d186_5de947bb","line":72,"updated":"2023-09-20 15:10:09.000000000","message":"What happens in self._attach.config()?  I\u0027m not sure if this should always happen in __init__.","commit_id":"f2574ec01b3b0144dcceefd41208b573844b8bbb"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"984ff493270acbab2a34fbcec8831ef2368e461f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            raise exception.BrickException("},{"line_number":70,"context_line":"                \u0027Could not initialize the StorPool API bindings: %s\u0027 % (e))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if \"SP_OURID\" not in self._attach.config():"},{"line_number":73,"context_line":"            raise exception.BrickException("},{"line_number":74,"context_line":"                \u0027Could not read \"SP_OURID\" from the StorPool configuration\"\u0027)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ce4eba65_13c56bf0","line":72,"in_reply_to":"1bf8eb99_39d2f997","updated":"2024-07-04 03:30:36.000000000","message":"Done","commit_id":"f2574ec01b3b0144dcceefd41208b573844b8bbb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e906d1f344ffbe1a8478ed3bb497a9ed9465a1d9","unresolved":true,"context_lines":[{"line_number":69,"context_line":"            raise exception.BrickException("},{"line_number":70,"context_line":"                \u0027Could not initialize the StorPool API bindings: %s\u0027 % (e))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if \"SP_OURID\" not in self._attach.config():"},{"line_number":73,"context_line":"            raise exception.BrickException("},{"line_number":74,"context_line":"                \u0027Could not read \"SP_OURID\" from the StorPool configuration\"\u0027)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1bf8eb99_39d2f997","line":72,"in_reply_to":"52d019a2_f5297def","updated":"2023-12-06 15:13:14.000000000","message":"This sounds fine after more review, since it\u0027s lightweight -- raising BrickException() here for missing requirements/config shouldn\u0027t cause problems for users of os-brick.","commit_id":"f2574ec01b3b0144dcceefd41208b573844b8bbb"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"58ad58b0b20984e2eb17e00c20279e657efbbb3f","unresolved":true,"context_lines":[{"line_number":69,"context_line":"            raise exception.BrickException("},{"line_number":70,"context_line":"                \u0027Could not initialize the StorPool API bindings: %s\u0027 % (e))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if \"SP_OURID\" not in self._attach.config():"},{"line_number":73,"context_line":"            raise exception.BrickException("},{"line_number":74,"context_line":"                \u0027Could not read \"SP_OURID\" from the StorPool configuration\"\u0027)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"52d019a2_f5297def","line":72,"in_reply_to":"9a68d186_5de947bb","updated":"2023-09-29 11:56:56.000000000","message":"`self._attach.config()` reads in an ini-style configuration file from\ndisk into a Python dictionary. It also caches this dictionary so further\ncalls don\u0027t have to read in the file again.\n\nThe `SP_OURID` configuration item is required for working with the\nStorPool storage system. It makes sense to error out (and report it)\nearly.","commit_id":"f2574ec01b3b0144dcceefd41208b573844b8bbb"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"3bd67bdb7ad0d99a6c6c8d926db6598dfccdc5d9","unresolved":true,"context_lines":[{"line_number":136,"context_line":"            raise exception.BrickException("},{"line_number":137,"context_line":"                \u0027Invalid access_mode specified in the connection data.\u0027)"},{"line_number":138,"context_line":"        try:"},{"line_number":139,"context_line":"            sp_ourid \u003d self._attach.config()[\"SP_OURID\"]"},{"line_number":140,"context_line":"        except KeyError:"},{"line_number":141,"context_line":"            raise exception.BrickException("},{"line_number":142,"context_line":"                \u0027SP_OURID missing, cannot connect volume %s\u0027 % volume_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"c57d7e73_be6f7616","line":139,"updated":"2023-11-10 04:17:27.000000000","message":"If you add the check into \\__init__, you can remove this try-except.","commit_id":"f2574ec01b3b0144dcceefd41208b573844b8bbb"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"3e25c244ca04dc9f3764d270d4e0fc2e58313d88","unresolved":true,"context_lines":[{"line_number":136,"context_line":"            raise exception.BrickException("},{"line_number":137,"context_line":"                \u0027Invalid access_mode specified in the connection data.\u0027)"},{"line_number":138,"context_line":"        try:"},{"line_number":139,"context_line":"            sp_ourid \u003d self._attach.config()[\"SP_OURID\"]"},{"line_number":140,"context_line":"        except KeyError:"},{"line_number":141,"context_line":"            raise exception.BrickException("},{"line_number":142,"context_line":"                \u0027SP_OURID missing, cannot connect volume %s\u0027 % volume_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ea535593_b665a02d","line":139,"in_reply_to":"5477392b_788fbabf","updated":"2023-12-06 09:20:56.000000000","message":"Expanding a bit on the above.\n\nAt some point we would like to re-read the ini-style configuration that\n`self._attach.config()` loads into a Python dictionary (mentioned in the\nother comment) if the file has been changed.Since `SP_OURID` might now\nbe missing in the changed file, we would need the checks.","commit_id":"f2574ec01b3b0144dcceefd41208b573844b8bbb"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"c7c5ecca1618f1e590d922521a2a46690d0eeaee","unresolved":true,"context_lines":[{"line_number":136,"context_line":"            raise exception.BrickException("},{"line_number":137,"context_line":"                \u0027Invalid access_mode specified in the connection data.\u0027)"},{"line_number":138,"context_line":"        try:"},{"line_number":139,"context_line":"            sp_ourid \u003d self._attach.config()[\"SP_OURID\"]"},{"line_number":140,"context_line":"        except KeyError:"},{"line_number":141,"context_line":"            raise exception.BrickException("},{"line_number":142,"context_line":"                \u0027SP_OURID missing, cannot connect volume %s\u0027 % volume_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5477392b_788fbabf","line":139,"in_reply_to":"c57d7e73_be6f7616","updated":"2023-11-22 15:12:40.000000000","message":"I would like to keep these checks as they would come in handy in a future planned change.","commit_id":"f2574ec01b3b0144dcceefd41208b573844b8bbb"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"984ff493270acbab2a34fbcec8831ef2368e461f","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            raise exception.BrickException("},{"line_number":137,"context_line":"                \u0027Invalid access_mode specified in the connection data.\u0027)"},{"line_number":138,"context_line":"        try:"},{"line_number":139,"context_line":"            sp_ourid \u003d self._attach.config()[\"SP_OURID\"]"},{"line_number":140,"context_line":"        except KeyError:"},{"line_number":141,"context_line":"            raise exception.BrickException("},{"line_number":142,"context_line":"                \u0027SP_OURID missing, cannot connect volume %s\u0027 % volume_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"c95ab158_9129a62e","line":139,"in_reply_to":"cfb58eb3_cbb6534d","updated":"2024-07-04 03:30:36.000000000","message":"Done","commit_id":"f2574ec01b3b0144dcceefd41208b573844b8bbb"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"cc1f3837430c2f812a6253689c08617d34c521a3","unresolved":true,"context_lines":[{"line_number":136,"context_line":"            raise exception.BrickException("},{"line_number":137,"context_line":"                \u0027Invalid access_mode specified in the connection data.\u0027)"},{"line_number":138,"context_line":"        try:"},{"line_number":139,"context_line":"            sp_ourid \u003d self._attach.config()[\"SP_OURID\"]"},{"line_number":140,"context_line":"        except KeyError:"},{"line_number":141,"context_line":"            raise exception.BrickException("},{"line_number":142,"context_line":"                \u0027SP_OURID missing, cannot connect volume %s\u0027 % volume_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"cfb58eb3_cbb6534d","line":139,"in_reply_to":"ea535593_b665a02d","updated":"2024-01-10 15:12:58.000000000","message":"I see, thanks.","commit_id":"f2574ec01b3b0144dcceefd41208b573844b8bbb"}]}