)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"999898da5cc3051ee0834971f4cfc6bdfcd56b8d","unresolved":true,"context_lines":[{"line_number":12,"context_line":"As per the multipathd documentation:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"$map can either be a device-mapper device as listed in /sys/block"},{"line_number":15,"context_line":"(e.g. dm-0) or it can be the alias for the multipath device"},{"line_number":16,"context_line":"(e.g. mpath1) or the uid of the multipath device"},{"line_number":17,"context_line":"(e.g. 36005076303ffc56200000000000010aa)."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b82009de_eb08f83d","line":15,"updated":"2023-07-24 14:18:01.000000000","message":"-1: I\u0027m not sure the multipathd documentation expresses this very well, because under /sys/block it\u0027s dm-0 (like you say), but the call should be passing the device itself instead (/dev/dm-0) like you are doing with this code change. Maybe just passing dm-0 also works?","commit_id":"a0b53f4127a47e1962a057359fd15eba6ec5123a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e51897e15bc64fecc08490c5c00b09aec7ce4314","unresolved":true,"context_lines":[{"line_number":12,"context_line":"As per the multipathd documentation:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"$map can either be a device-mapper device as listed in /sys/block"},{"line_number":15,"context_line":"(e.g. dm-0) or it can be the alias for the multipath device"},{"line_number":16,"context_line":"(e.g. mpath1) or the uid of the multipath device"},{"line_number":17,"context_line":"(e.g. 36005076303ffc56200000000000010aa)."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d6750e82_4bcfde10","line":15,"in_reply_to":"b82009de_eb08f83d","updated":"2023-07-27 21:21:02.000000000","message":"Yes, dm-0 works fine and also /dev/dm-0 works, I can change the code to pass dm-* if you would like but looks like both work the same.\n\nstack@rajat-devstack:~/os-brick$ sudo multipathd resize map dm-5\nok\nstack@rajat-devstack:~/os-brick$ echo $?\n0\nstack@rajat-devstack:~/os-brick$ sudo multipathd resize map /dev/dm-5\nok\nstack@rajat-devstack:~/os-brick$ echo $?\n0","commit_id":"a0b53f4127a47e1962a057359fd15eba6ec5123a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"999898da5cc3051ee0834971f4cfc6bdfcd56b8d","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"$map can either be a device-mapper device as listed in /sys/block"},{"line_number":15,"context_line":"(e.g. dm-0) or it can be the alias for the multipath device"},{"line_number":16,"context_line":"(e.g. mpath1) or the uid of the multipath device"},{"line_number":17,"context_line":"(e.g. 36005076303ffc56200000000000010aa)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"where $map is the argument passed to the ``multipathd resize map``"},{"line_number":20,"context_line":"command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"48adc0a6_f3914b19","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":41},"updated":"2023-07-24 14:18:01.000000000","message":"-1: I believe the docs of this are poorly written and is misleading. It\u0027s not 3 different things (device, alias, or UUID), but actually just 2:\n\n1- Multipath device\n2- Alias or UUID\n\nAnd like you say below, number 2 is the alias when using friendly names and UUID when they are not being used, which is the problem since we are always passing the UUID.\n\nWe should explain it a bit better here.","commit_id":"a0b53f4127a47e1962a057359fd15eba6ec5123a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e51897e15bc64fecc08490c5c00b09aec7ce4314","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"$map can either be a device-mapper device as listed in /sys/block"},{"line_number":15,"context_line":"(e.g. dm-0) or it can be the alias for the multipath device"},{"line_number":16,"context_line":"(e.g. mpath1) or the uid of the multipath device"},{"line_number":17,"context_line":"(e.g. 36005076303ffc56200000000000010aa)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"where $map is the argument passed to the ``multipathd resize map``"},{"line_number":20,"context_line":"command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e8574184_fe42bd0e","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":41},"in_reply_to":"48adc0a6_f3914b19","updated":"2023-07-27 21:21:02.000000000","message":"Done","commit_id":"a0b53f4127a47e1962a057359fd15eba6ec5123a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"674fa02af4798fc70493a67727123f0029ac2d61","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"There are 2 things we can pass to the multipathd resize map command:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"1) Multipath device (eg: dm-0)"},{"line_number":16,"context_line":"2) Alias (eg: mpath1) or UUID (eg: 36005076303ffc56200000000000010aa)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The value should be an alias (mpath1) when friendly names are ON"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f5f408e_b269df0a","line":15,"updated":"2023-08-07 16:21:54.000000000","message":"nit: dm-0 or /dev/dm-0","commit_id":"75714711f2631dbba19750c55a7b049bb07da379"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"674fa02af4798fc70493a67727123f0029ac2d61","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The value should be an alias (mpath1) when friendly names are ON"},{"line_number":19,"context_line":"and UUID (36005076303ffc56200000000000010aa) when friendly names"},{"line_number":20,"context_line":"are OFF. However, we only pass the UUID irrespective of the value"},{"line_number":21,"context_line":"set for friendly names."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This patch passes the multipath device path (to multipathd resize"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1c0c2503_41bb4522","line":20,"range":{"start_line":20,"start_character":18,"end_line":20,"end_character":31},"updated":"2023-08-07 16:21:54.000000000","message":"nit: we are only currently passing","commit_id":"75714711f2631dbba19750c55a7b049bb07da379"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1171cf1f09d8a8c7f15b14a8fff8660a192a9077","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af3d2771_3ed4c9ee","updated":"2023-07-22 15:52:46.000000000","message":"recheck docs job fixed","commit_id":"a0b53f4127a47e1962a057359fd15eba6ec5123a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b5f49f5707be09012eacecb23e336bbd11594570","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"796c7784_c65171f8","updated":"2023-07-24 08:12:23.000000000","message":"recheck image test failure in lvm lio barbican job","commit_id":"a0b53f4127a47e1962a057359fd15eba6ec5123a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"674fa02af4798fc70493a67727123f0029ac2d61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"170872d5_8fcacea8","updated":"2023-08-07 16:21:54.000000000","message":"Couple minor nits on the commit message, but looks great otherwise.","commit_id":"75714711f2631dbba19750c55a7b049bb07da379"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e51897e15bc64fecc08490c5c00b09aec7ce4314","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b79bd718_f7e5b640","updated":"2023-07-27 21:21:02.000000000","message":"Thanks Gorka!","commit_id":"75714711f2631dbba19750c55a7b049bb07da379"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d8c4b5a9aebaa211fcb05f3e482dcf5cfa616326","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c1838098_b21c9833","updated":"2023-08-16 23:06:35.000000000","message":"This is an elegant way to fix the issue.  Code \u0026 tests LGTM.  Since Gorka has classified his commit message suggestions as nits, I\u0027m going to +W.","commit_id":"75714711f2631dbba19750c55a7b049bb07da379"}],"os_brick/initiator/linuxscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"999898da5cc3051ee0834971f4cfc6bdfcd56b8d","unresolved":true,"context_lines":[{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return out"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def multipath_resize_map(self, mpath_id):"},{"line_number":581,"context_line":"        \"\"\"Issue a multipath resize map on device."},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        This forces the multipath daemon to update it\u0027s"}],"source_content_type":"text/x-python","patch_set":1,"id":"d6d4df6f_4725a117","line":580,"range":{"start_line":580,"start_character":35,"end_line":580,"end_character":43},"updated":"2023-07-24 14:18:01.000000000","message":"nit: It would be good to mention in the docstring what this mpath_id can be","commit_id":"a0b53f4127a47e1962a057359fd15eba6ec5123a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e51897e15bc64fecc08490c5c00b09aec7ce4314","unresolved":false,"context_lines":[{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return out"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def multipath_resize_map(self, mpath_id):"},{"line_number":581,"context_line":"        \"\"\"Issue a multipath resize map on device."},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        This forces the multipath daemon to update it\u0027s"}],"source_content_type":"text/x-python","patch_set":1,"id":"28c8de13_924d4752","line":580,"range":{"start_line":580,"start_character":35,"end_line":580,"end_character":43},"in_reply_to":"d6d4df6f_4725a117","updated":"2023-07-27 21:21:02.000000000","message":"Done","commit_id":"a0b53f4127a47e1962a057359fd15eba6ec5123a"}],"os_brick/tests/initiator/test_linuxscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"999898da5cc3051ee0834971f4cfc6bdfcd56b8d","unresolved":true,"context_lines":[{"line_number":822,"context_line":"        mock_find_mpath_path.return_value \u003d (\u0027/dev/mapper/dm-uuid-mpath-%s\u0027 %"},{"line_number":823,"context_line":"                                             wwn)"},{"line_number":824,"context_line":"        dm_path \u003d \u0027/dev/dm-5\u0027"},{"line_number":825,"context_line":"        mock_realpath.return_value \u003d dm_path"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"        ret_size \u003d self.linuxscsi.extend_volume([\u0027/dev/fake1\u0027, \u0027/dev/fake2\u0027],"},{"line_number":828,"context_line":"                                                use_multipath\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6427d514_b59e12f4","line":825,"updated":"2023-07-24 14:18:01.000000000","message":"-1: I don\u0027t see an explicit\n\n   mock_realpath.assert_called_once_with(...)\n   \nAfter L828","commit_id":"a0b53f4127a47e1962a057359fd15eba6ec5123a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e51897e15bc64fecc08490c5c00b09aec7ce4314","unresolved":false,"context_lines":[{"line_number":822,"context_line":"        mock_find_mpath_path.return_value \u003d (\u0027/dev/mapper/dm-uuid-mpath-%s\u0027 %"},{"line_number":823,"context_line":"                                             wwn)"},{"line_number":824,"context_line":"        dm_path \u003d \u0027/dev/dm-5\u0027"},{"line_number":825,"context_line":"        mock_realpath.return_value \u003d dm_path"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"        ret_size \u003d self.linuxscsi.extend_volume([\u0027/dev/fake1\u0027, \u0027/dev/fake2\u0027],"},{"line_number":828,"context_line":"                                                use_multipath\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"88b2babf_878b5790","line":825,"in_reply_to":"6427d514_b59e12f4","updated":"2023-07-27 21:21:02.000000000","message":"Done","commit_id":"a0b53f4127a47e1962a057359fd15eba6ec5123a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"999898da5cc3051ee0834971f4cfc6bdfcd56b8d","unresolved":true,"context_lines":[{"line_number":898,"context_line":"        mock_find_mpath_path.return_value \u003d (\u0027/dev/mapper/dm-uuid-mpath-%s\u0027 %"},{"line_number":899,"context_line":"                                             wwn)"},{"line_number":900,"context_line":"        dm_path \u003d \u0027/dev/dm-5\u0027"},{"line_number":901,"context_line":"        mock_realpath.return_value \u003d dm_path"},{"line_number":902,"context_line":"        mock_mpath_resize_map.side_effect \u003d ("},{"line_number":903,"context_line":"            putils.ProcessExecutionError(stdout\u003d\"timeout\"),"},{"line_number":904,"context_line":"            \"success\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"f4d85076_51ad8c70","line":901,"updated":"2023-07-24 14:18:01.000000000","message":"ditto","commit_id":"a0b53f4127a47e1962a057359fd15eba6ec5123a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e51897e15bc64fecc08490c5c00b09aec7ce4314","unresolved":false,"context_lines":[{"line_number":898,"context_line":"        mock_find_mpath_path.return_value \u003d (\u0027/dev/mapper/dm-uuid-mpath-%s\u0027 %"},{"line_number":899,"context_line":"                                             wwn)"},{"line_number":900,"context_line":"        dm_path \u003d \u0027/dev/dm-5\u0027"},{"line_number":901,"context_line":"        mock_realpath.return_value \u003d dm_path"},{"line_number":902,"context_line":"        mock_mpath_resize_map.side_effect \u003d ("},{"line_number":903,"context_line":"            putils.ProcessExecutionError(stdout\u003d\"timeout\"),"},{"line_number":904,"context_line":"            \"success\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"36b3a402_071f73ae","line":901,"in_reply_to":"f4d85076_51ad8c70","updated":"2023-07-27 21:21:02.000000000","message":"Done","commit_id":"a0b53f4127a47e1962a057359fd15eba6ec5123a"}]}