)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5fb11145943e6ae07097b1e88916beace5937d58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"553dd912_05bac05a","updated":"2023-08-24 18:02:40.000000000","message":"recheck os-brick-src-tempest-lvm-lio-barbican\n\nmultiple failures in this job","commit_id":"71627c56ac14bd3d31e78979d430eccee9a92d91"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3b0ec0d6e3f8d84d1591a493c743656fbff6f632","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"67a997fc_aeef0eda","updated":"2023-08-25 10:11:50.000000000","message":"recheck os-brick-src-tempest-lvm-lio-barbican failed again","commit_id":"71627c56ac14bd3d31e78979d430eccee9a92d91"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"00cd87d7f8e9f4b48739bbeb9aef6a0b72aea4a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1d6d2e81_3f78eaab","updated":"2023-08-24 22:24:09.000000000","message":"recheck os-brick-src-tempest-lvm-lio-barbican failed again...","commit_id":"71627c56ac14bd3d31e78979d430eccee9a92d91"}],"os_brick/tests/initiator/test_connector.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8d8dd0cf8edaefd8ed03537137d164628cdad1fa","unresolved":true,"context_lines":[{"line_number":58,"context_line":"                       return_value\u003dNone)"},{"line_number":59,"context_line":"    @mock.patch.object(linuxfc.LinuxFibreChannel, \u0027get_fc_wwnns\u0027,"},{"line_number":60,"context_line":"                       return_value\u003dNone)"},{"line_number":61,"context_line":"    @mock.patch.object(utils, \u0027get_nvme_host_id\u0027)"},{"line_number":62,"context_line":"    @mock.patch.object(platform, \u0027machine\u0027, mock.Mock(return_value\u003d\u0027s390x\u0027))"},{"line_number":63,"context_line":"    @mock.patch(\u0027sys.platform\u0027, \u0027linux2\u0027)"},{"line_number":64,"context_line":"    def _test_brick_get_connector_properties(self, multipath,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d4782c78_ee14aebf","line":61,"updated":"2023-08-24 14:41:34.000000000","message":"Can just do\n\n    @mock.patch.object(utils, \u0027get_nvme_host_id\u0027, mock.Mock(return_value\u003dNone))\n    \nand drop the parameter to make it simpler.","commit_id":"6bba7cd36349de87ade6e547c61a2b1ae7c23031"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2d056933f38fb4d1026f9d8e87d4e1ad6d29b8b0","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                       return_value\u003dNone)"},{"line_number":59,"context_line":"    @mock.patch.object(linuxfc.LinuxFibreChannel, \u0027get_fc_wwnns\u0027,"},{"line_number":60,"context_line":"                       return_value\u003dNone)"},{"line_number":61,"context_line":"    @mock.patch.object(utils, \u0027get_nvme_host_id\u0027)"},{"line_number":62,"context_line":"    @mock.patch.object(platform, \u0027machine\u0027, mock.Mock(return_value\u003d\u0027s390x\u0027))"},{"line_number":63,"context_line":"    @mock.patch(\u0027sys.platform\u0027, \u0027linux2\u0027)"},{"line_number":64,"context_line":"    def _test_brick_get_connector_properties(self, multipath,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4350e5a4_e564daf6","line":61,"in_reply_to":"d4782c78_ee14aebf","updated":"2023-08-24 15:29:14.000000000","message":"Done","commit_id":"6bba7cd36349de87ade6e547c61a2b1ae7c23031"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"cd97d3692ab091b718b32e820b29724292e99328","unresolved":true,"context_lines":[{"line_number":60,"context_line":"                       return_value\u003dNone)"},{"line_number":61,"context_line":"    @mock.patch.object(platform, \u0027machine\u0027, mock.Mock(return_value\u003d\u0027s390x\u0027))"},{"line_number":62,"context_line":"    @mock.patch(\u0027sys.platform\u0027, \u0027linux2\u0027)"},{"line_number":63,"context_line":"    @mock.patch.object(utils, \u0027get_nvme_host_id\u0027, mock.Mock(return_value\u003dNone))"},{"line_number":64,"context_line":"    def _test_brick_get_connector_properties(self, multipath,"},{"line_number":65,"context_line":"                                             enforce_multipath,"},{"line_number":66,"context_line":"                                             multipath_result,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bdfa45a2_064b74be","line":63,"updated":"2023-08-24 15:30:34.000000000","message":"nit: There\u0027s a simpler way to do this:\n\n @mock.patch.object(utils, \u0027get_nvme_host_id\u0027, return_value\u003dNone)","commit_id":"71627c56ac14bd3d31e78979d430eccee9a92d91"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3ac92488d18607970b7f077b161a5875ca16f342","unresolved":true,"context_lines":[{"line_number":60,"context_line":"                       return_value\u003dNone)"},{"line_number":61,"context_line":"    @mock.patch.object(platform, \u0027machine\u0027, mock.Mock(return_value\u003d\u0027s390x\u0027))"},{"line_number":62,"context_line":"    @mock.patch(\u0027sys.platform\u0027, \u0027linux2\u0027)"},{"line_number":63,"context_line":"    @mock.patch.object(utils, \u0027get_nvme_host_id\u0027, mock.Mock(return_value\u003dNone))"},{"line_number":64,"context_line":"    def _test_brick_get_connector_properties(self, multipath,"},{"line_number":65,"context_line":"                                             enforce_multipath,"},{"line_number":66,"context_line":"                                             multipath_result,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6f04600b_539c6e72","line":63,"in_reply_to":"bdfa45a2_064b74be","updated":"2023-08-24 15:51:09.000000000","message":"The reason for including mock.Mock(return_value\u003dNone) is to avoid passing the parameter in the method definition, i also discovered this while testing it\n\nTypeError: ConnectorUtilsTestCase._test_brick_get_connector_properties() got multiple values for argument \u0027host\u0027\n\nIf we just do return_value\u003dNone, it will require an additional parameter in the method.","commit_id":"71627c56ac14bd3d31e78979d430eccee9a92d91"}]}