)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4fee35b8ecb1d5767745e9a6a70b9f157d1e934f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NVMe-oF: Support nvme cli v2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The nvme cli has changed its behavior, now they no longer differentiate"},{"line_number":10,"context_line":"between errors returning a different exit code."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Exit code 1 is for errors and 0 for success."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0a0367c7_6ebc456e","line":10,"range":{"start_line":9,"start_character":39,"end_line":10,"end_character":47},"updated":"2024-01-06 09:28:46.000000000","message":"doesn\u0027t seem like a smart move for our use case, would be good to get more info on why this change was made","commit_id":"16ba8ed3967999ef8535074aa6d6cc2b09bca54d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"56d6811544bdf42590ceb202abd51236b002a813","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NVMe-oF: Support nvme cli v2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The nvme cli has changed its behavior, now they no longer differentiate"},{"line_number":10,"context_line":"between errors returning a different exit code."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Exit code 1 is for errors and 0 for success."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a8922fd_613c1f7b","line":10,"range":{"start_line":9,"start_character":39,"end_line":10,"end_character":47},"in_reply_to":"0a0367c7_6ebc456e","updated":"2024-01-09 06:07:26.000000000","message":"From the commit message [0], it looks like some of the libnvme error codes were in a range that could confuse some shells, and they decided it would be safer for the CLI to just return success or failure.\n\n[0] https://github.com/linux-nvme/nvme-cli/pull/1345/commits/13f74d20e1d9e571368b1d06fe9889a2fdd29849","commit_id":"16ba8ed3967999ef8535074aa6d6cc2b09bca54d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fc180f64b64a994ecbaffaad54151478ba160fd7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NVMe-oF: Support nvme cli v2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The nvme cli has changed its behavior, now they no longer differentiate"},{"line_number":10,"context_line":"between errors returning a different exit code."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Exit code 1 is for errors and 0 for success."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"869b07c5_26b3850e","line":10,"range":{"start_line":9,"start_character":39,"end_line":10,"end_character":47},"in_reply_to":"7a8922fd_613c1f7b","updated":"2024-01-11 08:44:47.000000000","message":"Acknowledged","commit_id":"16ba8ed3967999ef8535074aa6d6cc2b09bca54d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4fee35b8ecb1d5767745e9a6a70b9f157d1e934f","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Exit code 1 is for errors and 0 for success."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes the detection of race conditions to also look for the"},{"line_number":15,"context_line":"message in case it\u0027s a newer CLI version."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Together with change I318f167baa0ba7789f4ca2c7c12a8de5568195e0 we are"},{"line_number":18,"context_line":"ready for nvme CLI v2."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"82a4c637_ff0c7de2","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":41},"updated":"2024-01-06 09:28:46.000000000","message":"is this only an issue when connecting to the subsystem?","commit_id":"16ba8ed3967999ef8535074aa6d6cc2b09bca54d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"cef911d83011ad390350ea4f825320df4863d3c2","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Exit code 1 is for errors and 0 for success."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes the detection of race conditions to also look for the"},{"line_number":15,"context_line":"message in case it\u0027s a newer CLI version."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Together with change I318f167baa0ba7789f4ca2c7c12a8de5568195e0 we are"},{"line_number":18,"context_line":"ready for nvme CLI v2."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fb3d6445_a7ca2903","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":41},"in_reply_to":"82a4c637_ff0c7de2","updated":"2024-01-10 09:57:32.000000000","message":"We could also have race conditions when detaching volumes.\nBut it\u0027s important to remember that these race conditions only happens if things are incorrectly configured (os-brick file locks location is not shared).","commit_id":"16ba8ed3967999ef8535074aa6d6cc2b09bca54d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fc180f64b64a994ecbaffaad54151478ba160fd7","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Exit code 1 is for errors and 0 for success."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes the detection of race conditions to also look for the"},{"line_number":15,"context_line":"message in case it\u0027s a newer CLI version."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Together with change I318f167baa0ba7789f4ca2c7c12a8de5568195e0 we are"},{"line_number":18,"context_line":"ready for nvme CLI v2."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c31dc7f6_0e59f894","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":41},"in_reply_to":"fb3d6445_a7ca2903","updated":"2024-01-11 08:44:47.000000000","message":"Acknowledged","commit_id":"16ba8ed3967999ef8535074aa6d6cc2b09bca54d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"f8f8d07107b38050ada70a42e6b13573aa007a32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1dee3f9f_2829d075","updated":"2023-11-15 13:57:24.000000000","message":"Looks good to me and passes a 3rd party NVMe-based CI","commit_id":"520db7c95cb3af0f11fd85d6bfbdd9c6c4293580"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"d08dcbd55d2799d112af6eb4cc56918647edf5ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"27ef4134_aa7c089a","updated":"2023-12-28 14:41:15.000000000","message":"run Pure Storage CI","commit_id":"520db7c95cb3af0f11fd85d6bfbdd9c6c4293580"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"56d6811544bdf42590ceb202abd51236b002a813","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d3c71480_aefd3dda","updated":"2024-01-09 06:07:26.000000000","message":"Code and tests LGTM.  I share Rajat\u0027s concern about the error message changing, but our options are limited here; this seems the best we can do.","commit_id":"16ba8ed3967999ef8535074aa6d6cc2b09bca54d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4fee35b8ecb1d5767745e9a6a70b9f157d1e934f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1bd66080_f9c0c9d1","updated":"2024-01-06 09:28:46.000000000","message":"few questions inline but overall LGTM.","commit_id":"16ba8ed3967999ef8535074aa6d6cc2b09bca54d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ec7d735a1c3abf0b9adfc272767b97a5defab69f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0a2d014e_dc922622","updated":"2024-01-10 09:18:19.000000000","message":"recheck the previous patch in chain failed gate","commit_id":"16ba8ed3967999ef8535074aa6d6cc2b09bca54d"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"644d19431d6d9dfbee7d10a3facd66426e5cf421","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4a6d2508_0b48da03","updated":"2024-01-05 19:54:23.000000000","message":"run Pure Storage CI","commit_id":"16ba8ed3967999ef8535074aa6d6cc2b09bca54d"}],"os_brick/initiator/connectors/nvmeof.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4fee35b8ecb1d5767745e9a6a70b9f157d1e934f","unresolved":false,"context_lines":[{"line_number":931,"context_line":"                    # so we look in stderr and stdout."},{"line_number":932,"context_line":"                    if not (exc.exit_code in (70, errno.EALREADY) or"},{"line_number":933,"context_line":"                            (exc.exit_code \u003d\u003d 1 and"},{"line_number":934,"context_line":"                             \u0027already connected\u0027 in exc.stderr + exc.stdout)):"},{"line_number":935,"context_line":"                        LOG.error(\u0027Could not connect to %s: exit_code: %s, \u0027"},{"line_number":936,"context_line":"                                  \u0027stdout: \"%s\", stderr: \"%s\",\u0027, portal,"},{"line_number":937,"context_line":"                                  exc.exit_code, exc.stdout, exc.stderr)"}],"source_content_type":"text/x-python","patch_set":3,"id":"92bc3bc1_09d69d19","line":934,"range":{"start_line":934,"start_character":29,"end_line":934,"end_character":75},"updated":"2024-01-06 09:28:46.000000000","message":"guess we don\u0027t have any other way to check this instead of string matching since the exit code is very generic, the only worry i have is we will break if they modify this message ...","commit_id":"16ba8ed3967999ef8535074aa6d6cc2b09bca54d"}]}