)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ed14e8bea3fb6747374cea4719a83211140d83ac","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This patch improves the creation of the /etc/nvme/hostnqn file by using"},{"line_number":10,"context_line":"the system UUID value we usually already know."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This saves as one or two calls to the nvme-cli command and it also"},{"line_number":13,"context_line":"allows older nvme-cli versions that don\u0027t have the `show-hostnqn`"},{"line_number":14,"context_line":"command or have it but can only read from file to generate the same"},{"line_number":15,"context_line":"value every time, which may be useful when running inside a container"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7409a292_1d59f634","line":12,"range":{"start_line":12,"start_character":11,"end_line":12,"end_character":13},"updated":"2023-11-13 09:26:11.000000000","message":"nit: us","commit_id":"963e37b44bd8c1af9dc1ec7d2208d322259ff7eb"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"25420b122fa0da4ea4b81fd43da827b94b3ac8c1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch improves the creation of the /etc/nvme/hostnqn file by using"},{"line_number":10,"context_line":"the system UUID value we usually already know."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This saves as one or two calls to the nvme-cli command and it also"},{"line_number":13,"context_line":"allows older nvme-cli versions that don\u0027t have the `show-hostnqn`"},{"line_number":14,"context_line":"command or have it but can only read from file to generate the same"},{"line_number":15,"context_line":"value every time, which may be useful when running inside a container"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2de2a7b7_d2179159","line":12,"range":{"start_line":12,"start_character":11,"end_line":12,"end_character":13},"in_reply_to":"7409a292_1d59f634","updated":"2023-11-15 12:42:07.000000000","message":"Done","commit_id":"963e37b44bd8c1af9dc1ec7d2208d322259ff7eb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"66ecdb88b3436debd5e915ea8d2867c28aa4b6e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6aab4f0d_33c798c8","updated":"2024-01-05 16:48:29.000000000","message":"Code and tests LGTM.","commit_id":"088c676bf5d1846efc19385433a65c1675c2ebd1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"573a5cbfa45c64b65b921de5ba62889ebd835502","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f30834be_42355998","updated":"2024-01-06 09:45:20.000000000","message":"LGTM","commit_id":"088c676bf5d1846efc19385433a65c1675c2ebd1"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"3b7af0b693b81b74d04ca70281e2f3517ecfb8db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"359558fd_abf2988d","updated":"2023-12-28 14:37:47.000000000","message":"run Pure Storage CI","commit_id":"088c676bf5d1846efc19385433a65c1675c2ebd1"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c2c1dcce5062bbf10d13b585c8005ac5c79fb083","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6a3c9fd7_416af34f","updated":"2024-01-05 19:55:44.000000000","message":"run Pure Storage CI","commit_id":"088c676bf5d1846efc19385433a65c1675c2ebd1"}],"os_brick/privileged/nvmeof.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"7efcf264dc29308a8794fa9b5d0f77fc4d29d47d","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    get the nqn on each get_connector_properties call instead of having to make"},{"line_number":39,"context_line":"    a call to nvme show-hostnqn command."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    In newer nvme-cli versions calling show-hostqnqn will not only try to"},{"line_number":42,"context_line":"    locate the file (which we know doesn\u0027t exist or this method wouldn\u0027t have"},{"line_number":43,"context_line":"    been called), but it will also generate one.  In older nvme-cli versions"},{"line_number":44,"context_line":"    that is not the case."}],"source_content_type":"text/x-python","patch_set":1,"id":"33034783_e9d44381","line":41,"updated":"2023-11-15 04:48:57.000000000","message":"hostnqn","commit_id":"963e37b44bd8c1af9dc1ec7d2208d322259ff7eb"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"25420b122fa0da4ea4b81fd43da827b94b3ac8c1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    get the nqn on each get_connector_properties call instead of having to make"},{"line_number":39,"context_line":"    a call to nvme show-hostnqn command."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    In newer nvme-cli versions calling show-hostqnqn will not only try to"},{"line_number":42,"context_line":"    locate the file (which we know doesn\u0027t exist or this method wouldn\u0027t have"},{"line_number":43,"context_line":"    been called), but it will also generate one.  In older nvme-cli versions"},{"line_number":44,"context_line":"    that is not the case."}],"source_content_type":"text/x-python","patch_set":1,"id":"90675e61_defb4ffe","line":41,"in_reply_to":"33034783_e9d44381","updated":"2023-11-15 12:42:07.000000000","message":"Done","commit_id":"963e37b44bd8c1af9dc1ec7d2208d322259ff7eb"}],"os_brick/utils.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"7efcf264dc29308a8794fa9b5d0f77fc4d29d47d","unresolved":true,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    For the creation of the hostnqn file it can leverage a provided system_uuid"},{"line_number":228,"context_line":"    for systems that are using older versions of nvme-cli."},{"line_number":229,"context_line":"    \"\"\""},{"line_number":230,"context_line":"    try:"},{"line_number":231,"context_line":"        with open(\u0027/etc/nvme/hostnqn\u0027, \u0027r\u0027) as f:"},{"line_number":232,"context_line":"            host_nqn \u003d f.read().strip()"}],"source_content_type":"text/x-python","patch_set":1,"id":"b089d907_097178c8","line":229,"updated":"2023-11-15 04:48:57.000000000","message":"This comment is correct, but also highly miselading. It\u0027s easy to read as system uuid is to be used with older nvme-cli. But actually, it\u0027s always used, if available.","commit_id":"963e37b44bd8c1af9dc1ec7d2208d322259ff7eb"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"25420b122fa0da4ea4b81fd43da827b94b3ac8c1","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    For the creation of the hostnqn file it can leverage a provided system_uuid"},{"line_number":228,"context_line":"    for systems that are using older versions of nvme-cli."},{"line_number":229,"context_line":"    \"\"\""},{"line_number":230,"context_line":"    try:"},{"line_number":231,"context_line":"        with open(\u0027/etc/nvme/hostnqn\u0027, \u0027r\u0027) as f:"},{"line_number":232,"context_line":"            host_nqn \u003d f.read().strip()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9912bde2_1c054d48","line":229,"in_reply_to":"b089d907_097178c8","updated":"2023-11-15 12:42:07.000000000","message":"Good point, I have tried to rephrase it in the next patch version, I hope it\u0027s better.","commit_id":"963e37b44bd8c1af9dc1ec7d2208d322259ff7eb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"573a5cbfa45c64b65b921de5ba62889ebd835502","unresolved":true,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"def get_host_nqn(system_uuid: Optional[str] \u003d None) -\u003e Optional[str]:"},{"line_number":225,"context_line":"    \"\"\"Ensure that hostnqn exists, creating if necessary."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    This method tries to return contents from /etc/nvme/hostnqn and if not"},{"line_number":228,"context_line":"    possible then creates the file calling create_hostnqn and passing provided"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f53dd67_796bb4c1","line":225,"range":{"start_line":225,"start_character":19,"end_line":225,"end_character":26},"updated":"2024-01-06 09:45:20.000000000","message":"nit: hostnqn file","commit_id":"088c676bf5d1846efc19385433a65c1675c2ebd1"}]}