)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"6077c86be2a0356ddde047b5469a1d6b2a442bb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c7482b44_5c05b331","updated":"2024-02-16 15:21:26.000000000","message":"BTW, I don\u0027t see a corresponding patch to cinder. Are we relying on the service importing os_brick? Does that actually work?","commit_id":"cd57168700d6a9c47b9cbf86436d4a1384446ab4"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"ecc430cf7c560661984b2eb5ee2e20c5094f8e17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"363de2d3_e797dfd6","updated":"2024-02-16 15:16:45.000000000","message":"I agree that BaseWindowsConnector is the correct place for a deprecation warning.","commit_id":"cd57168700d6a9c47b9cbf86436d4a1384446ab4"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5e0e8638dfa79d92e9b070c3daf438522f3467b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ace16d3c_d637b48a","updated":"2023-11-17 14:38:03.000000000","message":"It\u0027s perfectly aligned to what we have already discussed. Thanks for taking care of it.\n\nDon\u0027t we have to say the same kind of message in [1]. ?\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/windows","commit_id":"cd57168700d6a9c47b9cbf86436d4a1384446ab4"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"4310bf38a58cbc02943ba748637e352cc6400097","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd2a239a_c89155bf","updated":"2023-11-15 14:17:27.000000000","message":"LGTM","commit_id":"cd57168700d6a9c47b9cbf86436d4a1384446ab4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8d53c442788caded33057dc33e7cce1e72f0a556","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55053614_253bae89","updated":"2024-02-21 14:29:04.000000000","message":"We should do this, question about the stacklevel, though.","commit_id":"cd57168700d6a9c47b9cbf86436d4a1384446ab4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"10dbbb19d2f2f8afd55c04845d67009d823d0dc9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"838eef87_8cb2bbb9","in_reply_to":"4bdfe45f_60d53009","updated":"2024-02-16 15:55:02.000000000","message":"Correction. Note oslo.service but oslo.concurrenct[1] and oslo.log[2]\n\n[1] https://review.opendev.org/c/openstack/oslo.concurrency/+/901381\n[2] https://review.opendev.org/c/openstack/oslo.log/+/894235","commit_id":"cd57168700d6a9c47b9cbf86436d4a1384446ab4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d6f6e8d1ba8deb03b3e0fa181b36a16bd3fabf10","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4bdfe45f_60d53009","in_reply_to":"c7482b44_5c05b331","updated":"2024-02-16 15:54:15.000000000","message":"The patch for cinder is already submitted here https://review.opendev.org/c/openstack/cinder/+/894237\n\nOnce os-brick removes support for Windows then functions using os-brick may no longer work. Furthermore we are removing Windows support from oslo.service so the core framework may be broken after that.","commit_id":"cd57168700d6a9c47b9cbf86436d4a1384446ab4"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"5ebad2023afaa42c04d4b4e6a522646019b036f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ce4bde2b_75345b3c","updated":"2024-02-21 15:10:51.000000000","message":"patches to oslo log and concurrency have already merged, this looks good\nto me.","commit_id":"26eef68d1fdfa43129c1d575962e89dc7e6728c7"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"ce48ed465dd9c5d1d830ddf2c697841ee3aa3980","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d7c0b36a_6a66f080","updated":"2024-02-21 15:08:21.000000000","message":"question","commit_id":"26eef68d1fdfa43129c1d575962e89dc7e6728c7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"acb76e86fbaa2dac84a26a440ea21252de59471a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"02c2d0d7_54bff606","updated":"2024-02-21 15:22:18.000000000","message":"From discussion in IRC, looks like stacklevel\u003d2 is what we want.  It\u0027s set to 2 in both places that set stacklevel on this patch, so LGTM.","commit_id":"278fdf8b3ad9be4c87146d086b7c4da1ce76c7ee"}],"os_brick/initiator/windows/base.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8d53c442788caded33057dc33e7cce1e72f0a556","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, root_helper\u003dNone, *args, **kwargs):"},{"line_number":38,"context_line":"        warnings.warn(\u0027Support for Windows OS has been deprecated.\u0027,"},{"line_number":39,"context_line":"                      category\u003dDeprecationWarning, stacklevel\u003d3)"},{"line_number":40,"context_line":"        kwargs[\u0027executor\u0027] \u003d kwargs.get(\u0027executor\u0027) or putils.execute"},{"line_number":41,"context_line":"        super(BaseWindowsConnector, self).__init__(root_helper,"},{"line_number":42,"context_line":"                                                   *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7cd4376_29f16e6c","line":39,"updated":"2024-02-21 14:29:04.000000000","message":"I find stacklevel confusing.  Is 3 correct? 1 would be __init__, i guess 2 would be BaseWindowsConnector, and then 3 would be the function that created a BaseWindowsConnector?","commit_id":"cd57168700d6a9c47b9cbf86436d4a1384446ab4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"410fbe9e87f3212a41d3f70aae3ea8c856d1250c","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, root_helper\u003dNone, *args, **kwargs):"},{"line_number":38,"context_line":"        warnings.warn(\u0027Support for Windows OS has been deprecated.\u0027,"},{"line_number":39,"context_line":"                      category\u003dDeprecationWarning, stacklevel\u003d3)"},{"line_number":40,"context_line":"        kwargs[\u0027executor\u0027] \u003d kwargs.get(\u0027executor\u0027) or putils.execute"},{"line_number":41,"context_line":"        super(BaseWindowsConnector, self).__init__(root_helper,"},{"line_number":42,"context_line":"                                                   *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"de66daa9_d1ed6387","line":39,"in_reply_to":"394453b9_baeac2dc","updated":"2024-02-21 15:05:37.000000000","message":"Done","commit_id":"cd57168700d6a9c47b9cbf86436d4a1384446ab4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2ea5466a7b71d596c10f2daf7c33e370df577b65","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, root_helper\u003dNone, *args, **kwargs):"},{"line_number":38,"context_line":"        warnings.warn(\u0027Support for Windows OS has been deprecated.\u0027,"},{"line_number":39,"context_line":"                      category\u003dDeprecationWarning, stacklevel\u003d3)"},{"line_number":40,"context_line":"        kwargs[\u0027executor\u0027] \u003d kwargs.get(\u0027executor\u0027) or putils.execute"},{"line_number":41,"context_line":"        super(BaseWindowsConnector, self).__init__(root_helper,"},{"line_number":42,"context_line":"                                                   *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"394453b9_baeac2dc","line":39,"in_reply_to":"f7cd4376_29f16e6c","updated":"2024-02-21 14:59:59.000000000","message":"Hmm yes 2 would be more appropriate. Let me fix this.","commit_id":"cd57168700d6a9c47b9cbf86436d4a1384446ab4"}],"os_brick/remotefs/windows_remotefs.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"ce48ed465dd9c5d1d830ddf2c697841ee3aa3980","unresolved":true,"context_lines":[{"line_number":38,"context_line":"                 execute\u003dNone, *args, **kwargs):"},{"line_number":39,"context_line":"        warnings.warn(\u0027Support for Windows OS has been deprecated.\u0027,"},{"line_number":40,"context_line":"                      category\u003dDeprecationWarning, stacklevel\u003d3)"},{"line_number":41,"context_line":"        mount_type_to_option_prefix \u003d {"},{"line_number":42,"context_line":"            \u0027cifs\u0027: \u0027smbfs\u0027,"},{"line_number":43,"context_line":"            \u0027smbfs\u0027: \u0027smbfs\u0027,"},{"line_number":44,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"14bc90c1_4ceeb06b","line":41,"updated":"2024-02-21 15:08:21.000000000","message":"Takashi changed stacklevel to 2 in BaseWindowsConnector but not here. Is this how Windows works, or is it an oversight?","commit_id":"26eef68d1fdfa43129c1d575962e89dc7e6728c7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cde7cd09a329c5f3b9000543ae10e5b4c38dd578","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                 execute\u003dNone, *args, **kwargs):"},{"line_number":39,"context_line":"        warnings.warn(\u0027Support for Windows OS has been deprecated.\u0027,"},{"line_number":40,"context_line":"                      category\u003dDeprecationWarning, stacklevel\u003d3)"},{"line_number":41,"context_line":"        mount_type_to_option_prefix \u003d {"},{"line_number":42,"context_line":"            \u0027cifs\u0027: \u0027smbfs\u0027,"},{"line_number":43,"context_line":"            \u0027smbfs\u0027: \u0027smbfs\u0027,"},{"line_number":44,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"b7b8052e_9a9047b0","line":41,"in_reply_to":"14bc90c1_4ceeb06b","updated":"2024-02-21 15:15:53.000000000","message":"Oops sorry this needs to be updated, too...","commit_id":"26eef68d1fdfa43129c1d575962e89dc7e6728c7"}]}