)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eefc236bb5a93cf9bc620fd01b8ef582a6cd0b28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b5bbe7c1_b47fdfef","updated":"2024-08-21 15:01:26.000000000","message":"LGTM","commit_id":"2aa9359b86b9bcdd1a6bacb04920becb8ab38ac6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"12e37d7ed3066993147fb92509a57b215c1980fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0b78b981_03d1eed5","updated":"2024-08-21 13:46:37.000000000","message":"Let\u0027s stay consistent with Dalmatian cinder, which is at hacking \u003e\u003d 6.1.0","commit_id":"2aa9359b86b9bcdd1a6bacb04920becb8ab38ac6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"57d2b5abd3ecea345f0f80c095105820aa41625e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b48872e9_ff59bc4c","updated":"2024-08-21 14:46:54.000000000","message":"at today\u0027s cinder meeting: this patch was determined release-critical for Dalmatian","commit_id":"2aa9359b86b9bcdd1a6bacb04920becb8ab38ac6"}],"os_brick/tests/initiator/test_linuxfc.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4d3fff3c1e6767b62091197958501848a449f291","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                    (\u0027\u0027, \u0027\u0027),"},{"line_number":92,"context_line":"                    # This is returned from the fc_remote_ports path"},{"line_number":93,"context_line":"                    (\u0027/sys/class/fc_remote_ports/\u0027"},{"line_number":94,"context_line":"                     f\u0027rport-6:0-{i+1}/port_name\\n\u0027, \u0027\u0027),  # noqa: E226"},{"line_number":95,"context_line":"                ]"},{"line_number":96,"context_line":"                expected_cmds +\u003d ["},{"line_number":97,"context_line":"                    mock.call(f\u0027grep -Gil \"{wwpns[i]}\" \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5e2e71d3_89a66e3b","line":94,"range":{"start_line":94,"start_character":33,"end_line":94,"end_character":38},"updated":"2024-08-21 14:11:17.000000000","message":"since E226 is about whitespaces around arithmetic operations, i think we can avoid the noqa part as both with/without whitespace, it works the same\nnot sure about readability though, which would be more convenient to understand\n\n\u003e\u003e\u003e i \u003d 1\n\u003e\u003e\u003e print(f\u0027rport-6:0-{i+1}/port_name\\n\u0027)\nrport-6:0-2/port_name\n\n\u003e\u003e\u003e print(f\u0027rport-6:0-{i + 1}/port_name\\n\u0027)\nrport-6:0-2/port_name","commit_id":"2aa9359b86b9bcdd1a6bacb04920becb8ab38ac6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"faa2b0b64e46af1fb5857af0e29c964eff8e5546","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                    (\u0027\u0027, \u0027\u0027),"},{"line_number":92,"context_line":"                    # This is returned from the fc_remote_ports path"},{"line_number":93,"context_line":"                    (\u0027/sys/class/fc_remote_ports/\u0027"},{"line_number":94,"context_line":"                     f\u0027rport-6:0-{i+1}/port_name\\n\u0027, \u0027\u0027),  # noqa: E226"},{"line_number":95,"context_line":"                ]"},{"line_number":96,"context_line":"                expected_cmds +\u003d ["},{"line_number":97,"context_line":"                    mock.call(f\u0027grep -Gil \"{wwpns[i]}\" \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"80d1ca06_ff90a941","line":94,"range":{"start_line":94,"start_character":33,"end_line":94,"end_character":38},"in_reply_to":"5e2e71d3_89a66e3b","updated":"2024-08-21 14:48:57.000000000","message":"I\u0027m a bit skeptical that this rule even makes sense for f-strings.  PEP-0701 uses the form w/o spaces throughout the whole document:\n    https://peps.python.org/pep-0701/","commit_id":"2aa9359b86b9bcdd1a6bacb04920becb8ab38ac6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eefc236bb5a93cf9bc620fd01b8ef582a6cd0b28","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                    (\u0027\u0027, \u0027\u0027),"},{"line_number":92,"context_line":"                    # This is returned from the fc_remote_ports path"},{"line_number":93,"context_line":"                    (\u0027/sys/class/fc_remote_ports/\u0027"},{"line_number":94,"context_line":"                     f\u0027rport-6:0-{i+1}/port_name\\n\u0027, \u0027\u0027),  # noqa: E226"},{"line_number":95,"context_line":"                ]"},{"line_number":96,"context_line":"                expected_cmds +\u003d ["},{"line_number":97,"context_line":"                    mock.call(f\u0027grep -Gil \"{wwpns[i]}\" \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7dc3dcfd_9ce88daa","line":94,"range":{"start_line":94,"start_character":33,"end_line":94,"end_character":38},"in_reply_to":"80d1ca06_ff90a941","updated":"2024-08-21 15:01:26.000000000","message":"Ack, yeah this is really strange. anyways this shouldn\u0027t block the requirement change from merging so going ahead with the approval.","commit_id":"2aa9359b86b9bcdd1a6bacb04920becb8ab38ac6"}]}