)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"18deb0a07d804ba38061f83b35e74aa031d5c76b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Nilesh Thathagar \u003cnilesh.thathagar@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-01-28 10:57:43 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerMax: Added retry for DM ID"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implemented a retry mechanism to retrieve the DM ID"},{"line_number":10,"context_line":"of the device, ensuring smoother connectivity and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5939a964_0447549f","line":7,"updated":"2025-02-05 16:06:54.000000000","message":"This message is misleading since the patch changes common FC code that impacts other drivers instead of just Dell. \n\nI would recommend mentioning FC instead, like this patch from Rajat:\nhttps://review.opendev.org/c/openstack/os-brick/+/940748","commit_id":"ecebb99de41acb792cf622d9b6fb55486f97e501"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f5de8ac6e3b8d4c01fe7f69e95d70957954c05d6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Nilesh Thathagar \u003cnilesh.thathagar@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-01-28 10:57:43 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerMax: Added retry for DM ID"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implemented a retry mechanism to retrieve the DM ID"},{"line_number":10,"context_line":"of the device, ensuring smoother connectivity and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5c987b42_efa350e6","line":7,"in_reply_to":"5939a964_0447549f","updated":"2025-02-05 23:45:27.000000000","message":"Fernando makes a good point.  You found the bug working with a Dell PowerMax, but the fix is being done to the main os-brick code.  Seems like a minor point, but you want to be clear for someone looking through the changelog that this change is not specific to a dell connector.","commit_id":"ecebb99de41acb792cf622d9b6fb55486f97e501"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dc0d7e1765648801330130ecd5f3efa7638b8959","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6c4f4184_c7f83d0b","updated":"2025-02-05 17:41:21.000000000","message":"Hi Nilesh,\n\nThanks for proposing this patch.\n\nThere are a few concerns I have with the approach:\n1. We are adding an additional 6 second wait to the FC attachment workflow\n2. Even after waiting for 6 seconds, we might still not discover the mpath device and fail with the same error\n\nThis patch can work under ideal testing conditions but in a production environment where multiple attach/detach calls happen, we might face the same issue again.\n\nGorka suggested that it\u0027s better to find the underlying issue of slowness causing the DM device to not appear in time.\n\nMeanwhile we can use this patch as a band-aid to resort to old behavior\n\nhttps://review.opendev.org/c/openstack/os-brick/+/940748","commit_id":"ecebb99de41acb792cf622d9b6fb55486f97e501"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"7a169825e7cf160b8694f684e5fbe290513c0a44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"022e1c69_c2fa0842","updated":"2025-01-28 14:08:46.000000000","message":"Please do a review.","commit_id":"ecebb99de41acb792cf622d9b6fb55486f97e501"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"18f314bf61a44903c7f6a941d7bbf94cdd5edda7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b1e65d8a_48cdc978","updated":"2025-01-29 15:41:57.000000000","message":"Since the PowerMax CI is currently down and will take some time to fix, I am attaching the local CI results to https://bugs.launchpad.net/os-brick/+bug/2095303 for your review of the patch.","commit_id":"ecebb99de41acb792cf622d9b6fb55486f97e501"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"aa75c618cfc2454f1760216480f94fd76f01692a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b8101fe7_cba33614","updated":"2025-02-06 06:16:09.000000000","message":"Thanks for the review.\n\nI spoke with Rajat yesterday, and he mentioned that this wait could impact other operations, such as live migration. He suggested investigating the delay in mapping the DM ID to the device from the platform side.\n\nI’ll check this with the PowerMax platform and provide an update soon.","commit_id":"ecebb99de41acb792cf622d9b6fb55486f97e501"}],"os_brick/initiator/connectors/fibre_channel.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"938017894701e6d8d08d77e0e1c7338447910e31","unresolved":true,"context_lines":[{"line_number":305,"context_line":"        device_info[\u0027path\u0027] \u003d device_path"},{"line_number":306,"context_line":"        return device_info"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @utils.retry(exception.VolumeDeviceNotFound, retries\u003d3, interval\u003d2)"},{"line_number":309,"context_line":"    def _find_sysfs_multipath_dm_with_retry(self, devices):"},{"line_number":310,"context_line":"        mpath \u003d self._linuxscsi.find_sysfs_multipath_dm("},{"line_number":311,"context_line":"            devices)"}],"source_content_type":"text/x-python","patch_set":4,"id":"77f57925_7aafa470","line":308,"updated":"2025-02-05 16:37:00.000000000","message":"Suggestion: It usually just needs a few extra millis, or a longer wait is really usually required? I\u0027m asking because a different approach for this retry could be fixing a 1 sec interval (the default) and adding a backoff rate of 2 secs.","commit_id":"ecebb99de41acb792cf622d9b6fb55486f97e501"}],"os_brick/tests/initiator/connectors/test_fibre_channel.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"d1492193f1dc9f49aed5d7708d89ab69494445fb","unresolved":true,"context_lines":[{"line_number":1017,"context_line":""},{"line_number":1018,"context_line":"    @mock.patch.object(linuxscsi.LinuxSCSI, \u0027find_sysfs_multipath_dm\u0027,"},{"line_number":1019,"context_line":"                       return_value\u003dNone)"},{"line_number":1020,"context_line":"    def test_find_sysfs_multipath_dm_with_retry_2(self, mock_dm):"},{"line_number":1021,"context_line":"        self.assertRaises("},{"line_number":1022,"context_line":"            exception.VolumeDeviceNotFound,"},{"line_number":1023,"context_line":"            self.connector._find_sysfs_multipath_dm_with_retry,"}],"source_content_type":"text/x-python","patch_set":4,"id":"b63cae14_4a4f3a72","line":1020,"updated":"2025-02-05 16:12:46.000000000","message":"This is just a suggestion and no issue if you prefer to keep this way, but I think this test could be renamed to something like `test_find_sysfs_multipath_dm_with_retry_volume_device_not_found` or `test_find_sysfs_multipath_dm_with_retry_device_not_found` to avoid naming tests using sequences.","commit_id":"ecebb99de41acb792cf622d9b6fb55486f97e501"}]}