)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"5ed8b52beece90051b26239b99da1faa2a583e32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"17b5894c_2241b9a6","updated":"2025-02-05 16:51:10.000000000","message":"Code and test coverage looks good. Thanks Rajat!","commit_id":"8ac46333d7161beb960b5ee04f60c533c32f9619"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1894e1a3602704c220fcef31cc377ee0ecb3609a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b02f8f74_896cae21","updated":"2025-02-06 15:49:10.000000000","message":"Code and tests look good.  Thanks for the detailed commit message.","commit_id":"8ac46333d7161beb960b5ee04f60c533c32f9619"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b9f22d0dd1abe6e7a4cc378b5ca5f7a848b24278","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"23fc99d1_2da498ab","updated":"2025-02-06 18:12:28.000000000","message":"Thanks Eric and Brian for the reviews!","commit_id":"8ac46333d7161beb960b5ee04f60c533c32f9619"}],"os_brick/initiator/connectors/fibre_channel.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1894e1a3602704c220fcef31cc377ee0ecb3609a","unresolved":true,"context_lines":[{"line_number":296,"context_line":"                mpath \u003d self._linuxscsi.find_sysfs_multipath_dm("},{"line_number":297,"context_line":"                    [device])"},{"line_number":298,"context_line":"                if mpath:"},{"line_number":299,"context_line":"                    # Sometimes the multipath device doesn\u0027t show up"},{"line_number":300,"context_line":"                    # in time and we don\u0027t want to fail here."},{"line_number":301,"context_line":"                    # Wait for multipath device to be ready for I/O"},{"line_number":302,"context_line":"                    self._linuxscsi.wait_for_mpath_device(mpath)"},{"line_number":303,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"a55f1c1e_8e079d52","line":300,"range":{"start_line":299,"start_character":0,"end_line":300,"end_character":61},"updated":"2025-02-06 15:49:10.000000000","message":"nit: I\u0027d put this comment before line 298 since it\u0027s explaining why you added the \"if\", but it should be clear enough from the blame for someone reading the code.","commit_id":"8ac46333d7161beb960b5ee04f60c533c32f9619"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b9f22d0dd1abe6e7a4cc378b5ca5f7a848b24278","unresolved":true,"context_lines":[{"line_number":296,"context_line":"                mpath \u003d self._linuxscsi.find_sysfs_multipath_dm("},{"line_number":297,"context_line":"                    [device])"},{"line_number":298,"context_line":"                if mpath:"},{"line_number":299,"context_line":"                    # Sometimes the multipath device doesn\u0027t show up"},{"line_number":300,"context_line":"                    # in time and we don\u0027t want to fail here."},{"line_number":301,"context_line":"                    # Wait for multipath device to be ready for I/O"},{"line_number":302,"context_line":"                    self._linuxscsi.wait_for_mpath_device(mpath)"},{"line_number":303,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9c958a47_663bf052","line":300,"range":{"start_line":299,"start_character":0,"end_line":300,"end_character":61},"in_reply_to":"a55f1c1e_8e079d52","updated":"2025-02-06 18:12:28.000000000","message":"Yeah, that would have made more sense, will take a note if a refactoring happens in future.","commit_id":"8ac46333d7161beb960b5ee04f60c533c32f9619"}]}
