)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e3eb6296b1501d414b91e68c1c2234879c20bc1","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Dell PowerFlex: Improve secret handling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Deprecate connector configuration for Dell PowerFlex driver."},{"line_number":10,"context_line":"In os-brick, `ScaleIOConnector` does not store PowerFlex secret."},{"line_number":11,"context_line":"Instead, PowerFlex driver handles rest calls to map/unmap volumes"},{"line_number":12,"context_line":"and set QoS."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #2114879"},{"line_number":15,"context_line":"Change-Id: I7d6b454b7e8ad1f50a87b6de10cc63d590eed65e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"0af94cae_dc228d72","line":12,"range":{"start_line":10,"start_character":0,"end_line":12,"end_character":12},"updated":"2025-08-04 08:55:05.000000000","message":"We should be more verbose here defining how the problem is being addressed by this patch","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bbad04b80b0cde0314070b75f54698eb14f028ea","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Dell PowerFlex: Improve secret handling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Deprecate connector configuration for Dell PowerFlex driver."},{"line_number":10,"context_line":"In os-brick, `ScaleIOConnector` does not store PowerFlex secret."},{"line_number":11,"context_line":"Instead, PowerFlex driver handles rest calls to map/unmap volumes"},{"line_number":12,"context_line":"and set QoS."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #2114879"},{"line_number":15,"context_line":"Change-Id: I7d6b454b7e8ad1f50a87b6de10cc63d590eed65e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"22908ba4_2500e27d","line":12,"range":{"start_line":10,"start_character":0,"end_line":12,"end_character":12},"in_reply_to":"0af94cae_dc228d72","updated":"2025-08-10 07:42:30.000000000","message":"Done","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e3eb6296b1501d414b91e68c1c2234879c20bc1","unresolved":true,"context_lines":[{"line_number":11,"context_line":"Instead, PowerFlex driver handles rest calls to map/unmap volumes"},{"line_number":12,"context_line":"and set QoS."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #2114879"},{"line_number":15,"context_line":"Change-Id: I7d6b454b7e8ad1f50a87b6de10cc63d590eed65e"},{"line_number":16,"context_line":"Signed-off-by: Yian Zong \u003cyian.zong@dell.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"8773008b_8d9a14bc","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":20},"updated":"2025-08-04 08:55:05.000000000","message":"The bug makes me believe this is another CVE as a side effect of the earlier CVE-2020-10755","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bbad04b80b0cde0314070b75f54698eb14f028ea","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Instead, PowerFlex driver handles rest calls to map/unmap volumes"},{"line_number":12,"context_line":"and set QoS."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #2114879"},{"line_number":15,"context_line":"Change-Id: I7d6b454b7e8ad1f50a87b6de10cc63d590eed65e"},{"line_number":16,"context_line":"Signed-off-by: Yian Zong \u003cyian.zong@dell.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a10dea4f_393e23dd","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":20},"in_reply_to":"8773008b_8d9a14bc","updated":"2025-08-10 07:42:30.000000000","message":"Please let me know if any further action needed from Dell team side.","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"1dc10a77feb20e6139c5410686037008ade08524","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"15d0ee9a_fd2da13a","updated":"2025-07-07 17:50:32.000000000","message":"Looking for PowerFlex CI results, do we have those?","commit_id":"1a74c121c0b2f0287be3f00fe1af5a0a4c5a1d5c"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"40e5548e4be12f60d9a02c49da0c24df7a236adf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6dd70de4_8e8ec4f5","updated":"2025-07-08 08:43:20.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"1a74c121c0b2f0287be3f00fe1af5a0a4c5a1d5c"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e56ad6dfe65d3519764d861a4b0bf3dc35be34b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa961a2d_31306a5a","in_reply_to":"15d0ee9a_fd2da13a","updated":"2025-07-08 10:47:08.000000000","message":"Hi @jobernar@redhat.com\n\nThanks for reviewing!\nThe CI result is available in the patch. However, I need to update the driver code.\nWill keep you updated.","commit_id":"1a74c121c0b2f0287be3f00fe1af5a0a4c5a1d5c"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"d8a1bc871a2c3df5e737910f80db2c4e15a72c47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de01ade8_018a3943","in_reply_to":"fa961a2d_31306a5a","updated":"2025-07-11 02:34:23.000000000","message":"Hi @jobernar@redhat.com,\n\nCI is present and passed. Please kindly review.\nThanks!","commit_id":"1a74c121c0b2f0287be3f00fe1af5a0a4c5a1d5c"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"664177d3f03b41eb65872099631b030948789656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bb2d1476_f7828fcc","updated":"2025-07-09 09:12:54.000000000","message":"recheck os-brick-src-tempest-lvm-lio-barbican massive timeout","commit_id":"bba98ba207902f2041040377aea2371d552b9a7b"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"4afcc75f8f12ad985973391c466d2a8294556d70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bad9cc48_a3a21991","updated":"2025-07-09 09:32:46.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bba98ba207902f2041040377aea2371d552b9a7b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ed0d6ff61f4c3d561d6e287ff2a4482672e4fa9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e77e9930_cf864e81","updated":"2025-08-07 12:54:36.000000000","message":"I just want to note that this will require some careful testing.  The original fix broke a cloud upgrade scenario and required a followup patch [0].  I\u0027m not saying that I see a flaw in the current code, but no one noticed a problem last time until after the fix was being used, so let\u0027s try to avoid that this time.\n\n[0] https://review.opendev.org/c/openstack/os-brick/+/746109","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e3eb6296b1501d414b91e68c1c2234879c20bc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8c419ceb_db57ddd1","updated":"2025-08-04 08:55:05.000000000","message":"few comments but mainly focusing on releasenote, it should be helpful for operators to understand what they need to change in the deployment in the new release where this change lands (eg: flamingo)","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"58135ec8c5891cc15e5749df0a2e3fbf68a05ebe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3b885cdc_61996386","updated":"2025-07-16 18:14:36.000000000","message":"run Pure Storage CI","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"c346a69769ee4751d3e381527d9709cc0cbe19c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e8af0a55_a92acea3","updated":"2025-07-10 12:42:27.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bbad04b80b0cde0314070b75f54698eb14f028ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8d406977_ba09893a","in_reply_to":"e77e9930_cf864e81","updated":"2025-08-10 07:42:30.000000000","message":"Understood.\nAnd unfortunately patch[0] introduced a regression, which was fixed in patch [1].\n\n[1] https://review.opendev.org/c/openstack/os-brick/+/876284","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"23d02c1aa6279cd819d86d7e42f641e3fb22752a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e90524c4_3f6d8fc8","updated":"2025-08-18 14:26:28.000000000","message":"Code and logic looks clean. LGTM","commit_id":"38277f4596d519fb65237279c216997768845ce3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ae3495f5f87c2e95401e2ee93ab67b9a593b0139","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fb717c61_5506a6a8","updated":"2025-08-18 14:45:19.000000000","message":"Code and tests look ok, Comment inline about the release note.","commit_id":"38277f4596d519fb65237279c216997768845ce3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"87d07995305e721ef47b665d57efff9eb6ac3007","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"54845b28_20edf73a","updated":"2025-08-11 19:59:55.000000000","message":"My comments are addressed, powerflex CI is passing (but the logs are not accessible). LGTM.","commit_id":"38277f4596d519fb65237279c216997768845ce3"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bbad04b80b0cde0314070b75f54698eb14f028ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"714864e4_c365554a","updated":"2025-08-10 07:42:30.000000000","message":"Thanks for reviewing! Comments are resolved.","commit_id":"38277f4596d519fb65237279c216997768845ce3"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"15f4d8b6c87fcddd6b3ef13e598751b60665f60a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cc58bfd3_a896d651","updated":"2025-08-09 01:48:44.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"38277f4596d519fb65237279c216997768845ce3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0f99621055e5bb78a68e58a54869a56b09490738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"328604cc_0f6d7aac","updated":"2025-08-19 13:06:33.000000000","message":"Code and tests look good. Thanks for rephrasing the releasenote, looks good after Brian\u0027s suggestion. powerflex CI is passing, looks good to be merged.","commit_id":"649cf90a60bf733a267daaadd6bb44a4c5d17d70"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"fc4cb3ea87d18f22bcbbb09de2a58b10f6895143","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"982378e9_24c03dbc","updated":"2025-08-25 09:58:31.000000000","message":"LGTM","commit_id":"649cf90a60bf733a267daaadd6bb44a4c5d17d70"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"460a127f2ca4583f0aa049a0b87d5b784dd1986a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"28da9265_7c170769","updated":"2025-08-19 12:30:42.000000000","message":"Revisions LGTM, zuul and PowerFlex CI are green.","commit_id":"649cf90a60bf733a267daaadd6bb44a4c5d17d70"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"84dfc302224319635740958b0b371bade29e2da5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"01b0bae0_03450f8a","updated":"2025-08-19 07:44:15.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"649cf90a60bf733a267daaadd6bb44a4c5d17d70"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"61cf875d7f81f65f18ef7b93f59a02334c483a1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5c627d5e_27c73962","updated":"2025-08-19 04:28:28.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"649cf90a60bf733a267daaadd6bb44a4c5d17d70"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"0945daf3d1d835914d48f04df16d87abf7df712c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dd0daeef_227ea57f","updated":"2025-08-19 09:37:01.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"649cf90a60bf733a267daaadd6bb44a4c5d17d70"}],"os_brick/initiator/connectors/scaleio.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e3eb6296b1501d414b91e68c1c2234879c20bc1","unresolved":true,"context_lines":[{"line_number":343,"context_line":"        self.volume_id \u003d connection_properties.get(\u0027scaleIO_volume_id\u0027)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # Since connector configuration is deprecated,"},{"line_number":346,"context_line":"        # connection_properties has no below properties:"},{"line_number":347,"context_line":"        key_list \u003d [\u0027hostIP\u0027, \u0027serverIP\u0027, \u0027serverPort\u0027, \u0027serverUsername\u0027,"},{"line_number":348,"context_line":"                    \u0027iopsLimit\u0027, \u0027bandwidthLimit\u0027]"},{"line_number":349,"context_line":"        if all(key in connection_properties for key in key_list):"}],"source_content_type":"text/x-python","patch_set":5,"id":"de134fae_2940ab27","line":346,"range":{"start_line":346,"start_character":32,"end_line":346,"end_character":44},"updated":"2025-08-04 08:55:05.000000000","message":"nit: doesn\u0027t have the following","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bbad04b80b0cde0314070b75f54698eb14f028ea","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        self.volume_id \u003d connection_properties.get(\u0027scaleIO_volume_id\u0027)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # Since connector configuration is deprecated,"},{"line_number":346,"context_line":"        # connection_properties has no below properties:"},{"line_number":347,"context_line":"        key_list \u003d [\u0027hostIP\u0027, \u0027serverIP\u0027, \u0027serverPort\u0027, \u0027serverUsername\u0027,"},{"line_number":348,"context_line":"                    \u0027iopsLimit\u0027, \u0027bandwidthLimit\u0027]"},{"line_number":349,"context_line":"        if all(key in connection_properties for key in key_list):"}],"source_content_type":"text/x-python","patch_set":5,"id":"8d0f82ea_8b48d85f","line":346,"range":{"start_line":346,"start_character":32,"end_line":346,"end_character":44},"in_reply_to":"de134fae_2940ab27","updated":"2025-08-10 07:42:30.000000000","message":"Done","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e3eb6296b1501d414b91e68c1c2234879c20bc1","unresolved":true,"context_lines":[{"line_number":363,"context_line":"            self.certificate_path \u003d connection_properties.get("},{"line_number":364,"context_line":"                \u0027certificate_path\u0027)"},{"line_number":365,"context_line":"        device_info \u003d {\u0027type\u0027: \u0027block\u0027,"},{"line_number":366,"context_line":"                       \u0027path\u0027: self.volume_path}"},{"line_number":367,"context_line":"        return device_info"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    @utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"98962e6e_70c43c45","line":366,"range":{"start_line":366,"start_character":31,"end_line":366,"end_character":47},"updated":"2025-08-04 08:55:05.000000000","message":"this looks wrong to me, we are relying on an in-memory variable which is set while we are connecting/discovering the volume and fetched when we are disconnecting the volume. If the service (nova) restarts between the two operations, we will have a value of None which is not desired, a better way to assure that this value will exist is,\n\n    \u0027path\u0027: self._find_volume_path()","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bbad04b80b0cde0314070b75f54698eb14f028ea","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            self.certificate_path \u003d connection_properties.get("},{"line_number":364,"context_line":"                \u0027certificate_path\u0027)"},{"line_number":365,"context_line":"        device_info \u003d {\u0027type\u0027: \u0027block\u0027,"},{"line_number":366,"context_line":"                       \u0027path\u0027: self.volume_path}"},{"line_number":367,"context_line":"        return device_info"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    @utils.trace"}],"source_content_type":"text/x-python","patch_set":5,"id":"ddbd6147_8784717b","line":366,"range":{"start_line":366,"start_character":31,"end_line":366,"end_character":47},"in_reply_to":"98962e6e_70c43c45","updated":"2025-08-10 07:42:30.000000000","message":"The change `\u0027path\u0027: self._find_volume_path()` works with the new routine as the new driver always passes \u0027scaleIO_volume_id\u0027 in the \u0027connection_properties\u0027.\nFor the old driver, as indicated in L340~343, \u0027self.volume_id\u0027 could be None. And that will cause method \u0027self._find_volume_path()\u0027 ending up with \u0027TypeError\u0027.\nIn the old routine, L409 is required before call \u0027self._find_volume_path()\u0027.","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e3eb6296b1501d414b91e68c1c2234879c20bc1","unresolved":true,"context_lines":[{"line_number":403,"context_line":"            device_info[\u0027path\u0027] \u003d self.volume_path"},{"line_number":404,"context_line":"            return device_info"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        # The old routin before connector configuration is deprecated"},{"line_number":407,"context_line":"        guid \u003d self._get_guid()"},{"line_number":408,"context_line":"        params \u003d {\u0027guid\u0027: guid, \u0027allowMultipleMappings\u0027: \u0027TRUE\u0027}"},{"line_number":409,"context_line":"        self.volume_id \u003d self.volume_id or self._get_volume_id()"}],"source_content_type":"text/x-python","patch_set":5,"id":"61356efd_dc98b610","line":406,"range":{"start_line":406,"start_character":18,"end_line":406,"end_character":24},"updated":"2025-08-04 08:55:05.000000000","message":"nit: routine","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bbad04b80b0cde0314070b75f54698eb14f028ea","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            device_info[\u0027path\u0027] \u003d self.volume_path"},{"line_number":404,"context_line":"            return device_info"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        # The old routin before connector configuration is deprecated"},{"line_number":407,"context_line":"        guid \u003d self._get_guid()"},{"line_number":408,"context_line":"        params \u003d {\u0027guid\u0027: guid, \u0027allowMultipleMappings\u0027: \u0027TRUE\u0027}"},{"line_number":409,"context_line":"        self.volume_id \u003d self.volume_id or self._get_volume_id()"}],"source_content_type":"text/x-python","patch_set":5,"id":"83ecfb9a_ea418ff0","line":406,"range":{"start_line":406,"start_character":18,"end_line":406,"end_character":24},"in_reply_to":"61356efd_dc98b610","updated":"2025-08-10 07:42:30.000000000","message":"Done","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e3eb6296b1501d414b91e68c1c2234879c20bc1","unresolved":true,"context_lines":[{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        # Since connector configuration is deprecated,"},{"line_number":523,"context_line":"        # the driver will unmap the volume."},{"line_number":524,"context_line":"        if self.no_secret:"},{"line_number":525,"context_line":"            return"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        # The old routin before connector configuration is deprecated"},{"line_number":528,"context_line":"        self.volume_id \u003d self.volume_id or self._get_volume_id()"}],"source_content_type":"text/x-python","patch_set":5,"id":"0d0b027a_26d7f286","line":525,"range":{"start_line":524,"start_character":8,"end_line":525,"end_character":18},"updated":"2025-08-04 08:55:05.000000000","message":"don\u0027t we need to remove the device from the host? not sure if the removal is handled by SDC but otherwise we will have a stale device on host.","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bbad04b80b0cde0314070b75f54698eb14f028ea","unresolved":false,"context_lines":[{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        # Since connector configuration is deprecated,"},{"line_number":523,"context_line":"        # the driver will unmap the volume."},{"line_number":524,"context_line":"        if self.no_secret:"},{"line_number":525,"context_line":"            return"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        # The old routin before connector configuration is deprecated"},{"line_number":528,"context_line":"        self.volume_id \u003d self.volume_id or self._get_volume_id()"}],"source_content_type":"text/x-python","patch_set":5,"id":"bdc6f04c_4841913d","line":525,"range":{"start_line":524,"start_character":8,"end_line":525,"end_character":18},"in_reply_to":"0d0b027a_26d7f286","updated":"2025-08-10 07:42:30.000000000","message":"Device removal is handled by SDC.","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"}],"releasenotes/notes/bug-2114879-dell-powerflex-improve-secret-handling-c468d66b58a9626d.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e3eb6296b1501d414b91e68c1c2234879c20bc1","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerFlex driver `Bug #2114879"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2114879\u003e`_: Improved"},{"line_number":6,"context_line":"    PowerFlex secret handling. The connector configuration is"},{"line_number":7,"context_line":"    deprecated."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f2a27bf_b2331e71","line":7,"range":{"start_line":5,"start_character":55,"end_line":7,"end_character":15},"updated":"2025-08-04 08:55:05.000000000","message":"This is not really a helpful text for operators reading the releasenotes. We need to explicitly mention that:\n1. We don\u0027t need to create the /opt/emc/scaleio/openstack/connector.conf file on the host using os-brick\n2. the security issue while using Ironic host is fixed\n3. The mapping logic is handled by cinder so we won\u0027t be passing the password in connection_properties as used to happen in the older security vulnerability case\n\nThese are just highlighted points which will need to be expanded in each of the sections like upgrades, deprecations, security etc.","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b1df2c841f75c5e42e2c13d9ff136454b9c06a30","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerFlex driver `Bug #2114879"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2114879\u003e`_: Improved"},{"line_number":6,"context_line":"    PowerFlex secret handling. The connector configuration is"},{"line_number":7,"context_line":"    deprecated."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"be0eb454_609871d0","line":7,"range":{"start_line":5,"start_character":55,"end_line":7,"end_character":15},"in_reply_to":"3f2a27bf_b2331e71","updated":"2025-08-07 12:15:16.000000000","message":"You can use the release note from the original fix as a model:\nreleasenotes/notes/bug-1823200-victoria-b414a1806cba3998.yaml","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bbad04b80b0cde0314070b75f54698eb14f028ea","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerFlex driver `Bug #2114879"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2114879\u003e`_: Improved"},{"line_number":6,"context_line":"    PowerFlex secret handling. The connector configuration is"},{"line_number":7,"context_line":"    deprecated."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0f896f0d_30e9b847","line":7,"range":{"start_line":5,"start_character":55,"end_line":7,"end_character":15},"in_reply_to":"ae667500_bb680e07","updated":"2025-08-10 07:42:30.000000000","message":"Rephrased.","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ed0d6ff61f4c3d561d6e287ff2a4482672e4fa9a","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerFlex driver `Bug #2114879"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2114879\u003e`_: Improved"},{"line_number":6,"context_line":"    PowerFlex secret handling. The connector configuration is"},{"line_number":7,"context_line":"    deprecated."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ae667500_bb680e07","line":7,"range":{"start_line":5,"start_character":55,"end_line":7,"end_character":15},"in_reply_to":"be0eb454_609871d0","updated":"2025-08-07 12:54:36.000000000","message":"Additionally, you need to point out that this version of os-brick is compatible with the legacy password-in-host-file strategy.  Saying that it is \u0027deprecated\u0027 implies that it is subject to removal ... if that is the case, you need to state when you expect the removal to happen so that operators can prepare.","commit_id":"aa22cb42d87b8eae26342f325d75a48a46d50cb8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"87d07995305e721ef47b665d57efff9eb6ac3007","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    Dell PowerFlex driver `Bug #2114879"},{"line_number":19,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2114879\u003e`_:"},{"line_number":20,"context_line":"    This release contains an updated connector for use with"},{"line_number":21,"context_line":"    Dell PowerFlex backend. The connector passed PowerFlex SDC GUID in the"},{"line_number":22,"context_line":"    connector properties. Dell PowerFlex cinder driver retrieved SDC GUID"},{"line_number":23,"context_line":"    from the connector properties and handled the mapping logic."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"efaee128_478941de","line":23,"range":{"start_line":21,"start_character":28,"end_line":23,"end_character":64},"updated":"2025-08-11 19:59:55.000000000","message":"the \u0027SDC GUID\u0027 detail might not be needed and just the part about cinder handling the mapping logic would suffice.","commit_id":"38277f4596d519fb65237279c216997768845ce3"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"f04899bf5e9e152cbeb468574119f92ffab061a2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    Dell PowerFlex driver `Bug #2114879"},{"line_number":19,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2114879\u003e`_:"},{"line_number":20,"context_line":"    This release contains an updated connector for use with"},{"line_number":21,"context_line":"    Dell PowerFlex backend. The connector passed PowerFlex SDC GUID in the"},{"line_number":22,"context_line":"    connector properties. Dell PowerFlex cinder driver retrieved SDC GUID"},{"line_number":23,"context_line":"    from the connector properties and handled the mapping logic."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"8eb93a7d_18e530ed","line":23,"range":{"start_line":21,"start_character":28,"end_line":23,"end_character":64},"in_reply_to":"684985df_cf479c9a","updated":"2025-08-19 04:31:32.000000000","message":"Done","commit_id":"38277f4596d519fb65237279c216997768845ce3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ae3495f5f87c2e95401e2ee93ab67b9a593b0139","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    Dell PowerFlex driver `Bug #2114879"},{"line_number":19,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2114879\u003e`_:"},{"line_number":20,"context_line":"    This release contains an updated connector for use with"},{"line_number":21,"context_line":"    Dell PowerFlex backend. The connector passed PowerFlex SDC GUID in the"},{"line_number":22,"context_line":"    connector properties. Dell PowerFlex cinder driver retrieved SDC GUID"},{"line_number":23,"context_line":"    from the connector properties and handled the mapping logic."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"684985df_cf479c9a","line":23,"range":{"start_line":21,"start_character":28,"end_line":23,"end_character":64},"in_reply_to":"efaee128_478941de","updated":"2025-08-18 14:45:19.000000000","message":"-1: please rewrite ... the change in tenses is confusing.  Line 20: this release *contains* , while line 21 says \"The connector *passed*, *retrieved*, *handled*\". So lines 21-23 seem to say what the connector and driver previously did (that you have fixed), but aren\u0027t these lines describing how the os-brick connector and cinder driver interact now?\n\nAlso, I agree with Rajat about the content ... it\u0027s probably enough to emphasize that os-brick no longer requires access to backend secrets, and all that is handled by the cinder driver now.","commit_id":"38277f4596d519fb65237279c216997768845ce3"}]}