)]}'
{"os_client_config/cloud_config.py":[{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"b33a4bbd3c72a96b980129da623df4d580818ced","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def get_auth_args(self):"},{"line_number":75,"context_line":"        return self.config[\u0027auth\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_interface(self, service_type\u003dNone):"},{"line_number":78,"context_line":"        if \u0027interface\u0027 in self.config:"},{"line_number":79,"context_line":"            interface \u003d self.config[\u0027interface\u0027]"},{"line_number":80,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_2da70f0c","line":77,"updated":"2015-07-15 19:44:37.000000000","message":"where is this method used? I don\u0027t see it used anywhere, so I am wondering if we shouldn\u0027t use it in https://review.openstack.org/#/c/198506/ to get the default interface for the case when we have a  {service_type}_interface entry in defaults.yaml","commit_id":"6270cfa868c0058ea97fd85db158baeeeebff941"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"d8e62aae20d8e92d05dcd278103dd33913845933","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            interface \u003d self.config[\u0027endpoint_type\u0027]"},{"line_number":82,"context_line":"        if not service_type:"},{"line_number":83,"context_line":"            return interface"},{"line_number":84,"context_line":"        key \u003d \u0027{service_type}_interface\u0027.format(service_type\u003dservice_type)"},{"line_number":85,"context_line":"        if key in self.config:"},{"line_number":86,"context_line":"            return self.config.get(key, interface)"},{"line_number":87,"context_line":"        key \u003d \u0027{service_type}_endpoint_type\u0027.format(service_type\u003dservice_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_9b333114","line":84,"updated":"2015-07-14 20:36:27.000000000","message":"Why the clunky use of format? \u0027{0}_interface\u0027.format(service_type) would work just as well. The {0} is needed for 2.6 support otherwise just \u0027{}\u0027 works.","commit_id":"6270cfa868c0058ea97fd85db158baeeeebff941"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"e62f5df447e5563fd904781f592db3e30e3bff0b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            interface \u003d self.config[\u0027endpoint_type\u0027]"},{"line_number":82,"context_line":"        if not service_type:"},{"line_number":83,"context_line":"            return interface"},{"line_number":84,"context_line":"        key \u003d \u0027{service_type}_interface\u0027.format(service_type\u003dservice_type)"},{"line_number":85,"context_line":"        if key in self.config:"},{"line_number":86,"context_line":"            return self.config.get(key, interface)"},{"line_number":87,"context_line":"        key \u003d \u0027{service_type}_endpoint_type\u0027.format(service_type\u003dservice_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_0db8e228","line":84,"in_reply_to":"9a41bdd9_9b333114","updated":"2015-07-16 13:21:31.000000000","message":"I\u0027m more of a fan of named parameters than positional myself.","commit_id":"6270cfa868c0058ea97fd85db158baeeeebff941"}],"os_client_config/tests/test_cloud_config.py":[{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"d8e62aae20d8e92d05dcd278103dd33913845933","unresolved":false,"context_lines":[{"line_number":20,"context_line":"fake_services_dict \u003d {"},{"line_number":21,"context_line":"    \u0027compute_api_version\u0027: 2,"},{"line_number":22,"context_line":"    \u0027compute_region_name\u0027: \u0027region-bl\u0027,"},{"line_number":23,"context_line":"    \u0027interface\u0027: \u0027public\u0027,"},{"line_number":24,"context_line":"    \u0027image_service_type\u0027: \u0027mage\u0027,"},{"line_number":25,"context_line":"    \u0027image_endpoint_type\u0027: \u0027private\u0027,"},{"line_number":26,"context_line":"    \u0027identity_interface\u0027: \u0027admin\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_db045919","line":23,"updated":"2015-07-14 20:36:27.000000000","message":"You need another fake_services_dict to support the old configuration using endpoint_type. Otherwise you are not full testing the code paths.","commit_id":"6270cfa868c0058ea97fd85db158baeeeebff941"}]}