)]}'
{"os_client_config/config.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c5ca4d53606348c79222b1a5dd92f5ec15e1ca93","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                return [self._expand_region_name(new_cloud[\u0027region_name\u0027])]"},{"line_number":308,"context_line":"            else:"},{"line_number":309,"context_line":"                # Wow. We really tried"},{"line_number":310,"context_line":"                return [self._expand_region_name(\u0027\u0027)]"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def _get_region(self, cloud\u003dNone, region_name\u003dNone):"},{"line_number":313,"context_line":"        if cloud is None and region_name is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_c8993e21","line":310,"updated":"2015-11-22 18:33:51.000000000","message":"HAH @ this comment.","commit_id":"31308497ba998a509b56559e89dfb267ad18a364"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c5ca4d53606348c79222b1a5dd92f5ec15e1ca93","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                return [self._expand_region_name(\u0027\u0027)]"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def _get_region(self, cloud\u003dNone, region_name\u003dNone):"},{"line_number":313,"context_line":"        if cloud is None and region_name is not None:"},{"line_number":314,"context_line":"            return self._expand_region_name(region_name)"},{"line_number":315,"context_line":"        if not region_name:"},{"line_number":316,"context_line":"            return self._get_regions(cloud)[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_686cd208","line":313,"updated":"2015-11-22 18:33:51.000000000","message":"(NIT, please don\u0027t re-roll for this comment):\n\nThis logic might be something to consider simplifiying down the line so there is less if \u003ccheck thing\u003e then if \u003ccheck something we already checked\u003e.\n\nIt\u0027s not terrible but something that can make reading the code harder in the long run. [OCC seems to have a lot of minor cleanup that can be done down the line, and I\u0027ll chalk this up to the same thing]","commit_id":"31308497ba998a509b56559e89dfb267ad18a364"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"b7108fb635208ff7d32a651fedfddaa6a050cb52","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                return [self._expand_region_name(\u0027\u0027)]"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def _get_region(self, cloud\u003dNone, region_name\u003dNone):"},{"line_number":313,"context_line":"        if cloud is None and region_name is not None:"},{"line_number":314,"context_line":"            return self._expand_region_name(region_name)"},{"line_number":315,"context_line":"        if not region_name:"},{"line_number":316,"context_line":"            return self._get_regions(cloud)[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_a8171a53","line":313,"in_reply_to":"ba8a016a_686cd208","updated":"2015-11-22 18:52:19.000000000","message":"A LOT of cleanup.","commit_id":"31308497ba998a509b56559e89dfb267ad18a364"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"d3774caba7b90dc5a869ffca76fe4be02c369200","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        if cloud is None and region_name is not None:"},{"line_number":314,"context_line":"            return self._expand_region_name(region_name)"},{"line_number":315,"context_line":"        if not region_name:"},{"line_number":316,"context_line":"            return self._get_regions(cloud)[0]"},{"line_number":317,"context_line":"        else:"},{"line_number":318,"context_line":"            for region in self._get_regions(cloud):"},{"line_number":319,"context_line":"                if region[\u0027name\u0027] \u003d\u003d region_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_6843726d","line":316,"updated":"2015-11-22 18:34:43.000000000","message":"Oh NVM Strike my last comment I see it here now. Cloud[0]","commit_id":"31308497ba998a509b56559e89dfb267ad18a364"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"38fd1f62144fa03c0f74cca116cdb9d88befa8b9","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        if cloud is None and region_name is not None:"},{"line_number":314,"context_line":"            return self._expand_region_name(region_name)"},{"line_number":315,"context_line":"        if not region_name:"},{"line_number":316,"context_line":"            return self._get_regions(cloud)[0]"},{"line_number":317,"context_line":"        else:"},{"line_number":318,"context_line":"            for region in self._get_regions(cloud):"},{"line_number":319,"context_line":"                if region[\u0027name\u0027] \u003d\u003d region_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_285eca45","line":316,"in_reply_to":"ba8a016a_6843726d","updated":"2015-11-22 18:36:08.000000000","message":"RE: comment below, the key eror might be a weird response...","commit_id":"31308497ba998a509b56559e89dfb267ad18a364"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"c5ca4d53606348c79222b1a5dd92f5ec15e1ca93","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                    region_name\u003dregion_name,"},{"line_number":326,"context_line":"                    region_list\u003d\u0027,\u0027.join("},{"line_number":327,"context_line":"                        [r[\u0027name\u0027] for r in self._get_regions(cloud)]),"},{"line_number":328,"context_line":"                    cloud\u003dcloud))"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def get_cloud_names(self):"},{"line_number":331,"context_line":"        return self.cloud_config[\u0027clouds\u0027].keys()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_e880c28d","line":328,"updated":"2015-11-22 18:33:51.000000000","message":"What is the fall-through case here if cloud\u003dNone and region_name\u003dNone? a simple return of None? It feels like there is a missing exception raise here.","commit_id":"31308497ba998a509b56559e89dfb267ad18a364"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"715a86c3bb0d6d56d81dc010d755cac11d54d227","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        if cloud is None:"},{"line_number":314,"context_line":"            return self._expand_region_name(region_name)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        regions \u003d self._get_regions(cloud)"},{"line_number":317,"context_line":"        if not region_name:"},{"line_number":318,"context_line":"            return regions[0]"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_db4826cf","line":316,"updated":"2015-11-22 20:43:45.000000000","message":"This is so very much more readable.","commit_id":"5b9d9e2253ba201979d33bf70d2faafb003332ad"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"259c6c7cde74167239bbb6d4c4a208b59f9e103a","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        if cloud is None:"},{"line_number":314,"context_line":"            return self._expand_region_name(region_name)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        regions \u003d self._get_regions(cloud)"},{"line_number":317,"context_line":"        if not region_name:"},{"line_number":318,"context_line":"            return regions[0]"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_5e342449","line":316,"in_reply_to":"ba8a016a_db4826cf","updated":"2015-11-22 23:20:08.000000000","message":"YAY!","commit_id":"5b9d9e2253ba201979d33bf70d2faafb003332ad"}],"os_client_config/tests/test_config.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"715a86c3bb0d6d56d81dc010d755cac11d54d227","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        )"},{"line_number":237,"context_line":"        self.options \u003d argparse.Namespace(**self.args)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def test_get_one_cloud_bad_region_argparse(self):"},{"line_number":240,"context_line":"        c \u003d config.OpenStackConfig(config_files\u003d[self.cloud_yaml],"},{"line_number":241,"context_line":"                                   vendor_files\u003d[self.vendor_yaml])"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_9b113eb2","line":239,"updated":"2015-11-22 20:43:45.000000000","message":"(NIT): I would also like to see a test where cloud and region_name are left as defaults, but I don\u0027t think it\u0027s critical to land this.","commit_id":"5b9d9e2253ba201979d33bf70d2faafb003332ad"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"259c6c7cde74167239bbb6d4c4a208b59f9e103a","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        )"},{"line_number":237,"context_line":"        self.options \u003d argparse.Namespace(**self.args)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def test_get_one_cloud_bad_region_argparse(self):"},{"line_number":240,"context_line":"        c \u003d config.OpenStackConfig(config_files\u003d[self.cloud_yaml],"},{"line_number":241,"context_line":"                                   vendor_files\u003d[self.vendor_yaml])"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_3e3cc02e","line":239,"in_reply_to":"ba8a016a_9b113eb2","updated":"2015-11-22 23:20:08.000000000","message":"There are actually already some of those in the test suite, actually.","commit_id":"5b9d9e2253ba201979d33bf70d2faafb003332ad"}]}