)]}'
{"os_client_config/config.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"5475f6dfbe6648f44ff89ceaddd24951f7a8855b","unresolved":false,"context_lines":[{"line_number":140,"context_line":"def _fix_argv(argv):"},{"line_number":141,"context_line":"    # Transform any _ characters in arg names to - so that we don\u0027t"},{"line_number":142,"context_line":"    # have to throw billions of compat argparse arguments around all"},{"line_number":143,"context_line":"    # over the place."},{"line_number":144,"context_line":"    changed \u003d collections.defaultdict(list)"},{"line_number":145,"context_line":"    for index in range(0, len(argv)):"},{"line_number":146,"context_line":"        if argv[index].startswith(\u0027--\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_d0a4ac09","line":143,"updated":"2015-12-15 19:26:31.000000000","message":"I wish we could just deny the old args with _ instead, but i get why we can\u0027t.","commit_id":"2b4b0823a64d40a019c1f938891ceb868609d1b8"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"43c4a4c4a19890f4e9fb06002f3831f5b1de0d6c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"def _fix_argv(argv):"},{"line_number":141,"context_line":"    # Transform any _ characters in arg names to - so that we don\u0027t"},{"line_number":142,"context_line":"    # have to throw billions of compat argparse arguments around all"},{"line_number":143,"context_line":"    # over the place."},{"line_number":144,"context_line":"    changed \u003d collections.defaultdict(list)"},{"line_number":145,"context_line":"    for index in range(0, len(argv)):"},{"line_number":146,"context_line":"        if argv[index].startswith(\u0027--\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_d9b6dddb","line":143,"in_reply_to":"5a710552_d0a4ac09","updated":"2015-12-15 22:30:00.000000000","message":"++","commit_id":"2b4b0823a64d40a019c1f938891ceb868609d1b8"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"5475f6dfbe6648f44ff89ceaddd24951f7a8855b","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                \" identical except that one has _ and one has -. There is\""},{"line_number":160,"context_line":"                \" no sane way for us to know what you\u0027re doing. Remove the\""},{"line_number":161,"context_line":"                \" duplicate option and try again\".format("},{"line_number":162,"context_line":"                    options\u003dold.join(\u0027,\u0027)))"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class OpenStackConfig(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_f07208ad","line":162,"updated":"2015-12-15 19:26:31.000000000","message":"do we really want to raise out at the first instance of this or report all and then raise out or build a comprehensive list and then raise out?","commit_id":"2b4b0823a64d40a019c1f938891ceb868609d1b8"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"799308e0bf4b2b885b09eb72f1d44a169af8dcee","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                \" identical except that one has _ and one has -. There is\""},{"line_number":160,"context_line":"                \" no sane way for us to know what you\u0027re doing. Remove the\""},{"line_number":161,"context_line":"                \" duplicate option and try again\".format("},{"line_number":162,"context_line":"                    options\u003dold.join(\u0027,\u0027)))"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class OpenStackConfig(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_fcb10e48","line":162,"in_reply_to":"5a710552_19c5453b","updated":"2015-12-18 15:11:48.000000000","message":"Done","commit_id":"2b4b0823a64d40a019c1f938891ceb868609d1b8"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"43c4a4c4a19890f4e9fb06002f3831f5b1de0d6c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                \" identical except that one has _ and one has -. There is\""},{"line_number":160,"context_line":"                \" no sane way for us to know what you\u0027re doing. Remove the\""},{"line_number":161,"context_line":"                \" duplicate option and try again\".format("},{"line_number":162,"context_line":"                    options\u003dold.join(\u0027,\u0027)))"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"class OpenStackConfig(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_19c5453b","line":162,"in_reply_to":"5a710552_f07208ad","updated":"2015-12-15 22:30:00.000000000","message":"Good call.","commit_id":"2b4b0823a64d40a019c1f938891ceb868609d1b8"}],"os_client_config/tests/test_config.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"d7929da240db4ead6d2439bd8ecf6ee0328cd57a","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        cc \u003d c.get_one_cloud(argparse\u003dopts)"},{"line_number":446,"context_line":"        self.assertEqual(cc.config[\u0027auth\u0027][\u0027username\u0027], \u0027user\u0027)"},{"line_number":447,"context_line":"        self.assertEqual(cc.config[\u0027auth\u0027][\u0027password\u0027], \u0027pass\u0027)"},{"line_number":448,"context_line":"        self.assertEqual(cc.config[\u0027auth\u0027][\u0027auth_url\u0027], \u0027auth-url\u0027)"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    def test_register_argparse_bad_plugin(self):"},{"line_number":451,"context_line":"        c \u003d config.OpenStackConfig(config_files\u003d[self.cloud_yaml],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_48cf3c29","line":448,"updated":"2015-12-18 16:23:06.000000000","message":"It would be nice to have a test for the duplicate arg error processing. This can be done as a followup patch (or I\u0027ll take a swing at it shortly).","commit_id":"4818d6f41893f2768406ed7bbf67fc7e0c661551"}]}
