)]}'
{"os_client_config/config.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"d40bc9a9ebe14c7ba6ec70fe748ffe9f16b29052","unresolved":false,"context_lines":[{"line_number":883,"context_line":"        if (((\u0027auth\u0027 in config and \u0027token\u0027 in config[\u0027auth\u0027]) or"},{"line_number":884,"context_line":"                (\u0027auth_token\u0027 in config and config[\u0027auth_token\u0027]) or"},{"line_number":885,"context_line":"                (\u0027token\u0027 in config and config[\u0027token\u0027])) and not"},{"line_number":886,"context_line":"                (\u0027url\u0027 in config)):"},{"line_number":887,"context_line":"            config[\u0027auth_type\u0027] \u003d \u0027token\u0027"},{"line_number":888,"context_line":"            config.setdefault(\u0027token\u0027, config.pop(\u0027auth_token\u0027, None))"},{"line_number":889,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_34ccdb88","line":886,"range":{"start_line":886,"start_character":15,"end_line":886,"end_character":35},"updated":"2015-12-23 20:11:19.000000000","message":"This is a fine change, we don\u0027t need to convert to the token endpoint in all cases if we have already said \"use this URL\".\n\nI would like to see if an auth-url is also passed we also do normal auth process. This likely needs to be:\n\n  (\u0027url\u0027 in config and \u0027auth_url\u0027 not in config)):\n\nSecond, we already broke once, we need a test to ensure we don\u0027t regress again in the future.","commit_id":"65fd9d1baa59dedc225782d3a067c6cae2e69f23"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"eae88b0620aef33ccec0a38ac4d3dc774f11ca3a","unresolved":false,"context_lines":[{"line_number":883,"context_line":"        if (((\u0027auth\u0027 in config and \u0027token\u0027 in config[\u0027auth\u0027]) or"},{"line_number":884,"context_line":"                (\u0027auth_token\u0027 in config and config[\u0027auth_token\u0027]) or"},{"line_number":885,"context_line":"                (\u0027token\u0027 in config and config[\u0027token\u0027])) and not"},{"line_number":886,"context_line":"                (\u0027url\u0027 in config)):"},{"line_number":887,"context_line":"            config[\u0027auth_type\u0027] \u003d \u0027token\u0027"},{"line_number":888,"context_line":"            config.setdefault(\u0027token\u0027, config.pop(\u0027auth_token\u0027, None))"},{"line_number":889,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_37cb7820","line":886,"range":{"start_line":886,"start_character":15,"end_line":886,"end_character":35},"in_reply_to":"1a7b0d38_147d1f1c","updated":"2015-12-24 19:11:29.000000000","message":"Done","commit_id":"65fd9d1baa59dedc225782d3a067c6cae2e69f23"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"ea1c36d6a138ad300792d9eb1a4fee8410489069","unresolved":false,"context_lines":[{"line_number":883,"context_line":"        if (((\u0027auth\u0027 in config and \u0027token\u0027 in config[\u0027auth\u0027]) or"},{"line_number":884,"context_line":"                (\u0027auth_token\u0027 in config and config[\u0027auth_token\u0027]) or"},{"line_number":885,"context_line":"                (\u0027token\u0027 in config and config[\u0027token\u0027])) and not"},{"line_number":886,"context_line":"                (\u0027url\u0027 in config)):"},{"line_number":887,"context_line":"            config[\u0027auth_type\u0027] \u003d \u0027token\u0027"},{"line_number":888,"context_line":"            config.setdefault(\u0027token\u0027, config.pop(\u0027auth_token\u0027, None))"},{"line_number":889,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_147d1f1c","line":886,"range":{"start_line":886,"start_character":15,"end_line":886,"end_character":35},"in_reply_to":"1a7b0d38_34ccdb88","updated":"2015-12-23 20:13:09.000000000","message":"Sorry, recommended code was wrong:\n\n  (\u0027url\u0027 in config and \u0027auth_url\u0027 in config)):","commit_id":"65fd9d1baa59dedc225782d3a067c6cae2e69f23"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b66865507d4d4eeb96106132d3c05e3b1983f92f","unresolved":false,"context_lines":[{"line_number":883,"context_line":"        if (((\u0027auth\u0027 in config and \u0027token\u0027 in config[\u0027auth\u0027]) or"},{"line_number":884,"context_line":"                (\u0027auth_token\u0027 in config and config[\u0027auth_token\u0027]) or"},{"line_number":885,"context_line":"                (\u0027token\u0027 in config and config[\u0027token\u0027])) and not"},{"line_number":886,"context_line":"                (\u0027url\u0027 in config)):"},{"line_number":887,"context_line":"            config[\u0027auth_type\u0027] \u003d \u0027token\u0027"},{"line_number":888,"context_line":"            config.setdefault(\u0027token\u0027, config.pop(\u0027auth_token\u0027, None))"},{"line_number":889,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_484a0cae","line":886,"range":{"start_line":886,"start_character":15,"end_line":886,"end_character":35},"in_reply_to":"1a7b0d38_37cb7820","updated":"2015-12-24 19:51:57.000000000","message":"I\u0027m digging more into this and this change is likely to break other associated things. I\u0027m currently trying to pick apart the cases we need to use a different plugin from \"token\".\n\nI think I have a fix almost ready.","commit_id":"65fd9d1baa59dedc225782d3a067c6cae2e69f23"}],"os_client_config/tests/test_config.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6c51effd27d8472e9847305224f2df18faa54dfd","unresolved":false,"context_lines":[{"line_number":483,"context_line":"        parser.add_argument(\u0027--os-auth-token\u0027)"},{"line_number":484,"context_line":"        opts, _remain \u003d parser.parse_known_args("},{"line_number":485,"context_line":"            [\u0027--os-auth-token\u0027, \u0027very-bad-things\u0027,"},{"line_number":486,"context_line":"             \u0027--os-auth-type\u0027, \u0027token\u0027])"},{"line_number":487,"context_line":"        cc \u003d c.get_one_cloud(argparse\u003dopts)"},{"line_number":488,"context_line":"        self.assertEqual(cc.config[\u0027auth_type\u0027], \u0027token\u0027)"},{"line_number":489,"context_line":"        self.assertEqual(cc.config[\u0027auth\u0027][\u0027token\u0027], \u0027very-bad-things\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_b33fcad5","line":486,"range":{"start_line":486,"start_character":32,"end_line":486,"end_character":37},"updated":"2015-12-29 17:40:53.000000000","message":"Should we add a test that you can explicitly say `--os-auth-type token_endpoint` and have that pass through to cc.config[\u0027auth_type\u0027]? That seems to be the part that broke.","commit_id":"77c0365ce2d42adce9352cf238fbdbc7c282222f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"82f0e07b205ea9dcc646dbf52cf88c09ce8eb3c5","unresolved":false,"context_lines":[{"line_number":483,"context_line":"        parser.add_argument(\u0027--os-auth-token\u0027)"},{"line_number":484,"context_line":"        opts, _remain \u003d parser.parse_known_args("},{"line_number":485,"context_line":"            [\u0027--os-auth-token\u0027, \u0027very-bad-things\u0027,"},{"line_number":486,"context_line":"             \u0027--os-auth-type\u0027, \u0027token\u0027])"},{"line_number":487,"context_line":"        cc \u003d c.get_one_cloud(argparse\u003dopts)"},{"line_number":488,"context_line":"        self.assertEqual(cc.config[\u0027auth_type\u0027], \u0027token\u0027)"},{"line_number":489,"context_line":"        self.assertEqual(cc.config[\u0027auth\u0027][\u0027token\u0027], \u0027very-bad-things\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_1f49f7d0","line":486,"range":{"start_line":486,"start_character":32,"end_line":486,"end_character":37},"in_reply_to":"fa69d971_b33fcad5","updated":"2015-12-29 20:16:44.000000000","message":"Keystoneauth (as far as i know) does not expose \"token_endpoint\" anymore, it is called \"admin_token\" so perhaps \"admin_token\" is the right one to add. I\u0027d be happy to see that test in a followup to this patch-set","commit_id":"77c0365ce2d42adce9352cf238fbdbc7c282222f"}]}
