)]}'
{"os_client_config/cloud_config.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"e57adc6504d8c7110855ab568fa55f6db8814665","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def __init__(self, name, region, config,"},{"line_number":74,"context_line":"                 force_ipv4\u003dFalse, auth_plugin\u003dNone,"},{"line_number":75,"context_line":"                 openstack_config\u003dNone, session_constructor\u003dNone,"},{"line_number":76,"context_line":"                 client_name\u003dNone, client_version\u003dNone,"},{"line_number":77,"context_line":"                 app_name\u003dNone, app_version\u003dNone):"},{"line_number":78,"context_line":"        self.name \u003d name"},{"line_number":79,"context_line":"        self.region \u003d region"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_fc59095a","line":76,"updated":"2017-04-17 21:44:10.000000000","message":"I\u0027m not sure client makes sense here.","commit_id":"6240e94cae57ba1dcae9ccd269dac1dd162e680a"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"b3474675d1575b5a11631529c03898a40870efc2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def __init__(self, name, region, config,"},{"line_number":74,"context_line":"                 force_ipv4\u003dFalse, auth_plugin\u003dNone,"},{"line_number":75,"context_line":"                 openstack_config\u003dNone, session_constructor\u003dNone,"},{"line_number":76,"context_line":"                 client_name\u003dNone, client_version\u003dNone,"},{"line_number":77,"context_line":"                 app_name\u003dNone, app_version\u003dNone):"},{"line_number":78,"context_line":"        self.name \u003d name"},{"line_number":79,"context_line":"        self.region \u003d region"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_bc1a617a","line":76,"in_reply_to":"7ffa3b31_fc59095a","updated":"2017-04-17 21:45:49.000000000","message":"It\u0027s just passthrough - since OCC makes both Session and Adapter for its users, they don\u0027t have another way to set these if they aren\u0027t exposde.","commit_id":"6240e94cae57ba1dcae9ccd269dac1dd162e680a"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"e57adc6504d8c7110855ab568fa55f6db8814665","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            interface\u003dself.get_interface(service_key),"},{"line_number":251,"context_line":"            region_name\u003dself.region,"},{"line_number":252,"context_line":"            client_name\u003dself._client_name,"},{"line_number":253,"context_line":"            client_version\u003dself._client_version)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def _get_highest_endpoint(self, service_types, kwargs):"},{"line_number":256,"context_line":"        session \u003d self.get_session()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_1c7275e4","line":253,"updated":"2017-04-17 21:44:10.000000000","message":"I think i would skip the client_name/version bit. KSA will ignore it if not present and you already have os-c-c in the path, i don\u0027t think this gives you any additional information?","commit_id":"6240e94cae57ba1dcae9ccd269dac1dd162e680a"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"b3474675d1575b5a11631529c03898a40870efc2","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            interface\u003dself.get_interface(service_key),"},{"line_number":251,"context_line":"            region_name\u003dself.region,"},{"line_number":252,"context_line":"            client_name\u003dself._client_name,"},{"line_number":253,"context_line":"            client_version\u003dself._client_version)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def _get_highest_endpoint(self, service_types, kwargs):"},{"line_number":256,"context_line":"        session \u003d self.get_session()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_1c2035b0","line":253,"in_reply_to":"7ffa3b31_1c7275e4","updated":"2017-04-17 21:45:49.000000000","message":"Oh, that was totally all passthrough to let someone set client_name if they wanted to.","commit_id":"6240e94cae57ba1dcae9ccd269dac1dd162e680a"}],"os_client_config/tests/test_cloud_config.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"78ec6ebf80f7825dc98726207350587d807c5e2a","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @mock.patch.object(ksa_session, \u0027Session\u0027)"},{"line_number":197,"context_line":"    def test_get_session_with_timeout(self, mock_session):"},{"line_number":198,"context_line":"        fake_session \u003d mock.Mock()"},{"line_number":199,"context_line":"        fake_session.additional_user_agent \u003d []"},{"line_number":200,"context_line":"        mock_session.return_value \u003d fake_session"},{"line_number":201,"context_line":"        config_dict \u003d defaults.get_defaults()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_e7cba247","line":198,"updated":"2017-04-18 10:13:33.000000000","message":"mock? why not just let it call and then test with requests-mock?","commit_id":"64b28d42eda595a6fb4ee8b46d93cd61e612aae1"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"b77f27db79bbe1339aec3e97c4ff874ed9e0ad7d","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @mock.patch.object(ksa_session, \u0027Session\u0027)"},{"line_number":197,"context_line":"    def test_get_session_with_timeout(self, mock_session):"},{"line_number":198,"context_line":"        fake_session \u003d mock.Mock()"},{"line_number":199,"context_line":"        fake_session.additional_user_agent \u003d []"},{"line_number":200,"context_line":"        mock_session.return_value \u003d fake_session"},{"line_number":201,"context_line":"        config_dict \u003d defaults.get_defaults()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_e7504261","line":198,"in_reply_to":"7ffa3b31_e7cba247","updated":"2017-04-18 10:18:33.000000000","message":"Because that\u0027s a bigger change to the os-client-config tests. I\u0027d like to do that, but I figured it would be out of scope for this.","commit_id":"64b28d42eda595a6fb4ee8b46d93cd61e612aae1"}]}