)]}'
{"id":"openstack%2Fos-client-config~468020","triplet_id":"openstack%2Fos-client-config~master~I7789f381c99311bfd1c1e0a9869cbacbc96b17d6","project":"openstack/os-client-config","branch":"master","topic":"popstop","hashtags":[],"change_id":"I7789f381c99311bfd1c1e0a9869cbacbc96b17d6","subject":"Don\u0027t pop from os.environ","status":"MERGED","created":"2017-05-25 12:27:39.000000000","updated":"2017-05-25 22:55:30.000000000","submitted":"2017-05-25 22:55:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4e45ef936491e1c9a2780182f608100ddce821fc","_number":468020,"virtual_id_number":468020,"owner":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":2,"date":"2017-05-25 22:55:30.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-05-25 21:37:35.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2017-05-25 13:49:18.000000000","_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-05-25 21:37:35.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-05-25 12:47:55.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2017-05-25 13:16:08.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2017-05-25 13:49:18.000000000","updated_by":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"reviewer":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"state":"REVIEWER"},{"updated":"2017-05-25 21:37:35.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2017-05-25 22:55:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b2fff4d6d4fb6453a7ff6371cca5deaf76a2f128","author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"date":"2017-05-25 12:27:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d5dc31fe57908e52006c45eff6e70a793bb124e1","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2017-05-25 12:47:55.000000000","message":"Patch Set 1: Code-Review+1\n\ngood catch","accounts_in_message":[],"_revision_number":1},{"id":"1db1699df11ee4e72c177a7f87fca5a05be2170d","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2017-05-25 13:16:08.000000000","message":"Patch Set 1: Code-Review-1\n\nDefinitely a good call of which I am supportive. However- _get_os_environ also needs updating to include OS_CLIENT_CONFIG_FILE, OS_CLIENT_SECURE_FILE and OS_CLOUD_NAME in the line:\n\n  if set(environkeys) - set([\u0027OS_CLOUD\u0027, \u0027OS_REGION_NAME\u0027])\n\nMaybe we should just copy os.environ at the outset into a dict we can pop and modify as needed? But if you don\u0027t feel like going that far - just add those three values and this patch shoudl be good.","accounts_in_message":[],"_revision_number":1},{"id":"8757f0c86e28c2a85ec214dac9a800d4affa6824","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2017-05-25 13:31:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"74eb0d7ae082977edae13f4cb2453c9e43ad3ddf","author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"date":"2017-05-25 13:49:18.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"21b6af6afa6dd27c47eb6c396e973dd7f938e068","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-25 14:46:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-os-client-config-docs-ubuntu-xenial http://docs-draft.openstack.org/20/468020/2/check/gate-os-client-config-docs-ubuntu-xenial/4368972//doc/build/html/ : SUCCESS in 2m 35s\n- gate-os-client-config-pep8-ubuntu-xenial http://logs.openstack.org/20/468020/2/check/gate-os-client-config-pep8-ubuntu-xenial/5f7af1c/ : SUCCESS in 3m 23s\n- gate-os-client-config-python27-ubuntu-xenial http://logs.openstack.org/20/468020/2/check/gate-os-client-config-python27-ubuntu-xenial/8e31759/ : SUCCESS in 2m 29s\n- gate-os-client-config-python35 http://logs.openstack.org/20/468020/2/check/gate-os-client-config-python35/bbd3708/ : SUCCESS in 4m 28s\n- gate-os-client-config-pypy http://logs.openstack.org/20/468020/2/check/gate-os-client-config-pypy/1dd21bd/ : SUCCESS in 2m 18s (non-voting)\n- gate-tempest-dsvm-neutron-src-os-client-config-ubuntu-xenial http://logs.openstack.org/20/468020/2/check/gate-tempest-dsvm-neutron-src-os-client-config-ubuntu-xenial/cbfcb57/ : SUCCESS in 1h 11m 52s\n- gate-shade-dsvm-functional-legacy-libs-nv http://logs.openstack.org/20/468020/2/check/gate-shade-dsvm-functional-legacy-libs-nv/bef355c/ : SUCCESS in 24m 54s (non-voting)\n- gate-shade-dsvm-functional-libs-nv http://logs.openstack.org/20/468020/2/check/gate-shade-dsvm-functional-libs-nv/dee0107/ : SUCCESS in 39m 55s (non-voting)\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/20/468020/2/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/3a088b6/ : FAILURE in 27m 03s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"fc91534e0168d43c944386aadc5cb10495bac4d9","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-05-25 21:37:35.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"2bd67b46edeb233913903e56409dec8079e60a24","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-25 21:37:45.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"9e12590bc562fac928c996182e3964c9fad59d9f","date":"2017-05-25 22:55:30.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"ae965ae2bf63798eb762a43d536ca449f8c79251","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-25 22:55:30.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-os-client-config-docs-ubuntu-xenial http://docs-draft.openstack.org/20/468020/2/gate/gate-os-client-config-docs-ubuntu-xenial/d4a10ad//doc/build/html/ : SUCCESS in 1m 58s\n- gate-os-client-config-pep8-ubuntu-xenial http://logs.openstack.org/20/468020/2/gate/gate-os-client-config-pep8-ubuntu-xenial/6454a7c/ : SUCCESS in 2m 58s\n- gate-os-client-config-python27-ubuntu-xenial http://logs.openstack.org/20/468020/2/gate/gate-os-client-config-python27-ubuntu-xenial/c866bab/ : SUCCESS in 1m 57s\n- gate-os-client-config-python35 http://logs.openstack.org/20/468020/2/gate/gate-os-client-config-python35/ff21686/ : SUCCESS in 3m 50s\n- gate-tempest-dsvm-neutron-src-os-client-config-ubuntu-xenial http://logs.openstack.org/20/468020/2/gate/gate-tempest-dsvm-neutron-src-os-client-config-ubuntu-xenial/b66f5fe/ : SUCCESS in 1h 15m 04s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"990cfa3ce24d0a92c7578b52ae1fea02d69f7e87","revisions":{"06200307e84d1fcb845c7baba805eb25583d445e":{"kind":"REWORK","_number":1,"created":"2017-05-25 12:27:39.000000000","uploader":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"ref":"refs/changes/20/468020/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/os-client-config","ref":"refs/changes/20/468020/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/os-client-config refs/changes/20/468020/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/os-client-config refs/changes/20/468020/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/os-client-config refs/changes/20/468020/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/os-client-config refs/changes/20/468020/1"}}},"commit":{"parents":[{"commit":"4493871824839782846c3825c754895876f8d08e","subject":"Revert \"Use interface not endpoint_type for keystoneclient\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-client-config/commit/4493871824839782846c3825c754895876f8d08e"}]}],"author":{"name":"Matthew Booth","email":"mbooth@redhat.com","date":"2017-05-25 12:26:48.000000000","tz":60},"committer":{"name":"Matthew Booth","email":"mbooth@redhat.com","date":"2017-05-25 12:26:48.000000000","tz":60},"subject":"Don\u0027t pop from os.environ","message":"Don\u0027t pop from os.environ\n\nIt\u0027s rude to other users and subsequent callers.\n\nChange-Id: I7789f381c99311bfd1c1e0a9869cbacbc96b17d6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-client-config/commit/06200307e84d1fcb845c7baba805eb25583d445e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-client-config/commit/06200307e84d1fcb845c7baba805eb25583d445e"}]},"branch":"refs/heads/master"},"990cfa3ce24d0a92c7578b52ae1fea02d69f7e87":{"kind":"REWORK","_number":2,"created":"2017-05-25 13:31:54.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/20/468020/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/os-client-config","ref":"refs/changes/20/468020/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/os-client-config refs/changes/20/468020/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/os-client-config refs/changes/20/468020/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/os-client-config refs/changes/20/468020/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/os-client-config refs/changes/20/468020/2"}}},"commit":{"parents":[{"commit":"4493871824839782846c3825c754895876f8d08e","subject":"Revert \"Use interface not endpoint_type for keystoneclient\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-client-config/commit/4493871824839782846c3825c754895876f8d08e"}]}],"author":{"name":"Matthew Booth","email":"mbooth@redhat.com","date":"2017-05-25 12:26:48.000000000","tz":60},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2017-05-25 13:31:42.000000000","tz":-300},"subject":"Don\u0027t pop from os.environ","message":"Don\u0027t pop from os.environ\n\nIt\u0027s rude to other users and subsequent callers.\n\nChange-Id: I7789f381c99311bfd1c1e0a9869cbacbc96b17d6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-client-config/commit/990cfa3ce24d0a92c7578b52ae1fea02d69f7e87"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-client-config/commit/990cfa3ce24d0a92c7578b52ae1fea02d69f7e87"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}