)]}'
{"id":"openstack%2Fos-cloud-config~95395","triplet_id":"openstack%2Fos-cloud-config~master~If1022be3a5203a81f6199e9881efd1680207dd49","project":"openstack/os-cloud-config","branch":"master","topic":"check-errors","hashtags":[],"change_id":"If1022be3a5203a81f6199e9881efd1680207dd49","subject":"Check for errors while parsing JSON","status":"ABANDONED","created":"2014-05-26 01:28:15.000000000","updated":"2014-06-11 12:05:38.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"77d99ac5ed1d1241095f2dddb84376579acb4fbe","_number":95395,"virtual_id_number":95395,"owner":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"value":1,"date":"2014-06-09 04:03:03.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8041,"name":"Petr Blaho","email":"pblaho@redhat.com","username":"pblaho"},{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},{"date":"2014-05-26 10:35:25.000000000","_account_id":8907,"name":"Dmitry Shulyak","email":"dshulyak@mirantis.com","username":"dshulyak"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"recommended":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"disliked":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"all":[{"value":-1,"date":"2014-05-29 12:23:44.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},{"value":1,"date":"2014-05-27 07:09:07.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8041,"name":"Petr Blaho","email":"pblaho@redhat.com","username":"pblaho"},{"value":2,"date":"2014-05-26 08:37:57.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8907,"name":"Dmitry Shulyak","email":"dshulyak@mirantis.com","username":"dshulyak"},{"value":-1,"date":"2014-06-09 03:59:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-06-09 12:57:17.000000000","_account_id":8041,"name":"Petr Blaho","email":"pblaho@redhat.com","username":"pblaho"},{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},{"_account_id":8907,"name":"Dmitry Shulyak","email":"dshulyak@mirantis.com","username":"dshulyak"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},{"_account_id":8041,"name":"Petr Blaho","email":"pblaho@redhat.com","username":"pblaho"},{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"_account_id":8907,"name":"Dmitry Shulyak","email":"dshulyak@mirantis.com","username":"dshulyak"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-05-26 08:37:57.000000000","updated_by":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"reviewer":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"state":"REVIEWER"},{"updated":"2014-05-26 10:35:25.000000000","updated_by":{"_account_id":8907,"name":"Dmitry Shulyak","email":"dshulyak@mirantis.com","username":"dshulyak"},"reviewer":{"_account_id":8907,"name":"Dmitry Shulyak","email":"dshulyak@mirantis.com","username":"dshulyak"},"state":"REVIEWER"},{"updated":"2014-05-27 07:09:07.000000000","updated_by":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"reviewer":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"state":"REVIEWER"},{"updated":"2014-05-29 12:23:44.000000000","updated_by":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"reviewer":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"state":"REVIEWER"},{"updated":"2014-06-09 03:59:50.000000000","updated_by":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"reviewer":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"state":"REVIEWER"},{"updated":"2014-06-09 04:03:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-06-09 12:57:17.000000000","updated_by":{"_account_id":8041,"name":"Petr Blaho","email":"pblaho@redhat.com","username":"pblaho"},"reviewer":{"_account_id":8041,"name":"Petr Blaho","email":"pblaho@redhat.com","username":"pblaho"},"state":"REVIEWER"}],"messages":[{"id":"95bdabd1febc1f463cde0a3c64bfc1d5d16d2523","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-26 01:28:15.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"25833494e9628d2aba7dc13ac7c1d65d01a20a6d","author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"date":"2014-05-26 01:28:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3bf6202c16d26cd52618de143ddf4be8083527d1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-26 01:29:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-os-cloud-config-pep8 http://logs.openstack.org/95/95395/1/check/gate-os-cloud-config-pep8/bb2027d : SUCCESS in 52s\n- gate-os-cloud-config-python26 http://logs.openstack.org/95/95395/1/check/gate-os-cloud-config-python26/340119a : SUCCESS in 55s\n- gate-os-cloud-config-python27 http://logs.openstack.org/95/95395/1/check/gate-os-cloud-config-python27/8343d1b : SUCCESS in 36s","accounts_in_message":[],"_revision_number":1},{"id":"8a3c71b9e089297fd27dbbe4b15190063a70384d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-26 03:28:21.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- check-tripleo-ironic-seed-precise http://logs.openstack.org/95/95395/1/check-tripleo/check-tripleo-ironic-seed-precise/f1fb560 : SUCCESS in 53m 55s\n- check-tripleo-undercloud-precise http://logs.openstack.org/95/95395/1/check-tripleo/check-tripleo-undercloud-precise/88e3b7f : SUCCESS in 42m 09s\n- check-tripleo-overcloud-precise http://logs.openstack.org/95/95395/1/check-tripleo/check-tripleo-overcloud-precise/9fcd2e9 : SUCCESS in 1h 15m 03s\n- check-tripleo-overcloud-f20 http://logs.openstack.org/95/95395/1/check-tripleo/check-tripleo-overcloud-f20/4841c7d : SUCCESS in 1h 16m 33s","accounts_in_message":[],"_revision_number":1},{"id":"9e59b48d7db7e610ccdf27235220725bb8bbb67b","author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"date":"2014-05-26 08:37:57.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a558a15a55245b2f62bddd6c66866f2b0048d55e","author":{"_account_id":8907,"name":"Dmitry Shulyak","email":"dshulyak@mirantis.com","username":"dshulyak"},"date":"2014-05-26 10:35:25.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6e381e2610d9105219cb6dd0de9a9158ee7eb5da","author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"date":"2014-05-27 07:09:07.000000000","message":"Patch Set 1: Code-Review+1\n\n+1 with Dmitry - I wasn\u0027t at summit so don\u0027t know what was discussed but is there plan/discussion about logging for os-cloud-config? Also applies to I4c7ce45fd064335b73b52569cad83974c19219ee (which I already +2 but depends on this.review)\n\nOne could also argue that logging is beyond the scope here/separate work/existing review but just wanted it to be brought up","accounts_in_message":[],"_revision_number":1},{"id":"06de672f55f6629f9bb99265bc5047e1e45d1cac","author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"date":"2014-05-29 12:23:44.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0ecf625be41f306d15dc0ecf8dd5e64cd633dcc0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-29 12:23:45.000000000","message":"Patch Set 1: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"f63cb7fc3577747a181ea49de55be7b6563ab9b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-29 12:31:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-os-cloud-config-pep8 http://logs.openstack.org/95/95395/1/check/gate-os-cloud-config-pep8/11cd353 : SUCCESS in 2m 43s\n- gate-os-cloud-config-python26 http://logs.openstack.org/95/95395/1/check/gate-os-cloud-config-python26/2630db4 : SUCCESS in 1m 48s\n- gate-os-cloud-config-python27 http://logs.openstack.org/95/95395/1/check/gate-os-cloud-config-python27/1f2a5a2 : SUCCESS in 2m 12s","accounts_in_message":[],"_revision_number":1},{"id":"d486deb6efaf7d305e7c93bf9167696fad9c1479","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-09 03:59:50.000000000","message":"Patch Set 1: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"17f118b80ec15bbcc72453841dfdc596098e624a","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2014-06-09 03:59:50.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4ea4ea9f00f930eaac7b080b47c1df4971403b08","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-09 04:03:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-os-cloud-config-pep8 http://logs.openstack.org/95/95395/1/check/gate-os-cloud-config-pep8/2bcf6de : SUCCESS in 2m 24s\n- gate-os-cloud-config-python26 http://logs.openstack.org/95/95395/1/check/gate-os-cloud-config-python26/1709439 : SUCCESS in 3m 12s\n- gate-os-cloud-config-python27 http://logs.openstack.org/95/95395/1/check/gate-os-cloud-config-python27/42bcf8d : SUCCESS in 2m 34s","accounts_in_message":[],"_revision_number":1},{"id":"bbe2f11313e5263c6054ec963cd7ea4e705deb3a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-09 05:24:00.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- check-tripleo-ironic-seed-precise http://logs.openstack.org/95/95395/1/check-tripleo/check-tripleo-ironic-seed-precise/1810411 : SUCCESS in 1h 13m 00s\n- check-tripleo-undercloud-precise http://logs.openstack.org/95/95395/1/check-tripleo/check-tripleo-undercloud-precise/db887df : SUCCESS in 1h 09m 21s\n- check-tripleo-overcloud-f20 http://logs.openstack.org/95/95395/1/check-tripleo/check-tripleo-overcloud-f20/471fa44 : SUCCESS in 1h 24m 09s","accounts_in_message":[],"_revision_number":1},{"id":"215b959189f251fefe55a5a4c164ed68f6180933","author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"date":"2014-06-11 12:05:38.000000000","message":"Abandoned\n\nI shall replace this with a change I have yet to push to catch all exceptions.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"641dc6c64924cfb549b2b55a94079b05844df262","revisions":{"641dc6c64924cfb549b2b55a94079b05844df262":{"kind":"REWORK","_number":1,"created":"2014-05-26 01:28:15.000000000","uploader":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"ref":"refs/changes/95/95395/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/os-cloud-config","ref":"refs/changes/95/95395/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/os-cloud-config refs/changes/95/95395/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/os-cloud-config refs/changes/95/95395/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/os-cloud-config refs/changes/95/95395/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/os-cloud-config refs/changes/95/95395/1"}}},"commit":{"parents":[{"commit":"8d33086d9e87c20c54de821af2dd370ecfbdba68","subject":"Loop for 600 seconds during user creation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-cloud-config/commit/8d33086d9e87c20c54de821af2dd370ecfbdba68"}]}],"author":{"name":"Steve Kowalik","email":"steven@wedontsleep.org","date":"2014-05-26 01:21:03.000000000","tz":600},"committer":{"name":"Steve Kowalik","email":"steven@wedontsleep.org","date":"2014-05-26 01:27:02.000000000","tz":600},"subject":"Check for errors while parsing JSON","message":"Check for errors while parsing JSON\n\nCurrently, if there is an error encountered while parsing the JSON\nnodes definition in register-nodes, simplejson will throw an\nexception which is not caught, leading to a messy traceback. Catch\nthe exception.\n\nChange-Id: If1022be3a5203a81f6199e9881efd1680207dd49\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-cloud-config/commit/641dc6c64924cfb549b2b55a94079b05844df262"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-cloud-config/commit/641dc6c64924cfb549b2b55a94079b05844df262"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}