)]}'
{"os_ken/tests/unit/test_lib.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b6f20cc8d88ce6393f1a73aa83102608133bbdb4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import unittest"},{"line_number":16,"context_line":"import logging"},{"line_number":17,"context_line":"import platform"},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":"from nose.tools import eq_"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from os_ken.lib import sockaddr"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_660b8529","line":18,"updated":"2020-07-10 08:45:48.000000000","message":"not needed","commit_id":"866dc9bc6898228769b520068129b92d8e9bf20d"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"92de4f8170c094c761e3771241b19c40fe5673cc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import unittest"},{"line_number":16,"context_line":"import logging"},{"line_number":17,"context_line":"import platform"},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":"from nose.tools import eq_"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from os_ken.lib import sockaddr"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_2a9aef12","line":18,"in_reply_to":"bf51134e_660b8529","updated":"2020-07-10 11:44:02.000000000","message":"Done","commit_id":"866dc9bc6898228769b520068129b92d8e9bf20d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b6f20cc8d88ce6393f1a73aa83102608133bbdb4","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from os_ken.lib import sockaddr"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":"system \u003d platform.system()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_a6011d09","line":23,"updated":"2020-07-10 08:45:48.000000000","message":"not needed","commit_id":"866dc9bc6898228769b520068129b92d8e9bf20d"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"92de4f8170c094c761e3771241b19c40fe5673cc","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from os_ken.lib import sockaddr"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":"system \u003d platform.system()"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_8a9b3b15","line":23,"in_reply_to":"bf51134e_a6011d09","updated":"2020-07-10 11:44:02.000000000","message":"Done","commit_id":"866dc9bc6898228769b520068129b92d8e9bf20d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b6f20cc8d88ce6393f1a73aa83102608133bbdb4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        pass"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def test_sockaddr_linux_sa_in4(self):"},{"line_number":36,"context_line":"        if system !\u003d \u0027Linux\u0027:"},{"line_number":37,"context_line":"            return"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        addr \u003d \u0027127.0.0.1\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_c43b6ace","line":36,"updated":"2020-07-10 08:45:48.000000000","message":"Are those tests dependent on the platform? I though sockaddr takes this into consideration.","commit_id":"866dc9bc6898228769b520068129b92d8e9bf20d"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"92de4f8170c094c761e3771241b19c40fe5673cc","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        pass"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def test_sockaddr_linux_sa_in4(self):"},{"line_number":36,"context_line":"        if system !\u003d \u0027Linux\u0027:"},{"line_number":37,"context_line":"            return"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        addr \u003d \u0027127.0.0.1\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_2a366f04","line":36,"in_reply_to":"bf51134e_c43b6ace","updated":"2020-07-10 11:44:02.000000000","message":"It is in os-ken itself https://opendev.org/openstack/os-ken/src/branch/master/os_ken/lib/sockaddr.py#L29\nSo header will change (I thought of just mock platform.system() to \u0027Linux\u0027 too, it would also work instead of conditional)","commit_id":"866dc9bc6898228769b520068129b92d8e9bf20d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b6f20cc8d88ce6393f1a73aa83102608133bbdb4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            return"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        addr \u003d \u0027127.0.0.1\u0027"},{"line_number":40,"context_line":"        expected_result \u003d b\u0027\\x02\\x00\\x00\\x00\u0027 \\"},{"line_number":41,"context_line":"            b\u0027\\x7f\\x00\\x00\\x01\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\u0027"},{"line_number":42,"context_line":"        eq_(expected_result, sockaddr.sa_in4(addr))"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_061ba980","line":40,"range":{"start_line":40,"start_character":46,"end_line":40,"end_character":47},"updated":"2020-07-10 08:45:48.000000000","message":"nit: maybe better with parenthesis","commit_id":"866dc9bc6898228769b520068129b92d8e9bf20d"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"92de4f8170c094c761e3771241b19c40fe5673cc","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            return"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        addr \u003d \u0027127.0.0.1\u0027"},{"line_number":40,"context_line":"        expected_result \u003d b\u0027\\x02\\x00\\x00\\x00\u0027 \\"},{"line_number":41,"context_line":"            b\u0027\\x7f\\x00\\x00\\x01\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\u0027"},{"line_number":42,"context_line":"        eq_(expected_result, sockaddr.sa_in4(addr))"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_4a1ac37c","line":40,"range":{"start_line":40,"start_character":46,"end_line":40,"end_character":47},"in_reply_to":"bf51134e_061ba980","updated":"2020-07-10 11:44:02.000000000","message":"Done","commit_id":"866dc9bc6898228769b520068129b92d8e9bf20d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b6f20cc8d88ce6393f1a73aa83102608133bbdb4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            return"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        addr \u003d \u0027dead:beef::1\u0027"},{"line_number":49,"context_line":"        expected_result \u003d b\u0027\\n\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\xde\\xad\\xbe\\xef\u0027 \\"},{"line_number":50,"context_line":"            b\u0027\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x01\\x00\\x00\\x00\\x00\u0027"},{"line_number":51,"context_line":"        eq_(expected_result, sockaddr.sa_in6(addr))"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_a628fd96","line":49,"updated":"2020-07-10 08:45:48.000000000","message":"ditto","commit_id":"866dc9bc6898228769b520068129b92d8e9bf20d"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"92de4f8170c094c761e3771241b19c40fe5673cc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            return"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        addr \u003d \u0027dead:beef::1\u0027"},{"line_number":49,"context_line":"        expected_result \u003d b\u0027\\n\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\xde\\xad\\xbe\\xef\u0027 \\"},{"line_number":50,"context_line":"            b\u0027\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x01\\x00\\x00\\x00\\x00\u0027"},{"line_number":51,"context_line":"        eq_(expected_result, sockaddr.sa_in6(addr))"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_2a1f8f6c","line":49,"in_reply_to":"bf51134e_a628fd96","updated":"2020-07-10 11:44:02.000000000","message":"Done","commit_id":"866dc9bc6898228769b520068129b92d8e9bf20d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"56593ba6a6c197e945162ed98e4774c8cd06af07","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2020 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_80cfea27","line":1,"updated":"2020-09-02 19:44:19.000000000","message":"why this is os_ken/tests/unit/test_lib.py and not os_ken/tests/unit/lib/test_sockaddr.py","commit_id":"e9a851f0df6b08e16a9d8cdd06d7b7acc8d1bdb5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"246e7a9d38a72729adb5711a982818a3afd4f93b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2020 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_ae6bf8ee","line":1,"in_reply_to":"9f560f44_80cfea27","updated":"2020-09-03 07:11:43.000000000","message":"Probably just lazy me not creating the directory, fixed","commit_id":"e9a851f0df6b08e16a9d8cdd06d7b7acc8d1bdb5"}]}