)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e024770ab1e29a03655b43c802064239278b365d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Enhance os-ken to support Nicira PacketIn2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"neutron ovs agent has to handle advanced packet_in"},{"line_number":10,"context_line":"with custom userdata which is necessary to openflow-based"},{"line_number":11,"context_line":"floating IP implementation, but current os-ken doesn\u0027t"},{"line_number":12,"context_line":"have such infrastructure."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This story is to enhance os-ken in order that neutron ovs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7194dc8f_3b867edb","line":11,"range":{"start_line":10,"start_character":43,"end_line":11,"end_character":26},"updated":"2021-06-14 11:32:42.000000000","message":"Do you have an RFE or bug for this in neutron side?","commit_id":"f246ae66d5cda8889c9f4d45ed4001fd119a0b63"},{"author":{"_account_id":30454,"name":"Yi Yang","email":"yangyi01@inspur.com","username":"yangyi01"},"change_message_id":"c39d919dddbb3dae07449e02823efe5246f49797","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Enhance os-ken to support Nicira PacketIn2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"neutron ovs agent has to handle advanced packet_in"},{"line_number":10,"context_line":"with custom userdata which is necessary to openflow-based"},{"line_number":11,"context_line":"floating IP implementation, but current os-ken doesn\u0027t"},{"line_number":12,"context_line":"have such infrastructure."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This story is to enhance os-ken in order that neutron ovs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"af72ce16_5eb540c2","line":11,"range":{"start_line":10,"start_character":43,"end_line":11,"end_character":26},"in_reply_to":"7194dc8f_3b867edb","updated":"2021-06-15 00:56:59.000000000","message":"This is a big change, I\u0027ll submit a spec for this, it isn\u0027t a bug.","commit_id":"f246ae66d5cda8889c9f4d45ed4001fd119a0b63"},{"author":{"_account_id":30454,"name":"Yi Yang","email":"yangyi01@inspur.com","username":"yangyi01"},"change_message_id":"e08080bb63d6a8e6d44f81a404b0a4d2f4891e67","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Enhance os-ken to support Nicira PacketIn2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"neutron ovs agent has to handle advanced packet_in"},{"line_number":10,"context_line":"with custom userdata which is necessary to openflow-based"},{"line_number":11,"context_line":"floating IP implementation, but current os-ken doesn\u0027t"},{"line_number":12,"context_line":"have such infrastructure."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This story is to enhance os-ken in order that neutron ovs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8024225c_ace3205f","line":11,"range":{"start_line":10,"start_character":43,"end_line":11,"end_character":26},"in_reply_to":"af72ce16_5eb540c2","updated":"2021-06-15 04:07:01.000000000","message":"Add a REF for this, https://bugs.launchpad.net/neutron/+bug/1931953","commit_id":"f246ae66d5cda8889c9f4d45ed4001fd119a0b63"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ee3d6dee7c83e7f79332d188b8b6149599ea0930","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Story: #2008964"},{"line_number":19,"context_line":"Task: #42600"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Signed-off-by: Yi Yang \u003cyangyi01@inspur.com\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I4f993be5dd4a5f48396c4be152da5b61ea92392f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e7f28acf_2136849d","line":20,"updated":"2021-06-15 08:18:24.000000000","message":"Please add a reference to the RFE:\nRelated-Bug: #1931953\n and use a topic like bug/1931953 to make easier following the patch series","commit_id":"7eb8ab2cc064918a1eb8c776ecf192a190351b64"},{"author":{"_account_id":30454,"name":"Yi Yang","email":"yangyi01@inspur.com","username":"yangyi01"},"change_message_id":"b6ccb09e1afc08dfe21d80e8146527266c5ade48","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Story: #2008964"},{"line_number":19,"context_line":"Task: #42600"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Signed-off-by: Yi Yang \u003cyangyi01@inspur.com\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I4f993be5dd4a5f48396c4be152da5b61ea92392f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5b33aa41_12ff4848","line":20,"in_reply_to":"e7f28acf_2136849d","updated":"2021-06-15 09:48:25.000000000","message":"I have added topic tag bug/1931953 and add Related-Bug: #1931953 in commit, update 4 reflected these changes.","commit_id":"7eb8ab2cc064918a1eb8c776ecf192a190351b64"}],"os_ken/ofproto/nicira_ext.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73adf78191520e007697b402a141f305187c8cce","unresolved":true,"context_lines":[{"line_number":156,"context_line":"NXPINT_CONTINUATION \u003d 8"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"# enum nxt_exp_type"},{"line_number":159,"context_line":"NXT_ET_SET_PACKET_IN_FORMAT \u003d 16"},{"line_number":160,"context_line":"NXT_ET_PACKET_IN2 \u003d 30"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"# Nicira extension: set_packet_in_format"}],"source_content_type":"text/x-python","patch_set":4,"id":"7965b98a_ed14ff3b","line":159,"updated":"2021-06-15 11:36:49.000000000","message":"Duplicated in L141","commit_id":"fdc45a9175283d3e5142f1a0cbb7cf652115b3c1"},{"author":{"_account_id":30454,"name":"Yi Yang","email":"yangyi01@inspur.com","username":"yangyi01"},"change_message_id":"29ab47acaf481a6f744dd647a8a85f9821b3aefe","unresolved":true,"context_lines":[{"line_number":156,"context_line":"NXPINT_CONTINUATION \u003d 8"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"# enum nxt_exp_type"},{"line_number":159,"context_line":"NXT_ET_SET_PACKET_IN_FORMAT \u003d 16"},{"line_number":160,"context_line":"NXT_ET_PACKET_IN2 \u003d 30"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"# Nicira extension: set_packet_in_format"}],"source_content_type":"text/x-python","patch_set":4,"id":"f7e496cf_b60f5bf0","line":159,"in_reply_to":"7965b98a_ed14ff3b","updated":"2021-06-16 03:25:52.000000000","message":"Good catch, I will use the old one.","commit_id":"fdc45a9175283d3e5142f1a0cbb7cf652115b3c1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73adf78191520e007697b402a141f305187c8cce","unresolved":true,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"# enum nxt_exp_type"},{"line_number":159,"context_line":"NXT_ET_SET_PACKET_IN_FORMAT \u003d 16"},{"line_number":160,"context_line":"NXT_ET_PACKET_IN2 \u003d 30"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"# Nicira extension: set_packet_in_format"},{"line_number":163,"context_line":"NXT_SET_PACKET_IN_FORMAT_PACK_STR \u003d \u0027!I\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"97dd8b83_8f1fb096","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":17},"updated":"2021-06-15 11:36:49.000000000","message":"Shouldn\u0027t need to go to \"# Messages\" section?","commit_id":"fdc45a9175283d3e5142f1a0cbb7cf652115b3c1"},{"author":{"_account_id":30454,"name":"Yi Yang","email":"yangyi01@inspur.com","username":"yangyi01"},"change_message_id":"29ab47acaf481a6f744dd647a8a85f9821b3aefe","unresolved":true,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"# enum nxt_exp_type"},{"line_number":159,"context_line":"NXT_ET_SET_PACKET_IN_FORMAT \u003d 16"},{"line_number":160,"context_line":"NXT_ET_PACKET_IN2 \u003d 30"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"# Nicira extension: set_packet_in_format"},{"line_number":163,"context_line":"NXT_SET_PACKET_IN_FORMAT_PACK_STR \u003d \u0027!I\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"f3edfe2c_b6d5576b","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":17},"in_reply_to":"97dd8b83_8f1fb096","updated":"2021-06-16 03:25:52.000000000","message":"Yes, it should be in \"# Messages\" section, I will move it there.","commit_id":"fdc45a9175283d3e5142f1a0cbb7cf652115b3c1"}],"os_ken/ofproto/ofproto_v1_3.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e024770ab1e29a03655b43c802064239278b365d","unresolved":true,"context_lines":[{"line_number":753,"context_line":"        OFP_PACKET_IN_SIZE)"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"# nx_packet_in2_prop_type"},{"line_number":756,"context_line":"NXPINT_PACKET \u003d 0"},{"line_number":757,"context_line":"NXPINT_FULL_LEN \u003d 1"},{"line_number":758,"context_line":"NXPINT_BUFFER_ID \u003d 2"},{"line_number":759,"context_line":"NXPINT_TABLE_ID \u003d 3"},{"line_number":760,"context_line":"NXPINT_COOKIE \u003d 4"},{"line_number":761,"context_line":"NXPINT_REASON \u003d 5"},{"line_number":762,"context_line":"NXPINT_METADATA \u003d 6"},{"line_number":763,"context_line":"NXPINT_USERDATA \u003d 7"},{"line_number":764,"context_line":"NXPINT_CONTINUATION \u003d 8"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"# enum nxt_exp_type"},{"line_number":767,"context_line":"NXT_ET_SET_PACKET_IN_FORMAT \u003d 16"},{"line_number":768,"context_line":"NXT_ET_PACKET_IN2 \u003d 30"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"#Nicira extension: set_packet_in_format"},{"line_number":771,"context_line":"NXT_SET_PACKET_IN_FORMAT_PACK_STR \u003d \u0027!I\u0027"},{"line_number":772,"context_line":"NXT_SET_PACKET_IN_FORMAT_SIZE \u003d 4"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"# enum ofp_packet_in_reason"},{"line_number":775,"context_line":"OFPR_NO_MATCH \u003d 0       # No matching flow."}],"source_content_type":"text/x-python","patch_set":1,"id":"32df3932_376f99a2","line":772,"range":{"start_line":756,"start_character":0,"end_line":772,"end_character":33},"updated":"2021-06-14 11:32:42.000000000","message":"If I understand well these should go to Nicira extension:\nhttps://opendev.org/openstack/os-ken/src/branch/master/os_ken/ofproto/nicira_ext.py","commit_id":"f246ae66d5cda8889c9f4d45ed4001fd119a0b63"},{"author":{"_account_id":30454,"name":"Yi Yang","email":"yangyi01@inspur.com","username":"yangyi01"},"change_message_id":"c39d919dddbb3dae07449e02823efe5246f49797","unresolved":true,"context_lines":[{"line_number":753,"context_line":"        OFP_PACKET_IN_SIZE)"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"# nx_packet_in2_prop_type"},{"line_number":756,"context_line":"NXPINT_PACKET \u003d 0"},{"line_number":757,"context_line":"NXPINT_FULL_LEN \u003d 1"},{"line_number":758,"context_line":"NXPINT_BUFFER_ID \u003d 2"},{"line_number":759,"context_line":"NXPINT_TABLE_ID \u003d 3"},{"line_number":760,"context_line":"NXPINT_COOKIE \u003d 4"},{"line_number":761,"context_line":"NXPINT_REASON \u003d 5"},{"line_number":762,"context_line":"NXPINT_METADATA \u003d 6"},{"line_number":763,"context_line":"NXPINT_USERDATA \u003d 7"},{"line_number":764,"context_line":"NXPINT_CONTINUATION \u003d 8"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"# enum nxt_exp_type"},{"line_number":767,"context_line":"NXT_ET_SET_PACKET_IN_FORMAT \u003d 16"},{"line_number":768,"context_line":"NXT_ET_PACKET_IN2 \u003d 30"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"#Nicira extension: set_packet_in_format"},{"line_number":771,"context_line":"NXT_SET_PACKET_IN_FORMAT_PACK_STR \u003d \u0027!I\u0027"},{"line_number":772,"context_line":"NXT_SET_PACKET_IN_FORMAT_SIZE \u003d 4"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"# enum ofp_packet_in_reason"},{"line_number":775,"context_line":"OFPR_NO_MATCH \u003d 0       # No matching flow."}],"source_content_type":"text/x-python","patch_set":1,"id":"d6f95e78_66041556","line":772,"range":{"start_line":756,"start_character":0,"end_line":772,"end_character":33},"in_reply_to":"32df3932_376f99a2","updated":"2021-06-15 00:56:59.000000000","message":"Yeah, you\u0027re right, they should be in https://opendev.org/openstack/os-ken/src/branch/master/os_ken/ofproto/nicira_ext.py","commit_id":"f246ae66d5cda8889c9f4d45ed4001fd119a0b63"}],"os_ken/ofproto/ofproto_v1_3_parser.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73adf78191520e007697b402a141f305187c8cce","unresolved":true,"context_lines":[{"line_number":6497,"context_line":"                    nicira_ext.NXT_ET_SET_PACKET_IN_FORMAT)"},{"line_number":6498,"context_line":"class NXTSetPacketInFormatMsg(OFPExperimenter):"},{"line_number":6499,"context_line":"    def __init__(self, datapath, packet_in_format,"},{"line_number":6500,"context_line":"                 properties\u003d[]):"},{"line_number":6501,"context_line":"        super(NXTSetPacketInFormatMsg, self).__init__("},{"line_number":6502,"context_line":"            datapath, ofproto_common.NX_EXPERIMENTER_ID,"},{"line_number":6503,"context_line":"            nicira_ext.NXT_ET_SET_PACKET_IN_FORMAT)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ad1f84c0_a42a23c9","line":6500,"range":{"start_line":6500,"start_character":28,"end_line":6500,"end_character":30},"updated":"2021-06-15 11:36:49.000000000","message":"A default kwarg value should not be a mutable object.\n\n  def __init__(self, datapath, packet_in_format, properties\u003dNone):\n    self.properties \u003d properties or []","commit_id":"fdc45a9175283d3e5142f1a0cbb7cf652115b3c1"},{"author":{"_account_id":30454,"name":"Yi Yang","email":"yangyi01@inspur.com","username":"yangyi01"},"change_message_id":"29ab47acaf481a6f744dd647a8a85f9821b3aefe","unresolved":true,"context_lines":[{"line_number":6497,"context_line":"                    nicira_ext.NXT_ET_SET_PACKET_IN_FORMAT)"},{"line_number":6498,"context_line":"class NXTSetPacketInFormatMsg(OFPExperimenter):"},{"line_number":6499,"context_line":"    def __init__(self, datapath, packet_in_format,"},{"line_number":6500,"context_line":"                 properties\u003d[]):"},{"line_number":6501,"context_line":"        super(NXTSetPacketInFormatMsg, self).__init__("},{"line_number":6502,"context_line":"            datapath, ofproto_common.NX_EXPERIMENTER_ID,"},{"line_number":6503,"context_line":"            nicira_ext.NXT_ET_SET_PACKET_IN_FORMAT)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2c296ab8_e3852d38","line":6500,"range":{"start_line":6500,"start_character":28,"end_line":6500,"end_character":30},"in_reply_to":"ad1f84c0_a42a23c9","updated":"2021-06-16 03:25:52.000000000","message":"Ok, changed it as you showed.","commit_id":"fdc45a9175283d3e5142f1a0cbb7cf652115b3c1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73adf78191520e007697b402a141f305187c8cce","unresolved":true,"context_lines":[{"line_number":6525,"context_line":"        msg.properties \u003d []"},{"line_number":6526,"context_line":"        rest \u003d super_msg.data[nicira_ext.NXT_SET_PACKET_IN_FORMAT_SIZE:]"},{"line_number":6527,"context_line":"        while rest:"},{"line_number":6528,"context_line":"            p, rest \u003d NXTSetPacketInFormatProp.parse(rest)"},{"line_number":6529,"context_line":"            msg.properties.append(p)"},{"line_number":6530,"context_line":""},{"line_number":6531,"context_line":"        return msg"}],"source_content_type":"text/x-python","patch_set":4,"id":"663af262_2d61eab3","line":6528,"range":{"start_line":6528,"start_character":22,"end_line":6528,"end_character":46},"updated":"2021-06-15 11:36:49.000000000","message":"Where is this class defined? Shouldn\u0027t be NXTPacketIn2Prop?","commit_id":"fdc45a9175283d3e5142f1a0cbb7cf652115b3c1"},{"author":{"_account_id":30454,"name":"Yi Yang","email":"yangyi01@inspur.com","username":"yangyi01"},"change_message_id":"29ab47acaf481a6f744dd647a8a85f9821b3aefe","unresolved":true,"context_lines":[{"line_number":6525,"context_line":"        msg.properties \u003d []"},{"line_number":6526,"context_line":"        rest \u003d super_msg.data[nicira_ext.NXT_SET_PACKET_IN_FORMAT_SIZE:]"},{"line_number":6527,"context_line":"        while rest:"},{"line_number":6528,"context_line":"            p, rest \u003d NXTSetPacketInFormatProp.parse(rest)"},{"line_number":6529,"context_line":"            msg.properties.append(p)"},{"line_number":6530,"context_line":""},{"line_number":6531,"context_line":"        return msg"}],"source_content_type":"text/x-python","patch_set":4,"id":"e25c4116_a9187234","line":6528,"range":{"start_line":6528,"start_character":22,"end_line":6528,"end_character":46},"in_reply_to":"663af262_2d61eab3","updated":"2021-06-16 03:25:52.000000000","message":"Actually, it shouldn\u0027t have any property there, so it can\u0027t reach here at runtime. I\u0027ll remove it.","commit_id":"fdc45a9175283d3e5142f1a0cbb7cf652115b3c1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73adf78191520e007697b402a141f305187c8cce","unresolved":true,"context_lines":[{"line_number":6534,"context_line":"@_register_exp_type(ofproto_common.NX_EXPERIMENTER_ID,"},{"line_number":6535,"context_line":"                    nicira_ext.NXT_ET_PACKET_IN2)"},{"line_number":6536,"context_line":"class NXTPacketIn2(OFPExperimenter):"},{"line_number":6537,"context_line":"    def __init__(self, datapath, properties\u003d[]):"},{"line_number":6538,"context_line":"        super(NXTPacketIn2, self).__init__("},{"line_number":6539,"context_line":"            datapath, ofproto_common.NX_EXPERIMENTER_ID,"},{"line_number":6540,"context_line":"            nicira_ext.NXT_ET_PACKET_IN2)"}],"source_content_type":"text/x-python","patch_set":4,"id":"6cdc82aa_dc97b8da","line":6537,"range":{"start_line":6537,"start_character":43,"end_line":6537,"end_character":46},"updated":"2021-06-15 11:36:49.000000000","message":"ditto","commit_id":"fdc45a9175283d3e5142f1a0cbb7cf652115b3c1"},{"author":{"_account_id":30454,"name":"Yi Yang","email":"yangyi01@inspur.com","username":"yangyi01"},"change_message_id":"29ab47acaf481a6f744dd647a8a85f9821b3aefe","unresolved":true,"context_lines":[{"line_number":6534,"context_line":"@_register_exp_type(ofproto_common.NX_EXPERIMENTER_ID,"},{"line_number":6535,"context_line":"                    nicira_ext.NXT_ET_PACKET_IN2)"},{"line_number":6536,"context_line":"class NXTPacketIn2(OFPExperimenter):"},{"line_number":6537,"context_line":"    def __init__(self, datapath, properties\u003d[]):"},{"line_number":6538,"context_line":"        super(NXTPacketIn2, self).__init__("},{"line_number":6539,"context_line":"            datapath, ofproto_common.NX_EXPERIMENTER_ID,"},{"line_number":6540,"context_line":"            nicira_ext.NXT_ET_PACKET_IN2)"}],"source_content_type":"text/x-python","patch_set":4,"id":"25b4316d_93c801ef","line":6537,"range":{"start_line":6537,"start_character":43,"end_line":6537,"end_character":46},"in_reply_to":"6cdc82aa_dc97b8da","updated":"2021-06-16 03:25:52.000000000","message":"fixed in next update.","commit_id":"fdc45a9175283d3e5142f1a0cbb7cf652115b3c1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73adf78191520e007697b402a141f305187c8cce","unresolved":true,"context_lines":[{"line_number":6615,"context_line":""},{"line_number":6616,"context_line":"@NXTPacketIn2Prop.register_type(nicira_ext.NXPINT_PACKET)"},{"line_number":6617,"context_line":"class NXTPacketIn2PropPacket(NXTPacketIn2Prop):"},{"line_number":6618,"context_line":"    def __init__(self, type_\u003dNone, length\u003dNone, data\u003dNone):"},{"line_number":6619,"context_line":"        self.type \u003d type_"},{"line_number":6620,"context_line":"        self.length \u003d length"},{"line_number":6621,"context_line":"        self.data \u003d data"},{"line_number":6622,"context_line":""},{"line_number":6623,"context_line":"    @classmethod"},{"line_number":6624,"context_line":"    def parser(cls, buf, type, length):"},{"line_number":6625,"context_line":"        p \u003d cls(type, length - 4, buf[4:length])"},{"line_number":6626,"context_line":"        return p"},{"line_number":6627,"context_line":""},{"line_number":6628,"context_line":""},{"line_number":6629,"context_line":"@NXTPacketIn2Prop.register_type(nicira_ext.NXPINT_FULL_LEN)"}],"source_content_type":"text/x-python","patch_set":4,"id":"120c00c0_bd4c86e8","line":6626,"range":{"start_line":6618,"start_character":0,"end_line":6626,"end_character":16},"updated":"2021-06-15 11:36:49.000000000","message":"All __init__  and parser methods inherited from NXTPacketIn2Prop are the same. Why don\u0027t you implement them in the parent class?","commit_id":"fdc45a9175283d3e5142f1a0cbb7cf652115b3c1"},{"author":{"_account_id":30454,"name":"Yi Yang","email":"yangyi01@inspur.com","username":"yangyi01"},"change_message_id":"29ab47acaf481a6f744dd647a8a85f9821b3aefe","unresolved":true,"context_lines":[{"line_number":6615,"context_line":""},{"line_number":6616,"context_line":"@NXTPacketIn2Prop.register_type(nicira_ext.NXPINT_PACKET)"},{"line_number":6617,"context_line":"class NXTPacketIn2PropPacket(NXTPacketIn2Prop):"},{"line_number":6618,"context_line":"    def __init__(self, type_\u003dNone, length\u003dNone, data\u003dNone):"},{"line_number":6619,"context_line":"        self.type \u003d type_"},{"line_number":6620,"context_line":"        self.length \u003d length"},{"line_number":6621,"context_line":"        self.data \u003d data"},{"line_number":6622,"context_line":""},{"line_number":6623,"context_line":"    @classmethod"},{"line_number":6624,"context_line":"    def parser(cls, buf, type, length):"},{"line_number":6625,"context_line":"        p \u003d cls(type, length - 4, buf[4:length])"},{"line_number":6626,"context_line":"        return p"},{"line_number":6627,"context_line":""},{"line_number":6628,"context_line":""},{"line_number":6629,"context_line":"@NXTPacketIn2Prop.register_type(nicira_ext.NXPINT_FULL_LEN)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7d0914aa_31d9c11e","line":6626,"range":{"start_line":6618,"start_character":0,"end_line":6626,"end_character":16},"in_reply_to":"120c00c0_bd4c86e8","updated":"2021-06-16 03:25:52.000000000","message":"Good idea, I don\u0027t know how to define a new class if I don\u0027t define new method or override a method, it seems there is a tricky way to handle this, new update will use it.","commit_id":"fdc45a9175283d3e5142f1a0cbb7cf652115b3c1"}]}