)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"7f75fe934cc8ce8e9cd890633624fd4957304adb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48eb8ba2_9d73662f","updated":"2021-10-22 09:59:07.000000000","message":"I would be for eventlet minimum version bump as Rodolfo mentioned","commit_id":"afd8f80f10a5d93af0eb888ef5f2d99c4884ecb0"}],"os_ken/controller/controller.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b66c9893e5ad5c1f619529a913f85c935fe63802","unresolved":true,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def server_loop(self, ofp_tcp_listen_port, ofp_ssl_listen_port):"},{"line_number":168,"context_line":"        if CONF.ctl_privkey is not None and CONF.ctl_cert is not None:"},{"line_number":169,"context_line":"            if not hasattr(ssl, \u0027SSLContext\u0027):"},{"line_number":170,"context_line":"                # anything less than python 2.7.9 supports only TLSv1"},{"line_number":171,"context_line":"                # or less, thus we choose TLSv1"},{"line_number":172,"context_line":"                ssl_args \u003d {\u0027ssl_version\u0027: ssl.PROTOCOL_TLSv1}"}],"source_content_type":"text/x-python","patch_set":1,"id":"979fb6ab_12087e3a","line":169,"range":{"start_line":169,"start_character":12,"end_line":169,"end_character":46},"updated":"2021-10-14 07:55:26.000000000","message":"This is for py27 compatibility, we should remove it","commit_id":"afd8f80f10a5d93af0eb888ef5f2d99c4884ecb0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b66c9893e5ad5c1f619529a913f85c935fe63802","unresolved":true,"context_lines":[{"line_number":170,"context_line":"                # anything less than python 2.7.9 supports only TLSv1"},{"line_number":171,"context_line":"                # or less, thus we choose TLSv1"},{"line_number":172,"context_line":"                ssl_args \u003d {\u0027ssl_version\u0027: ssl.PROTOCOL_TLSv1}"},{"line_number":173,"context_line":"            elif sys.version_info \u003e\u003d (3, 7,):"},{"line_number":174,"context_line":"                # On Python3.7+ we can\u0027t wrap an SSLContext due to this bug:"},{"line_number":175,"context_line":"                # https://github.com/eventlet/eventlet/issues/526"},{"line_number":176,"context_line":"                # Lets assume the system has a new enough OpenSSL that"}],"source_content_type":"text/x-python","patch_set":1,"id":"7bb43055_c68dccb7","line":173,"range":{"start_line":173,"start_character":12,"end_line":173,"end_character":45},"updated":"2021-10-14 07:55:26.000000000","message":"This is already solved: https://github.com/eventlet/eventlet/commit/1a41774f26f79b9e9ba03239c80796d35f9a0630\n\nBug [1] is closed. eventlet version with this patch is [2] 0.26.1 and we are using eventlet 0.32.0 (upper-contraints.txt).\n\nActually what we should do is to bump min version of eventlet in this project.\n\n\n[1]https://github.com/eventlet/eventlet/issues/526\n[2]https://github.com/openstack/requirements/commit/09aa8072807a6faae77dea81209ce8c848fefe7c","commit_id":"afd8f80f10a5d93af0eb888ef5f2d99c4884ecb0"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"7f75fe934cc8ce8e9cd890633624fd4957304adb","unresolved":true,"context_lines":[{"line_number":170,"context_line":"                # anything less than python 2.7.9 supports only TLSv1"},{"line_number":171,"context_line":"                # or less, thus we choose TLSv1"},{"line_number":172,"context_line":"                ssl_args \u003d {\u0027ssl_version\u0027: ssl.PROTOCOL_TLSv1}"},{"line_number":173,"context_line":"            elif sys.version_info \u003e\u003d (3, 7,):"},{"line_number":174,"context_line":"                # On Python3.7+ we can\u0027t wrap an SSLContext due to this bug:"},{"line_number":175,"context_line":"                # https://github.com/eventlet/eventlet/issues/526"},{"line_number":176,"context_line":"                # Lets assume the system has a new enough OpenSSL that"}],"source_content_type":"text/x-python","patch_set":1,"id":"571279bd_1d6c63b6","line":173,"range":{"start_line":173,"start_character":12,"end_line":173,"end_character":45},"in_reply_to":"7bb43055_c68dccb7","updated":"2021-10-22 09:59:07.000000000","message":"I like that alternate fix, we do not see it in most situations as upper-constraints has a much newer version, so only requiring a new enough eventlet sounds good\nAnd neutron already requires eventlet\u003d\u003d0.25.1 as minimal bound, so 0.26.1 in os-ken is not a large bump","commit_id":"afd8f80f10a5d93af0eb888ef5f2d99c4884ecb0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b66c9893e5ad5c1f619529a913f85c935fe63802","unresolved":true,"context_lines":[{"line_number":176,"context_line":"                # Lets assume the system has a new enough OpenSSL that"},{"line_number":177,"context_line":"                # SSL is fully disabled."},{"line_number":178,"context_line":"                ssl_args \u003d {\u0027ssl_version\u0027: ssl.PROTOCOL_TLSv1}"},{"line_number":179,"context_line":"            else:"},{"line_number":180,"context_line":"                # from 2.7.9 and versions 3.4+ ssl context creation is"},{"line_number":181,"context_line":"                # supported. Protocol_TLS from 2.7.13 and from 3.5.3"},{"line_number":182,"context_line":"                # replaced SSLv23. Functionality is similar."}],"source_content_type":"text/x-python","patch_set":1,"id":"4c6efb9a_b851aad9","line":179,"range":{"start_line":179,"start_character":12,"end_line":179,"end_character":17},"updated":"2021-10-14 07:55:26.000000000","message":"This is for py27 to py35. Because we don\u0027t support those versions anymore (according to this prohect setup.cfg), we could delete this.","commit_id":"afd8f80f10a5d93af0eb888ef5f2d99c4884ecb0"}]}