)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"3e336d83af72cd21ffee956d503e909fca508698","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"29adcfba_e4bb960f","updated":"2022-01-24 13:33:51.000000000","message":"well, the patch is already merged, but let me have a \u0027nit\u0027 comment for it, see in tox.ini.","commit_id":"99361db159f47e7cafcd52612d0f678891f84a8d"}],"tox.ini":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"3e336d83af72cd21ffee956d503e909fca508698","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[testenv:docs]"},{"line_number":42,"context_line":"deps \u003d"},{"line_number":43,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/wallaby}"},{"line_number":44,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":45,"context_line":"commands \u003d sphinx-build -W -b html doc/source doc/build/html"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"74ac6a7e_81d5679a","line":43,"updated":"2022-01-24 13:33:51.000000000","message":"i\u0027d rather add here an extra line:\n\n-r{toxinidir}/requirements.txt\n\ninstead of adding eventlet in doc/requirements.txt. Since what happens here is that due to \u0027usedevelop\u003dTrue\u0027 the \u0027develop-inst\u0027 tox phase installs os-ken, but it does it without any constraints. However, if os-ken\u0027s requirements are added to deps, then they are all installed in \u0027installdeps\u0027 phase with the above constraints, and during \u0027develop-inst\u0027 they won\u0027t be reinstalled. This would be more future-proof. With the current solution, whenever a new incompatible package is released we need to add its restriction to doc/requirements.txt.","commit_id":"99361db159f47e7cafcd52612d0f678891f84a8d"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"ea40b3a0334ee8e3e64e622edbaeb5aa09ea1266","unresolved":true,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[testenv:docs]"},{"line_number":42,"context_line":"deps \u003d"},{"line_number":43,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/wallaby}"},{"line_number":44,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":45,"context_line":"commands \u003d sphinx-build -W -b html doc/source doc/build/html"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"89394d6e_ee1fe3cb","line":43,"in_reply_to":"74ac6a7e_81d5679a","updated":"2022-01-26 14:53:24.000000000","message":"Thanks for the explanation Elod! This would work well indeed for os-ken or similar projetcs where requirements.txt list is short","commit_id":"99361db159f47e7cafcd52612d0f678891f84a8d"}]}