)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"33614cb9a294a046c5a1050276084160e9a3074b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b0d7eb74_cc6ae98f","updated":"2022-07-22 12:12:46.000000000","message":"\\o/\nSmall questions and notes, thanks for taking care of this","commit_id":"6c3b164c24841591d960e302179b1df236de72e9"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"7557c0a4331fdc22c510a8c0d754e716ffaa07e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cac37a63_ee855edd","updated":"2022-07-26 15:46:18.000000000","message":"Trusting your sed skills! Look good in those I checked and CI is happy","commit_id":"2495ebdff927a3de2f642b3346ed4f438b2c6316"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6a3e763aaa6a8733dd1772f27af3a5c29adf6c7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b1c9b5cb_7805ed30","updated":"2022-07-26 15:38:33.000000000","message":"thanks","commit_id":"2495ebdff927a3de2f642b3346ed4f438b2c6316"}],"os_ken/tests/integrated/bgp/test_basic.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"33614cb9a294a046c5a1050276084160e9a3074b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"206127f3_bac3ebf9","updated":"2022-07-22 12:12:46.000000000","message":"can\u0027t this module be deleted ?","commit_id":"6c3b164c24841591d960e302179b1df236de72e9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e4ed35dc087a575e657dee2b9f01816f9c58ebb0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5000b120_cd67f905","in_reply_to":"206127f3_bac3ebf9","updated":"2022-07-22 14:27:09.000000000","message":"Ups, what I need to add here is a note. We need to fix those UTs that require docker to be configured an running. This issue is affecting all \"BgpSpeakerTestBase\" derived tests (4 out of 121.000).\n\nI\u0027ll make a comment and add a note in the commit message.","commit_id":"6c3b164c24841591d960e302179b1df236de72e9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"76ee288b24efb9663496fa6fbff8ba4d0c09491e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d9e67290_c0e1d32a","in_reply_to":"5000b120_cd67f905","updated":"2022-07-26 10:07:57.000000000","message":"Done","commit_id":"6c3b164c24841591d960e302179b1df236de72e9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"61081c093ec2ff69a0579258748ec16fd5fc00fb","unresolved":true,"context_lines":[{"line_number":25,"context_line":"#                 them, now we need to disable them."},{"line_number":26,"context_line":"# class BgpSpeakerBasicTest(base.BgpSpeakerTestBase):"},{"line_number":27,"context_line":"#     def setUp(self):"},{"line_number":28,"context_line":"#         super(BgpSpeakerBasicTest, self).setUp()"},{"line_number":29,"context_line":"#         self.r1.stop_os_kenbgp(retry\u003dTrue)"},{"line_number":30,"context_line":"#         self.r1.start_os_kenbgp(retry\u003dTrue)"},{"line_number":31,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"12bf4571_0cc52778","line":28,"updated":"2022-07-25 08:31:02.000000000","message":"Why You simply not add \"skip\" for this setUp method?","commit_id":"6b7b70ff5d60ac59619f4731ec134f700d5fda31"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0e6e455580f7a33804cfedcc935f4b05e24a4def","unresolved":true,"context_lines":[{"line_number":25,"context_line":"#                 them, now we need to disable them."},{"line_number":26,"context_line":"# class BgpSpeakerBasicTest(base.BgpSpeakerTestBase):"},{"line_number":27,"context_line":"#     def setUp(self):"},{"line_number":28,"context_line":"#         super(BgpSpeakerBasicTest, self).setUp()"},{"line_number":29,"context_line":"#         self.r1.stop_os_kenbgp(retry\u003dTrue)"},{"line_number":30,"context_line":"#         self.r1.start_os_kenbgp(retry\u003dTrue)"},{"line_number":31,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"85ca8424_59664aef","line":28,"in_reply_to":"12bf4571_0cc52778","updated":"2022-07-25 14:04:00.000000000","message":"Because it is failing in the setUp method. That is executed before the skip() call in the test method.\n\nWhat I can do, if possible, is to add the skip method in the setUp call. It is not the expected way by I can justify it.","commit_id":"6b7b70ff5d60ac59619f4731ec134f700d5fda31"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"76ee288b24efb9663496fa6fbff8ba4d0c09491e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#                 them, now we need to disable them."},{"line_number":26,"context_line":"# class BgpSpeakerBasicTest(base.BgpSpeakerTestBase):"},{"line_number":27,"context_line":"#     def setUp(self):"},{"line_number":28,"context_line":"#         super(BgpSpeakerBasicTest, self).setUp()"},{"line_number":29,"context_line":"#         self.r1.stop_os_kenbgp(retry\u003dTrue)"},{"line_number":30,"context_line":"#         self.r1.start_os_kenbgp(retry\u003dTrue)"},{"line_number":31,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"f458c2b5_2cd8f120","line":28,"in_reply_to":"85ca8424_59664aef","updated":"2022-07-26 10:07:57.000000000","message":"Done","commit_id":"6b7b70ff5d60ac59619f4731ec134f700d5fda31"}],"os_ken/tests/integrated/bgp/test_ip6_basic.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"61081c093ec2ff69a0579258748ec16fd5fc00fb","unresolved":true,"context_lines":[{"line_number":25,"context_line":"#                 them, now we need to disable them."},{"line_number":26,"context_line":"# class BgpSpeakerBasicTest(base.BgpSpeakerTestBase):"},{"line_number":27,"context_line":"#     def setUp(self):"},{"line_number":28,"context_line":"#         super(BgpSpeakerBasicTest, self).setUp()"},{"line_number":29,"context_line":"#         self.r1.stop_os_kenbgp(retry\u003dTrue)"},{"line_number":30,"context_line":"#         self.r1.start_os_kenbgp(retry\u003dTrue)"},{"line_number":31,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"b2f69788_b562dc49","line":28,"updated":"2022-07-25 08:31:02.000000000","message":"same here","commit_id":"6b7b70ff5d60ac59619f4731ec134f700d5fda31"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0e6e455580f7a33804cfedcc935f4b05e24a4def","unresolved":true,"context_lines":[{"line_number":25,"context_line":"#                 them, now we need to disable them."},{"line_number":26,"context_line":"# class BgpSpeakerBasicTest(base.BgpSpeakerTestBase):"},{"line_number":27,"context_line":"#     def setUp(self):"},{"line_number":28,"context_line":"#         super(BgpSpeakerBasicTest, self).setUp()"},{"line_number":29,"context_line":"#         self.r1.stop_os_kenbgp(retry\u003dTrue)"},{"line_number":30,"context_line":"#         self.r1.start_os_kenbgp(retry\u003dTrue)"},{"line_number":31,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"d663315d_00ec1d88","line":28,"in_reply_to":"b2f69788_b562dc49","updated":"2022-07-25 14:04:00.000000000","message":"ditto","commit_id":"6b7b70ff5d60ac59619f4731ec134f700d5fda31"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"76ee288b24efb9663496fa6fbff8ba4d0c09491e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#                 them, now we need to disable them."},{"line_number":26,"context_line":"# class BgpSpeakerBasicTest(base.BgpSpeakerTestBase):"},{"line_number":27,"context_line":"#     def setUp(self):"},{"line_number":28,"context_line":"#         super(BgpSpeakerBasicTest, self).setUp()"},{"line_number":29,"context_line":"#         self.r1.stop_os_kenbgp(retry\u003dTrue)"},{"line_number":30,"context_line":"#         self.r1.start_os_kenbgp(retry\u003dTrue)"},{"line_number":31,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"f61160a0_1bb75fcc","line":28,"in_reply_to":"d663315d_00ec1d88","updated":"2022-07-26 10:07:57.000000000","message":"Done","commit_id":"6b7b70ff5d60ac59619f4731ec134f700d5fda31"}],"os_ken/tests/integrated/run_tests_with_ovs12.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"33614cb9a294a046c5a1050276084160e9a3074b","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        self._run_os_ken_manager_and_check_output(app)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_of_config(self):"},{"line_number":78,"context_line":"        self.skipTest(\u0027OVS 1.10 does not support of_config\u0027)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _run_os_ken_manager_and_check_output(self, app):"},{"line_number":81,"context_line":"        cmd \u003d [PYTHON_BIN, OSKEN_MGR, app]"}],"source_content_type":"text/x-python","patch_set":6,"id":"9418ea07_b9acfcc2","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":60},"updated":"2022-07-22 12:12:46.000000000","message":"+1","commit_id":"6c3b164c24841591d960e302179b1df236de72e9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0e6e455580f7a33804cfedcc935f4b05e24a4def","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self._run_os_ken_manager_and_check_output(app)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_of_config(self):"},{"line_number":78,"context_line":"        self.skipTest(\u0027OVS 1.10 does not support of_config\u0027)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _run_os_ken_manager_and_check_output(self, app):"},{"line_number":81,"context_line":"        cmd \u003d [PYTHON_BIN, OSKEN_MGR, app]"}],"source_content_type":"text/x-python","patch_set":6,"id":"747656e2_209e773d","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":60},"in_reply_to":"9418ea07_b9acfcc2","updated":"2022-07-25 14:04:00.000000000","message":"Done","commit_id":"6c3b164c24841591d960e302179b1df236de72e9"}],"os_ken/tests/unit/controller/test_controller.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"33614cb9a294a046c5a1050276084160e9a3074b","unresolved":true,"context_lines":[{"line_number":191,"context_line":"        c \u003d controller.OpenFlowController()"},{"line_number":192,"context_line":"        c()"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    # Skip"},{"line_number":195,"context_line":"    # def test_ssl(self):"},{"line_number":196,"context_line":"    #     \"\"\"Tests SSL server functionality.\"\"\""},{"line_number":197,"context_line":"    #     # TODO: TLS version enforcement is necessary to avoid"}],"source_content_type":"text/x-python","patch_set":6,"id":"2b149621_9f89122d","line":194,"updated":"2022-07-22 12:12:46.000000000","message":"can\u0027t we delete this test?","commit_id":"6c3b164c24841591d960e302179b1df236de72e9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e4ed35dc087a575e657dee2b9f01816f9c58ebb0","unresolved":true,"context_lines":[{"line_number":191,"context_line":"        c \u003d controller.OpenFlowController()"},{"line_number":192,"context_line":"        c()"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    # Skip"},{"line_number":195,"context_line":"    # def test_ssl(self):"},{"line_number":196,"context_line":"    #     \"\"\"Tests SSL server functionality.\"\"\""},{"line_number":197,"context_line":"    #     # TODO: TLS version enforcement is necessary to avoid"}],"source_content_type":"text/x-python","patch_set":6,"id":"52b17231_aff696bd","line":194,"in_reply_to":"2b149621_9f89122d","updated":"2022-07-22 14:27:09.000000000","message":"Yes. This test should be in functional or integration tests. I\u0027ll remove those tests.","commit_id":"6c3b164c24841591d960e302179b1df236de72e9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0e6e455580f7a33804cfedcc935f4b05e24a4def","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        c \u003d controller.OpenFlowController()"},{"line_number":192,"context_line":"        c()"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    # Skip"},{"line_number":195,"context_line":"    # def test_ssl(self):"},{"line_number":196,"context_line":"    #     \"\"\"Tests SSL server functionality.\"\"\""},{"line_number":197,"context_line":"    #     # TODO: TLS version enforcement is necessary to avoid"}],"source_content_type":"text/x-python","patch_set":6,"id":"af6c0fc9_bc7ffc99","line":194,"in_reply_to":"52b17231_aff696bd","updated":"2022-07-25 14:04:00.000000000","message":"Done","commit_id":"6c3b164c24841591d960e302179b1df236de72e9"}],"tools/install_venv.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"33614cb9a294a046c5a1050276084160e9a3074b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9ddbd3fa_70c25fc0","updated":"2022-07-22 12:12:46.000000000","message":"This file is only used in run_tests.sh so can be deleted also","commit_id":"6c3b164c24841591d960e302179b1df236de72e9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e4ed35dc087a575e657dee2b9f01816f9c58ebb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a00610bd_b2fde8ea","in_reply_to":"9ddbd3fa_70c25fc0","updated":"2022-07-22 14:27:09.000000000","message":"Done","commit_id":"6c3b164c24841591d960e302179b1df236de72e9"}],"tools/test-requires":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"33614cb9a294a046c5a1050276084160e9a3074b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"273fa58e_cf638fe0","updated":"2022-07-22 12:12:46.000000000","message":"This file is only used in install_venv.py, so if that can be removed as used only in run_stest.sh, this test-requires file can also be removed","commit_id":"6c3b164c24841591d960e302179b1df236de72e9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e4ed35dc087a575e657dee2b9f01816f9c58ebb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d310b058_aabf882b","in_reply_to":"273fa58e_cf638fe0","updated":"2022-07-22 14:27:09.000000000","message":"Done","commit_id":"6c3b164c24841591d960e302179b1df236de72e9"}]}