)]}'
{"os_ken/lib/packet/bgp.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8fb8ad91d9ddf35604fb68be78df0cb2d2f6f967","unresolved":true,"context_lines":[{"line_number":3861,"context_line":"    def parse_value(cls, buf):"},{"line_number":3862,"context_line":"        (ip_addr,) \u003d struct.unpack_from(cls._VALUE_PACK_STR,"},{"line_number":3863,"context_line":"                                        bytes(buf))"},{"line_number":3864,"context_line":"        if len(ip_addr) \u003d\u003d 4:"},{"line_number":3865,"context_line":"            return {"},{"line_number":3866,"context_line":"                \u0027value\u0027: addrconv.ipv4.bin_to_text(ip_addr),"},{"line_number":3867,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ce413ef_8e3194f1","line":3864,"updated":"2023-06-16 12:18:38.000000000","message":"I don\u0027t think that this works:\n\n\u003e\u003e\u003e (ip_addr,) \u003d struct.unpack_from(_VALUE_PACK_STR,b\"aaaabbbbccccdddd\")\n\u003e\u003e\u003e len(ip_addr)\n4\n\u003e\u003e\u003e ip_addr\nb\u0027aaaa\u0027\n\nThere seems to be some deeper logic error, for IPv6 BGPPathAttributeMpReachNLRI should be used, see BGPPathAttributeMpReachNLRI","commit_id":"35f6b2b49ff6440b60d91131d6df13e07b27698f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4fcaeff1f879ea4ff069fdc78a85ee15e76f3139","unresolved":true,"context_lines":[{"line_number":3861,"context_line":"    def parse_value(cls, buf):"},{"line_number":3862,"context_line":"        (ip_addr,) \u003d struct.unpack_from(cls._VALUE_PACK_STR,"},{"line_number":3863,"context_line":"                                        bytes(buf))"},{"line_number":3864,"context_line":"        if len(ip_addr) \u003d\u003d 4:"},{"line_number":3865,"context_line":"            return {"},{"line_number":3866,"context_line":"                \u0027value\u0027: addrconv.ipv4.bin_to_text(ip_addr),"},{"line_number":3867,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":1,"id":"d3b8d02d_3b6f3447","line":3864,"in_reply_to":"5ce413ef_8e3194f1","updated":"2023-06-20 09:47:03.000000000","message":"ack, if I have time I will come back to this also","commit_id":"35f6b2b49ff6440b60d91131d6df13e07b27698f"}]}