)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"281529cedf5cd63124d9990ed9686556d0dbd590","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     elajkat \u003clajos.katona@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-24 15:19:11 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raise ValuError in case unpack_from returns zero length"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #2067973"},{"line_number":10,"context_line":"Closes-Bug: #2067970"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4347d9ab_dacbb266","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":15},"updated":"2024-06-25 14:10:27.000000000","message":"ValueError","commit_id":"9134c58f66bff41eb3135ac4c2e56a6aeacd10d0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"264ca1dbda1a7393396751903cd907870b6233dd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     elajkat \u003clajos.katona@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-06-24 15:19:11 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raise ValuError in case unpack_from returns zero length"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #2067973"},{"line_number":10,"context_line":"Closes-Bug: #2067970"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"99c8ef56_9c8076ec","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":15},"in_reply_to":"4347d9ab_dacbb266","updated":"2024-06-25 21:00:13.000000000","message":"Done","commit_id":"9134c58f66bff41eb3135ac4c2e56a6aeacd10d0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"264ca1dbda1a7393396751903cd907870b6233dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"19dd07f4_993c57d9","updated":"2024-06-25 21:00:13.000000000","message":"Fixed typo to move along","commit_id":"2f30f44406535991ec982608d04c8893b8fda9ad"}],"os_ken/ofproto/ofproto_v1_3_parser.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"281529cedf5cd63124d9990ed9686556d0dbd590","unresolved":true,"context_lines":[{"line_number":1616,"context_line":"    @classmethod"},{"line_number":1617,"context_line":"    def parse(cls, buf):"},{"line_number":1618,"context_line":"        (type_, length) \u003d struct.unpack_from(cls._PACK_STR, buf, 0)"},{"line_number":1619,"context_line":"        if not length:"},{"line_number":1620,"context_line":"            raise ValueError"},{"line_number":1621,"context_line":"        rest \u003d buf[utils.round_up(length, 8):]"},{"line_number":1622,"context_line":"        try:"},{"line_number":1623,"context_line":"            subcls \u003d cls._TYPES[type_]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1c31e67e_593a7d36","line":1620,"range":{"start_line":1619,"start_character":8,"end_line":1620,"end_character":28},"updated":"2024-06-25 14:10:27.000000000","message":"(no action) I would implement a base class for OFPPropBase, that will be also used by NXTPacketIn2Prop. But checking the existing code and the amount of repeated code we have, that would be for a follow-up patch","commit_id":"9134c58f66bff41eb3135ac4c2e56a6aeacd10d0"}]}