)]}'
{"os_loganalyze/filter.py":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"1e923449f4edd7a76a8b83559260615305802dc1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.supports_sev \u003d SUPPORTS_SEV.search(fname) is not None"},{"line_number":91,"context_line":"        self.fname \u003d fname"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def __iter__(self):"},{"line_number":94,"context_line":"        old_sev \u003d \"NONE\""},{"line_number":95,"context_line":"        for line in self.gen:"},{"line_number":96,"context_line":"            logline \u003d LogLine(line, old_sev)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_5c82f852","line":93,"updated":"2014-07-10 11:45:03.000000000","message":"This is more technically an iterator.. This should probably be implemented in the next() method so:\n\n  def __iter__(self):\n      return self\n\n  def __next__(self):\n      # py3 compat\n      return self.next()\n\n  def next(self):\n      ... do something\n      yield something","commit_id":"0ebfa219303ae84e84c4fbcdac4a522aecf6fb24"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"12118e743b179d9f20c7afcb42f43c224e55a0cc","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.supports_sev \u003d SUPPORTS_SEV.search(fname) is not None"},{"line_number":91,"context_line":"        self.fname \u003d fname"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def __iter__(self):"},{"line_number":94,"context_line":"        old_sev \u003d \"NONE\""},{"line_number":95,"context_line":"        for line in self.gen:"},{"line_number":96,"context_line":"            logline \u003d LogLine(line, old_sev)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_3c4464b6","line":93,"in_reply_to":"baada198_5c82f852","updated":"2014-07-10 11:56:15.000000000","message":"ah, because it is yielding this is actually returning a generator... nevermind!","commit_id":"0ebfa219303ae84e84c4fbcdac4a522aecf6fb24"}],"os_loganalyze/wsgi.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"35992fd49fe499fc915ef6525070ff8982498d4e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"SYSLOG_MATCH \u003d \u0027^(?P\u003cdate\u003e%s) (?P\u003chost\u003e[\\w\\-]+) (?P\u003cservice\u003e\\S+):\u0027 % \\"},{"line_number":35,"context_line":"    (SYSLOGDATE)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"ALL_DATE \u003d \u0027(%s|%s)\u0027 % (DATEFMT, SYSLOGDATE)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _html_close():"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_61957387","line":37,"updated":"2014-07-09 18:33:19.000000000","message":"These regexes are in the new filter file. Shouldn\u0027t they be removed from here?\n\nI think ALL_DATE is the exception so you may want to move it to filter.py.","commit_id":"0ebfa219303ae84e84c4fbcdac4a522aecf6fb24"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"1e923449f4edd7a76a8b83559260615305802dc1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"SYSLOG_MATCH \u003d \u0027^(?P\u003cdate\u003e%s) (?P\u003chost\u003e[\\w\\-]+) (?P\u003cservice\u003e\\S+):\u0027 % \\"},{"line_number":35,"context_line":"    (SYSLOGDATE)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"ALL_DATE \u003d \u0027(%s|%s)\u0027 % (DATEFMT, SYSLOGDATE)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _html_close():"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_9cf3b009","line":37,"in_reply_to":"baada198_61957387","updated":"2014-07-10 11:45:03.000000000","message":"Agreed","commit_id":"0ebfa219303ae84e84c4fbcdac4a522aecf6fb24"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"1e923449f4edd7a76a8b83559260615305802dc1","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def color_by_sev(line, sev):"},{"line_number":156,"context_line":"    \"\"\"Wrap a line in a span whose class matches it\u0027s severity.\"\"\""},{"line_number":157,"context_line":"    return \"\u003c/span\u003e\u003cspan class\u003d\u0027%s\u0027\u003e%s\" % (sev, line)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def escape_html(line):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_9c0f30e1","line":157,"updated":"2014-07-10 11:45:03.000000000","message":"This method isn\u0027t very reusable (and the docstring is no longer correct). I think it should be dropped and the logic moved into the html_filter","commit_id":"0ebfa219303ae84e84c4fbcdac4a522aecf6fb24"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"1e923449f4edd7a76a8b83559260615305802dc1","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    return cgi.escape(line)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"def link_timestamp(line):"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    m \u003d re.search("},{"line_number":173,"context_line":"        \u0027(\u003cspan class\u003d\\\u0027(?P\u003cclass\u003e[^\\\u0027]+)\\\u0027\u003e)?\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_3cb9c415","line":170,"updated":"2014-07-10 11:45:03.000000000","message":"This method could probably go in the filter file too (which is perhaps better called \u0027formatter\u0027). Then ALL_DATE wouldn\u0027t need to be in here","commit_id":"0ebfa219303ae84e84c4fbcdac4a522aecf6fb24"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"1e923449f4edd7a76a8b83559260615305802dc1","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        yield line"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"def html_filter(fname, flines_generator, minsev):"},{"line_number":197,"context_line":"    \"\"\"Generator to read logs and output html in a stream."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    This produces a stream of the htmlified logs which lets us return"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_dcf8c8c6","line":196,"updated":"2014-07-10 11:45:03.000000000","message":"why not have these filters in the file called \u0027filter\u0027?","commit_id":"0ebfa219303ae84e84c4fbcdac4a522aecf6fb24"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"1e923449f4edd7a76a8b83559260615305802dc1","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    status \u003d \u0027200 OK\u0027"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    try:"},{"line_number":294,"context_line":"        logname, flines_generator \u003d osgen.get(environ, root_path, config)"},{"line_number":295,"context_line":"    except osgen.UnsafePath:"},{"line_number":296,"context_line":"        status \u003d \u0027400 Bad Request\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_5ce91819","line":293,"updated":"2014-07-10 11:45:03.000000000","message":"lets call fline_generator here something else as they aren\u0027t formatted lines","commit_id":"0ebfa219303ae84e84c4fbcdac4a522aecf6fb24"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"1e923449f4edd7a76a8b83559260615305802dc1","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        return [\u0027File Not Found\u0027]"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    minsev \u003d get_min_sev(environ)"},{"line_number":307,"context_line":"    flines_generator \u003d osfilter.Filter(logname, flines_generator, minsev)"},{"line_number":308,"context_line":"    if should_be_html(environ):"},{"line_number":309,"context_line":"        response_headers \u003d [(\u0027Content-type\u0027, \u0027text/html\u0027)]"},{"line_number":310,"context_line":"        generator \u003d html_filter(logname, flines_generator, minsev)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_fc902c98","line":307,"updated":"2014-07-10 11:45:03.000000000","message":"(nit) technically an iterator","commit_id":"0ebfa219303ae84e84c4fbcdac4a522aecf6fb24"}]}
