)]}'
{"os_loganalyze/wsgi.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2a74853565ecf2150c54a5b72e357661795fc8ff","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    flines_generator \u003d osfilter.Filter("},{"line_number":317,"context_line":"        logname, flines_generator, minsev, limit)"},{"line_number":318,"context_line":"    if environ.get(\u0027OS_LOGANALYZE_STRIP\u0027, None):"},{"line_number":319,"context_line":"        flines_generator.strip_control \u003d True"},{"line_number":320,"context_line":"    if should_be_html(environ):"},{"line_number":321,"context_line":"        response_headers \u003d [(\u0027Content-type\u0027, \u0027text/html\u0027)]"},{"line_number":322,"context_line":"        generator \u003d html_filter(logname, flines_generator, minsev)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_01bbd7c4","line":319,"updated":"2014-07-09 18:39:33.000000000","message":"Odd that you set all other options via the constructor but this one is just hammered in. Its python so it works and I am not really bothered by it.","commit_id":"45cbd52dc5f84e91afc6377eb03496117a8f1361"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7c5e21d678ccd944b188b4b46e0307c019bb438f","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    flines_generator \u003d osfilter.Filter("},{"line_number":317,"context_line":"        logname, flines_generator, minsev, limit)"},{"line_number":318,"context_line":"    if environ.get(\u0027OS_LOGANALYZE_STRIP\u0027, None):"},{"line_number":319,"context_line":"        flines_generator.strip_control \u003d True"},{"line_number":320,"context_line":"    if should_be_html(environ):"},{"line_number":321,"context_line":"        response_headers \u003d [(\u0027Content-type\u0027, \u0027text/html\u0027)]"},{"line_number":322,"context_line":"        generator \u003d html_filter(logname, flines_generator, minsev)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_81ac4737","line":319,"in_reply_to":"baada198_01bbd7c4","updated":"2014-07-09 18:46:56.000000000","message":"yeh, I\u0027m mixed on it as well, I felt like building a million options was weird. I could go either way.","commit_id":"45cbd52dc5f84e91afc6377eb03496117a8f1361"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"16ba29dec203d25334a73fbe2d0992c08d846c45","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    flines_generator \u003d osfilter.Filter("},{"line_number":317,"context_line":"        logname, flines_generator, minsev, limit)"},{"line_number":318,"context_line":"    if environ.get(\u0027OS_LOGANALYZE_STRIP\u0027, None):"},{"line_number":319,"context_line":"        flines_generator.strip_control \u003d True"},{"line_number":320,"context_line":"    if should_be_html(environ):"},{"line_number":321,"context_line":"        response_headers \u003d [(\u0027Content-type\u0027, \u0027text/html\u0027)]"},{"line_number":322,"context_line":"        generator \u003d html_filter(logname, flines_generator, minsev)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_a12eaba3","line":319,"in_reply_to":"baada198_81ac4737","updated":"2014-07-09 18:49:17.000000000","message":"I think it is ok as is which is why I +2\u0027d anyways. I say we fix the issue in the first change of this stack and hopefully then we can merge the whole stack.","commit_id":"45cbd52dc5f84e91afc6377eb03496117a8f1361"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"df717e3bde8660b2eb1d3fa62b86c3ebb78ab959","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    flines_generator \u003d osfilter.Filter("},{"line_number":317,"context_line":"        logname, flines_generator, minsev, limit)"},{"line_number":318,"context_line":"    if environ.get(\u0027OS_LOGANALYZE_STRIP\u0027, None):"},{"line_number":319,"context_line":"        flines_generator.strip_control \u003d True"},{"line_number":320,"context_line":"    if should_be_html(environ):"},{"line_number":321,"context_line":"        response_headers \u003d [(\u0027Content-type\u0027, \u0027text/html\u0027)]"},{"line_number":322,"context_line":"        generator \u003d html_filter(logname, flines_generator, minsev)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_1cade088","line":319,"in_reply_to":"baada198_a12eaba3","updated":"2014-07-10 11:52:26.000000000","message":"I have a preference for doing it in the constructor for consistency, but I do see why you didn\u0027t. However kwargs tend to make large methods usable.\n\nIf you re-rolling I would have a preference for changing this, but I\u0027m not going to block on it.","commit_id":"45cbd52dc5f84e91afc6377eb03496117a8f1361"}]}
