)]}'
{"os_loganalyze/view.py":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"9d7c132e3f67fda29fa474c2757f69418163b364","unresolved":false,"context_lines":[{"line_number":106,"context_line":"DATE_LINE \u003d (\"\u003cspan class\u003d\u0027%s %s\u0027\u003e\u003ca name\u003d\u0027%s\u0027 class\u003d\u0027date\u0027 href\u003d\u0027#%s\u0027\u003e\""},{"line_number":107,"context_line":"             \"%s\u003c/a\u003e%s\\n\u003c/span\u003e\")"},{"line_number":108,"context_line":"NONDATE_LINE \u003d \"\u003cspan class\u003d\u0027%s\u0027\u003e%s\\n\u003c/span\u003e\""},{"line_number":109,"context_line":"HTML_RE \u003d re.compile(\"\u003chtml\")"},{"line_number":110,"context_line":"SKIP_LINES \u003d re.compile(\"\u003c/?pre\u003e\")"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_c3b6f5db","line":109,"updated":"2014-07-18 13:22:44.000000000","message":"I think this needs to have .*\nFor example, the indexes generated are all on one line.\n\neg:\n\n  \u003chtml\u003e\u003chead\u003e\u003ctitle\u003e......","commit_id":"7a3994591c2a0d874e1cfe765ccd628bc54a14b4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"fcbc7c4602c1e2bf176d81ca280ece1b0962c85a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"DATE_LINE \u003d (\"\u003cspan class\u003d\u0027%s %s\u0027\u003e\u003ca name\u003d\u0027%s\u0027 class\u003d\u0027date\u0027 href\u003d\u0027#%s\u0027\u003e\""},{"line_number":107,"context_line":"             \"%s\u003c/a\u003e%s\\n\u003c/span\u003e\")"},{"line_number":108,"context_line":"NONDATE_LINE \u003d \"\u003cspan class\u003d\u0027%s\u0027\u003e%s\\n\u003c/span\u003e\""},{"line_number":109,"context_line":"HTML_RE \u003d re.compile(\"\u003chtml\")"},{"line_number":110,"context_line":"SKIP_LINES \u003d re.compile(\"\u003c/?pre\u003e\")"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_009a9c13","line":109,"in_reply_to":"baada198_c3b6f5db","updated":"2014-07-24 21:31:08.000000000","message":"you don\u0027t actually, because we don\u0027t end in $, so the match is good as is.","commit_id":"7a3994591c2a0d874e1cfe765ccd628bc54a14b4"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"9d7c132e3f67fda29fa474c2757f69418163b364","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.should_escape \u003d False"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _process_line(self, line):"},{"line_number":127,"context_line":"        if SKIP_LINES.match(line.line):"},{"line_number":128,"context_line":"            # pre tags mean we\u0027re partial html and shouldn\u0027t escape"},{"line_number":129,"context_line":"            self.should_escape \u003d False"},{"line_number":130,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_839b1d72","line":127,"updated":"2014-07-18 13:22:44.000000000","message":"SKIP lines should just return.","commit_id":"7a3994591c2a0d874e1cfe765ccd628bc54a14b4"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"9d7c132e3f67fda29fa474c2757f69418163b364","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _process_line(self, line):"},{"line_number":127,"context_line":"        if SKIP_LINES.match(line.line):"},{"line_number":128,"context_line":"            # pre tags mean we\u0027re partial html and shouldn\u0027t escape"},{"line_number":129,"context_line":"            self.should_escape \u003d False"},{"line_number":130,"context_line":"            return"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_c388b524","line":128,"updated":"2014-07-18 13:22:44.000000000","message":"We should have another regex for matching PRE since the functionality is to not escape.\n\nWe should also check that is_html \u003d\u003d False before matching pre tags in case we are rendering an html file","commit_id":"7a3994591c2a0d874e1cfe765ccd628bc54a14b4"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"133a76f0f43f8de1ed0eb56264c35087651d8e5f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def _process_line(self, line):"},{"line_number":127,"context_line":"        if SKIP_LINES.match(line.line):"},{"line_number":128,"context_line":"            # pre tags mean we\u0027re partial html and shouldn\u0027t escape"},{"line_number":129,"context_line":"            self.should_escape \u003d False"},{"line_number":130,"context_line":"            return"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if self.should_escape:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_25ca594f","line":129,"updated":"2014-07-18 12:31:22.000000000","message":"I don\u0027t understand why we don\u0027t toggle here. When we leave the pre tag shouldn\u0027t we start escaping again?","commit_id":"7a3994591c2a0d874e1cfe765ccd628bc54a14b4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"40b88fa746138819f2950dcf7f82679b71022583","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def _process_line(self, line):"},{"line_number":127,"context_line":"        if SKIP_LINES.match(line.line):"},{"line_number":128,"context_line":"            # pre tags mean we\u0027re partial html and shouldn\u0027t escape"},{"line_number":129,"context_line":"            self.should_escape \u003d False"},{"line_number":130,"context_line":"            return"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if self.should_escape:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_28415039","line":129,"in_reply_to":"baada198_25ca594f","updated":"2014-07-18 12:50:12.000000000","message":"we did this before because the console.html has \u003cpre\u003e but is already html escaped.","commit_id":"7a3994591c2a0d874e1cfe765ccd628bc54a14b4"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"44cb8f15fec6059dde3b3eb83f6fb00c0c4a9608","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def _process_line(self, line):"},{"line_number":127,"context_line":"        if SKIP_LINES.match(line.line):"},{"line_number":128,"context_line":"            # pre tags mean we\u0027re partial html and shouldn\u0027t escape"},{"line_number":129,"context_line":"            self.should_escape \u003d False"},{"line_number":130,"context_line":"            return"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if self.should_escape:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_e8e3d8d5","line":129,"in_reply_to":"baada198_28415039","updated":"2014-07-18 12:53:54.000000000","message":"Right, but when the \u003cpre\u003e is closed (ie \u003c/pre\u003e) shouldn\u0027t the double escaping stop?","commit_id":"7a3994591c2a0d874e1cfe765ccd628bc54a14b4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"48b068f5b7c62085651dec7bf13f120cd0483a5f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def _process_line(self, line):"},{"line_number":127,"context_line":"        if SKIP_LINES.match(line.line):"},{"line_number":128,"context_line":"            # pre tags mean we\u0027re partial html and shouldn\u0027t escape"},{"line_number":129,"context_line":"            self.should_escape \u003d False"},{"line_number":130,"context_line":"            return"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        if self.should_escape:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_03f0edfb","line":129,"in_reply_to":"baada198_e8e3d8d5","updated":"2014-07-21 15:43:52.000000000","message":"so in console.html, \u003c/pre\u003e is the end of file. \n\nThere is an issue here with us stripping raw pre lines from other html files, that being said, we probably want to figure out sending actual html through the PassThrough view","commit_id":"7a3994591c2a0d874e1cfe765ccd628bc54a14b4"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"133a76f0f43f8de1ed0eb56264c35087651d8e5f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        return newline"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def __iter__(self):"},{"line_number":146,"context_line":"        first_line \u003d next(x for x in self.gen)"},{"line_number":147,"context_line":"        self._discover_html(first_line.line)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if not self.is_html:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_85eb25a3","line":146,"updated":"2014-07-18 12:31:22.000000000","message":"We can\u0027t just call next(self.gen) here?","commit_id":"7a3994591c2a0d874e1cfe765ccd628bc54a14b4"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"44cb8f15fec6059dde3b3eb83f6fb00c0c4a9608","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        return newline"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def __iter__(self):"},{"line_number":146,"context_line":"        first_line \u003d next(x for x in self.gen)"},{"line_number":147,"context_line":"        self._discover_html(first_line.line)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if not self.is_html:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_68eee8b6","line":146,"in_reply_to":"baada198_08f56cec","updated":"2014-07-18 12:53:54.000000000","message":"seems odd.. the generator is just yielding so I would have thought the next() would work. It\u0027s odd that it actually pops the first item from the generator though (and why you needed it separate to the loop).. I\u0027m clearly not understanding some python magic so I\u0027m okay with it.","commit_id":"7a3994591c2a0d874e1cfe765ccd628bc54a14b4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"48b068f5b7c62085651dec7bf13f120cd0483a5f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        return newline"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def __iter__(self):"},{"line_number":146,"context_line":"        first_line \u003d next(x for x in self.gen)"},{"line_number":147,"context_line":"        self._discover_html(first_line.line)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if not self.is_html:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_6348c92d","line":146,"in_reply_to":"baada198_68eee8b6","updated":"2014-07-21 15:43:52.000000000","message":"next needs to be specificially supported, this is a big part of the complexity. Here is sample code to demonstrate.\n\n In [6]: class Foo(object):\n   ...:     def __iter__():\n   ...:         yield 1\n   ...:         yield 2\n   ...:         yield 3\n   ...:         \n\n In [7]: a \u003d Foo()\n\n In [8]: next(a)\n ---------------------------------------------------------------------------\n TypeError                                 Traceback (most recent call last)\n \u003cipython-input-8-3f6e2eea332d\u003e in \u003cmodule\u003e()\n ----\u003e 1 next(a)\n\n TypeError: Foo object is not an iterator","commit_id":"7a3994591c2a0d874e1cfe765ccd628bc54a14b4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"40b88fa746138819f2950dcf7f82679b71022583","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        return newline"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def __iter__(self):"},{"line_number":146,"context_line":"        first_line \u003d next(x for x in self.gen)"},{"line_number":147,"context_line":"        self._discover_html(first_line.line)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if not self.is_html:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_08f56cec","line":146,"in_reply_to":"baada198_85eb25a3","updated":"2014-07-18 12:50:12.000000000","message":"No, the swift generator doesn\u0027t work that way, it will through a not an iterator exception","commit_id":"7a3994591c2a0d874e1cfe765ccd628bc54a14b4"}]}
