)]}'
{"os_net_config/impl_ifcfg.py":[{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"6cf298399f84b938d92358c15d5666b47050b026","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                data +\u003d \"VLAN\u003dyes\\n\""},{"line_number":85,"context_line":"                if base_opt.device:"},{"line_number":86,"context_line":"                    data +\u003d \"PHYSDEV\u003d%s\\n\" % base_opt.device"},{"line_number":87,"context_line":"        elif re.match(\u0027\\w+\\.\\d+$\u0027, base_opt.name):"},{"line_number":88,"context_line":"            data +\u003d \"VLAN\u003dyes\\n\""},{"line_number":89,"context_line":"        if base_opt.ovs_port:"},{"line_number":90,"context_line":"            data +\u003d \"DEVICETYPE\u003dovs\\n\""},{"line_number":91,"context_line":"            if base_opt.bridge_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_6321a4fb","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":32},"updated":"2016-03-08 01:20:01.000000000","message":"I think what you are trying to do is take an existing VLAN on a Linux bond, and you want to add that VLAN to the bridge, rather than adding the bond and creating a VLAN interface.\n\nI\u0027m not sure I agree with the approach here. You are trying to add a VLAN to a bridge, by defining it as an interface. But here you are adding VLAN\u003dyes to any object which is *not* a VLAN, if it has a dot in the name. Isn\u0027t this only supposed to apply to interfaces? If you moved this stanza to after the else: in line 159 then you can avoid this issue.\n\nWe don\u0027t support that use case today. If we are going to add that use case, I\u0027d like to make it more general. What if the VLAN interface is created with a different name (the eth0.120 naming convention isn\u0027t enforced, just suggested). We could add an optional parameter, so setting vlan\u003dyes on the interface would trigger this logic in addition to matching on the name.","commit_id":"f00d545041b75b5d3e215bf435689e933dbb4f62"},{"author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"change_message_id":"726a35b8e53a0ab1f9668b8707244179719eab0c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                data +\u003d \"VLAN\u003dyes\\n\""},{"line_number":85,"context_line":"                if base_opt.device:"},{"line_number":86,"context_line":"                    data +\u003d \"PHYSDEV\u003d%s\\n\" % base_opt.device"},{"line_number":87,"context_line":"        elif re.match(\u0027\\w+\\.\\d+$\u0027, base_opt.name):"},{"line_number":88,"context_line":"            data +\u003d \"VLAN\u003dyes\\n\""},{"line_number":89,"context_line":"        if base_opt.ovs_port:"},{"line_number":90,"context_line":"            data +\u003d \"DEVICETYPE\u003dovs\\n\""},{"line_number":91,"context_line":"            if base_opt.bridge_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_9826dab8","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":32},"in_reply_to":"5aef4532_6321a4fb","updated":"2016-03-08 02:10:24.000000000","message":"Hi Dan,\n\nDebian/Ubuntu will identify a eth0.120 has been a vlan tagged interface just because of its name. The behavior was be be different on RHEL. The patch was here to avoid this inconsistency.\nThis said, the vlan parameter is a good idea.","commit_id":"f00d545041b75b5d3e215bf435689e933dbb4f62"}]}