)]}'
{"os_net_config/impl_ifcfg.py":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6e1ce82b6d35bd94e268c695317d4faae377eb61","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            else:"},{"line_number":232,"context_line":"                # Route is an IPv6 route"},{"line_number":233,"context_line":"                if route.default:"},{"line_number":234,"context_line":"                    first_line6\u003d \"default via %s dev %s\\n\" % (route.next_hop,"},{"line_number":235,"context_line":"                                                              interface_name)"},{"line_number":236,"context_line":"                else:"},{"line_number":237,"context_line":"                    data6+\u003d \"%s via %s dev %s\\n\" % (route.ip_netmask,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_27136d0f","line":234,"updated":"2016-01-18 00:40:01.000000000","message":"should be first_line6 \u003d ...\nmissing whitespace before operator","commit_id":"fbf3d5054f29bcb704b86060b5a7a5d738f564cf"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6e1ce82b6d35bd94e268c695317d4faae377eb61","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                    first_line6\u003d \"default via %s dev %s\\n\" % (route.next_hop,"},{"line_number":235,"context_line":"                                                              interface_name)"},{"line_number":236,"context_line":"                else:"},{"line_number":237,"context_line":"                    data6+\u003d \"%s via %s dev %s\\n\" % (route.ip_netmask,"},{"line_number":238,"context_line":"                                                    route.next_hop,"},{"line_number":239,"context_line":"                                                    interface_name)"},{"line_number":240,"context_line":"        self.route_data[interface_name] \u003d first_line + data"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_e7f555cb","line":237,"updated":"2016-01-18 00:40:01.000000000","message":"should be first_data6 +\u003d ...\nmissing whitespace before operator","commit_id":"fbf3d5054f29bcb704b86060b5a7a5d738f564cf"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6e1ce82b6d35bd94e268c695317d4faae377eb61","unresolved":false,"context_lines":[{"line_number":367,"context_line":"            route6_data \u003d self.route6_data.get(bridge_name, \u0027\u0027)"},{"line_number":368,"context_line":"            bridge_path \u003d self.root_dir + bridge_config_path(bridge_name)"},{"line_number":369,"context_line":"            bridge_route_path \u003d self.root_dir + route_config_path(bridge_name)"},{"line_number":370,"context_line":"            bridge_route6_path \u003d self.root_dir + route6_config_path(bridge_name)"},{"line_number":371,"context_line":"            all_file_names.append(bridge_path)"},{"line_number":372,"context_line":"            all_file_names.append(bridge_route_path)"},{"line_number":373,"context_line":"            all_file_names.append(bridge_route6_path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_a7ff5da9","line":370,"updated":"2016-01-18 00:40:01.000000000","message":"line too long","commit_id":"fbf3d5054f29bcb704b86060b5a7a5d738f564cf"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6e1ce82b6d35bd94e268c695317d4faae377eb61","unresolved":false,"context_lines":[{"line_number":387,"context_line":"            route6_data \u003d self.route6_data.get(bridge_name, \u0027\u0027)"},{"line_number":388,"context_line":"            bridge_path \u003d self.root_dir + bridge_config_path(bridge_name)"},{"line_number":389,"context_line":"            bridge_route_path \u003d self.root_dir + route_config_path(bridge_name)"},{"line_number":390,"context_line":"            bridge_route6_path \u003d self.root_dir + route6_config_path(bridge_name)"},{"line_number":391,"context_line":"            all_file_names.append(bridge_path)"},{"line_number":392,"context_line":"            all_file_names.append(bridge_route_path)"},{"line_number":393,"context_line":"            all_file_names.append(bridge_route6_path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_472b0134","line":390,"updated":"2016-01-18 00:40:01.000000000","message":"line too long","commit_id":"fbf3d5054f29bcb704b86060b5a7a5d738f564cf"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"17d472d80234f526c69b61e9903ada3e99d55861","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        first_line \u003d \"\""},{"line_number":219,"context_line":"        data6 \u003d \"\""},{"line_number":220,"context_line":"        first_line6 \u003d \"\""},{"line_number":221,"context_line":"        for route in routes:"},{"line_number":222,"context_line":"            if \":\" not in route.next_hop:"},{"line_number":223,"context_line":"                # Route is an IPv4 route"},{"line_number":224,"context_line":"                if route.default:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_3239ce42","line":221,"updated":"2016-02-24 22:18:25.000000000","message":"The code within the IPv4 and IPv6 blocks below look the same to me. Would it be reasonable to move this conditional below to where we set self.route6_data instead?","commit_id":"ced1ebd4084dc60684bdd55580b8d10b68bccbbd"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"cd9a11812ccd39e7412b3fe7d2601825f462ae84","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        first_line \u003d \"\""},{"line_number":219,"context_line":"        data6 \u003d \"\""},{"line_number":220,"context_line":"        first_line6 \u003d \"\""},{"line_number":221,"context_line":"        for route in routes:"},{"line_number":222,"context_line":"            if \":\" not in route.next_hop:"},{"line_number":223,"context_line":"                # Route is an IPv4 route"},{"line_number":224,"context_line":"                if route.default:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_98dc3b76","line":221,"in_reply_to":"bae84128_3239ce42","updated":"2016-02-24 22:56:04.000000000","message":"No, I can\u0027t do that without changing the logic. This determines if a route is a default, and if so makes it the first line in the file. If there is a default IPv4 and a default IPv6, then they will clobber each other.","commit_id":"ced1ebd4084dc60684bdd55580b8d10b68bccbbd"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"2302d5895cd6c3c6f7a07fd6293d840c981c8130","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            else:"},{"line_number":232,"context_line":"                # Route is an IPv6 route"},{"line_number":233,"context_line":"                if route.default:"},{"line_number":234,"context_line":"                    first_line6 \u003d \"default via %s dev %s\\n\" % (route.next_hop,"},{"line_number":235,"context_line":"                                                               interface_name)"},{"line_number":236,"context_line":"                else:"},{"line_number":237,"context_line":"                    data6 +\u003d \"%s via %s dev %s\\n\" % (route.ip_netmask,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_b8513fdb","line":234,"range":{"start_line":234,"start_character":30,"end_line":234,"end_character":31},"updated":"2016-02-24 22:57:11.000000000","message":"Here the code differs from the block above. That\u0027s why I need the two separate blocks.","commit_id":"ced1ebd4084dc60684bdd55580b8d10b68bccbbd"}],"os_net_config/tests/test_impl_ifcfg.py":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6e1ce82b6d35bd94e268c695317d4faae377eb61","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        route1 \u003d objects.Route(\u0027192.168.1.1\u0027, default\u003dTrue)"},{"line_number":297,"context_line":"        route2 \u003d objects.Route(\u0027192.168.1.1\u0027, \u0027172.19.0.0/24\u0027)"},{"line_number":298,"context_line":"        route3 \u003d objects.Route(\u00272001:db8::1\u0027, default\u003dTrue)"},{"line_number":299,"context_line":"        route4 \u003d objects.Route(\u0027fd00:fd00:2000::1\u0027,\u00272001:db8:dead:beef:cafe::/56\u0027)"},{"line_number":300,"context_line":"        v4_addr \u003d objects.Address(\u0027192.168.1.2/24\u0027)"},{"line_number":301,"context_line":"        v6_addr \u003d objects.Address(\u00272001:abc:a::/64\u0027)"},{"line_number":302,"context_line":"        interface \u003d objects.Interface(\u0027em1\u0027, addresses\u003d[v4_addr,v6_addr],"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_0725095b","line":299,"updated":"2016-01-18 00:40:01.000000000","message":"missing whitespace after \u0027,\u0027 line is too long","commit_id":"fbf3d5054f29bcb704b86060b5a7a5d738f564cf"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6e1ce82b6d35bd94e268c695317d4faae377eb61","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        route4 \u003d objects.Route(\u0027fd00:fd00:2000::1\u0027,\u00272001:db8:dead:beef:cafe::/56\u0027)"},{"line_number":300,"context_line":"        v4_addr \u003d objects.Address(\u0027192.168.1.2/24\u0027)"},{"line_number":301,"context_line":"        v6_addr \u003d objects.Address(\u00272001:abc:a::/64\u0027)"},{"line_number":302,"context_line":"        interface \u003d objects.Interface(\u0027em1\u0027, addresses\u003d[v4_addr,v6_addr],"},{"line_number":303,"context_line":"                                      routes\u003d[route1, route2, route3, route4])"},{"line_number":304,"context_line":"        self.provider.add_interface(interface)"},{"line_number":305,"context_line":"        self.assertEqual(_V4_V6_IFCFG, self.get_interface_config())"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_272a8d2d","line":302,"updated":"2016-01-18 00:40:01.000000000","message":"issing whitespace after \u0027,\u0027","commit_id":"fbf3d5054f29bcb704b86060b5a7a5d738f564cf"}]}