)]}'
{"os_net_config/impl_ifcfg.py":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"84d8b7432df30129ae01e1eaf7da69e20865bc6e","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            data +\u003d \"DHCLIENTARGS\u003d%s\\n\" % base_opt.dhclient_args"},{"line_number":402,"context_line":"        if base_opt.dns_servers:"},{"line_number":403,"context_line":"            data +\u003d \"DNS1\u003d%s\\n\" % base_opt.dns_servers[0]"},{"line_number":404,"context_line":"            if len(base_opt.dns_servers) \u003e\u003d 2:"},{"line_number":405,"context_line":"                data +\u003d \"DNS2\u003d%s\\n\" % base_opt.dns_servers[1]"},{"line_number":406,"context_line":"                if len(base_opt.dns_servers) \u003e 2:"},{"line_number":407,"context_line":"                    logger.warning(\u0027ifcfg format supports max 2 resolvers.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_864de573","line":404,"updated":"2017-09-13 08:34:53.000000000","message":"The patch adds 2nd DNS even though the configuration is not expected. I am fine with writing it and logging it a errors, but would wait for other to comment. The warning message could be enhanceed to be explicit to say that remaining resolvers are ignored.\n\nI think the better fix would be modify the schema to allow max 2 items - https://github.com/openstack/os-net-config/blob/master/os_net_config/schema.yaml#L58","commit_id":"8ddab87c6ee2e80025e9340d806f93921779198b"},{"author":{"_account_id":21908,"name":"Frank Zdarsky","email":"fzdarsky@redhat.com","username":"fzdarsky"},"change_message_id":"64e07b70a1505fed62580e3d5fdce477c71c71e5","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            data +\u003d \"DHCLIENTARGS\u003d%s\\n\" % base_opt.dhclient_args"},{"line_number":402,"context_line":"        if base_opt.dns_servers:"},{"line_number":403,"context_line":"            data +\u003d \"DNS1\u003d%s\\n\" % base_opt.dns_servers[0]"},{"line_number":404,"context_line":"            if len(base_opt.dns_servers) \u003e\u003d 2:"},{"line_number":405,"context_line":"                data +\u003d \"DNS2\u003d%s\\n\" % base_opt.dns_servers[1]"},{"line_number":406,"context_line":"                if len(base_opt.dns_servers) \u003e 2:"},{"line_number":407,"context_line":"                    logger.warning(\u0027ifcfg format supports max 2 resolvers.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_21705bdc","line":404,"in_reply_to":"5f2577a7_864de573","updated":"2017-09-13 10:41:25.000000000","message":"This is a limitation of ifcfg, but other implementations may support \u003e2 resolvers. So it seems wrong to add it to the schema, where it\u0027s meaning would be that this is generally invalid input.\n\nNote: Failed schema validation currently only results in a logged warning in os-net-config, i.e. it would still attempt to continue with the configuration. However, it is treated as error in os-net-config CI tests and in TripleO pre-deployment validations.\n\nBut, yes, adding a maxItem would do the trick, although I\u0027d then rename the type \"dns_address_list\" or something.","commit_id":"8ddab87c6ee2e80025e9340d806f93921779198b"}]}
