)]}'
{"etc/os-net-config/samples/sriov_pf.json":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"62ced53f9e6148543d4c44f85ed0e7fca157475f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            \"name\": \"p2p2\","},{"line_number":13,"context_line":"            \"numvfs\": 10,"},{"line_number":14,"context_line":"            \"use_dhcp\": false,"},{"line_number":15,"context_line":"            \"promisc\": on"},{"line_number":16,"context_line":"        },"},{"line_number":17,"context_line":"        {"},{"line_number":18,"context_line":"          \"type\": \"sriov_vf\","}],"source_content_type":"application/json","patch_set":6,"id":"3f79a3b5_71f5cb51","line":15,"range":{"start_line":15,"start_character":1,"end_line":15,"end_character":25},"updated":"2018-12-04 19:27:59.000000000","message":"its confusing as to whether this should be on, \"on\", or true as there are examples of each of these in this file.","commit_id":"82cac0d75b23aaa82156e490462f19d4b89ce96a"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"232f00b6a5be5304c5bc93f85149e68278bb3e86","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            \"name\": \"p2p2\","},{"line_number":13,"context_line":"            \"numvfs\": 10,"},{"line_number":14,"context_line":"            \"use_dhcp\": false,"},{"line_number":15,"context_line":"            \"promisc\": on"},{"line_number":16,"context_line":"        },"},{"line_number":17,"context_line":"        {"},{"line_number":18,"context_line":"          \"type\": \"sriov_vf\","}],"source_content_type":"application/json","patch_set":6,"id":"3f79a3b5_aa53dbdc","line":15,"range":{"start_line":15,"start_character":1,"end_line":15,"end_character":25},"in_reply_to":"3f79a3b5_71f5cb51","updated":"2018-12-05 11:12:05.000000000","message":"Nice Catch ! The applicable values are \"on\"/\"off\" and true/false. BY default the THT values \"on\"/\"off\" are converted to boolean in config.json. I\u0027ll update the patch accordingly.","commit_id":"82cac0d75b23aaa82156e490462f19d4b89ce96a"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"62ced53f9e6148543d4c44f85ed0e7fca157475f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                    \"vfid\": 3,"},{"line_number":96,"context_line":"                    \"vlan_id\": 113,"},{"line_number":97,"context_line":"                    \"qos\": 5,"},{"line_number":98,"context_line":"                    \"spoofcheck\": \"on\","},{"line_number":99,"context_line":"                    \"trust\": \"on\","},{"line_number":100,"context_line":"                    \"promisc\": \"off\","},{"line_number":101,"context_line":"                    \"primary\": true,"},{"line_number":102,"context_line":"                },"},{"line_number":103,"context_line":"                {"}],"source_content_type":"application/json","patch_set":6,"id":"3f79a3b5_11d8174f","line":100,"range":{"start_line":98,"start_character":1,"end_line":100,"end_character":37},"updated":"2018-12-04 19:27:59.000000000","message":"Se comment below about use of true/false vs \"on\"/\"off\"","commit_id":"82cac0d75b23aaa82156e490462f19d4b89ce96a"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"62ced53f9e6148543d4c44f85ed0e7fca157475f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                    \"vfid\": 3,"},{"line_number":107,"context_line":"                    \"vlan_id\": 113,"},{"line_number":108,"context_line":"                    \"qos\": 5,"},{"line_number":109,"context_line":"                    \"spoofcheck\": \"on\","},{"line_number":110,"context_line":"                    \"trust\": \"on\","},{"line_number":111,"context_line":"                    \"promisc\": \"off\""},{"line_number":112,"context_line":"                }"},{"line_number":113,"context_line":"            ]"},{"line_number":114,"context_line":"        }"}],"source_content_type":"application/json","patch_set":6,"id":"3f79a3b5_517f6f67","line":111,"range":{"start_line":109,"start_character":1,"end_line":111,"end_character":36},"updated":"2018-12-04 19:27:59.000000000","message":"Is it intentional that spoofcheck, trust, and promisc use boolean values at lines 68-70 and 78-80 above and \"on/off\" here?","commit_id":"82cac0d75b23aaa82156e490462f19d4b89ce96a"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"46658a42280f6e52cff407bc675946afb82438d7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"name\": \"p2p1\","},{"line_number":6,"context_line":"            \"numvfs\": 10,"},{"line_number":7,"context_line":"            \"use_dhcp\": false,"},{"line_number":8,"context_line":"            \"promisc\": \"on\""},{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"type\": \"sriov_pf\","}],"source_content_type":"application/json","patch_set":8,"id":"3f79a3b5_f6776e8c","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":27},"updated":"2018-12-05 21:17:25.000000000","message":"Rather than change all of these instances to \"on/off\" I would prefer if you used \"true/false\" everywhere. That will line up better with the other booleans, and I would prefer true/false as boolean rather than \"on\"/\"off\" as strings.","commit_id":"cc7bcfcecb96da15ee9dd164bf9e02eec968e3b4"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"e31561ed6805145bbe4ca136cb51e9c2536aa7a0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"name\": \"p2p1\","},{"line_number":6,"context_line":"            \"numvfs\": 10,"},{"line_number":7,"context_line":"            \"use_dhcp\": false,"},{"line_number":8,"context_line":"            \"promisc\": \"on\""},{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"type\": \"sriov_pf\","}],"source_content_type":"application/json","patch_set":8,"id":"3f79a3b5_1f88fd17","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":27},"in_reply_to":"3f79a3b5_f6776e8c","updated":"2018-12-06 01:09:08.000000000","message":"these \"on\"/\"off\" is actually the values used in the command \"ip link set dev \u003cPF device\u003e promisc on/off\". I thought its better to stick with the values used in the command to give the user better way of understanding the parameters. let me know if you still prefer true/false.","commit_id":"cc7bcfcecb96da15ee9dd164bf9e02eec968e3b4"}],"etc/os-net-config/samples/sriov_pf.yaml":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"62ced53f9e6148543d4c44f85ed0e7fca157475f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        device: p2p2"},{"line_number":115,"context_line":"        vfid: 2"},{"line_number":116,"context_line":"        vlan_id: 112"},{"line_number":117,"context_line":"        qos: 4"},{"line_number":118,"context_line":"  - type: linux_bond"},{"line_number":119,"context_line":"    name: bond_lnx"},{"line_number":120,"context_line":"    use_dhcp: true"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_ec190476","line":117,"updated":"2018-12-04 19:27:59.000000000","message":"Nit - would be good to have same defaults here as for values at lines 107-111","commit_id":"82cac0d75b23aaa82156e490462f19d4b89ce96a"}],"etc/os-net-config/samples/sriov_pf_ovs_dpdk.json":[{"author":{"_account_id":16690,"name":"Noam Angel","email":"noama@nvidia.com","username":"noama"},"change_message_id":"a51ca28e67931a5e34e51ac69509ac2547e4aff9","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                            \"members\": ["},{"line_number":86,"context_line":"                                {"},{"line_number":87,"context_line":"                                    \"type\": \"sriov_vf\","},{"line_number":88,"context_line":"                                    \"device\": \"p2p1\","},{"line_number":89,"context_line":"                                    \"vfid\": 4,"},{"line_number":90,"context_line":"                                    \"vlan_id\": 114,"},{"line_number":91,"context_line":"                                    \"spoofcheck\": false,"}],"source_content_type":"application/json","patch_set":2,"id":"3f79a3b5_35318659","line":88,"range":{"start_line":88,"start_character":50,"end_line":88,"end_character":51},"updated":"2018-11-20 07:08:28.000000000","message":"p2p2?","commit_id":"8f565ad1b6259df652207f624408e9233d3ee68a"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"ab2fd415b2447f01f5ae6bb8c3531f5d1b12f768","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                            \"members\": ["},{"line_number":86,"context_line":"                                {"},{"line_number":87,"context_line":"                                    \"type\": \"sriov_vf\","},{"line_number":88,"context_line":"                                    \"device\": \"p2p1\","},{"line_number":89,"context_line":"                                    \"vfid\": 4,"},{"line_number":90,"context_line":"                                    \"vlan_id\": 114,"},{"line_number":91,"context_line":"                                    \"spoofcheck\": false,"}],"source_content_type":"application/json","patch_set":2,"id":"3f79a3b5_755e1e79","line":88,"range":{"start_line":88,"start_character":50,"end_line":88,"end_character":51},"in_reply_to":"3f79a3b5_35318659","updated":"2018-11-20 07:12:17.000000000","message":"Done","commit_id":"8f565ad1b6259df652207f624408e9233d3ee68a"}],"os_net_config/impl_ifcfg.py":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"1d4cc6429f98cb01ff3b63b3f50ace27241eb9a5","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        elif isinstance(base_opt, objects.LinuxBond):"},{"line_number":439,"context_line":"            if base_opt.primary_interface_name:"},{"line_number":440,"context_line":"                primary_name \u003d base_opt.primary_interface_name"},{"line_number":441,"context_line":"                if not self.noop:"},{"line_number":442,"context_line":"                    primary_mac \u003d utils.interface_mac(primary_name)"},{"line_number":443,"context_line":"                    data +\u003d \"MACADDR\u003d\\\"%s\\\"\\n\" % primary_mac"},{"line_number":444,"context_line":"            if base_opt.use_dhcp:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_1baef87f","line":441,"updated":"2018-11-20 12:17:47.000000000","message":"Wondering why it is needed for sriov_vf cases? It should be same for normal interfaces to get mac address.","commit_id":"96eeca208d6eb40c29e2ee103b86cd38ba353bda"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"8d8a712bf915114845b3194b8a919c8f7ce7c12e","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        elif isinstance(base_opt, objects.LinuxBond):"},{"line_number":439,"context_line":"            if base_opt.primary_interface_name:"},{"line_number":440,"context_line":"                primary_name \u003d base_opt.primary_interface_name"},{"line_number":441,"context_line":"                if not self.noop:"},{"line_number":442,"context_line":"                    primary_mac \u003d utils.interface_mac(primary_name)"},{"line_number":443,"context_line":"                    data +\u003d \"MACADDR\u003d\\\"%s\\\"\\n\" % primary_mac"},{"line_number":444,"context_line":"            if base_opt.use_dhcp:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_56020573","line":441,"in_reply_to":"3f79a3b5_1baef87f","updated":"2018-11-20 13:15:25.000000000","message":"Until now none of the unit testcases for linux_bond has the primary field set and hence \"if base_opt.primary_interface_name\" block was not executed.","commit_id":"96eeca208d6eb40c29e2ee103b86cd38ba353bda"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"f7d57a073e442045229cd5756b7ca8a0fdac07ba","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        elif isinstance(base_opt, objects.LinuxBond):"},{"line_number":439,"context_line":"            if base_opt.primary_interface_name:"},{"line_number":440,"context_line":"                primary_name \u003d base_opt.primary_interface_name"},{"line_number":441,"context_line":"                if not self.noop:"},{"line_number":442,"context_line":"                    primary_mac \u003d utils.interface_mac(primary_name)"},{"line_number":443,"context_line":"                    data +\u003d \"MACADDR\u003d\\\"%s\\\"\\n\" % primary_mac"},{"line_number":444,"context_line":"            if base_opt.use_dhcp:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_0f6db601","line":441,"range":{"start_line":441,"start_character":16,"end_line":441,"end_character":33},"updated":"2018-11-29 18:21:01.000000000","message":"Just a question as to why this is needed here as we don\u0027t check with other instances.","commit_id":"f453ca13cb436e458a8783c151766a2d94d49abf"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"9995c1bcfef9179f6ea2f7431d71dfe84acc0cd7","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        elif isinstance(base_opt, objects.LinuxBond):"},{"line_number":439,"context_line":"            if base_opt.primary_interface_name:"},{"line_number":440,"context_line":"                primary_name \u003d base_opt.primary_interface_name"},{"line_number":441,"context_line":"                if not self.noop:"},{"line_number":442,"context_line":"                    primary_mac \u003d utils.interface_mac(primary_name)"},{"line_number":443,"context_line":"                    data +\u003d \"MACADDR\u003d\\\"%s\\\"\\n\" % primary_mac"},{"line_number":444,"context_line":"            if base_opt.use_dhcp:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_9bfb3dc4","line":441,"range":{"start_line":441,"start_character":16,"end_line":441,"end_character":33},"in_reply_to":"3f79a3b5_0f6db601","updated":"2018-11-29 22:47:58.000000000","message":"Good point, I don\u0027t see anything about either utils.interface_mac() or utils._get_dpdk_mac_address() that can\u0027t be run even if noop\u003dTrue.","commit_id":"f453ca13cb436e458a8783c151766a2d94d49abf"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"d30a47cec8dcd5e86edca38eaa087565d95426fb","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        elif isinstance(base_opt, objects.LinuxBond):"},{"line_number":439,"context_line":"            if base_opt.primary_interface_name:"},{"line_number":440,"context_line":"                primary_name \u003d base_opt.primary_interface_name"},{"line_number":441,"context_line":"                if not self.noop:"},{"line_number":442,"context_line":"                    primary_mac \u003d utils.interface_mac(primary_name)"},{"line_number":443,"context_line":"                    data +\u003d \"MACADDR\u003d\\\"%s\\\"\\n\" % primary_mac"},{"line_number":444,"context_line":"            if base_opt.use_dhcp:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_236bdf54","line":441,"range":{"start_line":441,"start_character":16,"end_line":441,"end_character":33},"in_reply_to":"3f79a3b5_0f6db601","updated":"2018-11-30 05:12:27.000000000","message":"Untill now the testcases for linux bond doesn\u0027t involve \"primary\" field, hence this block was not executed.","commit_id":"f453ca13cb436e458a8783c151766a2d94d49abf"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"435f271a3bfc29d62d802e96613eb17f48ab7cb7","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        elif isinstance(base_opt, objects.LinuxBond):"},{"line_number":439,"context_line":"            if base_opt.primary_interface_name:"},{"line_number":440,"context_line":"                primary_name \u003d base_opt.primary_interface_name"},{"line_number":441,"context_line":"                if not self.noop:"},{"line_number":442,"context_line":"                    primary_mac \u003d utils.interface_mac(primary_name)"},{"line_number":443,"context_line":"                    data +\u003d \"MACADDR\u003d\\\"%s\\\"\\n\" % primary_mac"},{"line_number":444,"context_line":"            if base_opt.use_dhcp:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_77742d8b","line":441,"range":{"start_line":441,"start_character":16,"end_line":441,"end_character":33},"in_reply_to":"3f79a3b5_4118531f","updated":"2018-11-30 07:51:13.000000000","message":"I think you can probably stub out utils.interface_mac() in the testcase, so you won\u0027t run into this.","commit_id":"f453ca13cb436e458a8783c151766a2d94d49abf"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"d30a47cec8dcd5e86edca38eaa087565d95426fb","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        elif isinstance(base_opt, objects.LinuxBond):"},{"line_number":439,"context_line":"            if base_opt.primary_interface_name:"},{"line_number":440,"context_line":"                primary_name \u003d base_opt.primary_interface_name"},{"line_number":441,"context_line":"                if not self.noop:"},{"line_number":442,"context_line":"                    primary_mac \u003d utils.interface_mac(primary_name)"},{"line_number":443,"context_line":"                    data +\u003d \"MACADDR\u003d\\\"%s\\\"\\n\" % primary_mac"},{"line_number":444,"context_line":"            if base_opt.use_dhcp:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_4118531f","line":441,"range":{"start_line":441,"start_character":16,"end_line":441,"end_character":33},"in_reply_to":"3f79a3b5_9bfb3dc4","updated":"2018-11-30 05:12:27.000000000","message":"The unit testcases will fail since the path \u0027/sys/class/net/\u003cnic\u003e\u0027 would not exist.","commit_id":"f453ca13cb436e458a8783c151766a2d94d49abf"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"9bc6804aca5451a010fa6f46f416008568206db4","unresolved":false,"context_lines":[{"line_number":440,"context_line":"                primary_name \u003d base_opt.primary_interface_name"},{"line_number":441,"context_line":"                if not self.noop:"},{"line_number":442,"context_line":"                    primary_mac \u003d utils.interface_mac(primary_name)"},{"line_number":443,"context_line":"                    data +\u003d \"MACADDR\u003d\\\"%s\\\"\\n\" % primary_mac"},{"line_number":444,"context_line":"            if base_opt.use_dhcp:"},{"line_number":445,"context_line":"                data +\u003d \"BOOTPROTO\u003ddhcp\\n\""},{"line_number":446,"context_line":"            if base_opt.members:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_ac0a8978","line":443,"range":{"start_line":443,"start_character":0,"end_line":443,"end_character":60},"updated":"2018-11-29 18:39:42.000000000","message":"Actually, I think the \"data +\u003d \"MACADDR...\" assignment needs to happen even if self.noop\u003d\u003dTrue. That way you can see the output that would get written to the ifcfg file when doing a dry run, e.g. \"os-net-config --noop -c \u003cconfig\u003e\". That should still show exactly what would be written to the ifcfg file, even though it never gets written to disk.","commit_id":"f453ca13cb436e458a8783c151766a2d94d49abf"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"d30a47cec8dcd5e86edca38eaa087565d95426fb","unresolved":false,"context_lines":[{"line_number":440,"context_line":"                primary_name \u003d base_opt.primary_interface_name"},{"line_number":441,"context_line":"                if not self.noop:"},{"line_number":442,"context_line":"                    primary_mac \u003d utils.interface_mac(primary_name)"},{"line_number":443,"context_line":"                    data +\u003d \"MACADDR\u003d\\\"%s\\\"\\n\" % primary_mac"},{"line_number":444,"context_line":"            if base_opt.use_dhcp:"},{"line_number":445,"context_line":"                data +\u003d \"BOOTPROTO\u003ddhcp\\n\""},{"line_number":446,"context_line":"            if base_opt.members:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_e1ce3f8d","line":443,"range":{"start_line":443,"start_character":0,"end_line":443,"end_character":60},"in_reply_to":"3f79a3b5_ac0a8978","updated":"2018-11-30 05:12:27.000000000","message":"I think we need to keep different configurations for dry run and unit test case. Or we\u0027ll have to have stubs for testcases to pass.","commit_id":"f453ca13cb436e458a8783c151766a2d94d49abf"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"435f271a3bfc29d62d802e96613eb17f48ab7cb7","unresolved":false,"context_lines":[{"line_number":440,"context_line":"                primary_name \u003d base_opt.primary_interface_name"},{"line_number":441,"context_line":"                if not self.noop:"},{"line_number":442,"context_line":"                    primary_mac \u003d utils.interface_mac(primary_name)"},{"line_number":443,"context_line":"                    data +\u003d \"MACADDR\u003d\\\"%s\\\"\\n\" % primary_mac"},{"line_number":444,"context_line":"            if base_opt.use_dhcp:"},{"line_number":445,"context_line":"                data +\u003d \"BOOTPROTO\u003ddhcp\\n\""},{"line_number":446,"context_line":"            if base_opt.members:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_f7aefde3","line":443,"range":{"start_line":443,"start_character":0,"end_line":443,"end_character":60},"in_reply_to":"3f79a3b5_e1ce3f8d","updated":"2018-11-30 07:51:13.000000000","message":"Yes, I think stubbing out the utils.interface_mac for the test cases would give us the best outcome. That way the test case can pass, but you can also get a true dry run that shows the actual MACADDR that would be used.","commit_id":"f453ca13cb436e458a8783c151766a2d94d49abf"}],"os_net_config/objects.py":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"1d4cc6429f98cb01ff3b63b3f50ace27241eb9a5","unresolved":false,"context_lines":[{"line_number":906,"context_line":"                    self.primary_interface_name \u003d member.name"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"    @staticmethod"},{"line_number":909,"context_line":"    def update_vf_config(iface):"},{"line_number":910,"context_line":"        if iface.trust is None:"},{"line_number":911,"context_line":"            logger.info(\"Trust is not set for VF %s:%d, defaulting to on\""},{"line_number":912,"context_line":"                        % (iface.device, iface.vfid))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_9be768d8","line":909,"updated":"2018-11-20 12:17:47.000000000","message":"Can we move this vf config update as a common function for all uses? Either global or in _BaseOpts class? Adding or changing a vf config requires modification in more than 3 places.","commit_id":"96eeca208d6eb40c29e2ee103b86cd38ba353bda"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"8d8a712bf915114845b3194b8a919c8f7ce7c12e","unresolved":false,"context_lines":[{"line_number":906,"context_line":"                    self.primary_interface_name \u003d member.name"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"    @staticmethod"},{"line_number":909,"context_line":"    def update_vf_config(iface):"},{"line_number":910,"context_line":"        if iface.trust is None:"},{"line_number":911,"context_line":"            logger.info(\"Trust is not set for VF %s:%d, defaulting to on\""},{"line_number":912,"context_line":"                        % (iface.device, iface.vfid))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_764861b3","line":909,"in_reply_to":"3f79a3b5_9be768d8","updated":"2018-11-20 13:15:25.000000000","message":"The default values for each of these attributes are different for linux_bond, ovs_bridge/ovs_bond, user_bridge. We will still have these customization if we move it to a common place.","commit_id":"96eeca208d6eb40c29e2ee103b86cd38ba353bda"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"1d4cc6429f98cb01ff3b63b3f50ace27241eb9a5","unresolved":false,"context_lines":[{"line_number":1203,"context_line":"                        OvsDpdkPort.update_vf_config(iface)"},{"line_number":1204,"context_line":"                        members.append(iface)"},{"line_number":1205,"context_line":"                    else:"},{"line_number":1206,"context_line":"                        msg \u003d \u0027OVS DPDK Port should have only interface member\u0027"},{"line_number":1207,"context_line":"                        raise InvalidConfigException(msg)"},{"line_number":1208,"context_line":"                else:"},{"line_number":1209,"context_line":"                    msg \u003d \u0027OVS DPDK Port should have only one member\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_9bd8c8ed","line":1206,"range":{"start_line":1206,"start_character":62,"end_line":1206,"end_character":71},"updated":"2018-11-20 12:17:47.000000000","message":"can we update this as it now accepts sriov_vf too?","commit_id":"96eeca208d6eb40c29e2ee103b86cd38ba353bda"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"8d8a712bf915114845b3194b8a919c8f7ce7c12e","unresolved":false,"context_lines":[{"line_number":1203,"context_line":"                        OvsDpdkPort.update_vf_config(iface)"},{"line_number":1204,"context_line":"                        members.append(iface)"},{"line_number":1205,"context_line":"                    else:"},{"line_number":1206,"context_line":"                        msg \u003d \u0027OVS DPDK Port should have only interface member\u0027"},{"line_number":1207,"context_line":"                        raise InvalidConfigException(msg)"},{"line_number":1208,"context_line":"                else:"},{"line_number":1209,"context_line":"                    msg \u003d \u0027OVS DPDK Port should have only one member\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_96f17d67","line":1206,"range":{"start_line":1206,"start_character":62,"end_line":1206,"end_character":71},"in_reply_to":"3f79a3b5_9bd8c8ed","updated":"2018-11-20 13:15:25.000000000","message":"Will do","commit_id":"96eeca208d6eb40c29e2ee103b86cd38ba353bda"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"62ced53f9e6148543d4c44f85ed0e7fca157475f","unresolved":false,"context_lines":[{"line_number":1340,"context_line":"        numvfs \u003d _get_required_field(json, \u0027numvfs\u0027, \u0027SriovPF\u0027)"},{"line_number":1341,"context_line":"        # SR-IOV PF - promisc: on (default)"},{"line_number":1342,"context_line":"        promisc \u003d json.get(\u0027promisc\u0027, True)"},{"line_number":1343,"context_line":"        promisc \u003d \"on\" if promisc else \"off\""},{"line_number":1344,"context_line":"        opts \u003d _BaseOpts.base_opts_from_json(json)"},{"line_number":1345,"context_line":"        return SriovPF(name, numvfs, *opts, promisc\u003dpromisc)"},{"line_number":1346,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_f1647b22","line":1343,"range":{"start_line":1343,"start_character":1,"end_line":1343,"end_character":44},"updated":"2018-12-04 19:27:59.000000000","message":"Because the values in sriov_pf.json are inconsistent there is some potential for error in this check.  What if for example, promisc was to \"off\" in the json file.  That would result in promisc being set to \"on\" here.","commit_id":"82cac0d75b23aaa82156e490462f19d4b89ce96a"}]}