)]}'
{"id":"openstack%2Fos-net-config~661721","triplet_id":"openstack%2Fos-net-config~master~I67d51a52d70369fbafdc59dd6936c0ae4ed6224d","project":"openstack/os-net-config","branch":"master","topic":"bug/1830716","hashtags":[],"change_id":"I67d51a52d70369fbafdc59dd6936c0ae4ed6224d","subject":"Take pf index instead of phys_port name in representors renaming script","status":"ABANDONED","created":"2019-05-28 11:07:41.000000000","updated":"2019-06-16 07:14:22.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7f452ed9c6e238fac1bb0cc986340a59d36c8431","_number":661721,"virtual_id_number":661721,"owner":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2019-05-29 18:53:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-05-29 13:36:42.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},{"date":"2019-06-03 19:43:32.000000000","_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},{"value":-1,"date":"2019-06-11 07:51:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},{"value":0,"date":"2019-06-04 09:35:01.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"date":"2019-06-03 17:53:51.000000000","_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},{"value":-1,"date":"2019-06-11 11:17:02.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-29 13:36:42.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-29 18:53:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-03 17:53:51.000000000","updated_by":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"reviewer":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"state":"REVIEWER"},{"updated":"2019-06-03 19:43:32.000000000","updated_by":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"reviewer":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"state":"REVIEWER"},{"updated":"2019-06-04 09:35:01.000000000","updated_by":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"reviewer":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"state":"REVIEWER"},{"updated":"2019-06-11 07:51:11.000000000","updated_by":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"reviewer":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"state":"REVIEWER"}],"messages":[{"id":"1c2abf05ce35c42b8a50085dd31bd910604c5140","author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"date":"2019-05-28 11:07:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0bfa7632bf12e9d25197615526e9399a177658ae","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-05-28 13:26:33.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/21/661721/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/1a11209/ : SUCCESS in 2h 17m 40s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/21/661721/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/cd243c8/ : SUCCESS in 2h 17m 57s\n- tripleo-ci-centos-7-multinode-1ctlr-featureset010 http://logs.rdoproject.org/21/661721/1/openstack-check/tripleo-ci-centos-7-multinode-1ctlr-featureset010/d51ef43/ : SUCCESS in 1h 23m 11s","accounts_in_message":[],"_revision_number":1},{"id":"62ea5b5293a236431cb1e70e16d6d8386d006d95","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-28 14:47:32.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/21/661721/1/check/openstack-tox-cover/e6abdb9/cover/ : SUCCESS in 5m 17s\n- openstack-tox-pep8 http://logs.openstack.org/21/661721/1/check/openstack-tox-pep8/d45a74c/ : FAILURE in 4m 12s\n- openstack-tox-py27 http://logs.openstack.org/21/661721/1/check/openstack-tox-py27/3431886/ : FAILURE in 4m 23s\n- openstack-tox-py35 http://logs.openstack.org/21/661721/1/check/openstack-tox-py35/ddc13a0/ : SUCCESS in 4m 42s\n- openstack-tox-py36 http://logs.openstack.org/21/661721/1/check/openstack-tox-py36/739e37f/ : SUCCESS in 4m 59s\n- openstack-tox-py37 http://logs.openstack.org/21/661721/1/check/openstack-tox-py37/b054029/ : SUCCESS in 6m 42s\n- openstack-tox-docs http://logs.openstack.org/21/661721/1/check/openstack-tox-docs/9324d1a/html/ : SUCCESS in 6m 53s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/21/661721/1/check/tripleo-ci-centos-7-containers-multinode/acbcf45/ : SUCCESS in 2h 56m 34s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/21/661721/1/check/tripleo-ci-centos-7-undercloud-containers/033f2e0/ : SUCCESS in 1h 28m 00s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/21/661721/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/d768e4d/ : SUCCESS in 2h 12m 52s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/21/661721/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/02d738a/ : SUCCESS in 2h 23m 13s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/21/661721/1/check/tripleo-ci-centos-7-standalone/8e0fa28/ : SUCCESS in 1h 45m 16s\n- tripleo-ci-fedora-28-standalone http://logs.openstack.org/21/661721/1/check/tripleo-ci-fedora-28-standalone/0452b92/ : SUCCESS in 1h 36m 38s\n- tripleo-ci-centos-7-standalone-upgrade http://logs.openstack.org/21/661721/1/check/tripleo-ci-centos-7-standalone-upgrade/56baf9c/ : SUCCESS in 2h 15m 44s (non-voting)\n- tripleo-ci-centos-7-standalone-upgrade-stein http://logs.openstack.org/21/661721/1/check/tripleo-ci-centos-7-standalone-upgrade-stein/1531fbc/ : SUCCESS in 2h 13m 43s","accounts_in_message":[],"_revision_number":1},{"id":"6b30560c40d7a430f7b9832c61c2c60c578481a9","author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"date":"2019-05-29 09:06:05.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"dba1eda4310364eb4df8f10fec4df78fb84a8c19","author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"date":"2019-05-29 12:17:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bd141db7fb6dfe9617041c9bdf35ecf1b6c438c8","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-05-29 13:36:42.000000000","message":"Patch Set 2:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/21/661721/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/6a6f804/ : RETRY_LIMIT in 2m 46s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/21/661721/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/69134e1/ : RETRY_LIMIT in 3m 04s\n- tripleo-ci-centos-7-multinode-1ctlr-featureset010 http://logs.rdoproject.org/21/661721/2/openstack-check/tripleo-ci-centos-7-multinode-1ctlr-featureset010/a99d7e8/ : SUCCESS in 1h 12m 56s","accounts_in_message":[],"_revision_number":2},{"id":"aaaa089972ff484aad49c08ffe4b7438b43d17b0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-29 18:53:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/21/661721/2/check/openstack-tox-cover/5794736/cover/ : SUCCESS in 5m 41s\n- openstack-tox-pep8 http://logs.openstack.org/21/661721/2/check/openstack-tox-pep8/7750e27/ : SUCCESS in 4m 24s\n- openstack-tox-py27 http://logs.openstack.org/21/661721/2/check/openstack-tox-py27/628ebb6/ : SUCCESS in 4m 39s\n- openstack-tox-py35 http://logs.openstack.org/21/661721/2/check/openstack-tox-py35/6d0db08/ : SUCCESS in 5m 13s\n- openstack-tox-py36 http://logs.openstack.org/21/661721/2/check/openstack-tox-py36/633786a/ : SUCCESS in 4m 25s\n- openstack-tox-py37 http://logs.openstack.org/21/661721/2/check/openstack-tox-py37/7d7ada2/ : SUCCESS in 5m 00s\n- openstack-tox-docs http://logs.openstack.org/21/661721/2/check/openstack-tox-docs/0c9d2bd/html/ : SUCCESS in 4m 36s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/21/661721/2/check/tripleo-ci-centos-7-containers-multinode/038dbce/ : SUCCESS in 1h 57m 08s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/21/661721/2/check/tripleo-ci-centos-7-undercloud-containers/c9008cf/ : SUCCESS in 1h 43m 09s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/21/661721/2/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/22b8852/ : SUCCESS in 2h 14m 38s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/21/661721/2/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/e9565d2/ : SUCCESS in 2h 15m 47s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/21/661721/2/check/tripleo-ci-centos-7-standalone/ee504c2/ : SUCCESS in 1h 39m 03s\n- tripleo-ci-fedora-28-standalone http://logs.openstack.org/21/661721/2/check/tripleo-ci-fedora-28-standalone/6f16e72/ : SUCCESS in 1h 49m 22s\n- tripleo-ci-centos-7-standalone-upgrade http://logs.openstack.org/21/661721/2/check/tripleo-ci-centos-7-standalone-upgrade/10eaec6/ : SUCCESS in 2h 03m 16s (non-voting)\n- tripleo-ci-centos-7-standalone-upgrade-stein http://logs.openstack.org/21/661721/2/check/tripleo-ci-centos-7-standalone-upgrade-stein/e71f316/ : SUCCESS in 2h 02m 55s","accounts_in_message":[],"_revision_number":2},{"id":"45b974917bc0b1db70874eaad74bf70c679bb393","author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"date":"2019-06-03 13:47:48.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"4ce51406417101faecef2a309bfc20c25be4842a","author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"date":"2019-06-03 17:53:51.000000000","message":"Patch Set 2:\n\nBefore I sign off on this, what is the effect on systems when upgrading os-net-config and a new sriov_config.py gets laid down? If there is no impact, then this looks good.","accounts_in_message":[],"_revision_number":2},{"id":"7650f7bd3648150d262635a943ac846c53ecbc81","author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"date":"2019-06-03 19:43:32.000000000","message":"Patch Set 2:\n\n\u003e Before I sign off on this, what is the effect on systems when\n \u003e upgrading os-net-config and a new sriov_config.py gets laid down?\n \u003e If there is no impact, then this looks good.\n\n@Dan, Not sure I understand the question, but I can explain the reason for the change. When we introduce this change of the renaming the VF representor it was based on kernel 7.6 + Mellanox OFED. Mellanox OFED include advance features that only included in upstream kernel or rhel 8.0 (feature that call uplink representors). We never tested on rhel 7.6 or 7.7 vanilla which don\u0027t have the uplink representor feature. (this was mistake on our end). The new implementation should work for all vendors which are support or don\u0027t have uplink representor.","accounts_in_message":[],"_revision_number":2},{"id":"d3d1c5b725dc80a789ca556d25259856f78bfaf3","author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"date":"2019-06-04 06:51:11.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"113b21a2e65949f3f9f45bcb1325833c676a04e7","author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"date":"2019-06-04 06:51:55.000000000","message":"Patch Set 2: -Code-Review\n\non second thought removing the -1 as my comment only suggests an improvement of the given logic","accounts_in_message":[],"_revision_number":2},{"id":"659ff9a91871582ac773cc5ee8a1e9f29f803816","author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"date":"2019-06-04 07:38:18.000000000","message":"Patch Set 2:\n\n\u003e Before I sign off on this, what is the effect on systems when upgrading os-net-config and a new sriov_config.py gets laid down? If there is no impact, then this looks good.\n\nAs of today, there are no active deployments with offload, so less impact on the offload scenarios for update/upgrade. But looking at the code, there are issues in one of the update/upgrade scenario, which needs to be handled for general SR-IOV deployment, as mentioned below.\n\nUpdate/Upgrade with sriov nic configs and NO change in numvfs count, will work. And during the update, there is no change in rules, only the script file is update. As the script file re-written always, it should have the latest script files. \n\nUpdate/Upgrade with sriov nic configs and change the numvfs count, will fail the update. I have created BZ [1] to analyze it further and document the behavior.\n\nSo, this patch looks fine to me.\n\n[1] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1716805","accounts_in_message":[],"_revision_number":2},{"id":"d072d355541d34379f5556cd96487149f64ab0e5","author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"date":"2019-06-04 09:35:01.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"84bf2659ada1963753bb1c5d65425055ddc6e676","author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"date":"2019-06-11 07:51:11.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"638844976f76e5a2f87076bbbf7cc1390505771f","author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"date":"2019-06-11 11:17:02.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"00f1a9196fc77d9e7fdece793e51c642ce0e94e4","author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"date":"2019-06-14 12:30:37.000000000","message":"Patch Set 2:\n\nThis patch is being updated with https://review.opendev.org/#/c/665108/, Can this patch be abandoned?","accounts_in_message":[],"_revision_number":2},{"id":"bed0f01c1e086274f8ea55dc899a96fae8939133","author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"date":"2019-06-16 07:13:55.000000000","message":"Patch Set 2:\n\nyes I\u0027ll abandon it","accounts_in_message":[],"_revision_number":2},{"id":"956c2f5a19764129a41328ddd1a52b64c8688ca7","author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"date":"2019-06-16 07:14:22.000000000","message":"Abandoned\n\nThis patch is being updated with https://review.opendev.org/#/c/665108/","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bc2e4ac326d01033884a6916111b96709df790c3","revisions":{"496ecf9c92f81bd728646d2543f22af616122c6c":{"kind":"REWORK","_number":1,"created":"2019-05-28 11:07:41.000000000","uploader":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"ref":"refs/changes/21/661721/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/os-net-config","ref":"refs/changes/21/661721/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/os-net-config refs/changes/21/661721/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/os-net-config refs/changes/21/661721/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/os-net-config refs/changes/21/661721/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/os-net-config refs/changes/21/661721/1"}}},"commit":{"parents":[{"commit":"905c23dd89375f7542d17ff4677440beb260e39e","subject":"Merge \"Publish documents\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-net-config/commit/905c23dd89375f7542d17ff4677440beb260e39e"}]}],"author":{"name":"waleed mousa","email":"waleedm@mellanox.com","date":"2019-05-28 10:53:55.000000000","tz":-240},"committer":{"name":"waleed mousa","email":"waleedm@mellanox.com","date":"2019-05-28 11:07:39.000000000","tz":-240},"subject":"Take pf index instead of phys_port name in representors renaming script","message":"Take pf index instead of phys_port name in representors renaming script\n\nIn rhel-7.7 kernel the uplink representor doesn\u0027t have value\nfor phys_port_name so the matching will always fail.\nSo modifying the script to compare with pf index instead\n\nChange-Id: I67d51a52d70369fbafdc59dd6936c0ae4ed6224d\nCloses-Bug: #1830716\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-net-config/commit/496ecf9c92f81bd728646d2543f22af616122c6c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-net-config/commit/496ecf9c92f81bd728646d2543f22af616122c6c"}]},"branch":"refs/heads/master"},"bc2e4ac326d01033884a6916111b96709df790c3":{"kind":"REWORK","_number":2,"created":"2019-05-29 12:17:06.000000000","uploader":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"ref":"refs/changes/21/661721/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/os-net-config","ref":"refs/changes/21/661721/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/os-net-config refs/changes/21/661721/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/os-net-config refs/changes/21/661721/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/os-net-config refs/changes/21/661721/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/os-net-config refs/changes/21/661721/2"}}},"commit":{"parents":[{"commit":"905c23dd89375f7542d17ff4677440beb260e39e","subject":"Merge \"Publish documents\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-net-config/commit/905c23dd89375f7542d17ff4677440beb260e39e"}]}],"author":{"name":"waleed mousa","email":"waleedm@mellanox.com","date":"2019-05-28 10:53:55.000000000","tz":-240},"committer":{"name":"waleed mousa","email":"waleedm@mellanox.com","date":"2019-05-29 12:16:47.000000000","tz":-240},"subject":"Take pf index instead of phys_port name in representors renaming script","message":"Take pf index instead of phys_port name in representors renaming script\n\nIn rhel-7.7 kernel the uplink representor doesn\u0027t have value\nfor phys_port_name so the matching will always fail.\nSo modifying the script to compare with pf index instead\n\nChange-Id: I67d51a52d70369fbafdc59dd6936c0ae4ed6224d\nCloses-Bug: #1830716\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-net-config/commit/bc2e4ac326d01033884a6916111b96709df790c3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/os-net-config/commit/bc2e4ac326d01033884a6916111b96709df790c3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}