)]}'
{"os_net_config/objects.py":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8daacfbc2c431b40c9b314bdb9bff12393866514","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                  % (object_name, name)"},{"line_number":100,"context_line":"            raise InvalidConfigException(msg)"},{"line_number":101,"context_line":"    elif not isinstance(field, datatype):"},{"line_number":102,"context_line":"        msg \u003d \u0027%s JSON objects require \\\u0027%s\\\u0027 to be configured.\u0027 \\"},{"line_number":103,"context_line":"              % (object_name, name)"},{"line_number":104,"context_line":"        raise InvalidConfigException(msg)"},{"line_number":105,"context_line":"    return field"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_262f2af7","line":102,"updated":"2019-06-07 13:35:53.000000000","message":"Can you update this error message to indicate it\u0027s a type mismatch?","commit_id":"73cd2c693077c227b1f99371bf19e7cd27bfcd57"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"51ca39782562cc12b17a09d79a387ff981056ab7","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"    @staticmethod"},{"line_number":1408,"context_line":"    def from_json(json):"},{"line_number":1409,"context_line":"        # Get the VF id"},{"line_number":1410,"context_line":"        vfid \u003d _get_required_field(json, \u0027vfid\u0027, \u0027SriovVF\u0027, int)"},{"line_number":1411,"context_line":"        # Get the PF device name"},{"line_number":1412,"context_line":"        device \u003d _get_required_field(json, \u0027device\u0027, \u0027SriovVF\u0027)"},{"line_number":1413,"context_line":"        opts \u003d _BaseOpts.base_opts_from_json(json)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fb8cfa7_05e4203b","line":1410,"range":{"start_line":1410,"start_character":0,"end_line":1410,"end_character":63},"updated":"2019-06-11 20:32:11.000000000","message":"Maybe in the next patch you can do:\n        vfid \u003d _get_required_field(json, \u0027vfid\u0027, \u0027SriovVF\u0027, datatype\u003dint)\nJust because this is the only place we use datatype, so it makes it clear what is being done.","commit_id":"6c95b83fe9be70f0926b4ed43e7a12fde6ef4fd2"}],"os_net_config/tests/test_objects.py":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"14395885d70e0fedb2dbb4d40498ce86c1ec6728","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                          {})"},{"line_number":141,"context_line":"        data \u003d \u0027{\"ip_netmask\": false}\u0027"},{"line_number":142,"context_line":"        json_data \u003d json.loads(data)"},{"line_number":143,"context_line":"        self.assertRaises(TypeError,"},{"line_number":144,"context_line":"                          objects.Address.from_json,"},{"line_number":145,"context_line":"                          json_data)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_760602d1","line":143,"updated":"2019-06-11 07:59:26.000000000","message":"Is this change valid? As per the change, the change of datatype is applicable for only vfid.","commit_id":"98cc75b22b0be94c910d5dda7f748607713960d0"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"3e615f60f7c5fee8f361cfd819c86051d9c7b534","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                          {})"},{"line_number":141,"context_line":"        data \u003d \u0027{\"ip_netmask\": false}\u0027"},{"line_number":142,"context_line":"        json_data \u003d json.loads(data)"},{"line_number":143,"context_line":"        self.assertRaises(TypeError,"},{"line_number":144,"context_line":"                          objects.Address.from_json,"},{"line_number":145,"context_line":"                          json_data)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_b6c6ba67","line":143,"in_reply_to":"9fb8cfa7_760602d1","updated":"2019-06-11 08:10:56.000000000","message":"This testcase is actually incorrect.\n1) we are only checking if the data is available and not the type of data in _get_required_field()\n2) If \"data \u003d \u0027{\"ip_netmask\": true}\u0027\" then the testcase would have failed earlier as well.\n\nIf this change is not done, this testcase fails.","commit_id":"98cc75b22b0be94c910d5dda7f748607713960d0"}]}