)]}'
{"os_net_config/sriov_config.py":[{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"37007a148f582bd94241470b3fe385fdce5efb20","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                configure_switchdev(item[\u0027name\u0027])"},{"line_number":154,"context_line":"                # Clear the vf_queue,"},{"line_number":155,"context_line":"                # As moving to switchdev will remove the vfs and create"},{"line_number":156,"context_line":"                # vf-representros and uplink representor, and the vf-queue"},{"line_number":157,"context_line":"                # will be filled with these events, So we need to clear it"},{"line_number":158,"context_line":"                # before the next iteration of next sriov_pf in order not"},{"line_number":159,"context_line":"                # to affect the logic of _wait_for_vf_creation method above"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_430250b6","line":156,"range":{"start_line":156,"start_character":21,"end_line":156,"end_character":33},"updated":"2019-06-23 13:25:08.000000000","message":"representor","commit_id":"21e4251f86767c200887ab8788fab02187195837"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"fa95787c3a92f26812ca0e98818911926a009dc2","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                configure_switchdev(item[\u0027name\u0027])"},{"line_number":154,"context_line":"                # Clear the vf_queue,"},{"line_number":155,"context_line":"                # As moving to switchdev will remove the vfs and create"},{"line_number":156,"context_line":"                # vf-representros and uplink representor, and the vf-queue"},{"line_number":157,"context_line":"                # will be filled with these events, So we need to clear it"},{"line_number":158,"context_line":"                # before the next iteration of next sriov_pf in order not"},{"line_number":159,"context_line":"                # to affect the logic of _wait_for_vf_creation method above"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_fce656b0","line":156,"range":{"start_line":156,"start_character":21,"end_line":156,"end_character":33},"in_reply_to":"9fb8cfa7_430250b6","updated":"2019-06-26 05:31:04.000000000","message":"Done","commit_id":"21e4251f86767c200887ab8788fab02187195837"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"37007a148f582bd94241470b3fe385fdce5efb20","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                # vf-representros and uplink representor, and the vf-queue"},{"line_number":157,"context_line":"                # will be filled with these events, So we need to clear it"},{"line_number":158,"context_line":"                # before the next iteration of next sriov_pf in order not"},{"line_number":159,"context_line":"                # to affect the logic of _wait_for_vf_creation method above"},{"line_number":160,"context_line":"                vf_queue.queue.clear()"},{"line_number":161,"context_line":"                if_up_interface(item[\u0027name\u0027])"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_83036842","line":159,"updated":"2019-06-23 13:25:08.000000000","message":"Are there any known issues with those udev events ? in _wait_for_vf_creation() we match the pf_name and acknowledge the event. if the udev event is triggered for another pf device, _wait_for_vf_creation() will read and discard the event.","commit_id":"21e4251f86767c200887ab8788fab02187195837"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"cff12903cc2d2064db539bff86b70116f88cd70d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                # vf-representros and uplink representor, and the vf-queue"},{"line_number":157,"context_line":"                # will be filled with these events, So we need to clear it"},{"line_number":158,"context_line":"                # before the next iteration of next sriov_pf in order not"},{"line_number":159,"context_line":"                # to affect the logic of _wait_for_vf_creation method above"},{"line_number":160,"context_line":"                vf_queue.queue.clear()"},{"line_number":161,"context_line":"                if_up_interface(item[\u0027name\u0027])"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_776a8181","line":159,"in_reply_to":"9fb8cfa7_7c4ca6c7","updated":"2019-06-26 06:32:06.000000000","message":"Oh ! Can these error logs be converted to warning logs ? Also are we sure that we will not receive further udev events for the earlier switchdev configuration ?","commit_id":"21e4251f86767c200887ab8788fab02187195837"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"fa95787c3a92f26812ca0e98818911926a009dc2","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                # vf-representros and uplink representor, and the vf-queue"},{"line_number":157,"context_line":"                # will be filled with these events, So we need to clear it"},{"line_number":158,"context_line":"                # before the next iteration of next sriov_pf in order not"},{"line_number":159,"context_line":"                # to affect the logic of _wait_for_vf_creation method above"},{"line_number":160,"context_line":"                vf_queue.queue.clear()"},{"line_number":161,"context_line":"                if_up_interface(item[\u0027name\u0027])"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_7c4ca6c7","line":159,"in_reply_to":"9fb8cfa7_83036842","updated":"2019-06-26 05:31:04.000000000","message":"No there is known issue, but just to avoid some error logs like this\n[ERROR] Unable to parse event /sys/devices/pci0000:00/0000:00:02.0/0000:03:08.5/net/enp3s8f5\n[ERROR] /sys/devices/pci0000:00/0000:00:02.0/0000:03:00.1/physfn/net is not a directory\n[ERROR] /sys/devices/virtual/physfn/net is not a directory","commit_id":"21e4251f86767c200887ab8788fab02187195837"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"50e1eb88689279c4a5b966ef510c188013c4e06c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                # will be filled with these events, So we need to clear it"},{"line_number":158,"context_line":"                # before the next iteration of next sriov_pf in order not"},{"line_number":159,"context_line":"                # to affect the logic of _wait_for_vf_creation method above"},{"line_number":160,"context_line":"                vf_queue.queue.clear()"},{"line_number":161,"context_line":"                if_up_interface(item[\u0027name\u0027])"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    observer.stop()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_899ae76b","line":160,"updated":"2019-06-19 10:17:01.000000000","message":"I am not sure why the observer is started globally, if this creating issue with switchdev, instead of clearing queues, can we start and stop only when required?","commit_id":"21e4251f86767c200887ab8788fab02187195837"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"e68bf63163e08c5c4cbd991a8b692f50697c567c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                # will be filled with these events, So we need to clear it"},{"line_number":158,"context_line":"                # before the next iteration of next sriov_pf in order not"},{"line_number":159,"context_line":"                # to affect the logic of _wait_for_vf_creation method above"},{"line_number":160,"context_line":"                vf_queue.queue.clear()"},{"line_number":161,"context_line":"                if_up_interface(item[\u0027name\u0027])"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    observer.stop()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_244c4275","line":160,"in_reply_to":"9fb8cfa7_899ae76b","updated":"2019-06-19 10:55:43.000000000","message":"+1 on re-checking this possibility.\n\nalso i think that its enough to go with a shorter comment like:\n\n# Clear vf_queue from switchdev related events\n# before next iteration.","commit_id":"21e4251f86767c200887ab8788fab02187195837"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"fa95787c3a92f26812ca0e98818911926a009dc2","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                # will be filled with these events, So we need to clear it"},{"line_number":158,"context_line":"                # before the next iteration of next sriov_pf in order not"},{"line_number":159,"context_line":"                # to affect the logic of _wait_for_vf_creation method above"},{"line_number":160,"context_line":"                vf_queue.queue.clear()"},{"line_number":161,"context_line":"                if_up_interface(item[\u0027name\u0027])"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    observer.stop()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_9cde3ad8","line":160,"in_reply_to":"9fb8cfa7_899ae76b","updated":"2019-06-26 05:31:04.000000000","message":"We couldn\u0027t start and stop more that one time, and also if we want to initialize it every time when needed, the stop will not stop it completely, so it will still listen to events","commit_id":"21e4251f86767c200887ab8788fab02187195837"}]}