)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"0a2c6855d1a72df0f87abef0d66b11d1a19e8aec","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Noam Angel \u003cnoama@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-10 13:12:19 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ifdown happen before writing_config and if interface is up by dhcp/dhclient will not be down, ifdown relaying on ifcfg exist."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"https://github.com/openstack/os-net-config/blob/master/os_net_config/impl_ifcfg.py#L1592"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_7a9028ee","line":7,"updated":"2019-07-15 04:06:23.000000000","message":"commit heading could be improved with a short heading and moving the description down","commit_id":"67d2ea7faa7faa45fb6d2248e135821d3590514a"}],"os_net_config/__init__.py":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"0a2c6855d1a72df0f87abef0d66b11d1a19e8aec","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    def ifdown(self, interface, iftype\u003d\u0027interface\u0027):"},{"line_number":312,"context_line":"        msg \u003d \u0027running ifdown on %s: %s\u0027 % (iftype, interface)"},{"line_number":313,"context_line":"        self.execute(msg, \u0027/sbin/ifdown\u0027, interface, check_exit_code\u003dFalse)"},{"line_number":314,"context_line":"        if utils.is_active_nic(interface):"},{"line_number":315,"context_line":"            msg \u003d \u0027%s %s is up, trying with ip command\u0027 % (iftype, interface)"},{"line_number":316,"context_line":"            self.execute(msg, \u0027/sbin/ip\u0027,"},{"line_number":317,"context_line":"                         \u0027link\u0027, \u0027set\u0027, \u0027dev\u0027, interface, \u0027down\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_dab03c8d","line":314,"updated":"2019-07-15 04:06:23.000000000","message":"A check need to be added to see if the file is already created, there are scenarios where os-net-config will re-run.  It should be done only when earlier ifdown is failed or ifcfg file is not created.\n\nAs this is a common function, what happens to devices which is not yet created, like ovs devices or bonds?","commit_id":"67d2ea7faa7faa45fb6d2248e135821d3590514a"},{"author":{"_account_id":16690,"name":"Noam Angel","email":"noama@nvidia.com","username":"noama"},"change_message_id":"b347cecb8fef8ec84c22157ebf74a0a4ec8da20e","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    def ifdown(self, interface, iftype\u003d\u0027interface\u0027):"},{"line_number":312,"context_line":"        msg \u003d \u0027running ifdown on %s: %s\u0027 % (iftype, interface)"},{"line_number":313,"context_line":"        self.execute(msg, \u0027/sbin/ifdown\u0027, interface, check_exit_code\u003dFalse)"},{"line_number":314,"context_line":"        if utils.is_active_nic(interface):"},{"line_number":315,"context_line":"            msg \u003d \u0027%s %s is up, trying with ip command\u0027 % (iftype, interface)"},{"line_number":316,"context_line":"            self.execute(msg, \u0027/sbin/ip\u0027,"},{"line_number":317,"context_line":"                         \u0027link\u0027, \u0027set\u0027, \u0027dev\u0027, interface, \u0027down\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_1a17b453","line":314,"in_reply_to":"7faddb67_dab03c8d","updated":"2019-07-15 04:52:50.000000000","message":"is_active_nic will only return true if it is a real interface and if this interface is up","commit_id":"67d2ea7faa7faa45fb6d2248e135821d3590514a"}]}