)]}'
{"os_net_config/sriov_config.py":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"07b32ea29c53f9aff1a8274a505654dce2ee9679","unresolved":true,"context_lines":[{"line_number":277,"context_line":"        if type \u003d\u003d \u0027vf\u0027:"},{"line_number":278,"context_line":"            name \u003d config.get(\u0027device\u0027, {}).get(\u0027name\u0027)"},{"line_number":279,"context_line":"            if dev_name \u003d\u003d name:"},{"line_number":280,"context_line":"                logger.warning(\"VF-io binding exists for %s VF(s)\" % dev_name)"},{"line_number":281,"context_line":"                return True"},{"line_number":282,"context_line":"            else:"},{"line_number":283,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"22c0aed7_91f8a9d9","line":280,"range":{"start_line":280,"start_character":32,"end_line":280,"end_character":56},"updated":"2021-08-31 12:01:18.000000000","message":"This does not signify vfio binding, but the VF is used by the host.","commit_id":"2bcae6897ce79a64331ff9d23838ab261b9ad50c"},{"author":{"_account_id":33688,"name":"Vijayalakshmi","display_name":"Viji Candappa","email":"vcandapp@redhat.com","username":"VijiC"},"change_message_id":"88afa1a5fe3c0645c72fd1dfcb0cd21e5ccd05fd","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        if type \u003d\u003d \u0027vf\u0027:"},{"line_number":278,"context_line":"            name \u003d config.get(\u0027device\u0027, {}).get(\u0027name\u0027)"},{"line_number":279,"context_line":"            if dev_name \u003d\u003d name:"},{"line_number":280,"context_line":"                logger.warning(\"VF-io binding exists for %s VF(s)\" % dev_name)"},{"line_number":281,"context_line":"                return True"},{"line_number":282,"context_line":"            else:"},{"line_number":283,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"617fc10d_3667e45f","line":280,"range":{"start_line":280,"start_character":32,"end_line":280,"end_character":56},"in_reply_to":"22c0aed7_91f8a9d9","updated":"2021-09-08 09:34:17.000000000","message":"Done","commit_id":"2bcae6897ce79a64331ff9d23838ab261b9ad50c"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"07b32ea29c53f9aff1a8274a505654dce2ee9679","unresolved":true,"context_lines":[{"line_number":301,"context_line":"            if item.get(\u0027link_mode\u0027) \u003d\u003d \"legacy\":"},{"line_number":302,"context_line":"                # Add a udev rule to configure the VF\u0027s when PF\u0027s are"},{"line_number":303,"context_line":"                # released by a guest"},{"line_number":304,"context_line":"                if is_partitioned_pf(item[\u0027name\u0027]) is False:"},{"line_number":305,"context_line":"                    add_udev_rule_for_legacy_sriov_pf(item[\u0027name\u0027],"},{"line_number":306,"context_line":"                                                      item[\u0027numvfs\u0027])"},{"line_number":307,"context_line":"            # When configuring vdpa, we need to configure switchdev before"}],"source_content_type":"text/x-python","patch_set":2,"id":"99ab3f14_f61e5ad8","line":304,"range":{"start_line":304,"start_character":19,"end_line":304,"end_character":60},"updated":"2021-08-31 12:01:18.000000000","message":"change it as \"if not is_partitioned_pf(item[\u0027name\u0027]):\" which is more meaningful in reading code.","commit_id":"2bcae6897ce79a64331ff9d23838ab261b9ad50c"},{"author":{"_account_id":33688,"name":"Vijayalakshmi","display_name":"Viji Candappa","email":"vcandapp@redhat.com","username":"VijiC"},"change_message_id":"cede41f6d3a17b306f226f851b864cab973261e6","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            if item.get(\u0027link_mode\u0027) \u003d\u003d \"legacy\":"},{"line_number":302,"context_line":"                # Add a udev rule to configure the VF\u0027s when PF\u0027s are"},{"line_number":303,"context_line":"                # released by a guest"},{"line_number":304,"context_line":"                if is_partitioned_pf(item[\u0027name\u0027]) is False:"},{"line_number":305,"context_line":"                    add_udev_rule_for_legacy_sriov_pf(item[\u0027name\u0027],"},{"line_number":306,"context_line":"                                                      item[\u0027numvfs\u0027])"},{"line_number":307,"context_line":"            # When configuring vdpa, we need to configure switchdev before"}],"source_content_type":"text/x-python","patch_set":2,"id":"5b0a825c_32b36903","line":304,"range":{"start_line":304,"start_character":19,"end_line":304,"end_character":60},"in_reply_to":"99ab3f14_f61e5ad8","updated":"2021-09-07 07:09:48.000000000","message":"Done","commit_id":"2bcae6897ce79a64331ff9d23838ab261b9ad50c"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"47be9471bebf7a35b97948703f8a24f340d6ad9f","unresolved":true,"context_lines":[{"line_number":280,"context_line":"            if dev_name \u003d\u003d name:"},{"line_number":281,"context_line":"                logger.warning(\"%s has VF(%s) used by host\" % (name, vf_name))"},{"line_number":282,"context_line":"                return True"},{"line_number":283,"context_line":"            else:"},{"line_number":284,"context_line":"                return False"},{"line_number":285,"context_line":"    return False"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d507b278_cc503ee5","line":283,"updated":"2021-09-09 04:41:53.000000000","message":"This breaks the for loop when the first VF\u0027s PF doesn\u0027t match dev_name. So if there are VFs from multiple devices this will break the functionality","commit_id":"628dcaebc08605faf1ed2b2d38280e6435dc47c0"},{"author":{"_account_id":33688,"name":"Vijayalakshmi","display_name":"Viji Candappa","email":"vcandapp@redhat.com","username":"VijiC"},"change_message_id":"30a6b97a658bb4bf896af3cf69d6617d24184ed9","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            if dev_name \u003d\u003d name:"},{"line_number":281,"context_line":"                logger.warning(\"%s has VF(%s) used by host\" % (name, vf_name))"},{"line_number":282,"context_line":"                return True"},{"line_number":283,"context_line":"            else:"},{"line_number":284,"context_line":"                return False"},{"line_number":285,"context_line":"    return False"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"6d2df4df_ab14c81c","line":283,"in_reply_to":"d507b278_cc503ee5","updated":"2021-09-09 05:55:31.000000000","message":"Done","commit_id":"628dcaebc08605faf1ed2b2d38280e6435dc47c0"}],"os_net_config/tests/test_utils.py":[{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"94f9ad89d9fb2eb21c418deca20321e5a802adf5","unresolved":true,"context_lines":[{"line_number":263,"context_line":"        test_sriov_vf_map \u003d {\u0027device\u0027: {\u0027name\u0027: \u0027eth1\u0027, \u0027vfid\u0027: 2},"},{"line_number":264,"context_line":"                             \u0027device_type\u0027: \u0027vf\u0027, \u0027max_tx_rate\u0027: 0,"},{"line_number":265,"context_line":"                             \u0027min_tx_rate\u0027: 0, \u0027name\u0027: \u0027eth1_2\u0027}"},{"line_number":266,"context_line":"        print(sriov_config._UDEV_LEGACY_RULE_FILE)"},{"line_number":267,"context_line":"        udev_file \u003d open(sriov_config._UDEV_LEGACY_RULE_FILE, \"w\")"},{"line_number":268,"context_line":"        udev_file.write(udev_content)"},{"line_number":269,"context_line":"        udev_file.close()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5c29aa8d_2b228d02","line":266,"updated":"2021-09-09 08:16:53.000000000","message":"Shall be removed","commit_id":"a8bcc88a3957b416c06cd688c958ad0a89f87093"},{"author":{"_account_id":33688,"name":"Vijayalakshmi","display_name":"Viji Candappa","email":"vcandapp@redhat.com","username":"VijiC"},"change_message_id":"a992ca09c4ccd02910736731a9bc063c331bdeb2","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        test_sriov_vf_map \u003d {\u0027device\u0027: {\u0027name\u0027: \u0027eth1\u0027, \u0027vfid\u0027: 2},"},{"line_number":264,"context_line":"                             \u0027device_type\u0027: \u0027vf\u0027, \u0027max_tx_rate\u0027: 0,"},{"line_number":265,"context_line":"                             \u0027min_tx_rate\u0027: 0, \u0027name\u0027: \u0027eth1_2\u0027}"},{"line_number":266,"context_line":"        print(sriov_config._UDEV_LEGACY_RULE_FILE)"},{"line_number":267,"context_line":"        udev_file \u003d open(sriov_config._UDEV_LEGACY_RULE_FILE, \"w\")"},{"line_number":268,"context_line":"        udev_file.write(udev_content)"},{"line_number":269,"context_line":"        udev_file.close()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3d1b4cc3_04d29bf2","line":266,"in_reply_to":"5c29aa8d_2b228d02","updated":"2021-12-15 10:24:46.000000000","message":"Done","commit_id":"a8bcc88a3957b416c06cd688c958ad0a89f87093"}],"os_net_config/utils.py":[{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"47be9471bebf7a35b97948703f8a24f340d6ad9f","unresolved":true,"context_lines":[{"line_number":609,"context_line":"                    fp.write(line)"},{"line_number":610,"context_line":"            else:"},{"line_number":611,"context_line":"                fp.write(line)"},{"line_number":612,"context_line":"                continue"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"def _configure_sriov_config_service():"}],"source_content_type":"text/x-python","patch_set":5,"id":"75bbb8f8_a746b81c","line":612,"updated":"2021-09-09 04:41:53.000000000","message":"this statement will not be required","commit_id":"628dcaebc08605faf1ed2b2d38280e6435dc47c0"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"ad96a96a7ec73055538c20af3366bf361b96b93c","unresolved":true,"context_lines":[{"line_number":609,"context_line":"                    fp.write(line)"},{"line_number":610,"context_line":"            else:"},{"line_number":611,"context_line":"                fp.write(line)"},{"line_number":612,"context_line":"                continue"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"def _configure_sriov_config_service():"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a652fb9_aa293c44","line":612,"range":{"start_line":612,"start_character":16,"end_line":612,"end_character":24},"updated":"2021-09-15 08:33:22.000000000","message":"not required.","commit_id":"40f3679ea34974cdae11905451d3e8bd1d308696"},{"author":{"_account_id":33688,"name":"Vijayalakshmi","display_name":"Viji Candappa","email":"vcandapp@redhat.com","username":"VijiC"},"change_message_id":"a992ca09c4ccd02910736731a9bc063c331bdeb2","unresolved":false,"context_lines":[{"line_number":609,"context_line":"                    fp.write(line)"},{"line_number":610,"context_line":"            else:"},{"line_number":611,"context_line":"                fp.write(line)"},{"line_number":612,"context_line":"                continue"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"def _configure_sriov_config_service():"}],"source_content_type":"text/x-python","patch_set":7,"id":"7695a408_19235a78","line":612,"range":{"start_line":612,"start_character":16,"end_line":612,"end_character":24},"in_reply_to":"9a652fb9_aa293c44","updated":"2021-12-15 10:24:46.000000000","message":"Done","commit_id":"40f3679ea34974cdae11905451d3e8bd1d308696"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"ad96a96a7ec73055538c20af3366bf361b96b93c","unresolved":true,"context_lines":[{"line_number":633,"context_line":"def configure_sriov_vfs():"},{"line_number":634,"context_line":"    logger.info(\"Configuring VFs now\")"},{"line_number":635,"context_line":"    sriov_config.configure_sriov_vf()"},{"line_number":636,"context_line":"    logger.info(\"UDEV rules check for NIC partition used VFs\")"},{"line_number":637,"context_line":"    nicpart_udev_rules_check()"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"33bbdec7_7061095c","line":636,"updated":"2021-09-15 08:33:22.000000000","message":"Let\u0027s remove this log, as this will be misleading on non-nic partition deployment. As there is already a warning log in the matching case, that should be enough. This function will be called irrespective of nic partition or not.","commit_id":"40f3679ea34974cdae11905451d3e8bd1d308696"},{"author":{"_account_id":33688,"name":"Vijayalakshmi","display_name":"Viji Candappa","email":"vcandapp@redhat.com","username":"VijiC"},"change_message_id":"a992ca09c4ccd02910736731a9bc063c331bdeb2","unresolved":false,"context_lines":[{"line_number":633,"context_line":"def configure_sriov_vfs():"},{"line_number":634,"context_line":"    logger.info(\"Configuring VFs now\")"},{"line_number":635,"context_line":"    sriov_config.configure_sriov_vf()"},{"line_number":636,"context_line":"    logger.info(\"UDEV rules check for NIC partition used VFs\")"},{"line_number":637,"context_line":"    nicpart_udev_rules_check()"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7c155e5f_82e19497","line":636,"in_reply_to":"33bbdec7_7061095c","updated":"2021-12-15 10:24:46.000000000","message":"Done","commit_id":"40f3679ea34974cdae11905451d3e8bd1d308696"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"7b6432a02288594afb5f63b1e17b10a3318dd2b6","unresolved":true,"context_lines":[{"line_number":597,"context_line":"    udev \u003d \u0027^KERNEL\u003d\u003d\"(.*)\", RUN.*\u0027"},{"line_number":598,"context_line":"    udev_reg \u003d re.compile(udev, 0)"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    with open(sriov_config._UDEV_LEGACY_RULE_FILE, \"r\") as fp:"},{"line_number":601,"context_line":"        rules \u003d fp.readlines()"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    with open(sriov_config._UDEV_LEGACY_RULE_FILE, \"w\") as fp:"}],"source_content_type":"text/x-python","patch_set":8,"id":"06beee7e_788e2423","line":600,"updated":"2021-09-15 14:05:02.000000000","message":"In case of the UDEV file is not present (for offload deployment), this will throw an error as file is not found. Add a check to see if the file exists before reading?","commit_id":"de2daf84c0bab42e8b23529df6ceb1403dd32940"},{"author":{"_account_id":33688,"name":"Vijayalakshmi","display_name":"Viji Candappa","email":"vcandapp@redhat.com","username":"VijiC"},"change_message_id":"a992ca09c4ccd02910736731a9bc063c331bdeb2","unresolved":false,"context_lines":[{"line_number":597,"context_line":"    udev \u003d \u0027^KERNEL\u003d\u003d\"(.*)\", RUN.*\u0027"},{"line_number":598,"context_line":"    udev_reg \u003d re.compile(udev, 0)"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    with open(sriov_config._UDEV_LEGACY_RULE_FILE, \"r\") as fp:"},{"line_number":601,"context_line":"        rules \u003d fp.readlines()"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    with open(sriov_config._UDEV_LEGACY_RULE_FILE, \"w\") as fp:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffc85f36_e68a9138","line":600,"in_reply_to":"06beee7e_788e2423","updated":"2021-12-15 10:24:46.000000000","message":"Done","commit_id":"de2daf84c0bab42e8b23529df6ceb1403dd32940"}]}