)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33688,"name":"Vijayalakshmi","display_name":"Viji Candappa","email":"vcandapp@redhat.com","username":"VijiC"},"change_message_id":"8b45f35f009d12c45dd55c137f0930c730e015e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"be5ae7ef_dfd1604f","updated":"2021-10-26 10:35:50.000000000","message":"recheck","commit_id":"9779d853c8c787fbccb324c23015d25842672de4"},{"author":{"_account_id":33688,"name":"Vijayalakshmi","display_name":"Viji Candappa","email":"vcandapp@redhat.com","username":"VijiC"},"change_message_id":"6557b0c2d98003939fa2399fe923cc892c01befc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d26b5bce_32344c35","updated":"2021-11-09 12:56:14.000000000","message":"recheck","commit_id":"78f69db88f2b30818939a3665fe56d6978329fdb"}],"os_net_config/impl_ifcfg.py":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"78d088c102b722a62e9a27916936418671135d27","unresolved":true,"context_lines":[{"line_number":985,"context_line":"        for the interface which is a member of ovs_dpdk_port"},{"line_number":986,"context_line":"        with NM and DHCP disabled"},{"line_number":987,"context_line":"        \"\"\""},{"line_number":988,"context_line":"        if vendor_id \u003d\u003d MLNX_VENDOR_ID:"},{"line_number":989,"context_line":"            self.nm_controlled \u003d False"},{"line_number":990,"context_line":"            self.use_dhcp \u003d False"},{"line_number":991,"context_line":"            dpdk_if_name \u003d objects.Interface(ifname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a81f546_c5fb158e","line":988,"updated":"2021-10-18 05:22:30.000000000","message":"Creating a function as utils.is_mellanox_interface restricts the vendor id check withing the utils.py itlse, which will be one place for vendor related conditions.","commit_id":"73d621396a32f76f593faef9d8842dbb5615ffaf"},{"author":{"_account_id":33688,"name":"Vijayalakshmi","display_name":"Viji Candappa","email":"vcandapp@redhat.com","username":"VijiC"},"change_message_id":"a68c1206d0ff0030e3f541fd332439603f4b6632","unresolved":false,"context_lines":[{"line_number":985,"context_line":"        for the interface which is a member of ovs_dpdk_port"},{"line_number":986,"context_line":"        with NM and DHCP disabled"},{"line_number":987,"context_line":"        \"\"\""},{"line_number":988,"context_line":"        if vendor_id \u003d\u003d MLNX_VENDOR_ID:"},{"line_number":989,"context_line":"            self.nm_controlled \u003d False"},{"line_number":990,"context_line":"            self.use_dhcp \u003d False"},{"line_number":991,"context_line":"            dpdk_if_name \u003d objects.Interface(ifname)"}],"source_content_type":"text/x-python","patch_set":1,"id":"34ed12dc_297c1e1f","line":988,"in_reply_to":"1a81f546_c5fb158e","updated":"2021-10-26 05:41:58.000000000","message":"Done","commit_id":"73d621396a32f76f593faef9d8842dbb5615ffaf"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"78d088c102b722a62e9a27916936418671135d27","unresolved":true,"context_lines":[{"line_number":988,"context_line":"        if vendor_id \u003d\u003d MLNX_VENDOR_ID:"},{"line_number":989,"context_line":"            self.nm_controlled \u003d False"},{"line_number":990,"context_line":"            self.use_dhcp \u003d False"},{"line_number":991,"context_line":"            dpdk_if_name \u003d objects.Interface(ifname)"},{"line_number":992,"context_line":"            self.add_interface(dpdk_if_name)"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"    def add_ovs_dpdk_bond(self, ovs_dpdk_bond):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5bc669bd_6fed786b","line":991,"updated":"2021-10-18 05:22:30.000000000","message":"The same change has to be added to ovs_dpdk_bond interface too.","commit_id":"73d621396a32f76f593faef9d8842dbb5615ffaf"},{"author":{"_account_id":33688,"name":"Vijayalakshmi","display_name":"Viji Candappa","email":"vcandapp@redhat.com","username":"VijiC"},"change_message_id":"a68c1206d0ff0030e3f541fd332439603f4b6632","unresolved":false,"context_lines":[{"line_number":988,"context_line":"        if vendor_id \u003d\u003d MLNX_VENDOR_ID:"},{"line_number":989,"context_line":"            self.nm_controlled \u003d False"},{"line_number":990,"context_line":"            self.use_dhcp \u003d False"},{"line_number":991,"context_line":"            dpdk_if_name \u003d objects.Interface(ifname)"},{"line_number":992,"context_line":"            self.add_interface(dpdk_if_name)"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"    def add_ovs_dpdk_bond(self, ovs_dpdk_bond):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d9ca1360_0cc8c49f","line":991,"in_reply_to":"5bc669bd_6fed786b","updated":"2021-10-26 05:41:58.000000000","message":"Done","commit_id":"73d621396a32f76f593faef9d8842dbb5615ffaf"}],"os_net_config/utils.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"196a857852a4e864f153a46bf2b3e1ad683bef1a","unresolved":true,"context_lines":[{"line_number":405,"context_line":"def is_mellanox_interface(ifname):"},{"line_number":406,"context_line":"    MLNX_VENDOR_ID \u003d \"0x15b3\""},{"line_number":407,"context_line":"    vendor_id \u003d get_vendor_id(ifname)"},{"line_number":408,"context_line":"    if vendor_id \u003d\u003d MLNX_VENDOR_ID:"},{"line_number":409,"context_line":"        return True"},{"line_number":410,"context_line":"    return False"},{"line_number":411,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"15041304_a6317e8c","line":408,"updated":"2021-11-10 19:28:10.000000000","message":"you can just return vendor_id \u003d\u003d MLNX_VENDOR_ID","commit_id":"e5c50e8cf3c5d9f23ddbcd2123f227d95be79bae"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"0b17075951c818f2aa36057501c9e680b4816466","unresolved":false,"context_lines":[{"line_number":405,"context_line":"def is_mellanox_interface(ifname):"},{"line_number":406,"context_line":"    MLNX_VENDOR_ID \u003d \"0x15b3\""},{"line_number":407,"context_line":"    vendor_id \u003d get_vendor_id(ifname)"},{"line_number":408,"context_line":"    if vendor_id \u003d\u003d MLNX_VENDOR_ID:"},{"line_number":409,"context_line":"        return True"},{"line_number":410,"context_line":"    return False"},{"line_number":411,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b04a1848_e33fcbd7","line":408,"in_reply_to":"15041304_a6317e8c","updated":"2021-11-11 02:11:24.000000000","message":"Moshe you are correct that this could be reduced to one line, in fact you could even do:\nreturn vendor_id \u003d\u003d \"0x15b3\" # 0x15b3 is the Mellanox Vendor ID\nBut I actually think the code is more clear to read this way and an extra line assignment or comparison won\u0027t slow things down noticeably.","commit_id":"e5c50e8cf3c5d9f23ddbcd2123f227d95be79bae"}]}