)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"38ab7ac82e1f2498918582648cae72075b14678f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding steering_mode config to sriov_pf object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Current behavioure is to enable smfs software steering"},{"line_number":10,"context_line":"by default when moving to switchdev, in some cases we need"},{"line_number":11,"context_line":"it to be in dmfs mode (FW steering), so adding steering_mode"},{"line_number":12,"context_line":"config to sriov_pf object to make it configrable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7d622d37_d4d30a73","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":12},"updated":"2022-01-18 22:04:43.000000000","message":"s/Current/current s/behavioure/behaviour","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"8b0a955c05d9e6b6c1611a3440e136ba6af94468","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6d1fc11a_4a589cdd","updated":"2022-01-19 06:25:22.000000000","message":"I agree with Karthik\u0027s comment on not setting default value in sriov_config.yaml file for all sriov_pf\u0027s\n","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"86da0530ad5d95e4fec5b524dcd91d169f319d47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"71e2b8f5_98895cde","updated":"2022-01-19 05:43:35.000000000","message":"IMHO the default value of steering_mode shall be \u0027None\u0027 since its vendor specific and shall not force an entry to sriov_config.yaml unless its defined in nic-configs.","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"fd35d051281c05d660eb5c50dc03d831f199884d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4407daf8_f1cfb127","in_reply_to":"71e2b8f5_98895cde","updated":"2022-01-19 07:16:10.000000000","message":"I agree","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"94a3cae8b7ade3e8a6c71fd38df288bb84c8e826","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3437267c_f0ff32bb","updated":"2022-01-19 07:26:54.000000000","message":"If another revision is added, please consider adding a testcase when steering_mode is None.\nHowever this LGTM. Thanks.","commit_id":"26ac5b273469b5174a354a8fc1a970228fc83b35"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"af0cc42c247e126fd394620a1387ba7beddd4fb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8c8824eb_8ca22fb5","in_reply_to":"3437267c_f0ff32bb","updated":"2022-01-19 07:32:23.000000000","message":"Done","commit_id":"26ac5b273469b5174a354a8fc1a970228fc83b35"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"1c1e25c036b72c56a256d7c9bd81ecfe9dc35a89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a6f78d99_09417e49","updated":"2022-01-19 07:40:26.000000000","message":"Thanks. LGTM","commit_id":"9fd13a9c79e793de2ae24c59dfa44ac6f3e9479f"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"a1a2c2883a6d43403945e50966cb6b76dffda0ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c9decda6_22d1dc3a","updated":"2022-01-19 08:37:05.000000000","message":"missing a sample","commit_id":"9fd13a9c79e793de2ae24c59dfa44ac6f3e9479f"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"e421fcf930f889b1f49176bc8907d90d67697bc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"718a1053_7b7534b6","in_reply_to":"c9decda6_22d1dc3a","updated":"2022-01-19 08:38:26.000000000","message":"done","commit_id":"9fd13a9c79e793de2ae24c59dfa44ac6f3e9479f"}],"os_net_config/objects.py":[{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"86da0530ad5d95e4fec5b524dcd91d169f319d47","unresolved":true,"context_lines":[{"line_number":1513,"context_line":"                 defroute\u003dTrue, dhclient_args\u003dNone, dns_servers\u003dNone,"},{"line_number":1514,"context_line":"                 nm_controlled\u003dFalse, onboot\u003dTrue, domain\u003dNone, members\u003dNone,"},{"line_number":1515,"context_line":"                 promisc\u003dNone, link_mode\u003d\u0027legacy\u0027, ethtool_opts\u003dNone,"},{"line_number":1516,"context_line":"                 vdpa\u003dFalse, steering_mode\u003d\u0027smfs\u0027):"},{"line_number":1517,"context_line":"        addresses \u003d addresses or []"},{"line_number":1518,"context_line":"        routes \u003d routes or []"},{"line_number":1519,"context_line":"        rules \u003d rules or []"}],"source_content_type":"text/x-python","patch_set":4,"id":"076bcb27_703c9aac","line":1516,"updated":"2022-01-19 05:43:35.000000000","message":"The default value shall be None, since its vendor specific.","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"fd35d051281c05d660eb5c50dc03d831f199884d","unresolved":false,"context_lines":[{"line_number":1513,"context_line":"                 defroute\u003dTrue, dhclient_args\u003dNone, dns_servers\u003dNone,"},{"line_number":1514,"context_line":"                 nm_controlled\u003dFalse, onboot\u003dTrue, domain\u003dNone, members\u003dNone,"},{"line_number":1515,"context_line":"                 promisc\u003dNone, link_mode\u003d\u0027legacy\u0027, ethtool_opts\u003dNone,"},{"line_number":1516,"context_line":"                 vdpa\u003dFalse, steering_mode\u003d\u0027smfs\u0027):"},{"line_number":1517,"context_line":"        addresses \u003d addresses or []"},{"line_number":1518,"context_line":"        routes \u003d routes or []"},{"line_number":1519,"context_line":"        rules \u003d rules or []"}],"source_content_type":"text/x-python","patch_set":4,"id":"2412f022_aace6b87","line":1516,"in_reply_to":"076bcb27_703c9aac","updated":"2022-01-19 07:16:10.000000000","message":"Done","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"86da0530ad5d95e4fec5b524dcd91d169f319d47","unresolved":true,"context_lines":[{"line_number":1555,"context_line":"        ethtool_opts \u003d json.get(\u0027ethtool_opts\u0027, None)"},{"line_number":1556,"context_line":"        vdpa \u003d json.get(\u0027vdpa\u0027, False)"},{"line_number":1557,"context_line":"        steering_mode \u003d json.get(\u0027steering_mode\u0027, \u0027smfs\u0027)"},{"line_number":1558,"context_line":"        if steering_mode not in [\u0027smfs\u0027, \u0027dmfs\u0027]:"},{"line_number":1559,"context_line":"            msg \u003d \u0027Expecting steering_mode to match smfs/dmfs\u0027"},{"line_number":1560,"context_line":"            raise InvalidConfigException(msg)"},{"line_number":1561,"context_line":"        if vdpa:"}],"source_content_type":"text/x-python","patch_set":4,"id":"a8eaa3cd_95bb7558","line":1558,"updated":"2022-01-19 05:43:35.000000000","message":"Shall handle the required default value None as well","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"fd35d051281c05d660eb5c50dc03d831f199884d","unresolved":false,"context_lines":[{"line_number":1555,"context_line":"        ethtool_opts \u003d json.get(\u0027ethtool_opts\u0027, None)"},{"line_number":1556,"context_line":"        vdpa \u003d json.get(\u0027vdpa\u0027, False)"},{"line_number":1557,"context_line":"        steering_mode \u003d json.get(\u0027steering_mode\u0027, \u0027smfs\u0027)"},{"line_number":1558,"context_line":"        if steering_mode not in [\u0027smfs\u0027, \u0027dmfs\u0027]:"},{"line_number":1559,"context_line":"            msg \u003d \u0027Expecting steering_mode to match smfs/dmfs\u0027"},{"line_number":1560,"context_line":"            raise InvalidConfigException(msg)"},{"line_number":1561,"context_line":"        if vdpa:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac6580d_ea57ceb9","line":1558,"in_reply_to":"a8eaa3cd_95bb7558","updated":"2022-01-19 07:16:10.000000000","message":"Done","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"}],"os_net_config/sriov_config.py":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"9f1e525d8f3e695c21cc461f43bfaf3668775f73","unresolved":true,"context_lines":[{"line_number":364,"context_line":"                    dpdk_vfs_pcis_list +\u003d vf_pcis_list"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"                    # Configure flow steering mode"},{"line_number":367,"context_line":"                    configure_flow_steering(item[\u0027name\u0027],"},{"line_number":368,"context_line":"                                            item[\u0027steering_mode\u0027])"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"                    # Configure switchdev mode"}],"source_content_type":"text/x-python","patch_set":2,"id":"9d278094_c0ee1be2","line":367,"updated":"2022-01-18 11:19:28.000000000","message":"It is possible that existing sriov map does not have steering_mode, can handle it to set it to smfs if steering_mode is not in the item?","commit_id":"2cc962b455a2245c1fe1e98b4b55066a94864c1f"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"ed0342882255e49ba1f662c10dcc7cd14226228e","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                    dpdk_vfs_pcis_list +\u003d vf_pcis_list"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"                    # Configure flow steering mode"},{"line_number":367,"context_line":"                    configure_flow_steering(item[\u0027name\u0027],"},{"line_number":368,"context_line":"                                            item[\u0027steering_mode\u0027])"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"                    # Configure switchdev mode"}],"source_content_type":"text/x-python","patch_set":2,"id":"ef123f27_bd410d76","line":367,"in_reply_to":"9d278094_c0ee1be2","updated":"2022-01-18 18:18:04.000000000","message":"Done","commit_id":"2cc962b455a2245c1fe1e98b4b55066a94864c1f"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"86da0530ad5d95e4fec5b524dcd91d169f319d47","unresolved":true,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"                    # Configure flow steering mode, default to smfs"},{"line_number":367,"context_line":"                    configure_flow_steering(item[\u0027name\u0027],"},{"line_number":368,"context_line":"                                            item.get(\u0027steering_mode\u0027, \u0027smfs\u0027))"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"                    # Configure switchdev mode"},{"line_number":371,"context_line":"                    configure_switchdev(item[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"f3841b81_995f78e5","line":368,"updated":"2022-01-19 05:43:35.000000000","message":"The default value is anyway set here, irrespective of the yaml configuration. So backward compatibility and absence of default values in yaml is already taken care","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"fd35d051281c05d660eb5c50dc03d831f199884d","unresolved":true,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"                    # Configure flow steering mode, default to smfs"},{"line_number":367,"context_line":"                    configure_flow_steering(item[\u0027name\u0027],"},{"line_number":368,"context_line":"                                            item.get(\u0027steering_mode\u0027, \u0027smfs\u0027))"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"                    # Configure switchdev mode"},{"line_number":371,"context_line":"                    configure_switchdev(item[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"14d0355f_482f6e57","line":368,"in_reply_to":"f3841b81_995f78e5","updated":"2022-01-19 07:16:10.000000000","message":"I agree","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"}],"os_net_config/utils.py":[{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"86da0530ad5d95e4fec5b524dcd91d169f319d47","unresolved":true,"context_lines":[{"line_number":421,"context_line":""},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"def update_sriov_pf_map(ifname, numvfs, noop, promisc\u003dNone,"},{"line_number":424,"context_line":"                        link_mode\u003d\u0027legacy\u0027, vdpa\u003dFalse, steering_mode\u003d\u0027smfs\u0027):"},{"line_number":425,"context_line":"    if not noop:"},{"line_number":426,"context_line":"        cur_numvfs \u003d sriov_config.get_numvfs(ifname)"},{"line_number":427,"context_line":"        if cur_numvfs \u003e 0 and cur_numvfs !\u003d numvfs:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f14e71d_83739590","line":424,"updated":"2022-01-19 05:43:35.000000000","message":"Default value shall be steering_mode\u003dNone","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"fd35d051281c05d660eb5c50dc03d831f199884d","unresolved":false,"context_lines":[{"line_number":421,"context_line":""},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"def update_sriov_pf_map(ifname, numvfs, noop, promisc\u003dNone,"},{"line_number":424,"context_line":"                        link_mode\u003d\u0027legacy\u0027, vdpa\u003dFalse, steering_mode\u003d\u0027smfs\u0027):"},{"line_number":425,"context_line":"    if not noop:"},{"line_number":426,"context_line":"        cur_numvfs \u003d sriov_config.get_numvfs(ifname)"},{"line_number":427,"context_line":"        if cur_numvfs \u003e 0 and cur_numvfs !\u003d numvfs:"}],"source_content_type":"text/x-python","patch_set":4,"id":"a3cd98f8_45918322","line":424,"in_reply_to":"5f14e71d_83739590","updated":"2022-01-19 07:16:10.000000000","message":"Done","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"86da0530ad5d95e4fec5b524dcd91d169f319d47","unresolved":true,"context_lines":[{"line_number":435,"context_line":"                if promisc is not None:"},{"line_number":436,"context_line":"                    item[\u0027promisc\u0027] \u003d promisc"},{"line_number":437,"context_line":"                item[\u0027link_mode\u0027] \u003d link_mode"},{"line_number":438,"context_line":"                item[\u0027steering_mode\u0027] \u003d steering_mode"},{"line_number":439,"context_line":"                break"},{"line_number":440,"context_line":"        else:"},{"line_number":441,"context_line":"            new_item \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"719ea0aa_fcf64ac9","line":438,"updated":"2022-01-19 05:43:35.000000000","message":"IMHO, its better to add this param to yaml only when the steering_mode is set in nic configs, since its vendor specific and shall not be made available for other vendors by default.","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"fd35d051281c05d660eb5c50dc03d831f199884d","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                if promisc is not None:"},{"line_number":436,"context_line":"                    item[\u0027promisc\u0027] \u003d promisc"},{"line_number":437,"context_line":"                item[\u0027link_mode\u0027] \u003d link_mode"},{"line_number":438,"context_line":"                item[\u0027steering_mode\u0027] \u003d steering_mode"},{"line_number":439,"context_line":"                break"},{"line_number":440,"context_line":"        else:"},{"line_number":441,"context_line":"            new_item \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"b5319282_5dc2755c","line":438,"in_reply_to":"719ea0aa_fcf64ac9","updated":"2022-01-19 07:16:10.000000000","message":"Done","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"86da0530ad5d95e4fec5b524dcd91d169f319d47","unresolved":true,"context_lines":[{"line_number":446,"context_line":"            if promisc is not None:"},{"line_number":447,"context_line":"                new_item[\u0027promisc\u0027] \u003d promisc"},{"line_number":448,"context_line":"            new_item[\u0027link_mode\u0027] \u003d link_mode"},{"line_number":449,"context_line":"            new_item[\u0027steering_mode\u0027] \u003d steering_mode"},{"line_number":450,"context_line":"            sriov_map.append(new_item)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        write_yaml_config(common.SRIOV_CONFIG_FILE, sriov_map)"}],"source_content_type":"text/x-python","patch_set":4,"id":"054fa360_578cb6ac","line":449,"updated":"2022-01-19 05:43:35.000000000","message":"same as above.","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"},{"author":{"_account_id":25241,"name":"waleed mousa","email":"waleedm@nvidia.com","username":"waleedm"},"change_message_id":"fd35d051281c05d660eb5c50dc03d831f199884d","unresolved":false,"context_lines":[{"line_number":446,"context_line":"            if promisc is not None:"},{"line_number":447,"context_line":"                new_item[\u0027promisc\u0027] \u003d promisc"},{"line_number":448,"context_line":"            new_item[\u0027link_mode\u0027] \u003d link_mode"},{"line_number":449,"context_line":"            new_item[\u0027steering_mode\u0027] \u003d steering_mode"},{"line_number":450,"context_line":"            sriov_map.append(new_item)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        write_yaml_config(common.SRIOV_CONFIG_FILE, sriov_map)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a4c1cef4_c2144883","line":449,"in_reply_to":"054fa360_578cb6ac","updated":"2022-01-19 07:16:10.000000000","message":"Done","commit_id":"8f33005a06685a560023db2932b48d10e27d4edb"}]}