)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"ee3eaa2de3306487b7b153dd2105a78b45a0221e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"535a1aaa_97f357a3","updated":"2023-05-08 04:54:38.000000000","message":"recheck","commit_id":"21923493c8ff41794496a144c1f6ffe4a44898a3"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"a5b835e6330f417d9c92719a4235aecfd325afd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4d90aad1_41bfebce","updated":"2023-06-09 04:30:06.000000000","message":"recheck","commit_id":"447d07550d73d07bae2a3a6ed9cd1841b06e1943"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"a3f480977a84b6391f47a152505dbbb860e7304b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"66d6a72b_6cc2b03c","updated":"2023-06-06 10:21:36.000000000","message":"recheck","commit_id":"447d07550d73d07bae2a3a6ed9cd1841b06e1943"}],"os_net_config/impl_nmstate.py":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"5f6d5ae2bf6d8eb7a3940f477cd025d09bac7268","unresolved":true,"context_lines":[{"line_number":591,"context_line":"        elif isinstance(base_opt, objects.OvsDpdkBond):"},{"line_number":592,"context_line":"            msg \u003d \"Error: OVS DPDK Bonds not yet supported by impl_nmstate\""},{"line_number":593,"context_line":"            raise os_net_config.NotImplemented(msg)"},{"line_number":594,"context_line":"        else:"},{"line_number":595,"context_line":"            msg \u003d \"Error: Unsupported interface by impl_nmstate\""},{"line_number":596,"context_line":"            raise os_net_config.NotImplemented(msg)"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"cba72df0_c4e1520a","side":"PARENT","line":594,"updated":"2023-05-22 09:27:19.000000000","message":"Is this line wrongly removed?","commit_id":"0350a82f19fe4eff89a0bb1dff24fa9f43e4d09e"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"c9cf446de5746a573212c863cbd75ac3078ba1a2","unresolved":false,"context_lines":[{"line_number":591,"context_line":"        elif isinstance(base_opt, objects.OvsDpdkBond):"},{"line_number":592,"context_line":"            msg \u003d \"Error: OVS DPDK Bonds not yet supported by impl_nmstate\""},{"line_number":593,"context_line":"            raise os_net_config.NotImplemented(msg)"},{"line_number":594,"context_line":"        else:"},{"line_number":595,"context_line":"            msg \u003d \"Error: Unsupported interface by impl_nmstate\""},{"line_number":596,"context_line":"            raise os_net_config.NotImplemented(msg)"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c0709bbe_d5edbc5e","side":"PARENT","line":594,"in_reply_to":"c7cc929c_50ef82d5","updated":"2023-05-22 09:55:01.000000000","message":"Ok. yes go ahead and remove them. Also chek below lines #628-630, these are added in above too. One of the instance could be removed.","commit_id":"0350a82f19fe4eff89a0bb1dff24fa9f43e4d09e"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"8997f8ebb085119f86753f6917afefdffbbd9a50","unresolved":true,"context_lines":[{"line_number":591,"context_line":"        elif isinstance(base_opt, objects.OvsDpdkBond):"},{"line_number":592,"context_line":"            msg \u003d \"Error: OVS DPDK Bonds not yet supported by impl_nmstate\""},{"line_number":593,"context_line":"            raise os_net_config.NotImplemented(msg)"},{"line_number":594,"context_line":"        else:"},{"line_number":595,"context_line":"            msg \u003d \"Error: Unsupported interface by impl_nmstate\""},{"line_number":596,"context_line":"            raise os_net_config.NotImplemented(msg)"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c7cc929c_50ef82d5","side":"PARENT","line":594,"in_reply_to":"cba72df0_c4e1520a","updated":"2023-05-22 09:39:55.000000000","message":"No, ideally non supported interfaces are already handled by the absence of the respective add_\u003cinterface_type\u003e. So even the above if elif block is dead code. Since this else case affects the linux bond, I removed it in this patch. If its fine I shall remove the complete if elif block as well.","commit_id":"0350a82f19fe4eff89a0bb1dff24fa9f43e4d09e"}]}